Hi guys, Don't waste to much time on this issue. You can just increase the delta (INT_EPS) to a bigger value for 32 bit windows systems and that's all. I think it's enough if the precise values are checked on 64 bit systems. This is a known issue that checking the positions of chart components is unstable, so it might be just small platform differences. As you can see in the code INT_EPS already set to a bigger value for 32bit Linux, you can add a check for 32bit windows too and set this delta to a different value which makes the test pass.
Best Regards, Tamás Luke Benes <lukebe...@hotmail.com> ezt írta (időpont: 2019. márc. 20., Sze, 3:04): > Hey Mike, > After > https://cgit.freedesktop.org/libreoffice/core/commit/?id=166a4989a0d1e5a6271c66bceb73a27970afc882 > > tdf#123504: 0 and 360 are different angles in charts > > My 32-bit Windows box is failing with the following error: > > ChartDataTest::verify finished in: 2796ms > PivotChartDataButtonTest::verify finished in: 962ms > PointLineChartTest::verify finished in: 15087ms > GridTest::verify finished in: 5035ms > AxisLabelTest::verify finished in: 3948ms > AxisGeometryTest::verify finished in: 8078ms > D:/core/chart2/qa/extras/chart2dump/chart2dump.cxx:902:PieChartTest::verify > double equality assertion failed > - Expected: 3210 > - Actual : 3207 > - Delta : 0.1 > - Failing test file is: pie_chart_100_and_0.ods > > PieChartTest::verify finished in: 8407ms > ColumnBarChartTest::verify finished in: 10112ms > D:/core/chart2/qa/extras/chart2dump/chart2dump.cxx(902) : error : Assertion > Test name: PieChartTest::verify > double equality assertion failed > - Expected: 3210 > - Actual : 3207 > - Delta : 0.1 > - Failing test file is: pie_chart_100_and_0.ods > > Failures !!! > Run: 11 Failure total: 1 Failures: 1 Errors: 0 > > Error: a unit test failed, please do one of: > make CppunitTest_chart2_dump CPPUNITTRACE=TRUE # which is a shortcut for > the following line > make CppunitTest_chart2_dump CPPUNITTRACE="'C:/Program Files > (x86)/Microsoft Visual Studio/2017/Community/Common7/IDE/devenv.exe' > /debugexe" # for interactive debugging in Visual Studio > make CppunitTest_chart2_dump CPPUNITTRACE="drmemory -free_max_frames 20" # > for memory checking (install Dr.Memory first, and put it to your PATH) > > You can limit the execution to just one particular test by: > > make CppunitTest_chart2_dump CPPUNIT_TEST_NAME="testXYZ" ...above > mentioned params... > > make[1]: *** [D:/core/solenv/gbuild/CppunitTest.mk:114: > D:/core/workdir/CppunitTest/chart2_dump.test] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:282: build] Error 2 > > Would you like any more debug info or info about my system? > > Thanks > > -Luke > > > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
