On 08/02/12 17:59, Greg Kroah-Hartman wrote: > On Tue, Feb 07, 2012 at 01:26:18AM +0100, Michael Stahl wrote: >> patches to remove the tools/fsys trainwreck completely and adapt callers >> to use osl/file.hxx would be appreciated of course :) > > I've started to look into this.
great :) > It is safe to say that I should only be > cleaning up the usages outside of the tools/ directory? And that any > in-tools directory usage is "safe" in that once all out of the local > module users are gone, we can just delete the whole "module"? the eventual deletion of the entire tools module is certainly a worthy goal, but alas that is still a long way off... of course, an incremental approach is a good idea in these cases, so i guess the best way is to convert callers one at a time, keep callers in the tools module for last, and when the last one is gone we can remove the fsys stuff. also, please note that there is an optional part called "binfilter" that contains lots of ancient filters; it's in an extra git repo and not enabled by default, "configure --enable-binfilter && make fetch" should enable it; when doing such cleanups it's recommended to have that enabled, because that ancient code calls lots of obsolete things. of course, since binfilter will be removed eventually, try not to change it, just keep it building (if something is only used in binfilter it can be removed from core and moved to binfilter repo). > thanks, > > greg k-h _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
