vcl/quartz/salbmp.cxx | 5 +++++ 1 file changed, 5 insertions(+) New commits: commit 993913469e74e9db9743004bbe36aa412411671c Author: Tor Lillqvist <t...@iki.fi> AuthorDate: Wed Dec 26 13:31:16 2018 +0200 Commit: Tor Lillqvist <t...@iki.fi> CommitDate: Wed Dec 26 13:31:16 2018 +0200
Add some pondering about code of questionable provenance in a comment Change-Id: I20b3c8ba0ae4018307a97150440c708cfa3edc40 diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx index 34fd42caf2ad..791844632267 100644 --- a/vcl/quartz/salbmp.cxx +++ b/vcl/quartz/salbmp.cxx @@ -955,6 +955,11 @@ bool QuartzSalBitmap::GetSystemData( BitmapSystemData& rData ) { /** * We need to hack things because VCL does not use kCGBitmapByteOrder32Host, while Cairo requires it. + * + * Not sure what the above comment means. We don't use Cairo on macOS or iOS. + * + * This whole if statement was originally (before 2011) inside #ifdef CAIRO. Did we use Cairo on Mac back then? + * Anyway, nowadays (since many years, I think) we don't, so should this if statement be dropped? Fun. */ SAL_INFO("vcl.cg", "QuartzSalBitmap::" << __func__ << "(): kCGBitmapByteOrder32Host not found => inserting it."); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits