On 01/30/2012 10:35 PM, julien2412 wrote:
Cppchecks reports this :
core/store/source/storlckb.cxx
74 duplicateBranch style Found duplicate branches for if and else.
Here are the lines :
67 OStoreLockBytes::~OStoreLockBytes (void)
68 {
69 if (m_xManager.is())
70 {
71 if (m_xNode.is())
72 {
73 OStorePageDescriptor aDescr (m_xNode->m_aDescr);
74 if (m_bWriteable)
75 m_xManager->releasePage (aDescr);
76 else
77 m_xManager->releasePage (aDescr);
78 }
79 }
80 }
It's from commit 7c704c78d3c652504c064b4ac7af55a2c1ee49bb
Could we just remove the if or must something be added ?
51b85a38b03781a93db33b7817d3c6cebcae11e7 made the conditional
superfluous; further simplified now as
51b85a38b03781a93db33b7817d3c6cebcae11e7.
Thanks for spotting,
Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice