compilerplugins/clang/unusedfields.only-used-in-constructor.results | 88 +++-- compilerplugins/clang/unusedfields.readonly.results | 158 ++++++---- compilerplugins/clang/unusedfields.untouched.results | 88 +++-- compilerplugins/clang/unusedfields.writeonly.results | 42 +- cui/source/inc/grfpage.hxx | 1 cui/source/tabpages/grfpage.cxx | 3 sc/source/ui/Accessibility/AccessiblePageHeader.cxx | 4 sc/source/ui/Accessibility/AccessiblePageHeaderArea.cxx | 4 sc/source/ui/Accessibility/AccessibleText.cxx | 57 +-- sc/source/ui/inc/AccessiblePageHeaderArea.hxx | 2 sc/source/ui/inc/AccessibleText.hxx | 3 vcl/inc/printerinfomanager.hxx | 2 vcl/unx/generic/printer/cpdmgr.cxx | 1 vcl/unx/generic/printer/cupsmgr.cxx | 1 vcl/unx/generic/printer/printerinfomanager.cxx | 2 15 files changed, 243 insertions(+), 213 deletions(-)
New commits: commit a6c7c2fe1bc48ffddca486de0f97164421ca6404 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Wed Sep 26 09:09:53 2018 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Fri Sep 28 09:06:48 2018 +0200 loplugin:unusedfields Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747 Reviewed-on: https://gerrit.libreoffice.org/61059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index d6fb9aef851a..d0af141ef3a7 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -120,14 +120,22 @@ cppu/source/uno/check.cxx:138 (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3 cui/source/dialogs/colorpicker.cxx:719 cui::ColorPickerDialog m_aColorPrevious class cui::ColorPreviewControl -cui/source/factory/dlgfact.cxx:1396 +cui/source/factory/dlgfact.cxx:1398 SvxMacroAssignDialog m_aItems class SfxItemSet cui/source/inc/cfgutil.hxx:190 SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl -cui/source/inc/cuitabarea.hxx:236 +cui/source/inc/cuitabarea.hxx:234 SvxAreaTabPage maFixed_ChangeType enum ChangeType -cui/source/inc/cuitabarea.hxx:244 +cui/source/inc/cuitabarea.hxx:242 SvxAreaTabPage m_aXFillAttr class XFillAttrSetItem +cui/source/inc/tabstpge.hxx:93 + SvxTabulatorTabPage m_aLeftWin class TabWin_Impl +cui/source/inc/tabstpge.hxx:94 + SvxTabulatorTabPage m_aRightWin class TabWin_Impl +cui/source/inc/tabstpge.hxx:95 + SvxTabulatorTabPage m_aCenterWin class TabWin_Impl +cui/source/inc/tabstpge.hxx:96 + SvxTabulatorTabPage m_aDezWin class TabWin_Impl dbaccess/source/core/api/RowSet.hxx:111 dbaccess::ORowSet m_aURL class rtl::OUString dbaccess/source/core/api/RowSet.hxx:125 @@ -205,7 +213,7 @@ include/svx/ClassificationDialog.hxx:63 include/svx/itemwin.hxx:34 SvxLineBox aDelayTimer class Timer include/vcl/font/Feature.hxx:102 - vcl::font::Feature m_eType enum vcl::font::FeatureType + vcl::font::Feature m_eType const enum vcl::font::FeatureType include/xmloff/shapeimport.hxx:140 SdXML3DLightContext mbSpecular _Bool jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx:102 @@ -314,21 +322,25 @@ sc/source/core/data/document.cxx:1244 (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch sc/source/core/data/document.cxx:1245 (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast +sc/source/filter/html/htmlpars.cxx:3029 + (anonymous namespace)::CSSHandler::MemStr mp const char * +sc/source/filter/html/htmlpars.cxx:3030 + (anonymous namespace)::CSSHandler::MemStr mn size_t sc/source/filter/inc/htmlpars.hxx:614 ScHTMLQueryParser mnUnusedId ScHTMLTableId -sc/source/filter/inc/sheetdatacontext.hxx:61 +sc/source/filter/inc/sheetdatacontext.hxx:62 oox::xls::SheetDataContext aReleaser class SolarMutexReleaser -sc/source/filter/inc/xetable.hxx:1004 +sc/source/filter/inc/xetable.hxx:1002 XclExpCellTable maArrayBfr class XclExpArrayBuffer -sc/source/filter/inc/xetable.hxx:1005 +sc/source/filter/inc/xetable.hxx:1003 XclExpCellTable maShrfmlaBfr class XclExpShrfmlaBuffer -sc/source/filter/inc/xiescher.hxx:1201 +sc/source/filter/inc/xiescher.hxx:1202 XclImpDffPropSet maDummyStrm class SvMemoryStream -sc/source/filter/inc/xihelper.hxx:329 +sc/source/filter/inc/xihelper.hxx:328 XclImpCachedValue mxTokArr XclImpCachedValue::ScTokenArrayPtr -sc/source/filter/inc/xistream.hxx:171 +sc/source/filter/inc/xistream.hxx:172 XclImpBiff8StdDecrypter maCodec ::msfilter::MSCodec_Std97 -sc/source/filter/inc/xistream.hxx:193 +sc/source/filter/inc/xistream.hxx:194 XclImpBiff8CryptoAPIDecrypter maCodec ::msfilter::MSCodec_CryptoAPI sc/source/filter/oox/worksheethelper.cxx:387 oox::xls::WorksheetGlobals mxProgressBar oox::ISegmentProgressBarRef @@ -340,6 +352,16 @@ sc/source/filter/xml/xmltransformationi.hxx:121 ScXMLColumnNumberContext aType class rtl::OUString sc/source/filter/xml/xmltransformationi.hxx:155 ScXMLDateTimeContext aType class rtl::OUString +sc/source/ui/Accessibility/AccessibleText.cxx:52 + ScViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:273 + ScPreviewCellViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:289 + ScPreviewHeaderCellViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:305 + ScPreviewNoteViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:1309 + ScCsvViewForwarder maBoundBox tools::Rectangle sc/source/ui/inc/acredlin.hxx:58 ScAcceptChgDlg aReOpenIdle class Idle sc/source/ui/inc/anyrefdg.hxx:119 @@ -370,7 +392,7 @@ sccomp/source/solver/DifferentialEvolution.hxx:35 DifferentialEvolutionAlgorithm maRandomDevice std::random_device sccomp/source/solver/ParticelSwarmOptimization.hxx:56 ParticleSwarmOptimizationAlgorithm maRandomDevice std::random_device -scripting/source/stringresource/stringresource.cxx:1317 +scripting/source/stringresource/stringresource.cxx:1318 stringresource::BinaryInput m_aData Sequence<sal_Int8> sd/inc/anminfo.hxx:52 SdAnimationInfo maSecondSoundFile class rtl::OUString @@ -388,17 +410,15 @@ sd/source/ui/table/TableDesignPane.hxx:106 sd::TableDesignPane aImpl class sd::TableDesignWidget sd/source/ui/view/DocumentRenderer.cxx:1319 sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef -sd/source/ui/view/viewshel.cxx:1216 +sd/source/ui/view/viewshel.cxx:1211 sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock -sd/source/ui/view/viewshel.cxx:1217 +sd/source/ui/view/viewshel.cxx:1212 sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock -sd/source/ui/view/viewshel.cxx:1218 +sd/source/ui/view/viewshel.cxx:1213 sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock -sd/source/ui/view/viewshel.cxx:1219 +sd/source/ui/view/viewshel.cxx:1214 sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context -sfx2/source/dialog/itemconnect.cxx:139 - sfx::MultiControlWrapperHelper_Impl maVec sfx::ControlWrpVec -sfx2/source/doc/doctempl.cxx:115 +sfx2/source/doc/doctempl.cxx:116 DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock slideshow/source/engine/animationnodes/animationbasenode.hxx:89 slideshow::internal::AnimationBaseNode mpSubsetManager slideshow::internal::SubsettableShapeManagerSharedPtr @@ -420,7 +440,7 @@ slideshow/source/engine/smilfunctionparser.cxx:504 slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition identifier ::boost::spirit::rule<ScannerT> starmath/inc/view.hxx:218 SmViewShell maGraphicController class SmGraphicController -starmath/source/accessibility.hxx:273 +starmath/source/accessibility.hxx:271 SmEditSource rEditAcc class SmEditAccessible & svgio/inc/svgcharacternode.hxx:89 svgio::svgreader::SvgTextPosition maY ::std::vector<double> @@ -508,10 +528,6 @@ sw/source/ui/dbui/mmaddressblockpage.hxx:212 SwCustomizeAddressBlockDialog m_aTextFilter class TextFilter sw/source/uibase/docvw/romenu.hxx:35 SwReadOnlyPopup m_aBuilder class VclBuilder -sw/source/uibase/inc/chrdlg.hxx:43 - SwCharDlg m_nCharUrlId sal_uInt16 -sw/source/uibase/inc/chrdlg.hxx:45 - SwCharDlg m_nCharBrdId sal_uInt16 sw/source/uibase/inc/cption.hxx:44 SwCaptionDialog m_aTextFilter class TextFilterAutoConvert sw/source/uibase/inc/glossary.hxx:95 @@ -555,13 +571,7 @@ vcl/inc/opengl/RenderList.hxx:29 vcl/inc/opengl/RenderList.hxx:30 Vertex lineData glm::vec4 vcl/inc/opengl/zone.hxx:46 - OpenGLVCLContextZone aZone class OpenGLZone -vcl/inc/qt5/Qt5Graphics.hxx:61 - Qt5Graphics m_lastPopupRect class QRect -vcl/inc/qt5/Qt5Object.hxx:34 - Qt5Object m_aSystemData struct SystemEnvData -vcl/inc/qt5/Qt5Object.hxx:36 - Qt5Object m_pParent class Qt5Frame * + OpenGLVCLContextZone aZone const class OpenGLZone vcl/inc/salmenu.hxx:42 SalMenuButtonItem mnId sal_uInt16 vcl/inc/salmenu.hxx:43 @@ -582,26 +592,24 @@ vcl/inc/unx/i18n_ic.hxx:46 SalI18N_InputContext maSwitchIMCallback XIMCallback vcl/inc/unx/i18n_ic.hxx:47 SalI18N_InputContext maDestroyCallback XIMCallback -vcl/source/app/salvtables.cxx:1396 +vcl/source/app/salvtables.cxx:1462 SalInstanceEntry m_aTextFilter class SalInstanceEntry::WeldTextFilter vcl/source/gdi/jobset.cxx:35 ImplOldJobSetupData cDeviceName char [32] vcl/source/gdi/jobset.cxx:36 ImplOldJobSetupData cPortName char [32] -vcl/unx/gtk3/gtk3gtkinst.cxx:2248 +vcl/unx/gtk3/gtk3gtkinst.cxx:2255 CrippledViewport viewport GtkViewport vcl/unx/gtk/a11y/atkhypertext.cxx:29 - (anonymous) atk_hyper_link AtkHyperlink + (anonymous) atk_hyper_link const AtkHyperlink vcl/unx/gtk/a11y/atkwrapper.hxx:49 - AtkObjectWrapper aParent AtkObject -vcl/unx/gtk/a11y/atkwrapper.hxx:80 - AtkObjectWrapperClass aParentClass AtkObjectClass + AtkObjectWrapper aParent const AtkObject +vcl/unx/gtk/a11y/atkwrapper.hxx:78 + AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass vcl/unx/gtk/gloactiongroup.cxx:30 GLOAction parent_instance GObject vcl/unx/gtk/glomenu.cxx:20 - GLOMenu parent_instance GMenuModel -vcl/unx/kde5/KDE5FilePicker.hxx:81 - KDE5FilePicker allowRemoteUrls _Bool + GLOMenu parent_instance const GMenuModel writerfilter/source/dmapper/PropertyMap.hxx:197 writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32 xmloff/source/text/XMLTextListBlockContext.hxx:35 diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 704f95cd3d96..940c24fe2ed0 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -158,11 +158,11 @@ cui/source/options/optcolor.cxx:255 ColorConfigWindow_Impl aModuleOptions class SvtModuleOptions cui/source/options/optpath.cxx:79 OptPath_Impl m_aDefOpt class SvtDefaultOptions -cui/source/options/personalization.hxx:35 - SvxPersonalizationTabPage m_vDefaultPersonaImages VclPtr<class PushButton> [3] -cui/source/options/personalization.hxx:86 +cui/source/options/personalization.hxx:38 + SvxPersonalizationTabPage m_vDefaultPersonaImages VclPtr<class PushButton> [6] +cui/source/options/personalization.hxx:102 SelectPersonaDialog m_vResultList VclPtr<class PushButton> [9] -cui/source/options/personalization.hxx:87 +cui/source/options/personalization.hxx:103 SelectPersonaDialog m_vSearchSuggestions VclPtr<class PushButton> [6] cui/source/options/treeopt.cxx:469 OptionsGroupInfo m_bLoadError _Bool @@ -298,6 +298,12 @@ include/registry/refltype.hxx:69 RTUik m_Data5 sal_uInt32 include/sfx2/charmapcontrol.hxx:44 SfxCharmapCtrl m_pFavCharView VclPtr<class SvxCharViewControl> [16] +include/sfx2/itemconnect.hxx:234 + sfx::ItemControlConnection maItemWrp sfx::ItemControlConnection::ItemWrapperType +include/sfx2/itemconnect.hxx:235 + sfx::ItemControlConnection mxCtrlWrp std::unique_ptr<ControlWrpT> +include/sfx2/itemwrapper.hxx:115 + sfx::SingleItemWrapper mnSlot sal_uInt16 include/sfx2/msg.hxx:95 SfxTypeAttrib nAID sal_uInt16 include/sfx2/msg.hxx:96 @@ -318,6 +324,18 @@ include/svl/adrparse.hxx:52 SvAddressParser m_bHasFirst _Bool include/svl/ondemand.hxx:58 OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale +include/svtools/ctrlbox.hxx:449 + FontSizeBox nRelMin sal_uInt16 +include/svtools/ctrlbox.hxx:450 + FontSizeBox nRelMax sal_uInt16 +include/svtools/ctrlbox.hxx:451 + FontSizeBox nRelStep sal_uInt16 +include/svtools/ctrlbox.hxx:452 + FontSizeBox nPtRelMin short +include/svtools/ctrlbox.hxx:453 + FontSizeBox nPtRelMax short +include/svtools/ctrlbox.hxx:454 + FontSizeBox nPtRelStep short include/svtools/editsyntaxhighlighter.hxx:33 MultiLineEditSyntaxHighlight m_aColorConfig svtools::ColorConfig include/svx/sdr/overlay/overlayanimatedbitmapex.hxx:51 @@ -332,10 +350,6 @@ include/svx/svdoedge.hxx:160 SdrEdgeObj mbBoundRectCalculationRunning _Bool include/svx/svdpntv.hxx:170 SdrPaintView maDrawinglayerOpt class SvtOptionsDrawinglayer -include/svx/SvxPresetListBox.hxx:35 - SvxPresetListBox maRenameHdl Link<class SvxPresetListBox *, void> -include/svx/SvxPresetListBox.hxx:36 - SvxPresetListBox maDeleteHdl Link<class SvxPresetListBox *, void> include/test/sheet/xdatapilottable.hxx:31 apitest::XDataPilotTable xCellForChange css::uno::Reference<css::table::XCell> include/test/sheet/xdatapilottable.hxx:32 @@ -369,10 +383,10 @@ include/unoidl/unoidl.hxx:453 include/unotest/bootstrapfixturebase.hxx:37 test::BootstrapFixtureBase m_directories class test::Directories include/vcl/filter/pdfdocument.hxx:200 - vcl::filter::PDFNameElement m_nLength sal_uInt64 + vcl::filter::PDFNameElement m_nLength const sal_uInt64 include/vcl/opengl/OpenGLContext.hxx:57 OpenGLCapabilitySwitch mbLimitedShaderRegisters _Bool -include/vcl/opengl/OpenGLContext.hxx:177 +include/vcl/opengl/OpenGLContext.hxx:176 OpenGLContext mpLastFramebuffer class OpenGLFramebuffer * include/vcl/ppdparser.hxx:134 psp::PPDParser::PPDConstraint m_pKey1 const class psp::PPDKey * @@ -440,26 +454,34 @@ sc/source/core/inc/adiasync.hxx:42 ScAddInAsync::(anonymous) pStr class rtl::OUString * sc/source/core/inc/interpre.hxx:99 ScTokenStack pPointer const formula::FormulaToken *[512] -sc/source/filter/inc/autofilterbuffer.hxx:178 +sc/source/filter/excel/xltoolbar.cxx:34 + MSOExcelCommandConvertor msoToOOcmd IdToString +sc/source/filter/excel/xltoolbar.cxx:35 + MSOExcelCommandConvertor tcidToOOcmd IdToString +sc/source/filter/inc/autofilterbuffer.hxx:181 oox::xls::FilterColumn mxSettings std::shared_ptr<FilterSettingsBase> sc/source/filter/inc/commentsbuffer.hxx:42 oox::xls::CommentModel maAnchor css::awt::Rectangle -sc/source/filter/inc/defnamesbuffer.hxx:85 - oox::xls::DefinedNameBase maRefAny css::uno::Any sc/source/filter/inc/htmlpars.hxx:56 ScHTMLStyles maEmpty const class rtl::OUString -sc/source/filter/inc/namebuff.hxx:85 +sc/source/filter/inc/namebuff.hxx:80 RangeNameBufferWK3::Entry nAbsInd sal_uInt16 -sc/source/filter/inc/qproform.hxx:57 +sc/source/filter/inc/qproform.hxx:55 QProToSc mnAddToken struct TokenId -sc/source/filter/inc/stylesbuffer.hxx:675 +sc/source/filter/inc/stylesbuffer.hxx:676 oox::xls::Dxf mxAlignment std::shared_ptr<Alignment> -sc/source/filter/inc/stylesbuffer.hxx:677 +sc/source/filter/inc/stylesbuffer.hxx:678 oox::xls::Dxf mxProtection std::shared_ptr<Protection> -sc/source/filter/inc/workbooksettings.hxx:75 - oox::xls::CalcSettingsModel mbUseNlr _Bool +sc/source/filter/inc/stylesbuffer.hxx:767 + oox::xls::CellStyleBuffer maBuiltinStyles oox::xls::CellStyleBuffer::CellStyleVector +sc/source/filter/inc/stylesbuffer.hxx:768 + oox::xls::CellStyleBuffer maUserStyles oox::xls::CellStyleBuffer::CellStyleVector sc/source/filter/inc/xepage.hxx:122 XclExpChartPageSettings maData struct XclPageData +sc/source/filter/inc/xistyle.hxx:517 + XclImpXFBuffer maBuiltinStyles XclImpXFBuffer::XclImpStyleList +sc/source/filter/inc/xistyle.hxx:518 + XclImpXFBuffer maUserStyles XclImpXFBuffer::XclImpStyleList sc/source/filter/inc/xltracer.hxx:82 XclTracer mbEnabled _Bool sc/source/filter/xml/xmlcelli.hxx:96 @@ -478,6 +500,8 @@ sc/source/ui/vba/vbaformatconditions.hxx:37 ScVbaFormatConditions mxRangeParent css::uno::Reference<ov::excel::XRange> sc/source/ui/vba/vbaformatconditions.hxx:38 ScVbaFormatConditions mxParentRangePropertySet css::uno::Reference<css::beans::XPropertySet> +sc/source/ui/vba/vbaworksheet.hxx:54 + ScVbaWorksheet mxButtons ::rtl::Reference<ScVbaSheetObjectsBase> [2] sd/inc/Outliner.hxx:280 SdOutliner mpFirstObj class SdrObject * sd/inc/sdmod.hxx:116 @@ -498,6 +522,8 @@ sd/source/ui/sidebar/MasterPageContainer.cxx:155 sd::sidebar::MasterPageContainer::Implementation maSmallPreviewNotAvailable class Image sd/source/ui/slideshow/showwindow.hxx:103 sd::ShowWindow mbMouseCursorHidden _Bool +sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx:143 + sd::slidesorter::cache::PageCacheManager::RecentlyUsedPageCaches maMap std::map<key_type, mapped_type> sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx:97 sd::slidesorter::controller::Animator maElapsedTime ::canvas::tools::ElapsedTime sd/source/ui/table/TableDesignPane.hxx:96 @@ -510,7 +536,7 @@ sfx2/source/appl/lnkbase2.cxx:95 sfx2::ImplDdeItem pLink class sfx2::SvBaseLink * slideshow/source/engine/slideshowimpl.cxx:153 (anonymous namespace)::FrameSynchronization maTimer canvas::tools::ElapsedTime -sot/source/sdstor/ucbstorage.cxx:407 +sot/source/sdstor/ucbstorage.cxx:408 UCBStorageStream_Impl m_aKey class rtl::OString starmath/source/view.cxx:856 SmViewShell_Impl aOpts class SvtMiscOptions @@ -528,7 +554,7 @@ svtools/source/control/headbar.cxx:38 ImplHeadItem maHelpId class rtl::OString svtools/source/control/headbar.cxx:39 ImplHeadItem maImage class Image -svtools/source/control/tabbar.cxx:207 +svtools/source/control/tabbar.cxx:208 ImplTabBarItem maHelpId class rtl::OString svtools/source/dialogs/insdlg.cxx:46 OleObjectDescriptor cbSize sal_uInt32 @@ -574,14 +600,24 @@ sw/inc/acmplwrd.hxx:42 SwAutoCompleteWord m_LookupTree editeng::Trie sw/inc/calc.hxx:196 SwCalc m_aSysLocale class SvtSysLocale -sw/inc/hints.hxx:199 +sw/inc/hints.hxx:223 SwAttrSetChg m_bDelSet _Bool -sw/inc/shellio.hxx:141 +sw/inc/shellio.hxx:142 SwReader pStg tools::SvRef<SotStorage> sw/inc/swevent.hxx:71 SwCallMouseEvent::(anonymous union)::(anonymous) pFormat const class SwFrameFormat * sw/source/core/access/accfrmobjmap.hxx:100 SwAccessibleChildMap maMap std::map<key_type, mapped_type, key_compare> +sw/source/core/access/acchypertextdata.hxx:40 + SwAccessibleHyperTextData maMap std::map<key_type, mapped_type, key_compare> +sw/source/core/access/accmap.cxx:99 + SwAccessibleContextMap_Impl maMap std::map<key_type, mapped_type, key_compare> +sw/source/core/access/accmap.cxx:233 + SwAccessibleShapeMap_Impl maMap std::map<key_type, mapped_type, SwShapeFunc> +sw/source/core/access/accmap.cxx:590 + SwAccessibleEventMap_Impl maMap std::map<key_type, mapped_type, key_compare> +sw/source/core/access/accmap.cxx:630 + SwAccessibleSelectedParas_Impl maMap std::map<key_type, mapped_type, key_compare> sw/source/core/doc/swstylemanager.cxx:58 SwStyleManager aAutoCharPool class StylePool sw/source/core/doc/swstylemanager.cxx:59 @@ -653,37 +689,43 @@ unoidl/source/unoidlprovider.cxx:455 unoidl/source/unoidlprovider.cxx:456 unoidl::detail::MapEntry data struct unoidl::detail::(anonymous namespace)::Memory32 unotools/source/config/pathoptions.cxx:90 - SvtPathOptions_Impl m_aEmptyString class rtl::OUString + SvtPathOptions_Impl m_aEmptyString const class rtl::OUString unotools/source/config/saveopt.cxx:77 SvtSaveOptions_Impl bROUserAutoSave _Bool vcl/inc/BitmapFastScaleFilter.hxx:31 - BitmapFastScaleFilter maSize class Size + BitmapFastScaleFilter maSize const class Size vcl/inc/printerinfomanager.hxx:73 psp::PrinterInfoManager::SystemPrintQueue m_aComment class rtl::OUString vcl/inc/salwtype.hxx:154 SalWheelMouseEvent mbDeltaIsPixel _Bool vcl/inc/salwtype.hxx:201 - SalSurroundingTextSelectionChangeEvent mnStart sal_uLong + SalSurroundingTextSelectionChangeEvent mnStart const sal_uLong vcl/inc/salwtype.hxx:202 - SalSurroundingTextSelectionChangeEvent mnEnd sal_uLong + SalSurroundingTextSelectionChangeEvent mnEnd const sal_uLong vcl/inc/salwtype.hxx:208 SalQueryCharPositionEvent mnCharPos sal_uLong -vcl/inc/svdata.hxx:267 - ImplSVNWFData mnStatusBarLowerRightOffset int vcl/inc/svdata.hxx:273 + ImplSVNWFData mnStatusBarLowerRightOffset int +vcl/inc/svdata.hxx:279 ImplSVNWFData mbMenuBarDockingAreaCommonBG _Bool -vcl/inc/svdata.hxx:283 +vcl/inc/svdata.hxx:289 ImplSVNWFData mbCenteredTabs _Bool -vcl/inc/svdata.hxx:284 +vcl/inc/svdata.hxx:290 ImplSVNWFData mbNoActiveTabTextRaise _Bool -vcl/inc/svdata.hxx:286 +vcl/inc/svdata.hxx:292 ImplSVNWFData mbProgressNeedsErase _Bool +vcl/inc/svdata.hxx:301 + ImplSVNWFData mbRolloverMenubar _Bool +vcl/inc/toolbox.h:108 + vcl::ToolBoxLayoutData m_aLineItemIds std::vector<sal_uInt16> vcl/inc/unx/i18n_status.hxx:56 - vcl::I18NStatus m_aCurrentIM class rtl::OUString + vcl::I18NStatus m_aCurrentIM const class rtl::OUString vcl/inc/unx/saldisp.hxx:288 - SalDisplay m_aInvalidScreenData struct SalDisplay::ScreenData + SalDisplay m_aInvalidScreenData const struct SalDisplay::ScreenData +vcl/source/control/tabctrl.cxx:70 + ImplTabCtrlData maLayoutPageIdToLine std::unordered_map<int, int> vcl/source/filter/jpeg/Exif.hxx:62 - Exif::TiffHeader byteOrder sal_uInt16 + Exif::TiffHeader byteOrder const sal_uInt16 vcl/source/filter/jpeg/transupp.h:132 (anonymous) slow_hflip boolean vcl/source/filter/jpeg/transupp.h:144 @@ -695,11 +737,11 @@ vcl/source/filter/jpeg/transupp.h:148 vcl/source/filter/jpeg/transupp.h:150 (anonymous) crop_yoffset_set JCROP_CODE vcl/source/fontsubset/sft.cxx:1049 - vcl::_subHeader2 firstCode sal_uInt16 + vcl::_subHeader2 firstCode const sal_uInt16 vcl/source/fontsubset/sft.cxx:1050 - vcl::_subHeader2 entryCount sal_uInt16 + vcl::_subHeader2 entryCount const sal_uInt16 vcl/source/fontsubset/sft.cxx:1051 - vcl::_subHeader2 idDelta sal_uInt16 + vcl::_subHeader2 idDelta const sal_uInt16 vcl/source/gdi/dibtools.cxx:51 (anonymous namespace)::CIEXYZ aXyzX FXPT2DOT30 vcl/source/gdi/dibtools.cxx:52 @@ -737,40 +779,42 @@ vcl/source/gdi/dibtools.cxx:118 vcl/source/gdi/pdfwriter_impl.hxx:299 vcl::PDFWriterImpl::TransparencyEmit m_pSoftMaskStream std::unique_ptr<SvMemoryStream> vcl/source/window/menuitemlist.hxx:57 - MenuItemData aAccessibleName class rtl::OUString + MenuItemData aAccessibleName const class rtl::OUString vcl/unx/generic/print/bitmap_gfx.cxx:67 psp::HexEncoder mpFileBuffer sal_Char [16400] vcl/unx/gtk/a11y/atkwrapper.hxx:49 - AtkObjectWrapper aParent AtkObject -vcl/unx/gtk/a11y/atkwrapper.hxx:80 - AtkObjectWrapperClass aParentClass AtkObjectClass + AtkObjectWrapper aParent const AtkObject +vcl/unx/gtk/a11y/atkwrapper.hxx:78 + AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass vcl/unx/gtk/gloactiongroup.cxx:30 GLOAction parent_instance GObject vcl/unx/gtk/glomenu.cxx:20 - GLOMenu parent_instance GMenuModel + GLOMenu parent_instance const GMenuModel +writerfilter/inc/ooxml/QNameToString.hxx:41 + writerfilter::QNameToString mMap writerfilter::QNameToString::Map writerfilter/source/dmapper/DomainMapper_Impl.hxx:410 - writerfilter::dmapper::DomainMapper_Impl m_aSaveOpt class SvtSaveOptions + writerfilter::dmapper::DomainMapper_Impl m_aSaveOpt const class SvtSaveOptions writerfilter/source/ooxml/OOXMLFactory.hxx:62 - writerfilter::ooxml::AttributeInfo m_nToken writerfilter::Token_t + writerfilter::ooxml::AttributeInfo m_nToken const writerfilter::Token_t writerfilter/source/ooxml/OOXMLFactory.hxx:63 - writerfilter::ooxml::AttributeInfo m_nResource enum writerfilter::ooxml::ResourceType + writerfilter::ooxml::AttributeInfo m_nResource const enum writerfilter::ooxml::ResourceType writerfilter/source/ooxml/OOXMLFactory.hxx:64 - writerfilter::ooxml::AttributeInfo m_nRef Id + writerfilter::ooxml::AttributeInfo m_nRef const Id xmloff/inc/MultiPropertySetHelper.hxx:78 - MultiPropertySetHelper aEmptyAny css::uno::Any + MultiPropertySetHelper aEmptyAny const css::uno::Any xmloff/source/chart/SchXMLChartContext.cxx:448 - (anonymous namespace)::NewDonutSeries msStyleName class rtl::OUString + (anonymous namespace)::NewDonutSeries msStyleName const class rtl::OUString xmloff/source/chart/SchXMLChartContext.hxx:54 - SeriesDefaultsAndStyles maErrorIndicatorDefault css::uno::Any + SeriesDefaultsAndStyles maErrorIndicatorDefault const css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:55 - SeriesDefaultsAndStyles maErrorCategoryDefault css::uno::Any + SeriesDefaultsAndStyles maErrorCategoryDefault const css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:56 - SeriesDefaultsAndStyles maConstantErrorLowDefault css::uno::Any + SeriesDefaultsAndStyles maConstantErrorLowDefault const css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:57 - SeriesDefaultsAndStyles maConstantErrorHighDefault css::uno::Any + SeriesDefaultsAndStyles maConstantErrorHighDefault const css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:58 - SeriesDefaultsAndStyles maPercentageErrorDefault css::uno::Any + SeriesDefaultsAndStyles maPercentageErrorDefault const css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:59 - SeriesDefaultsAndStyles maErrorMarginDefault css::uno::Any -xmloff/source/core/xmlexp.cxx:258 - SvXMLExport_Impl maSaveOptions class SvtSaveOptions + SeriesDefaultsAndStyles maErrorMarginDefault const css::uno::Any +xmloff/source/core/xmlexp.cxx:260 + SvXMLExport_Impl maSaveOptions const class SvtSaveOptions diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index 1533679669d6..9553918ad64d 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -40,6 +40,10 @@ cui/source/dialogs/colorpicker.cxx:721 cui::ColorPickerDialog m_xColorField std::unique_ptr<weld::CustomWeld> cui/source/dialogs/colorpicker.cxx:723 cui::ColorPickerDialog m_xColorPreview std::unique_ptr<weld::CustomWeld> +cui/source/inc/align.hxx:89 + svx::AlignmentTabPage m_xFtVerAlign std::unique_ptr<weld::Label> +cui/source/inc/align.hxx:98 + svx::AlignmentTabPage m_xBoxDirection std::unique_ptr<weld::Widget> cui/source/inc/cfg.hxx:575 SvxNewToolbarDialog m_xBtnOK std::unique_ptr<weld::Button> cui/source/inc/cuicharmap.hxx:104 @@ -52,9 +56,13 @@ cui/source/inc/cuicharmap.hxx:108 SvxCharacterMap m_xShowSetArea std::unique_ptr<weld::CustomWeld> cui/source/inc/cuicharmap.hxx:110 SvxCharacterMap m_xSearchSetArea std::unique_ptr<weld::CustomWeld> -cui/source/inc/cuitabarea.hxx:718 +cui/source/inc/cuigrfflt.hxx:84 + GraphicFilterDialog mxPreview std::unique_ptr<weld::CustomWeld> +cui/source/inc/cuigrfflt.hxx:180 + GraphicFilterEmboss mxCtlLight std::unique_ptr<weld::CustomWeld> +cui/source/inc/cuitabarea.hxx:709 SvxColorTabPage m_xCtlPreviewOld std::unique_ptr<weld::CustomWeld> -cui/source/inc/cuitabarea.hxx:719 +cui/source/inc/cuitabarea.hxx:710 SvxColorTabPage m_xCtlPreviewNew std::unique_ptr<weld::CustomWeld> cui/source/inc/FontFeaturesDialog.hxx:53 cui::FontFeaturesDialog m_xPreviewWindow std::unique_ptr<weld::CustomWeld> @@ -76,9 +84,9 @@ cui/source/inc/textattr.hxx:69 SvxTextAttrPage m_xCtlPosition std::unique_ptr<weld::CustomWeld> cui/source/inc/transfrm.hxx:104 SvxPositionSizeTabPage m_xCtlPos std::unique_ptr<weld::CustomWeld> -cui/source/inc/transfrm.hxx:191 +cui/source/inc/transfrm.hxx:190 SvxAngleTabPage m_xCtlRect std::unique_ptr<weld::CustomWeld> -cui/source/inc/transfrm.hxx:194 +cui/source/inc/transfrm.hxx:193 SvxAngleTabPage m_xCtlAngle std::unique_ptr<weld::CustomWeld> dbaccess/source/sdbtools/inc/connectiondependent.hxx:116 sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard @@ -110,7 +118,7 @@ include/sfx2/msg.hxx:117 SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> include/sfx2/msg.hxx:119 SfxType0 nAttribs sal_uInt16 -include/svtools/ctrlbox.hxx:355 +include/svtools/ctrlbox.hxx:353 SvtLineListBox m_xLineSetWin std::unique_ptr<weld::CustomWeld> include/svtools/genericunodialog.hxx:218 svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard @@ -127,7 +135,7 @@ include/svx/colorwindow.hxx:133 include/svx/hdft.hxx:87 SvxHFPage m_xBspWin std::unique_ptr<weld::CustomWeld> include/vcl/font/Feature.hxx:102 - vcl::font::Feature m_eType enum vcl::font::FeatureType + vcl::font::Feature m_eType const enum vcl::font::FeatureType include/vcl/uitest/uiobject.hxx:270 TabPageUIObject mxTabPage VclPtr<class TabPage> include/xmloff/formlayerexport.hxx:173 @@ -192,13 +200,27 @@ sc/source/core/data/document.cxx:1244 (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch sc/source/core/data/document.cxx:1245 (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast -sc/source/filter/inc/sheetdatacontext.hxx:61 +sc/source/filter/html/htmlpars.cxx:3029 + (anonymous namespace)::CSSHandler::MemStr mp const char * +sc/source/filter/html/htmlpars.cxx:3030 + (anonymous namespace)::CSSHandler::MemStr mn size_t +sc/source/filter/inc/sheetdatacontext.hxx:62 oox::xls::SheetDataContext aReleaser class SolarMutexReleaser +sc/source/ui/Accessibility/AccessibleText.cxx:52 + ScViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:273 + ScPreviewCellViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:289 + ScPreviewHeaderCellViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:305 + ScPreviewNoteViewForwarder maCellPos class ScAddress +sc/source/ui/Accessibility/AccessibleText.cxx:1309 + ScCsvViewForwarder maBoundBox tools::Rectangle sc/source/ui/inc/crdlg.hxx:33 ScColOrRowDlg m_xBtnRows std::unique_ptr<weld::RadioButton> sc/source/ui/inc/delcodlg.hxx:39 ScDeleteContentsDlg m_xBtnOk std::unique_ptr<weld::Button> -sc/source/ui/inc/docsh.hxx:463 +sc/source/ui/inc/docsh.hxx:462 ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector> sc/source/ui/inc/instbdlg.hxx:66 ScInsertTableDlg m_xBtnBehind std::unique_ptr<weld::RadioButton> @@ -220,41 +242,41 @@ sd/source/ui/table/TableDesignPane.hxx:106 sd::TableDesignPane aImpl class sd::TableDesignWidget sd/source/ui/view/DocumentRenderer.cxx:1319 sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef -sd/source/ui/view/viewshel.cxx:1216 +sd/source/ui/view/viewshel.cxx:1211 sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock -sd/source/ui/view/viewshel.cxx:1217 +sd/source/ui/view/viewshel.cxx:1212 sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock -sd/source/ui/view/viewshel.cxx:1218 +sd/source/ui/view/viewshel.cxx:1213 sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock -sd/source/ui/view/viewshel.cxx:1219 +sd/source/ui/view/viewshel.cxx:1214 sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context sd/source/ui/view/ViewShellBase.cxx:193 sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager> -sfx2/source/dialog/itemconnect.cxx:139 - sfx::MultiControlWrapperHelper_Impl maVec sfx::ControlWrpVec -sfx2/source/doc/doctempl.cxx:115 +sfx2/source/doc/doctempl.cxx:116 DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock sfx2/source/inc/sfxpicklist.hxx:33 SfxPickList mxImpl std::unique_ptr<SfxPickListImpl> -sfx2/source/view/viewfrm.cxx:161 +sfx2/source/view/viewfrm.cxx:163 (anonymous namespace)::SfxEditDocumentDialog m_xEditDocument std::unique_ptr<weld::Button> -sfx2/source/view/viewfrm.cxx:162 +sfx2/source/view/viewfrm.cxx:164 (anonymous namespace)::SfxEditDocumentDialog m_xCancel std::unique_ptr<weld::Button> -starmath/inc/dialog.hxx:347 +starmath/inc/dialog.hxx:91 + SmFontDialog m_xShowFont std::unique_ptr<weld::CustomWeld> +starmath/inc/dialog.hxx:331 SmSymbolDialog m_xSymbolSetDisplayArea std::unique_ptr<weld::CustomWeld> -starmath/inc/dialog.hxx:349 +starmath/inc/dialog.hxx:333 SmSymbolDialog m_xSymbolDisplay std::unique_ptr<weld::CustomWeld> -starmath/inc/dialog.hxx:426 +starmath/inc/dialog.hxx:410 SmSymDefineDialog m_xOldSymbolDisplay std::unique_ptr<weld::CustomWeld> -starmath/inc/dialog.hxx:427 +starmath/inc/dialog.hxx:411 SmSymDefineDialog m_xSymbolDisplay std::unique_ptr<weld::CustomWeld> -starmath/inc/dialog.hxx:429 +starmath/inc/dialog.hxx:413 SmSymDefineDialog m_xCharsetDisplayArea std::unique_ptr<weld::CustomWeld> starmath/inc/smmod.hxx:69 SmModule mpLocSymbolData std::unique_ptr<SmLocalizedSymbolData> starmath/inc/view.hxx:218 SmViewShell maGraphicController class SmGraphicController -starmath/source/accessibility.hxx:273 +starmath/source/accessibility.hxx:271 SmEditSource rEditAcc class SmEditAccessible & svl/source/crypto/cryptosign.cxx:121 (anonymous namespace)::(anonymous) extnID SECItem @@ -319,20 +341,10 @@ unoidl/source/unoidlprovider.cxx:673 uui/source/unknownauthdlg.hxx:36 UnknownAuthDialog m_xOptionButtonDontAccept std::unique_ptr<weld::RadioButton> vcl/inc/opengl/zone.hxx:46 - OpenGLVCLContextZone aZone class OpenGLZone -vcl/inc/qt5/Qt5Data.hxx:35 - Qt5Data m_pGlyphCache std::unique_ptr<GlyphCache> -vcl/inc/qt5/Qt5Graphics.hxx:59 - Qt5Graphics m_focusedButton std::unique_ptr<QPushButton> -vcl/inc/qt5/Qt5Graphics.hxx:60 - Qt5Graphics m_image std::unique_ptr<QImage> -vcl/inc/qt5/Qt5Graphics.hxx:61 - Qt5Graphics m_lastPopupRect class QRect -vcl/inc/qt5/Qt5Object.hxx:34 - Qt5Object m_aSystemData struct SystemEnvData + OpenGLVCLContextZone aZone const class OpenGLZone vcl/inc/salprn.hxx:44 SalPrinterQueueInfo mpPortName std::unique_ptr<OUString> -vcl/source/app/salvtables.cxx:520 +vcl/source/app/salvtables.cxx:564 SalInstanceContainer m_xContainer VclPtr<vcl::Window> vcl/source/gdi/jobset.cxx:35 ImplOldJobSetupData cDeviceName char [32] @@ -344,12 +356,10 @@ vcl/unx/generic/print/prtsetup.hxx:73 RTSPaperPage m_xContainer std::unique_ptr<weld::Widget> vcl/unx/generic/print/prtsetup.hxx:108 RTSDevicePage m_xContainer std::unique_ptr<weld::Widget> -vcl/unx/gtk3/gtk3gtkinst.cxx:2248 +vcl/unx/gtk3/gtk3gtkinst.cxx:2255 CrippledViewport viewport GtkViewport vcl/unx/gtk/a11y/atkhypertext.cxx:29 - (anonymous) atk_hyper_link AtkHyperlink -vcl/unx/kde5/KDE5FilePicker.hxx:81 - KDE5FilePicker allowRemoteUrls _Bool + (anonymous) atk_hyper_link const AtkHyperlink writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43 writerfilter::ooxml::OOXMLStreamImpl mxFastParser css::uno::Reference<css::xml::sax::XFastParser> writerperfect/inc/WPFTEncodingDialog.hxx:37 diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index 7cf1b46b8308..669d348e7f89 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -146,6 +146,8 @@ cui/source/inc/cuihyperdlg.hxx:57 SvxHlinkCtrl aRdOnlyForwarder class SfxStatusForwarder cui/source/inc/cuihyperdlg.hxx:77 SvxHpLinkDlg maCtrl class SvxHlinkCtrl +cui/source/inc/grfpage.hxx:62 + SvxGrfCropPage bReset _Bool dbaccess/source/core/dataaccess/documentdefinition.cxx:287 dbaccess::LifetimeCoupler m_xClient Reference<class com::sun::star::uno::XInterface> desktop/qa/desktop_lib/test_desktop_lib.cxx:178 @@ -340,17 +342,17 @@ sc/source/filter/excel/xltools.cxx:104 smD union sal_math_Double sc/source/filter/inc/exp_op.hxx:47 ExportBiff5 pExcRoot struct RootData * -sc/source/filter/inc/imp_op.hxx:81 +sc/source/filter/inc/imp_op.hxx:84 ImportExcel::LastFormula mpCell class ScFormulaCell * -sc/source/filter/inc/orcusinterface.hxx:450 +sc/source/filter/inc/orcusinterface.hxx:446 ScOrcusStyles::xf mnStyleXf size_t -sc/source/filter/inc/orcusinterface.hxx:470 +sc/source/filter/inc/orcusinterface.hxx:466 ScOrcusStyles::cell_style mnBuiltInId size_t -sc/source/filter/inc/root.hxx:95 +sc/source/filter/inc/root.hxx:92 LOTUS_ROOT eActType enum Lotus123Typ -sc/source/filter/inc/root.hxx:96 +sc/source/filter/inc/root.hxx:93 LOTUS_ROOT aActRange class ScRange -sc/source/filter/inc/tokstack.hxx:145 +sc/source/filter/inc/tokstack.hxx:142 TokenPool pP_Err TokenPoolPool<sal_uInt16, 8> sc/source/filter/oox/biffhelper.cxx:41 oox::xls::(anonymous namespace)::DecodedDouble maStruct union sal_math_Double @@ -362,6 +364,8 @@ sc/source/filter/xml/xmlexternaltabi.hxx:112 ScXMLExternalRefCellContext mnCellType sal_Int16 sc/source/ui/inc/AccessibleText.hxx:194 ScAccessiblePreviewHeaderCellTextData mbRowHeader _Bool +sc/source/ui/inc/AccessibleText.hxx:223 + ScAccessibleHeaderTextData mbHeader _Bool sc/source/ui/inc/datastream.hxx:108 sc::DataStream mnSettings sal_uInt32 sc/source/ui/inc/preview.hxx:47 @@ -390,6 +394,8 @@ slideshow/source/engine/opengl/TransitionImpl.hxx:297 Vertex texcoord glm::vec2 slideshow/source/engine/slideshowimpl.cxx:1043 (anonymous namespace)::SlideShowImpl::PrefetchPropertiesFunc mpSlideShowImpl class (anonymous namespace)::SlideShowImpl *const +slideshow/source/inc/shapeattributelayer.hxx:501 + slideshow::internal::ShapeAttributeLayer mnCharRotationAngle double soltools/cpp/cpp.h:143 macroValidator pMacro Nlist * starmath/inc/view.hxx:158 @@ -436,7 +442,7 @@ svx/source/svdraw/svdpdf.hxx:197 ImpSdrPdfImport mdPageWidthPts double svx/source/table/tablertfimporter.cxx:54 sdr::table::RTFCellDefault maItemSet class SfxItemSet -sw/inc/shellio.hxx:146 +sw/inc/shellio.hxx:147 SwReader aFileName class rtl::OUString sw/source/core/doc/tblafmt.cxx:186 SwAfVersions m_nVerticalAlignmentVersion sal_uInt16 @@ -484,10 +490,8 @@ vcl/inc/opengl/RenderList.hxx:29 Vertex color glm::vec4 vcl/inc/opengl/RenderList.hxx:30 Vertex lineData glm::vec4 -vcl/inc/qt5/Qt5Frame.hxx:65 - Qt5Frame m_pSalMenu class Qt5Menu * -vcl/inc/qt5/Qt5Graphics.hxx:56 - Qt5Graphics m_pFontCollection class PhysicalFontCollection * +vcl/inc/printerinfomanager.hxx:100 + psp::PrinterInfoManager::Printer m_bModified _Bool vcl/inc/salmenu.hxx:34 SalItemParams nBits enum MenuItemBits vcl/inc/salmenu.hxx:42 @@ -514,13 +518,13 @@ vcl/inc/salwtype.hxx:213 SalQueryCharPositionEvent mnCursorBoundHeight long vcl/inc/salwtype.hxx:248 SalSwipeEvent mnVelocityY double -vcl/inc/sft.hxx:461 +vcl/inc/sft.hxx:462 vcl::TrueTypeFont mapper sal_uInt32 (*)(const sal_uInt8 *, sal_uInt32, sal_uInt32) vcl/inc/unx/gtk/gtkframe.hxx:215 GtkSalFrame m_nFloatFlags enum FloatWinPopupFlags vcl/opengl/salbmp.cxx:440 (anonymous namespace)::ScanlineWriter mpCurrentScanline sal_uInt8 * -vcl/source/filter/graphicfilter.cxx:1009 +vcl/source/filter/graphicfilter.cxx:1010 ImpFilterLibCache mpLast struct ImpFilterLibCacheEntry * vcl/source/filter/jpeg/Exif.hxx:56 Exif::ExifIFD type sal_uInt16 @@ -531,20 +535,16 @@ vcl/unx/generic/app/wmadaptor.cxx:1269 vcl/unx/generic/app/wmadaptor.cxx:1270 _mwmhints status unsigned long vcl/unx/gtk/a11y/atkwrapper.hxx:49 - AtkObjectWrapper aParent AtkObject -vcl/unx/gtk/a11y/atkwrapper.hxx:80 - AtkObjectWrapperClass aParentClass AtkObjectClass + AtkObjectWrapper aParent const AtkObject +vcl/unx/gtk/a11y/atkwrapper.hxx:78 + AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass vcl/unx/gtk/gloactiongroup.cxx:30 GLOAction parent_instance GObject vcl/unx/gtk/glomenu.cxx:20 - GLOMenu parent_instance GMenuModel + GLOMenu parent_instance const GMenuModel vcl/unx/gtk/hudawareness.cxx:20 (anonymous) connection GDBusConnection * vcl/unx/gtk/hudawareness.cxx:23 (anonymous) notify GDestroyNotify -vcl/unx/kde4/KDEXLib.hxx:49 - KDEXLib::SocketData pending YieldFunc -vcl/unx/kde4/KDEXLib.hxx:50 - KDEXLib::SocketData queued YieldFunc writerfilter/source/dmapper/PropertyMap.hxx:197 writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32 diff --git a/cui/source/inc/grfpage.hxx b/cui/source/inc/grfpage.hxx index e1b15e2c1520..9843e32387e4 100644 --- a/cui/source/inc/grfpage.hxx +++ b/cui/source/inc/grfpage.hxx @@ -59,7 +59,6 @@ class SvxGrfCropPage : public SfxTabPage Size aPageSize; long nOldWidth; long nOldHeight; - bool bReset; bool bSetOrigSize; SvxCropExample m_aExampleWN; diff --git a/cui/source/tabpages/grfpage.cxx b/cui/source/tabpages/grfpage.cxx index a94e1b4569b7..49cd1da7b7c8 100644 --- a/cui/source/tabpages/grfpage.cxx +++ b/cui/source/tabpages/grfpage.cxx @@ -53,7 +53,6 @@ SvxGrfCropPage::SvxGrfCropPage(TabPageParent pParent, const SfxItemSet &rSet) : SfxTabPage(pParent, "cui/ui/croppage.ui", "CropPage", &rSet) , nOldWidth(0) , nOldHeight(0) - , bReset(false) , bSetOrigSize(false) , m_xCropFrame(m_xBuilder->weld_widget("cropframe")) , m_xZoomConstRB(m_xBuilder->weld_radio_button("keepscale")) @@ -217,9 +216,7 @@ void SvxGrfCropPage::Reset( const SfxItemSet *rSet ) } GraphicHasChanged( bFound ); - bReset = true; ActivatePage( *rSet ); - bReset = false; } bool SvxGrfCropPage::FillItemSet(SfxItemSet *rSet) diff --git a/sc/source/ui/Accessibility/AccessiblePageHeader.cxx b/sc/source/ui/Accessibility/AccessiblePageHeader.cxx index 41408fc18639..e8c2d2818d26 100644 --- a/sc/source/ui/Accessibility/AccessiblePageHeader.cxx +++ b/sc/source/ui/Accessibility/AccessiblePageHeader.cxx @@ -362,12 +362,12 @@ void ScAccessiblePageHeader::AddChild(const EditTextObject* pArea, sal_uInt32 nI { if (!ScGlobal::EETextObjEqual(maAreas[nIndex]->GetEditTextObject(), pArea)) { - maAreas[nIndex] = new ScAccessiblePageHeaderArea(this, mpViewShell, pArea, mbHeader, eAdjust); + maAreas[nIndex] = new ScAccessiblePageHeaderArea(this, mpViewShell, pArea, eAdjust); } } else { - maAreas[nIndex] = new ScAccessiblePageHeaderArea(this, mpViewShell, pArea, mbHeader, eAdjust); + maAreas[nIndex] = new ScAccessiblePageHeaderArea(this, mpViewShell, pArea, eAdjust); } ++mnChildCount; } diff --git a/sc/source/ui/Accessibility/AccessiblePageHeaderArea.cxx b/sc/source/ui/Accessibility/AccessiblePageHeaderArea.cxx index 1109f8de7429..c68232e2081f 100644 --- a/sc/source/ui/Accessibility/AccessiblePageHeaderArea.cxx +++ b/sc/source/ui/Accessibility/AccessiblePageHeaderArea.cxx @@ -49,12 +49,10 @@ ScAccessiblePageHeaderArea::ScAccessiblePageHeaderArea( const uno::Reference<XAccessible>& rxParent, ScPreviewShell* pViewShell, const EditTextObject* pEditObj, - bool bHeader, SvxAdjust eAdjust) : ScAccessibleContextBase(rxParent, AccessibleRole::TEXT), mpEditObj(pEditObj->Clone().release()), mpViewShell(pViewShell), - mbHeader(bHeader), meAdjust(eAdjust) { if (mpViewShell) @@ -280,7 +278,7 @@ void ScAccessiblePageHeaderArea::CreateTextHelper() mpTextHelper.reset( new ::accessibility::AccessibleTextHelper( o3tl::make_unique<ScAccessibilityEditSource>( o3tl::make_unique<ScAccessibleHeaderTextData>( - mpViewShell, mpEditObj.get(), mbHeader, meAdjust))) ); + mpViewShell, mpEditObj.get(), meAdjust))) ); mpTextHelper->SetEventSource(this); } } diff --git a/sc/source/ui/Accessibility/AccessibleText.cxx b/sc/source/ui/Accessibility/AccessibleText.cxx index a3ca67e793ab..246db80cad97 100644 --- a/sc/source/ui/Accessibility/AccessibleText.cxx +++ b/sc/source/ui/Accessibility/AccessibleText.cxx @@ -49,10 +49,9 @@ class ScViewForwarder : public SvxViewForwarder { ScTabViewShell* mpViewShell; - ScAddress maCellPos; ScSplitPos meSplitPos; public: - ScViewForwarder(ScTabViewShell* pViewShell, ScSplitPos eSplitPos, const ScAddress& rCell); + ScViewForwarder(ScTabViewShell* pViewShell, ScSplitPos eSplitPos); virtual bool IsValid() const override; virtual Point LogicToPixel( const Point& rPoint, const MapMode& rMapMode ) const override; @@ -61,10 +60,9 @@ public: void SetInvalid(); }; -ScViewForwarder::ScViewForwarder(ScTabViewShell* pViewShell, ScSplitPos eSplitPos, const ScAddress& rCell) +ScViewForwarder::ScViewForwarder(ScTabViewShell* pViewShell, ScSplitPos eSplitPos) : mpViewShell(pViewShell), - maCellPos(rCell), meSplitPos(eSplitPos) { } @@ -270,49 +268,37 @@ ScPreviewHeaderFooterViewForwarder::ScPreviewHeaderFooterViewForwarder(ScPreview class ScPreviewCellViewForwarder : public ScPreviewViewForwarder { - ScAddress maCellPos; public: - ScPreviewCellViewForwarder(ScPreviewShell* pViewShell, - const ScAddress& aCellPos); + ScPreviewCellViewForwarder(ScPreviewShell* pViewShell); }; -ScPreviewCellViewForwarder::ScPreviewCellViewForwarder(ScPreviewShell* pViewShell, - const ScAddress& aCellPos) +ScPreviewCellViewForwarder::ScPreviewCellViewForwarder(ScPreviewShell* pViewShell) : - ScPreviewViewForwarder(pViewShell), - maCellPos(aCellPos) + ScPreviewViewForwarder(pViewShell) { } class ScPreviewHeaderCellViewForwarder : public ScPreviewViewForwarder { - ScAddress maCellPos; public: - ScPreviewHeaderCellViewForwarder(ScPreviewShell* pViewShell, - const ScAddress& aCellPos); + ScPreviewHeaderCellViewForwarder(ScPreviewShell* pViewShell); }; -ScPreviewHeaderCellViewForwarder::ScPreviewHeaderCellViewForwarder(ScPreviewShell* pViewShell, - const ScAddress& aCellPos) +ScPreviewHeaderCellViewForwarder::ScPreviewHeaderCellViewForwarder(ScPreviewShell* pViewShell) : - ScPreviewViewForwarder(pViewShell), - maCellPos(aCellPos) + ScPreviewViewForwarder(pViewShell) { } class ScPreviewNoteViewForwarder : public ScPreviewViewForwarder { - ScAddress maCellPos; public: - ScPreviewNoteViewForwarder(ScPreviewShell* pViewShell, - const ScAddress& aCellPos); + ScPreviewNoteViewForwarder(ScPreviewShell* pViewShell); }; -ScPreviewNoteViewForwarder::ScPreviewNoteViewForwarder(ScPreviewShell* pViewShell, - const ScAddress& aCellPos) +ScPreviewNoteViewForwarder::ScPreviewNoteViewForwarder(ScPreviewShell* pViewShell) : - ScPreviewViewForwarder(pViewShell), - maCellPos(aCellPos) + ScPreviewViewForwarder(pViewShell) { } @@ -632,7 +618,7 @@ SvxTextForwarder* ScAccessibleCellTextData::GetTextForwarder() SvxViewForwarder* ScAccessibleCellTextData::GetViewForwarder() { if (!mpViewForwarder) - mpViewForwarder.reset(new ScViewForwarder(mpViewShell, meSplitPos, aCellPos)); + mpViewForwarder.reset(new ScViewForwarder(mpViewShell, meSplitPos)); return mpViewForwarder.get(); } @@ -976,7 +962,7 @@ SvxTextForwarder* ScAccessiblePreviewCellTextData::GetTextForwarder() SvxViewForwarder* ScAccessiblePreviewCellTextData::GetViewForwarder() { if (!mpViewForwarder) - mpViewForwarder.reset(new ScPreviewCellViewForwarder(mpViewShell, aCellPos)); + mpViewForwarder.reset(new ScPreviewCellViewForwarder(mpViewShell)); return mpViewForwarder.get(); } @@ -1076,7 +1062,7 @@ SvxTextForwarder* ScAccessiblePreviewHeaderCellTextData::GetTextForwarder() SvxViewForwarder* ScAccessiblePreviewHeaderCellTextData::GetViewForwarder() { if (!mpViewForwarder) - mpViewForwarder.reset(new ScPreviewHeaderCellViewForwarder(mpViewShell, aCellPos)); + mpViewForwarder.reset(new ScPreviewHeaderCellViewForwarder(mpViewShell)); return mpViewForwarder.get(); } @@ -1089,13 +1075,12 @@ ScDocShell* ScAccessiblePreviewHeaderCellTextData::GetDocShell(ScPreviewShell* p } ScAccessibleHeaderTextData::ScAccessibleHeaderTextData(ScPreviewShell* pViewShell, - const EditTextObject* pEditObj, bool bHeader, SvxAdjust eAdjust) + const EditTextObject* pEditObj, SvxAdjust eAdjust) : mpViewForwarder(nullptr), mpViewShell(pViewShell), mpDocSh(nullptr), mpEditObj(pEditObj), - mbHeader(bHeader), mbDataValid(false), meAdjust(eAdjust) { @@ -1119,7 +1104,7 @@ ScAccessibleHeaderTextData::~ScAccessibleHeaderTextData() ScAccessibleTextData* ScAccessibleHeaderTextData::Clone() const { - return new ScAccessibleHeaderTextData(mpViewShell, mpEditObj, mbHeader, meAdjust); + return new ScAccessibleHeaderTextData(mpViewShell, mpEditObj, meAdjust); } void ScAccessibleHeaderTextData::Notify( SfxBroadcaster&, const SfxHint& rHint ) @@ -1298,7 +1283,7 @@ SvxTextForwarder* ScAccessibleNoteTextData::GetTextForwarder() SvxViewForwarder* ScAccessibleNoteTextData::GetViewForwarder() { if (!mpViewForwarder) - mpViewForwarder = new ScPreviewNoteViewForwarder(mpViewShell, maCellPos); + mpViewForwarder = new ScPreviewNoteViewForwarder(mpViewShell); return mpViewForwarder; } @@ -1306,11 +1291,10 @@ SvxViewForwarder* ScAccessibleNoteTextData::GetViewForwarder() class ScCsvViewForwarder : public SvxViewForwarder { - tools::Rectangle maBoundBox; VclPtr<vcl::Window> mpWindow; public: - explicit ScCsvViewForwarder( vcl::Window* pWindow, const tools::Rectangle& rBoundBox ); + explicit ScCsvViewForwarder( vcl::Window* pWindow ); virtual bool IsValid() const override; virtual Point LogicToPixel( const Point& rPoint, const MapMode& rMapMode ) const override; @@ -1319,8 +1303,7 @@ public: void SetInvalid(); }; -ScCsvViewForwarder::ScCsvViewForwarder( vcl::Window* pWindow, const tools::Rectangle& rBoundBox ) : - maBoundBox( rBoundBox ), +ScCsvViewForwarder::ScCsvViewForwarder( vcl::Window* pWindow ) : mpWindow( pWindow ) { } @@ -1396,7 +1379,7 @@ SvxTextForwarder* ScAccessibleCsvTextData::GetTextForwarder() SvxViewForwarder* ScAccessibleCsvTextData::GetViewForwarder() { if( !mpViewForwarder.get() ) - mpViewForwarder.reset( new ScCsvViewForwarder( mpWindow, maBoundBox ) ); + mpViewForwarder.reset( new ScCsvViewForwarder( mpWindow ) ); return mpViewForwarder.get(); } diff --git a/sc/source/ui/inc/AccessiblePageHeaderArea.hxx b/sc/source/ui/inc/AccessiblePageHeaderArea.hxx index 7a3eba11eac4..b29ca101098c 100644 --- a/sc/source/ui/inc/AccessiblePageHeaderArea.hxx +++ b/sc/source/ui/inc/AccessiblePageHeaderArea.hxx @@ -39,7 +39,6 @@ public: const css::uno::Reference<css::accessibility::XAccessible>& rxParent, ScPreviewShell* pViewShell, const EditTextObject* pEditObj, - bool bHeader, SvxAdjust eAdjust); protected: virtual ~ScAccessiblePageHeaderArea() override; @@ -107,7 +106,6 @@ private: std::unique_ptr<EditTextObject> mpEditObj; std::unique_ptr<accessibility::AccessibleTextHelper> mpTextHelper; ScPreviewShell* mpViewShell; - bool mbHeader; SvxAdjust meAdjust; void CreateTextHelper(); diff --git a/sc/source/ui/inc/AccessibleText.hxx b/sc/source/ui/inc/AccessibleText.hxx index 057515a329e3..3ffb27588355 100644 --- a/sc/source/ui/inc/AccessibleText.hxx +++ b/sc/source/ui/inc/AccessibleText.hxx @@ -201,7 +201,7 @@ class ScAccessibleHeaderTextData : public ScAccessibleTextData { public: ScAccessibleHeaderTextData(ScPreviewShell* pViewShell, - const EditTextObject* pEditObj, bool bHeader, SvxAdjust eAdjust); + const EditTextObject* pEditObj, SvxAdjust eAdjust); virtual ~ScAccessibleHeaderTextData() override; virtual ScAccessibleTextData* Clone() const override; @@ -220,7 +220,6 @@ private: std::unique_ptr<SvxEditEngineForwarder> mpForwarder; ScDocShell* mpDocSh; const EditTextObject* mpEditObj; - bool mbHeader; bool mbDataValid; SvxAdjust meAdjust; }; diff --git a/vcl/inc/printerinfomanager.hxx b/vcl/inc/printerinfomanager.hxx index fda53207c550..49bbc1491483 100644 --- a/vcl/inc/printerinfomanager.hxx +++ b/vcl/inc/printerinfomanager.hxx @@ -96,8 +96,6 @@ protected: // this must be unique over all configuration files // it usually should be the printer name OString m_aGroup; - // whether changes need to be saved - bool m_bModified; // the corresponding info and job data PrinterInfo m_aInfo; }; diff --git a/vcl/unx/generic/printer/cpdmgr.cxx b/vcl/unx/generic/printer/cpdmgr.cxx index f46987e28ec1..aedcd5b42543 100644 --- a/vcl/unx/generic/printer/cpdmgr.cxx +++ b/vcl/unx/generic/printer/cpdmgr.cxx @@ -235,7 +235,6 @@ void CPDManager::addNewPrinter(const OUString& aPrinterName, const OUString& aUn } aPrinter.m_aInfo.setDefaultBackend(true); aPrinter.m_aInfo.m_aDriverName = aBuf.makeStringAndClear(); - aPrinter.m_bModified = false; m_aPrinters[ aUniqueName ] = aPrinter; } #endif diff --git a/vcl/unx/generic/printer/cupsmgr.cxx b/vcl/unx/generic/printer/cupsmgr.cxx index 2c791e426929..49f7ce201516 100644 --- a/vcl/unx/generic/printer/cupsmgr.cxx +++ b/vcl/unx/generic/printer/cupsmgr.cxx @@ -341,7 +341,6 @@ void CUPSManager::initialize() } aPrinter.m_aInfo.setDefaultBackend(bUsePDF); aPrinter.m_aInfo.m_aDriverName = aBuf.makeStringAndClear(); - aPrinter.m_bModified = false; m_aPrinters[ aPrinter.m_aInfo.m_aPrinterName ] = aPrinter; m_aCUPSDestMap[ aPrinter.m_aInfo.m_aPrinterName ] = nPrinter; diff --git a/vcl/unx/generic/printer/printerinfomanager.cxx b/vcl/unx/generic/printer/printerinfomanager.cxx index 8ca49d1d3ff2..e97a7888a13f 100644 --- a/vcl/unx/generic/printer/printerinfomanager.cxx +++ b/vcl/unx/generic/printer/printerinfomanager.cxx @@ -462,7 +462,6 @@ void PrinterInfoManager::initialize() // finally insert printer FileBase::getFileURLFromSystemPath( aFile.PathToFileName(), aPrinter.m_aFile ); - aPrinter.m_bModified = false; aPrinter.m_aGroup = aConfig.GetGroupName( nGroup ); std::unordered_map< OUString, Printer >::const_iterator find_it = m_aPrinters.find( aPrinterName ); @@ -534,7 +533,6 @@ void PrinterInfoManager::initialize() aPrinter.m_aInfo.m_aCommand = aCmd; aPrinter.m_aInfo.m_aComment = printQueue.m_aComment; aPrinter.m_aInfo.m_aLocation = printQueue.m_aLocation; - aPrinter.m_bModified = false; aPrinter.m_aGroup = OUStringToOString(aPrinterName, aEncoding); //provide group name in case user makes this one permanent m_aPrinters[ aPrinterName ] = aPrinter; _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits