sfx2/source/appl/appdata.cxx | 6 +-----
sfx2/source/appl/childwin.cxx | 1 -
sfx2/source/appl/helpinterceptor.cxx | 1 -
sfx2/source/appl/impldde.cxx | 2 +-
sfx2/source/appl/linksrc.cxx | 3 +--
sfx2/source/appl/lnkbase2.cxx | 1 -
sfx2/source/appl/module.cxx | 1 -
sfx2/source/appl/shutdownicon.cxx | 1 -
sfx2/source/bastyp/sfxhtml.cxx | 1 -
sfx2/source/control/request.cxx | 2 --
sfx2/source/control/shell.cxx | 2 --
sfx2/source/dialog/basedlgs.cxx | 3 +--
sfx2/source/dialog/tabdlg.cxx | 2 --
sfx2/source/dialog/templdlg.cxx | 2 --
sfx2/source/dialog/versdlg.cxx | 2 --
sfx2/source/doc/docfile.cxx | 7 -------
sfx2/source/doc/docinsert.cxx | 1 -
sfx2/source/doc/guisaveas.cxx | 2 --
sfx2/source/doc/printhelper.cxx | 3 +--
sfx2/source/doc/sfxbasemodel.cxx | 2 --
sfx2/source/notebookbar/NotebookbarTabControl.cxx | 1 -
sfx2/source/view/viewfrm.cxx | 1 -
sfx2/source/view/viewprn.cxx | 1 -
sfx2/source/view/viewsh.cxx | 1 -
sot/source/sdstor/ucbstorage.cxx | 2 --
sot/source/unoolestorage/xolesimplestorage.cxx | 1 -
starmath/source/document.cxx | 1 -
27 files changed, 5 insertions(+), 48 deletions(-)
New commits:
commit 700929e8e0f930faa983a3945901b74a745b6347
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Sep 10 09:21:15 2018 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Sep 10 12:24:50 2018 +0200
loplugin:simplifyconstruct in sfx2..starmath
Change-Id: I9fbdd23ad61773e57aaf7d70fd19d05a50b8d399
Reviewed-on: https://gerrit.libreoffice.org/60238
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/sfx2/source/appl/appdata.cxx b/sfx2/source/appl/appdata.cxx
index fa3413c95ced..db15fb0e9562 100644
--- a/sfx2/source/appl/appdata.cxx
+++ b/sfx2/source/appl/appdata.cxx
@@ -81,11 +81,7 @@ void SfxBasicManagerCreationListener::onBasicManagerCreated(
const Reference< XM
}
SfxAppData_Impl::SfxAppData_Impl()
- : pDdeService( nullptr )
- , pDocTopics( nullptr )
- , pTriggerTopic(nullptr)
- , pDdeService2(nullptr)
- , pFactArr(nullptr)
+ : pFactArr(nullptr)
, pMatcher( nullptr )
, m_pToolsErrorHdl(nullptr)
, m_pSoErrorHdl(nullptr)
diff --git a/sfx2/source/appl/childwin.cxx b/sfx2/source/appl/childwin.cxx
index afdf5b21f548..aa8018eb0ed4 100644
--- a/sfx2/source/appl/childwin.cxx
+++ b/sfx2/source/appl/childwin.cxx
@@ -44,7 +44,6 @@ SfxChildWinFactory::SfxChildWinFactory( SfxChildWinCtor
pTheCtor, sal_uInt16 nID
: pCtor(pTheCtor)
, nId( nID )
, nPos(n)
- , pArr( nullptr )
{}
SfxChildWinFactory::~SfxChildWinFactory()
diff --git a/sfx2/source/appl/helpinterceptor.cxx
b/sfx2/source/appl/helpinterceptor.cxx
index a41fc472a02b..3d6ec464c96e 100644
--- a/sfx2/source/appl/helpinterceptor.cxx
+++ b/sfx2/source/appl/helpinterceptor.cxx
@@ -37,7 +37,6 @@ using namespace ::com::sun::star::lang;
HelpInterceptor_Impl::HelpInterceptor_Impl() :
- m_pHistory ( nullptr ),
m_pWindow ( nullptr ),
m_nCurPos ( 0 )
diff --git a/sfx2/source/appl/impldde.cxx b/sfx2/source/appl/impldde.cxx
index bd61ed37bd39..4ea44c7d2b4f 100644
--- a/sfx2/source/appl/impldde.cxx
+++ b/sfx2/source/appl/impldde.cxx
@@ -96,7 +96,7 @@ IMPL_LINK_NOARG( SvDDELinkEditDialog, EditHdl_Impl,
weld::Entry&, void)
}
SvDDEObject::SvDDEObject()
- : pConnection( nullptr ), pLink( nullptr ), pRequest( nullptr ), pGetData(
nullptr )
+ : pGetData( nullptr )
{
SetUpdateTimeout( 100 );
bWaitForData = false;
diff --git a/sfx2/source/appl/linksrc.cxx b/sfx2/source/appl/linksrc.cxx
index dde56a43d23f..27a2915b0429 100644
--- a/sfx2/source/appl/linksrc.cxx
+++ b/sfx2/source/appl/linksrc.cxx
@@ -181,8 +181,7 @@ struct SvLinkSource_Impl
bool m_bIsReadOnly;
SvLinkSource_Impl()
- : pTimer(nullptr)
- , nTimeout(3000)
+ : nTimeout(3000)
, m_bIsReadOnly(false)
{
}
diff --git a/sfx2/source/appl/lnkbase2.cxx b/sfx2/source/appl/lnkbase2.cxx
index 1c5b6154db73..49d23010de6d 100644
--- a/sfx2/source/appl/lnkbase2.cxx
+++ b/sfx2/source/appl/lnkbase2.cxx
@@ -55,7 +55,6 @@ struct BaseLink_Impl
BaseLink_Impl() :
m_pLinkMgr( nullptr )
, m_pParentWin( nullptr )
- , m_pFileDlg( nullptr )
, m_bIsConnect( false )
{}
};
diff --git a/sfx2/source/appl/module.cxx b/sfx2/source/appl/module.cxx
index 39274e31b8c6..2a0aef44d6c8 100644
--- a/sfx2/source/appl/module.cxx
+++ b/sfx2/source/appl/module.cxx
@@ -54,7 +54,6 @@ public:
};
SfxModule_Impl::SfxModule_Impl()
- : pSlotPool(nullptr), pTbxCtrlFac(nullptr), pStbCtrlFac(nullptr),
pFactArr(nullptr)
{
}
diff --git a/sfx2/source/appl/shutdownicon.cxx
b/sfx2/source/appl/shutdownicon.cxx
index bdde99c9eccc..b02dc8f7260e 100644
--- a/sfx2/source/appl/shutdownicon.cxx
+++ b/sfx2/source/appl/shutdownicon.cxx
@@ -180,7 +180,6 @@ ShutdownIcon::ShutdownIcon( const css::uno::Reference<
XComponentContext > & rxC
m_bVeto ( false ),
m_bListenForTermination ( false ),
m_bSystemDialogs( false ),
- m_pFileDlg( nullptr ),
m_xContext( rxContext ),
m_bInitialized( false )
{
diff --git a/sfx2/source/bastyp/sfxhtml.cxx b/sfx2/source/bastyp/sfxhtml.cxx
index 2b70371f35e1..82b81e93b45d 100644
--- a/sfx2/source/bastyp/sfxhtml.cxx
+++ b/sfx2/source/bastyp/sfxhtml.cxx
@@ -63,7 +63,6 @@ SfxHTMLParser::SfxHTMLParser( SvStream& rStream, bool
bIsNewDoc,
SfxMedium *pMed )
: HTMLParser(rStream, bIsNewDoc)
, pMedium(pMed)
- , pDLMedium(nullptr)
, eScriptType(STARBASIC)
{
DBG_ASSERT( RTL_TEXTENCODING_UTF8 == GetSrcEncoding( ),
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index 7c73d3664c8e..3249e6d81dea 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -190,7 +190,6 @@ SfxRequest::SfxRequest
*/
: nSlot(nSlotId),
- pArgs(nullptr),
pImpl( new SfxRequest_Impl(this) )
{
pImpl->bDone = false;
@@ -223,7 +222,6 @@ SfxRequest::SfxRequest
// creates a SfxRequest without arguments
: nSlot(nSlotId),
- pArgs(nullptr),
pImpl( new SfxRequest_Impl(this) )
{
pImpl->bDone = false;
diff --git a/sfx2/source/control/shell.cxx b/sfx2/source/control/shell.cxx
index 6d5e1fd137c7..2d8b9b0a707d 100644
--- a/sfx2/source/control/shell.cxx
+++ b/sfx2/source/control/shell.cxx
@@ -75,8 +75,6 @@ struct SfxShell_Impl: public SfxBroadcaster
, pRepeatTarget(nullptr)
, bActive(false)
, nDisableFlags(SfxDisableFlags::NONE)
- , pExecuter(nullptr)
- , pUpdater(nullptr)
{
}
diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index f58b2f407f4f..0868350ec74e 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -124,8 +124,7 @@ void SfxModalDialog::GetDialogData_Impl()
SfxModalDialog::SfxModalDialog(vcl::Window *pParent, const OUString& rID,
const OUString& rUIXMLDescription )
: ModalDialog(pParent, rID, rUIXMLDescription),
- pInputSet(nullptr),
- pOutputSet(nullptr)
+ pInputSet(nullptr)
{
GetDialogData_Impl();
}
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 7f763e306532..3890448fc6d0 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -385,8 +385,6 @@ SfxTabDialog::SfxTabDialog
)
: TabDialog(pParent, rID, rUIXMLDescription)
, m_pSet(pItemSet ? new SfxItemSet(*pItemSet) : nullptr)
- , m_pOutSet(nullptr)
- , m_pRanges(nullptr)
, m_nAppPageId(USHRT_MAX)
, m_bStandardPushed(false)
, m_pExampleSet(nullptr)
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 3bec0c87479b..50d6f4764d96 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -637,8 +637,6 @@ SfxCommonTemplateDialog_Impl::SfxCommonTemplateDialog_Impl(
SfxBindings* pB, vcl
: pBindings(pB)
, pWindow(pW)
, pModule(nullptr)
- , pIdle(nullptr)
- , pStyleFamilies(nullptr)
, pStyleSheetPool(nullptr)
, pCurObjShell(nullptr)
,
xModuleManager(frame::ModuleManager::create(::comphelper::getProcessComponentContext()))
diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx
index 9320d6f37362..d01e5c8c0932 100644
--- a/sfx2/source/dialog/versdlg.cxx
+++ b/sfx2/source/dialog/versdlg.cxx
@@ -180,7 +180,6 @@ void SfxVersionsTabListBox_Impl::setColSizes()
SfxVersionDialog::SfxVersionDialog ( SfxViewFrame* pVwFrame, bool
bIsSaveVersionOnClose )
: SfxModalDialog(nullptr, "VersionsOfDialog", "sfx/ui/versionsofdialog.ui")
, pViewFrame(pVwFrame)
- , m_pTable(nullptr)
, m_bIsSaveVersionOnClose(bIsSaveVersionOnClose)
{
get(m_pSaveButton, "save");
@@ -497,7 +496,6 @@ IMPL_LINK(SfxViewVersionDialog_Impl, ButtonHdl,
weld::Button&, rButton, void)
SfxCmisVersionsDialog::SfxCmisVersionsDialog ( SfxViewFrame* pVwFrame )
: SfxModalDialog(nullptr, "VersionsCmisDialog", "sfx/ui/versionscmis.ui")
, pViewFrame(pVwFrame)
- , m_pTable(nullptr)
{
get(m_pOpenButton, "open");
get(m_pViewButton, "show");
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 0da123becf7f..2e6fc691cea2 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -333,14 +333,7 @@ SfxMedium_Impl::SfxMedium_Impl() :
m_bRemote(false),
m_bInputStreamIsReadOnly(false),
m_bInCheckIn(false),
- m_pSet(nullptr),
- m_pURLObj(nullptr),
- m_pFilter(nullptr),
- m_pInStream(nullptr),
- m_pOutStream(nullptr),
- pOrigFilter( nullptr ),
aExpireTime( DateTime( DateTime::SYSTEM ) + static_cast<sal_Int32>(10) ),
- pTempFile( nullptr ),
nLastStorageError( ERRCODE_NONE ),
m_nSignatureState( SignatureState::NOSIGNATURES )
{
diff --git a/sfx2/source/doc/docinsert.cxx b/sfx2/source/doc/docinsert.cxx
index 012cbcc02651..987548f1f80e 100644
--- a/sfx2/source/doc/docinsert.cxx
+++ b/sfx2/source/doc/docinsert.cxx
@@ -78,7 +78,6 @@ DocumentInserter::DocumentInserter(weld::Window* pParent,
const OUString& rFacto
, m_sDocFactory ( rFactory )
, m_nDlgFlags ( lcl_map_mode_to_flags(mode) )
, m_nError ( ERRCODE_NONE )
- , m_pFileDlg ( nullptr )
, m_pItemSet ( nullptr )
{
}
diff --git a/sfx2/source/doc/guisaveas.cxx b/sfx2/source/doc/guisaveas.cxx
index acab90b6cd4a..1fb91642e9cd 100644
--- a/sfx2/source/doc/guisaveas.cxx
+++ b/sfx2/source/doc/guisaveas.cxx
@@ -351,8 +351,6 @@ ModelData_Impl::ModelData_Impl( SfxStoringHelper& aOwner,
const uno::Sequence< beans::PropertyValue >&
aMediaDescr )
: m_pOwner( &aOwner )
, m_xModel( xModel )
-, m_pDocumentPropsHM( nullptr )
-, m_pModulePropsHM( nullptr )
, m_aMediaDescrHM( aMediaDescr )
, m_bRecommendReadOnly( false )
{
diff --git a/sfx2/source/doc/printhelper.cxx b/sfx2/source/doc/printhelper.cxx
index 41c2f547c99b..5092712f799e 100644
--- a/sfx2/source/doc/printhelper.cxx
+++ b/sfx2/source/doc/printhelper.cxx
@@ -68,8 +68,7 @@ struct IMPL_PrintListener_DataContainer : public SfxListener
css::uno::Sequence< css::beans::PropertyValue > m_aPrintOptions;
explicit IMPL_PrintListener_DataContainer( ::osl::Mutex& aMutex)
- : m_pObjectShell ( nullptr )
- , m_aInterfaceContainer ( aMutex )
+ : m_aInterfaceContainer ( aMutex )
{
}
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 39a304dd5bbe..0cc27bb9a231 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -221,7 +221,6 @@ struct IMPL_SfxBaseModel_DataContainer : public
::sfx2::IModifiableDocument
, m_bSuicide ( false )
, m_bExternalTitle ( false )
, m_bModifiedSinceLastSave( false )
- , m_pStorageModifyListen ( nullptr )
, m_xTitleHelper ()
, m_xNumberedControllers ()
, m_xDocumentMetadata () // lazy
@@ -447,7 +446,6 @@ SfxSaveGuard::SfxSaveGuard(const Reference< frame::XModel
>& xModel
IMPL_SfxBaseModel_DataContainer* pData)
: m_xModel ( xModel )
, m_pData ( pData )
- , m_pFramesLock( nullptr )
{
if ( m_pData->m_bClosed )
throw lang::DisposedException("Object already disposed.");
diff --git a/sfx2/source/notebookbar/NotebookbarTabControl.cxx
b/sfx2/source/notebookbar/NotebookbarTabControl.cxx
index 6ed83ad9b0c8..994dbf7d3a3f 100644
--- a/sfx2/source/notebookbar/NotebookbarTabControl.cxx
+++ b/sfx2/source/notebookbar/NotebookbarTabControl.cxx
@@ -130,7 +130,6 @@ public:
NotebookbarTabControl::NotebookbarTabControl( Window* pParent )
: NotebookbarTabControlBase( pParent )
-, m_pListener( nullptr )
, m_bInitialized( false )
, m_bInvalidate( true )
{
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 645ed2668094..2e77d5d189a3 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1452,7 +1452,6 @@ SfxViewFrame::SfxViewFrame
SfxObjectShell* pObjShell
)
: m_pImpl( new SfxViewFrame_Impl( rFrame ) )
- , m_pDispatcher(nullptr)
, m_pBindings( new SfxBindings )
, m_nAdjustPosPixelLock( 0 )
{
diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx
index 1bbc296bf371..9a034bcbe963 100644
--- a/sfx2/source/view/viewprn.cxx
+++ b/sfx2/source/view/viewprn.cxx
@@ -426,7 +426,6 @@ SfxDialogExecutor_Impl::SfxDialogExecutor_Impl(
SfxViewShell* pViewSh, PrinterSe
_pViewSh ( pViewSh ),
_rSetupParent ( rParent ),
- _pOptions ( nullptr ),
_bHelpDisabled ( false )
{
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index cb0bdebc7cb3..124ef2bd38e4 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -223,7 +223,6 @@ SfxViewShell_Impl::SfxViewShell_Impl(SfxViewShellFlags
const nFlags)
, m_bHasPrintOptions(nFlags & SfxViewShellFlags::HAS_PRINTOPTIONS)
, m_bIsShowView(!(nFlags & SfxViewShellFlags::NO_SHOW))
, m_nFamily(0xFFFF) // undefined, default set by TemplateDialog
-, m_pController(nullptr)
, m_pLibreOfficeKitViewCallback(nullptr)
, m_pLibreOfficeKitViewData(nullptr)
, m_bTiledSearching(false)
diff --git a/sot/source/sdstor/ucbstorage.cxx b/sot/source/sdstor/ucbstorage.cxx
index a943f2d8272f..fe66ddd809fc 100644
--- a/sot/source/sdstor/ucbstorage.cxx
+++ b/sot/source/sdstor/ucbstorage.cxx
@@ -110,7 +110,6 @@ protected:
FileStreamWrapper_Impl::FileStreamWrapper_Impl( const OUString& rName )
: m_aURL( rName )
- , m_pSvStream(nullptr)
{
// if no URL is provided the stream is empty
}
@@ -622,7 +621,6 @@ UCBStorageStream_Impl::UCBStorageStream_Impl( const
OUString& rName, StreamMode
: m_pAntiImpl( pStream )
, m_aURL( rName )
, m_pContent( nullptr )
- , m_pStream( nullptr )
, m_nError( ERRCODE_NONE )
, m_nMode( nMode )
, m_bSourceRead( !( nMode & StreamMode::TRUNC ) )
diff --git a/sot/source/unoolestorage/xolesimplestorage.cxx
b/sot/source/unoolestorage/xolesimplestorage.cxx
index a3c95d52334e..d4414a2e58ec 100644
--- a/sot/source/unoolestorage/xolesimplestorage.cxx
+++ b/sot/source/unoolestorage/xolesimplestorage.cxx
@@ -45,7 +45,6 @@ OLESimpleStorage::OLESimpleStorage(
css::uno::Reference<css::uno::XComponentContext> const & xContext,
css::uno::Sequence<css::uno::Any> const &aArguments)
: m_bDisposed( false )
-, m_pStream( nullptr )
, m_pStorage( nullptr )
, m_pListenersContainer( nullptr )
, m_xContext( xContext )
diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index 7a443b998014..c49fc8712998 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -613,7 +613,6 @@ void SmDocShell::Repaint()
SmDocShell::SmDocShell( SfxModelFlags i_nSfxCreationFlags )
: SfxObjectShell(i_nSfxCreationFlags)
, mpEditEngineItemPool(nullptr)
- , mpEditEngine(nullptr)
, mpPrinter(nullptr)
, mpTmpPrinter(nullptr)
, mnModifyCount(0)
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
