sd/source/ui/sidebar/SlideBackground.cxx | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-)
New commits: commit 955eb9d196bdb626f876f02b3961aac79cce3849 Author: Xisco Fauli <xiscofa...@libreoffice.org> AuthorDate: Sat Jul 14 20:37:56 2018 +0200 Commit: Tamás Zolnai <tamas.zol...@collabora.com> CommitDate: Mon Aug 13 11:24:20 2018 +0200 tdf#111306: Hide background widget in sidebar in master and notes view Background is lost if it's changed from the sidebar in master or notes view, thus hide the widget for now, until the real issue is fixed. Keep the insert image button visible as it works. The background can be changed from the page properties dialog Change-Id: Ic3f6116cb0997024096343cb20ec40ac07307918 Reviewed-on: https://gerrit.libreoffice.org/57440 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofa...@libreoffice.org> (cherry picked from commit c57f10b67fceef47d304d74dce93be7389a7720c) Reviewed-on: https://gerrit.libreoffice.org/58184 Reviewed-by: Tamás Zolnai <tamas.zol...@collabora.com> diff --git a/sd/source/ui/sidebar/SlideBackground.cxx b/sd/source/ui/sidebar/SlideBackground.cxx index 7ce4bb4e6aa7..4e9a7a1bee04 100644 --- a/sd/source/ui/sidebar/SlideBackground.cxx +++ b/sd/source/ui/sidebar/SlideBackground.cxx @@ -243,11 +243,11 @@ void SlideBackground::HandleContextChange( mpMasterSlide->Disable(); mpDspMasterBackground->Disable(); mpDspMasterObjects->Disable(); - mpFillStyle->Show(); - mpBackgroundLabel->Show(); + mpFillStyle->Hide(); + mpBackgroundLabel->Hide(); mpInsertImage->Show(); } - else if ( maContext == maImpressHandoutContext ) + else if ( maContext == maImpressHandoutContext || maContext == maImpressNotesContext ) { mpCloseMaster->Hide(); mpEditMaster->Hide(); @@ -269,17 +269,7 @@ void SlideBackground::HandleContextChange( mpBackgroundLabel->Show(); mpInsertImage->Show(); } - else if (maContext == maImpressNotesContext) - { - mpCloseMaster->Hide(); - mpEditMaster->Hide(); - mpMasterSlide->Disable(); - mpDspMasterBackground->Disable(); - mpDspMasterObjects->Disable(); - mpFillStyle->Show(); - mpBackgroundLabel->Show(); - mpInsertImage->Hide(); - } + // Need to do a relayouting, otherwise the panel size is not updated after show / hide controls sfx2::sidebar::Panel* pPanel = dynamic_cast<sfx2::sidebar::Panel*>(GetParent()); if(pPanel) @@ -295,7 +285,7 @@ void SlideBackground::Update() { eFillStyle nPos = static_cast<eFillStyle>(mpFillStyle->GetSelectedEntryPos()); - if(maContext == maImpressHandoutContext) + if(maContext != maImpressOtherContext) nPos = NONE; SfxObjectShell* pSh = SfxObjectShell::Current(); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits