On Sun, 2012-01-15 at 21:52 -0500, Marc-André Laverdière wrote: > Hello list, > > Since I went a bit beyond unusedcode.easy, I prefer to ask review on this one > :)
I assume you are talking about the change in SVGExport? It all looks reasonable to me. If the push method is not used, then that implies that the clip container is always empty. With that, you can remove a little more code like you did in your patch. BTW, we ask all patch submitters to put [PATCH] in the subject line, or prospective patch reviewers may overlook your patch.[1] Also, I didn't apply your changes in the datetime files in tools. Looks like someone else has got to it first. Thanks, Kohei [1] http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline -- Kohei Yoshida, LibreOffice hacker, Calc _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
