sc/source/filter/excel/xename.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0b38b7313bdd57588ce51b0a0e4b86295b16d21b
Author: Justin Luth <justin_l...@sil.org>
Date: Sat May 5 21:41:46 2018 +0300
misleading comment: not every sheet is examined
In fact, if there are no sheet-local names defined, then the loop
will not even be entered. Only the sheets that actually contain
the desired item will be iterated through.
Change-Id: I1fa94d8b9190f43b2896a002acdec18397225395
Reviewed-on: https://gerrit.libreoffice.org/54742
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Andras Timar <andras.ti...@collabora.com>
diff --git a/sc/source/filter/excel/xename.cxx
b/sc/source/filter/excel/xename.cxx
index 4f9963b53b1f..84ab353ee2d8 100644
--- a/sc/source/filter/excel/xename.cxx
+++ b/sc/source/filter/excel/xename.cxx
@@ -645,7 +645,7 @@ void XclExpNameManagerImpl::CreateUserNames()
if (!FindNamedExpIndex(SCTAB_GLOBAL, itr->second->GetIndex()))
CreateName(SCTAB_GLOBAL, *itr->second);
}
- //look at every sheet for local range names
+ //look at sheets containing local range names
ScRangeName::TabNameCopyMap rLocalNames;
GetDoc().GetAllTabRangeNames(rLocalNames);
ScRangeName::TabNameCopyMap::iterator tabIt = rLocalNames.begin(),
tabItEnd = rLocalNames.end();
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
