include/xmloff/settingsstore.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commits: commit 7132ffcefe3110a9e65fe990891c1a262508a41a Author: Stephan Bergmann <sberg...@redhat.com> Date: Fri Feb 16 23:15:56 2018 +0100 DocumentSettingsSerializer must be SAL_DLLPUBLIC_RTTI for dynamic_cast ...in SdXMLImport::SetConfigurationSettings (xmloff/source/draw/sdxmlimp.cxx) to work with instances of sd::DocumentSettings (defined in sd/source/ui/unoidl/UnoDocumentSettings.cxx, derived from DocumentSettingsSerializer), at least on platforms using the strict by-address RTTI equality check form (e.g., macOS). (Cross-casts like this are not detected by loplugin:dyncastvisibility.) Change-Id: I3f8712f9c64852cc8cb17c0c25211963360f117c Reviewed-on: https://gerrit.libreoffice.org/49884 Tested-by: Jenkins <c...@libreoffice.org> Reviewed-by: Stephan Bergmann <sberg...@redhat.com> (cherry picked from commit ff570b4b58dbf274d3094d21d974f18b613e9b4b) Reviewed-on: https://gerrit.libreoffice.org/49928 Reviewed-by: Michael Stahl <mst...@redhat.com> diff --git a/include/xmloff/settingsstore.hxx b/include/xmloff/settingsstore.hxx index e78ae0a82ca3..0878a5ec288f 100644 --- a/include/xmloff/settingsstore.hxx +++ b/include/xmloff/settingsstore.hxx @@ -18,7 +18,7 @@ // Scans list of properties for certain URL properties that could refer // to internal objects, and initializes from these. -class DocumentSettingsSerializer { +class SAL_DLLPUBLIC_RTTI DocumentSettingsSerializer { public: // Import objects and update properties (eliding URLs) virtual css::uno::Sequence<css::beans::PropertyValue> _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits