On 16.02.2018 09:55, Samuel Thibault wrote:
Miklos Vajna, on ven. 16 févr. 2018 09:24:38 +0100, wrote:
On Thu, Feb 15, 2018 at 06:58:42PM +0100, Samuel Thibault <sthiba...@hypra.fr> 
wrote:
For now I have patched the build system to call the tool as the attached
patch does, does it look OK? (basically it's called along building the
image list in the UIC rule, I need to doublecheck the clean rule, but
the build rule works fine)

Please submit patches to gerrit:
<https://wiki.documentfoundation.org/Development/gerrit>, it's much
easier to review anything there. :-)

For reviews, sure, I'm here just asking whether the general approach is
fine, not an actual review of the implementation.

...but even that can be easier to answer if people see a full, working patch, which they can actually try out. (It doesn't need to be feature-complete, of course, just working well enough to demonstrate what is going on.)
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to