Hello Lubos, On Tue, Jan 3, 2012 at 00:35, Lubos Lunak <l.lu...@suse.cz> wrote: > On Monday 02 of January 2012, Petr Mladek wrote: >> Winfried Donkers píše v Pá 23. 12. 2011 v 17:04 +0100: >> > >Your code looks definitely better than the original one. Well, I am >> > >still not sure about the calculation. It makes perfect sense when I >> > >imagine the paper with blank labels. On the other hand, >> > >please look at http://download.go-oo.org/tmp/labels.png. >> > >> > I looked at a lot of (blank) labels and also came to the conclusion that >> > the definition of the labels leaves room for interpretation. >> > My calculation is based on the assumption (presumption?) that the >> > page containing the labels is symmetrical, i.e. rotating the page >> > 180 degrees is not a problem, left margine equals right margin and >> > top margin equals bottom margin. >> >> I see the point and agree with your assumption. Your patch makes sense >> and I have pushed it to the 3-4 branch, see >> http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id >>=502ef71db74c3cdb1433c3402a0d93971dc47f1b >> >> We need two more approvals for the 3-4-5 branch. > > Looks ok.
Just a reminder. As you are the third reviewer, could you please cherry-pick it to 3-4-5? Thanks! Best Regards, -- Korrawit Pruegsanusak _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
