On 21.12.2011 21:00, Eike Rathke wrote: > > The assertion tells if there was a dup, in that case something was going > wrong and memory leaks. > > Anyway, aparently you were confused by the two different tables/maps and > mixing iterator from different map, see > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1db721af6286ae4c3164075337d81e943845938 >
Oh, good catch. I've overlooked that when reviewing the patch myself. > Note that instead of map.erase(key) you can use map.erase(iterator) if > you already obtained one and don't access it afterwards, that saves an > internal map.find(key) I will keep that in mind for future patches. > Btw, did you check if Calc changetracking and accepting/rejecting > actions still works? Well, I assumed that this was cached by the `make check` tests but If you're asking like that I think this isn't sufficient, right? regards Marcel _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
