[Libreoffice-commits] core.git: lingucomponent/source

[Julien Nabet]

 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 83288332f7ced698610739419989c464256f1c4d
Author: Julien Nabet <serval2...@yahoo.fr>
Date:   Sat Sep 16 22:14:26 2017 +0200

    tdf#112425: fix leak in MacSpellChecker
    
    by using "autorelease" keyword with init vars
    
    Change-Id: I056282460b94f8052287f5ad29d26a4870cd06a5
    Reviewed-on: https://gerrit.libreoffice.org/42361
    Reviewed-by: Julien Nabet <serval2...@yahoo.fr>
    Tested-by: Julien Nabet <serval2...@yahoo.fr>

diff --git a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm 
b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
index 033b87555cf8..51e82f1dd0fb 100644
--- a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
+++ b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
@@ -231,13 +231,12 @@ sal_Int16 MacSpellChecker::GetSpellFailure( const 
OUString &rWord, const Locale
     {
         aEnc = 0;
         NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
-        NSString* aNSStr = [[NSString alloc] initWithCharacters: 
reinterpret_cast<unichar const *>(nWord.getStr()) length: nWord.getLength()];
-        NSString* aLang = [[NSString alloc] initWithCharacters: 
reinterpret_cast<unichar const *>(rLocale.Language.getStr()) length: 
rLocale.Language.getLength()];
+        NSString* aNSStr = [[[NSString alloc] initWithCharacters: 
reinterpret_cast<unichar const *>(nWord.getStr()) length: 
nWord.getLength()]autorelease];
+        NSString* aLang = [[[NSString alloc] initWithCharacters: 
reinterpret_cast<unichar const *>(rLocale.Language.getStr()) length: 
rLocale.Language.getLength()]autorelease];
         if(rLocale.Country.getLength()>0)
         {
-            NSString* aCountry = [[NSString alloc] initWithCharacters: 
reinterpret_cast<unichar const *>(rLocale.Country.getStr()) length: 
rLocale.Country.getLength()];
+            NSString* aCountry = [[[NSString alloc] initWithCharacters: 
reinterpret_cast<unichar const *>(rLocale.Country.getStr()) length: 
rLocale.Country.getLength()]autorelease];
             NSString* aTaggedCountry = [@"_" stringByAppendingString:aCountry];
-            [aLang autorelease];
             aLang = [aLang  stringByAppendingString:aTaggedCountry];
         }
 
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits