> On 27 Apr 2017, at 6:07 pm, Stephan Bergmann <sberg...@redhat.com> wrote: > >> On 04/27/2017 10:04 AM, Stephan Bergmann wrote: >> commit 5a7123d6869c9248a7ce3a22fffd84f76ceb360f >> Author: Stephan Bergmann <sberg...@redhat.com> >> Date: Thu Apr 27 10:03:03 2017 +0200 >> Fix build after 7d71451e8e0226d3f3f523611f55132eda6ec10f >> "vcl: change pImpl class names to fit with existing convention" > > Please think twice (or even more often) before doing cosmetic changes like > that > <https://cgit.freedesktop.org/libreoffice/core/commit/?id=7d71451e8e0226d3f3f523611f55132eda6ec10f> > "vcl: change pImpl class names to fit with existing convention". They > easily cause more pain (for others) than they're worth the trouble. > >> Change-Id: Ic02ca5b71a96b852951ac1b14b966b1ba2f006e9 >> diff --git a/compilerplugins/clang/vclwidgets.cxx >> b/compilerplugins/clang/vclwidgets.cxx >> index 32d471240de1..2d5dd6333bc9 100644 >> --- a/compilerplugins/clang/vclwidgets.cxx >> +++ b/compilerplugins/clang/vclwidgets.cxx >> @@ -428,7 +428,7 @@ bool VCLWidgets::VisitFieldDecl(const FieldDecl * >> fieldDecl) { >> if (containsVclReferenceBaseSubclass(fieldDecl->getType())) { >> // have to ignore this for now, nasty reverse dependency from >> tools->vcl >> auto check = loplugin::DeclCheck(pParentRecordDecl); >> - if (!(check.Struct("ErrorContextImpl").GlobalNamespace() >> + if (!(check.Struct("ImplErrorContext").GlobalNamespace() >> || check.Class("ScHFEditPage").GlobalNamespace())) >> { >> report(
What exactly did it break? Genuinely curious. Chris _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
