Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan. 10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1404932: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1404932: Incorrect expression (USELESS_CALL) /sd/source/ui/view/viewshe2.cxx: 366 in sd::ViewShell::GetZoom() const() 360 } 361 362 long ViewShell::GetZoom() const 363 { 364 if (mpContentWindow) 365 { >>> CID 1404932: Incorrect expression (USELESS_CALL) >>> Calling "this->mpContentWindow->GetZoom()" is only useful for its >>> return value, which is ignored. 366 mpContentWindow->GetZoom(); 367 } 368 369 return 0; 370 } 371 ** CID 1404931: Code maintainability issues (UNUSED_VALUE) /unotools/source/ucbhelper/localfilehelper.cxx: 147 in utl::removeTree(const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1404931: Code maintainability issues (UNUSED_VALUE) /unotools/source/ucbhelper/localfilehelper.cxx: 147 in utl::removeTree(const rtl::OUString &)() 141 SAL_WARN_IF( 142 rc != osl::FileBase::E_None, "desktop.app", 143 "cannot remove file " << stat.getFileURL() << ": " << +rc); 144 } 145 } 146 if (dir.isOpen()) { >>> CID 1404931: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "dir.close()" to "rc" here, but that stored value >>> is overwritten before it can be used. 147 rc = dir.close(); 148 SAL_WARN_IF( 149 rc != osl::FileBase::E_None, "desktop.app", 150 "cannot close directory " << dir.getURL() << ": " << +rc); 151 } 152 rc = osl::Directory::remove(url); ** CID 1404930: Code maintainability issues (UNUSED_VALUE) /unotools/source/ucbhelper/localfilehelper.cxx: 140 in utl::removeTree(const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1404930: Code maintainability issues (UNUSED_VALUE) /unotools/source/ucbhelper/localfilehelper.cxx: 140 in utl::removeTree(const rtl::OUString &)() 134 SAL_WARN( "desktop.app", "cannot stat in directory " << dir.getURL() << ": " << +rc); 135 continue; 136 } 137 if (stat.getFileType() == osl::FileStatus::Directory) { //TODO: symlinks 138 removeTree(stat.getFileURL()); 139 } else { >>> CID 1404930: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from >>> "osl::File::remove(rtl::OUString(stat.getFileURL()))" to "rc" here, but >>> that stored value is overwritten before it can be used. 140 rc = osl::File::remove(stat.getFileURL()); 141 SAL_WARN_IF( 142 rc != osl::FileBase::E_None, "desktop.app", 143 "cannot remove file " << stat.getFileURL() << ": " << +rc); 144 } 145 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyh4wD7vwNcRrQBRngBLK6WYcUr7VbHch80tIbGW9bvnJ7WP1OQf4etMDJl50HxfIfPcxg5-2BX-2Btnx-2FV-2FU2N-2Ff7-2BYiOGroLkXU-2Bolpo7m6hlq4gCyrRYBm4UD2brrndr7E3r4-2BJGzfBYOU494LV6RJulD3zKTioU4tW-2BIiUjU91PhY-3D To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyh4wD7vwNcRrQBRngBLK6WWtEuXMKidQq4KZNjXL9hnVm89D0ISHrpY7fugc2z1DgdUFO470siN0Wu5gIXDep5ykjKQSvTHlVam3b-2FfOGZKDobhCkjrL0lUz2yDm-2Bm51T8gRKqIRzOyfcnv-2FpRzdqhADHlUptiEDm1q-2BQ1w5Zi1U-3D _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice