Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
8 new defect(s) introduced to LibreOffice found with Coverity Scan.
30 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)
** CID 1401475: Error handling issues (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 342 in
std::unique_ptr<sd::slidesorter::view::SlideSorterView::DrawLock,
std::default_delete<sd::slidesorter::view::SlideSorterView::DrawLock>>::reset(sd::slidesorter::view::SlideSorterView::DrawLock
*)()
________________________________________________________________________________________________________
*** CID 1401475: Error handling issues (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 342 in
std::unique_ptr<sd::slidesorter::view::SlideSorterView::DrawLock,
std::default_delete<sd::slidesorter::view::SlideSorterView::DrawLock>>::reset(sd::slidesorter::view::SlideSorterView::DrawLock
*)()
336 *
337 * @param __p The new pointer to store.
338 *
339 * The deleter will be invoked if a pointer is already owned.
340 */
341 void
>>> CID 1401475: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list
>>> "throw()" doesn't allow it to be thrown. This will cause a call to
>>> unexpected() which usually calls terminate().
342 reset(pointer __p = pointer()) noexcept
343 {
344 using std::swap;
345 swap(std::get<0>(_M_t), __p);
346 if (__p != pointer())
347 get_deleter()(__p);
** CID 1401474: Error handling issues (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 235 in
std::unique_ptr<sd::slidesorter::view::SlideSorterView::DrawLock,
std::default_delete<sd::slidesorter::view::SlideSorterView::DrawLock>>::~unique_ptr()()
________________________________________________________________________________________________________
*** CID 1401474: Error handling issues (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 235 in
std::unique_ptr<sd::slidesorter::view::SlideSorterView::DrawLock,
std::default_delete<sd::slidesorter::view::SlideSorterView::DrawLock>>::~unique_ptr()()
229 template<typename _Up, typename = _Require<
230 is_convertible<_Up*, _Tp*>, is_same<_Dp,
default_delete<_Tp>>>>
231 unique_ptr(auto_ptr<_Up>&& __u) noexcept;
232 #endif
233
234 /// Destructor, invokes the deleter if the stored pointer is not
null.
>>> CID 1401474: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list
>>> "throw()" doesn't allow it to be thrown. This will cause a call to
>>> unexpected() which usually calls terminate().
235 ~unique_ptr() noexcept
236 {
237 auto& __ptr = std::get<0>(_M_t);
238 if (__ptr != nullptr)
239 get_deleter()(__ptr);
240 __ptr = pointer();
** CID 1401473: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx: 238 in
sd::slidesorter::controller::FocusManager::FocusHider::~FocusHider()()
________________________________________________________________________________________________________
*** CID 1401473: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx: 238 in
sd::slidesorter::controller::FocusManager::FocusHider::~FocusHider()()
232 : mbFocusVisible(rManager.IsFocusShowing())
233 , mrManager(rManager)
234 {
235 mrManager.HideFocus();
236 }
237
>>> CID 1401473: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list
>>> "throw()" doesn't allow it to be thrown. This will cause a call to
>>> unexpected() which usually calls terminate().
238 FocusManager::FocusHider::~FocusHider()
239 {
240 if (mbFocusVisible)
241 mrManager.ShowFocus();
242 }
243
244 } } } // end of namespace ::sd::slidesorter::controller
245
** CID 1401472: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsSelectionObserver.cxx: 41 in
sd::slidesorter::controller::SelectionObserver::Context::~Context()()
________________________________________________________________________________________________________
*** CID 1401472: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsSelectionObserver.cxx: 41 in
sd::slidesorter::controller::SelectionObserver::Context::~Context()()
35
rSlideSorter.GetController().GetSelectionManager()->GetSelectionObserver())
36 {
37 if (mpSelectionObserver)
38 mpSelectionObserver->StartObservation();
39 }
40
>>> CID 1401472: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list
>>> "throw()" doesn't allow it to be thrown. This will cause a call to
>>> unexpected() which usually calls terminate().
41 SelectionObserver::Context::~Context()
42 {
43 if (mpSelectionObserver)
44 mpSelectionObserver->EndObservation();
45 }
46
** CID 1401471: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sc/inc/postit.hxx: 42 in ()
________________________________________________________________________________________________________
*** CID 1401471: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sc/inc/postit.hxx: 42 in ()
36 class Rectangle;
37 struct ScCaptionInitData;
38
39 /** Some desperate attempt to fight against the caption object ownership
mess,
40 to which none of shared/weak/plain pointer is a cure.
41 */
>>> CID 1401471: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "ScCaptionPtr" may benefit from adding a move assignment
>>> operator. See other events which show the copy assignment operator being
>>> applied to rvalue(s), where a move assignment may be faster.
42 class ScCaptionPtr
43 {
44 public:
45 ScCaptionPtr();
46 explicit ScCaptionPtr( SdrCaptionObj* p );
47 ScCaptionPtr( const ScCaptionPtr& r );
** CID 1401470: Possible Control flow issues (DEADCODE)
/vcl/source/window/builder.cxx: 2636 in VclBuilder::handleMenuObject(PopupMenu
*, xmlreader::XmlReader &)()
________________________________________________________________________________________________________
*** CID 1401470: Possible Control flow issues (DEADCODE)
/vcl/source/window/builder.cxx: 2636 in VclBuilder::handleMenuObject(PopupMenu
*, xmlreader::XmlReader &)()
2630
2631 if (!nLevel)
2632 break;
2633 }
2634
2635 if (bInserted)
>>> CID 1401470: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
2636 return;
2637
2638 insertMenuObject(pParent, pSubMenu, sClass, sID, aProperties,
aAccelerators);
2639 }
2640
2641 void VclBuilder::handleSizeGroup(xmlreader::XmlReader &reader, const
OString &rID)
** CID 1371301: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sw/inc/ndindex.hxx: 35 in ()
________________________________________________________________________________________________________
*** CID 1371301: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sw/inc/ndindex.hxx: 35 in ()
29 #include <ndarr.hxx>
30
31 class SwNode;
32 class SwNodes;
33
34 /// Marks a node in the document model.
>>> CID 1371301: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "SwNodeIndex" may benefit from adding a move assignment operator.
>>> See other events which show the copy assignment operator being applied to
>>> rvalue(s), where a move assignment may be faster.
35 class SW_DLLPUBLIC SwNodeIndex final : public sw::Ring<SwNodeIndex>
36 {
37 SwNode * m_pNode;
38
39 // These are not allowed!
40 SwNodeIndex( SwNodes& rNds, sal_uInt16 nIdx ) = delete;
** CID 1371215: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sw/inc/ring.hxx: 39 in ()
________________________________________________________________________________________________________
*** CID 1371215: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/sw/inc/ring.hxx: 39 in ()
33 template <typename value_type> class RingIterator;
34 /**
35 * An intrusive container class double linking the contained nodes
36 * @example sw/qa/core/uwriter.cxx
37 */
38 template <typename value_type>
>>> CID 1371215: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "sw::Ring<SwNodeIndex>" may benefit from adding a move assignment
>>> operator. See other events which show the copy assignment operator being
>>> applied to rvalue(s), where a move assignment may be faster.
39 class Ring
40 {
41 public:
42 typedef typename std::add_const<value_type>::type
const_value_type;
43 typedef RingContainer<value_type> ring_container;
44 typedef RingContainer<const_value_type> const_ring_container;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyKedBXvZUqf4tpTc8ku2L9DeAO6g420Z9EHpjdjNZEYNAqbZc59psmK155yLxrZ3Gip0W6TsvtSssepQEy7N1Z10ZsSrNmmt5y85VzQ2ZR8NLQfl-2B5DyPbURCwNXZQy0uW0ITVRmCfg0sAbh6IuqCxTcPLwt7G9opPho8kcpxaRg-3D
To manage Coverity Scan email notifications for
"libreoffice@lists.freedesktop.org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyKedBXvZUqf4tpTc8ku2L9MxssmbpzlYpDVRtumvtAh-2BoqdKCITg3nwDgMgAEF-2B-2Bs8NuAhsvxIABSUOgXwcE3JVS-2F504E0uBjGPkKYhm0RTR3878fbyZhlzbSKdMyX7fRwqK4boqmQgECm1vdlBgAeZXPiPGeidZ-2FlBBK6Q6EAj4-3D
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
