Hello,
On Sat, 2011-11-12 at 16:27 +0900, Tomofumi Yagi wrote:
> This patch will fix fdo#40831 "Writer will crash when searching text with
> using regular expressions".
> Please review my attached patch.
>
> Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831
>
> I reproduced this bug on LibO 3.4 and 3.5.
> This bug occurs when a row or column containing cursor position was removed
> by substitution.
> This patch is to skip the process of returning the position of the cursor,
> when the row or column containing cursor position is removed.
Many thanks for your patch. There are still some rough edges or things
I'ld like you to explain.
* The if should be like the following or we still have the crash when
the last line is removed.
if( pSavePos && pSavePos->nNode < uNodeCount )
* Then I have no idea why you added the checks on the nIdx, I have the
impression that this is not really needed.
Regards,
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
