compilerplugins/clang/charrightshift.cxx | 57 +++++++++++++++++++++++++++++++
helpcompiler/source/HelpLinker.cxx | 2 -
vcl/source/fontsubset/cff.cxx | 2 -
3 files changed, 59 insertions(+), 2 deletions(-)
New commits:
commit a7d554f3b24d582919656233476c89a6d74cb207
Author: Stephan Bergmann <sberg...@redhat.com>
Date: Fri Jan 6 18:15:24 2017 +0100
New loplugin:charrightshift
Change-Id: Ib645fb11004bc0fe05c9c416ae72b0ae56c23a15
diff --git a/compilerplugins/clang/charrightshift.cxx
b/compilerplugins/clang/charrightshift.cxx
new file mode 100644
index 0000000..c1bf951
--- /dev/null
+++ b/compilerplugins/clang/charrightshift.cxx
@@ -0,0 +1,57 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "check.hxx"
+#include "plugin.hxx"
+
+namespace {
+
+class CharRightShift:
+ public RecursiveASTVisitor<CharRightShift>, public loplugin::Plugin
+{
+public:
+ explicit CharRightShift(InstantiationData const & data): Plugin(data) {}
+
+ void run() override
+ { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
+
+ bool VisitBinShr(BinaryOperator const * expr) {
+ if (ignoreLocation(expr)) {
+ return true;
+ }
+ auto t = expr->getLHS()->IgnoreParenImpCasts()->getType();
+ if (!loplugin::TypeCheck(t).Char()) {
+ return true;
+ }
+ if (!expr->getRHS()->getType()->isBuiltinType()) {
+ //TODO: in which case the expression should be an
+ // CXXOperatorCallExpr instead of a BinaryOperator? but at least
+ // recent Clang trunk reports
+ //
+ // '(' >> orExpression
+ //
+ // (connectivity/source/commontools/RowFunctionParser.cxx, the RHS
+ // being of type boost::spirit::rule<ScannerT>) here
+ return true;
+ }
+ report(
+ DiagnosticsEngine::Warning,
+ ("right shift of %0 is implementation-defined when 'char' is
signed"
+ " and value is negative"),
+ expr->getLHS()->getExprLoc())
+ << t << expr->getSourceRange();
+ return true;
+ }
+};
+
+loplugin::Plugin::Registration<CharRightShift> X("charrightshift");
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/helpcompiler/source/HelpLinker.cxx
b/helpcompiler/source/HelpLinker.cxx
index 66ad44b..cfff46a 100644
--- a/helpcompiler/source/HelpLinker.cxx
+++ b/helpcompiler/source/HelpLinker.cxx
@@ -216,7 +216,7 @@ namespace URLEncoder
result += c;
else {
result += '%';
- result += hex[c >> 4];
+ result += hex[static_cast<unsigned char>(c) >> 4];
result += hex[c & 0xf];
}
}
diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx
index cca14ed..a50801f 100644
--- a/vcl/source/fontsubset/cff.cxx
+++ b/vcl/source/fontsubset/cff.cxx
@@ -1777,7 +1777,7 @@ inline void Type1Emitter::emitAllHex()
char* pOut = aHexBuf;
while( (p < mpPtr) && (pOut < aHexBuf+sizeof(aHexBuf)-4)) {
// convert each byte to hex
- char cNibble = (*p >> 4) & 0x0F;
+ char cNibble = (static_cast<unsigned char>(*p) >> 4) & 0x0F;
cNibble += (cNibble < 10) ? '0' : 'A'-10;
*(pOut++) = cNibble;
cNibble = *(p++) & 0x0F;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
