On 01/03/2017 11:46 AM, Bjoern Michaelsen wrote: > Hi, > > On Tue, Jan 03, 2017 at 10:34:27AM +0000, Kaganski Mike wrote: >> But I suppose a better thing is to mark it -1 in the beginning, and revert >> to 0 when ready. > > No. No, no, no. > > Very explicitly: NO! > > Dont do that. In fact, be prepared that if you push stuff that is unfit to be > merged to gerrit _others_ will mark it as CR-2 to save themselves from the > noise. They have every right to do so: The social contract of gerrit is: if > you > push something there, you ask for a review. > > Breaking that social contract is a very Bad Thing(tm). > > Again: DONT DO THAT.
but what if i want to try if for example some experimental change builds on a Mac, or Windows, whatever i don't have locally? the jenkins doesn't build draft changes, only public ones. that is a valid use case for submitting something with a -1 self-review. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
