Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
27 new defect(s) introduced to LibreOffice found with Coverity Scan.
125 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 27 defect(s)
** CID 1397064: FindBugs: Dodgy code
(FB.UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/db/RecordParser.java: 160 in ()
________________________________________________________________________________________________________
*** CID 1397064: FindBugs: Dodgy code
(FB.UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/db/RecordParser.java: 160 in ()
154 public boolean executeCommand(int _nCommandType) throws
InvalidQueryException
155 {
156 try
157 {
158 Helper.setUnoPropertyValue(xRowSet, "DataSourceName",
DataSourceName);
159 Helper.setUnoPropertyValue(xRowSet,
PropertyNames.ACTIVE_CONNECTION, DBConnection);
>>> CID 1397064: FindBugs: Dodgy code
>>> (FB.UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)
>>> Unwritten public or protected field:
>>> com.sun.star.wizards.db.QueryMetaData.Command.
160 Helper.setUnoPropertyValue(xRowSet, PropertyNames.COMMAND,
Command);
161 Helper.setUnoPropertyValue(xRowSet,
PropertyNames.COMMAND_TYPE, Integer.valueOf(_nCommandType)); // CommandType
162 xExecute.executeWithCompletion(xInteraction);
163 com.sun.star.sdb.XResultSetAccess xResultAccess =
UnoRuntime.queryInterface(com.sun.star.sdb.XResultSetAccess.class, xRowSet);
164 ResultSet = xResultAccess.createResultSet();
165 xResultSetRow =
UnoRuntime.queryInterface(com.sun.star.sdbc.XRow.class, ResultSet);
** CID 1397063: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/text/TextDocument.java: 152 in ()
/wizards/com/sun/star/wizards/text/TextDocument.java: 153 in ()
/wizards/com/sun/star/wizards/text/TextDocument.java: 159 in ()
________________________________________________________________________________________________________
*** CID 1397063: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/text/TextDocument.java: 152 in ()
146 {
147 XStatusIndicatorFactory xStatusIndicatorFactory =
UnoRuntime.queryInterface(XStatusIndicatorFactory.class, xFrame);
148 xProgressBar =
xStatusIndicatorFactory.createStatusIndicator();
149 xProgressBar.start(PropertyNames.EMPTY_STRING, 100);
150 xProgressBar.setValue(5);
151 }
>>> CID 1397063: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.text.TextDocument.xWindowPeer.
152 xWindowPeer = UnoRuntime.queryInterface(XWindowPeer.class,
xFrame.getComponentWindow());
153 xMSFDoc = UnoRuntime.queryInterface(XMultiServiceFactory.class,
xTextDocument);
154 UnoRuntime.queryInterface(XNumberFormatsSupplier.class,
xTextDocument);
155
156 XDocumentPropertiesSupplier xDocPropsSuppl =
UnoRuntime.queryInterface(XDocumentPropertiesSupplier.class, xTextDocument);
157 xDocPropsSuppl.getDocumentProperties();
/wizards/com/sun/star/wizards/text/TextDocument.java: 153 in ()
147 XStatusIndicatorFactory xStatusIndicatorFactory =
UnoRuntime.queryInterface(XStatusIndicatorFactory.class, xFrame);
148 xProgressBar =
xStatusIndicatorFactory.createStatusIndicator();
149 xProgressBar.start(PropertyNames.EMPTY_STRING, 100);
150 xProgressBar.setValue(5);
151 }
152 xWindowPeer = UnoRuntime.queryInterface(XWindowPeer.class,
xFrame.getComponentWindow());
>>> CID 1397063: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.text.TextDocument.xMSFDoc.
153 xMSFDoc = UnoRuntime.queryInterface(XMultiServiceFactory.class,
xTextDocument);
154 UnoRuntime.queryInterface(XNumberFormatsSupplier.class,
xTextDocument);
155
156 XDocumentPropertiesSupplier xDocPropsSuppl =
UnoRuntime.queryInterface(XDocumentPropertiesSupplier.class, xTextDocument);
157 xDocPropsSuppl.getDocumentProperties();
158 Helper.getUnoStructValue(xComponent, "CharLocale");
/wizards/com/sun/star/wizards/text/TextDocument.java: 159 in ()
153 xMSFDoc = UnoRuntime.queryInterface(XMultiServiceFactory.class,
xTextDocument);
154 UnoRuntime.queryInterface(XNumberFormatsSupplier.class,
xTextDocument);
155
156 XDocumentPropertiesSupplier xDocPropsSuppl =
UnoRuntime.queryInterface(XDocumentPropertiesSupplier.class, xTextDocument);
157 xDocPropsSuppl.getDocumentProperties();
158 Helper.getUnoStructValue(xComponent, "CharLocale");
>>> CID 1397063: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.text.TextDocument.xText.
159 xText = xTextDocument.getText();
160 }
161
162 private void init()
163 {
164 xWindowPeer = UnoRuntime.queryInterface(XWindowPeer.class,
xFrame.getComponentWindow());
** CID 1397062: FindBugs: Dodgy code (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/document/Shape.java: 66 in ()
________________________________________________________________________________________________________
*** CID 1397062: FindBugs: Dodgy code
(FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/document/Shape.java: 66 in ()
60 {
61 this.aPoint = _aPoint;
62 this.aSize = _aSize;
63 this.oFormHandler = _oFormHandler;
64 Object oShape =
oFormHandler.xMSF.createInstance(_sServiceName);
65 xShapes = UnoRuntime.queryInterface(XShapes.class, oShape);
>>> CID 1397062: FindBugs: Dodgy code
>>> (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.document.Shape.xServiceInfo.
66 xServiceInfo = UnoRuntime.queryInterface(XServiceInfo.class,
oShape);
67 }
68 catch (Exception e)
69 {
70 e.printStackTrace();
71 }
** CID 1397061: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 44 in ()
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 45 in ()
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 47 in ()
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 48 in ()
________________________________________________________________________________________________________
*** CID 1397061: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 44 in ()
38 protected int iCurPosY;
39 protected int FirstHelpIndex;
40
41 public DBLimitedFieldSelection(WizardDialog _CurUnoDialog, int
iStep, int iCompPosY, int _FirstHelpIndex)
42 {
43 this.CurUnoDialog = _CurUnoDialog;
>>> CID 1397061: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.ui.DBLimitedFieldSelection.FirstHelpIndex.
44 FirstHelpIndex = _FirstHelpIndex;
45 curtabindex = (short) (iStep * 100);
46 sNoField =
CurUnoDialog.m_oResource.getResText(UIConsts.RID_REPORT + 8);
47 IStep = Integer.valueOf(iStep);
48 iCurPosY = iCompPosY;
49 for (int i = 0; i < rowcount; i++)
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 45 in ()
39 protected int FirstHelpIndex;
40
41 public DBLimitedFieldSelection(WizardDialog _CurUnoDialog, int
iStep, int iCompPosY, int _FirstHelpIndex)
42 {
43 this.CurUnoDialog = _CurUnoDialog;
44 FirstHelpIndex = _FirstHelpIndex;
>>> CID 1397061: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.ui.DBLimitedFieldSelection.curtabindex.
45 curtabindex = (short) (iStep * 100);
46 sNoField =
CurUnoDialog.m_oResource.getResText(UIConsts.RID_REPORT + 8);
47 IStep = Integer.valueOf(iStep);
48 iCurPosY = iCompPosY;
49 for (int i = 0; i < rowcount; i++)
50 {
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 47 in ()
41 public DBLimitedFieldSelection(WizardDialog _CurUnoDialog, int
iStep, int iCompPosY, int _FirstHelpIndex)
42 {
43 this.CurUnoDialog = _CurUnoDialog;
44 FirstHelpIndex = _FirstHelpIndex;
45 curtabindex = (short) (iStep * 100);
46 sNoField =
CurUnoDialog.m_oResource.getResText(UIConsts.RID_REPORT + 8);
>>> CID 1397061: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.ui.DBLimitedFieldSelection.IStep.
47 IStep = Integer.valueOf(iStep);
48 iCurPosY = iCompPosY;
49 for (int i = 0; i < rowcount; i++)
50 {
51 insertControlGroup(i);
52 }
/wizards/com/sun/star/wizards/ui/DBLimitedFieldSelection.java: 48 in ()
42 {
43 this.CurUnoDialog = _CurUnoDialog;
44 FirstHelpIndex = _FirstHelpIndex;
45 curtabindex = (short) (iStep * 100);
46 sNoField =
CurUnoDialog.m_oResource.getResText(UIConsts.RID_REPORT + 8);
47 IStep = Integer.valueOf(iStep);
>>> CID 1397061: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.ui.DBLimitedFieldSelection.iCurPosY.
48 iCurPosY = iCompPosY;
49 for (int i = 0; i < rowcount; i++)
50 {
51 insertControlGroup(i);
52 }
53 }
** CID 1397060: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/ui/UnoDialog.java: 72 in ()
/wizards/com/sun/star/wizards/ui/UnoDialog.java: 592 in ()
________________________________________________________________________________________________________
*** CID 1397060: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/ui/UnoDialog.java: 72 in ()
66 xControl = UnoRuntime.queryInterface(XControl.class,
xUnoDialog);
67 XControlModel xControlModel =
UnoRuntime.queryInterface(XControlModel.class, xDialogModel);
68 xControl.setModel(xControlModel);
69 UnoRuntime.queryInterface(XPropertySet.class, xDialogModel);
70 xDlgContainer =
UnoRuntime.queryInterface(XControlContainer.class, xUnoDialog);
71 xDlgNames = UnoRuntime.queryInterface(XNameContainer.class,
xDialogModel);
>>> CID 1397060: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.ui.UnoDialog.xComponent.
72 xComponent = UnoRuntime.queryInterface(XComponent.class,
xUnoDialog);
73 xWindow = UnoRuntime.queryInterface(XWindow.class,
xUnoDialog);
74 }
75 catch (com.sun.star.uno.Exception exception)
76 {
77 exception.printStackTrace(System.err);
/wizards/com/sun/star/wizards/ui/UnoDialog.java: 592 in ()
586 Object tk = xMSF.createInstance("com.sun.star.awt.Toolkit");
587 if (parentPeer == null)
588 {
589 parentPeer = UnoRuntime.queryInterface(XToolkit.class,
tk).getDesktopWindow();
590 }
591 XToolkit xToolkit = UnoRuntime.queryInterface(XToolkit.class,
tk);
>>> CID 1397060: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.ui.UnoDialog.xReschedule.
592 xReschedule = UnoRuntime.queryInterface(XReschedule.class,
xToolkit);
593 // TEUER!
594 xControl.createPeer(xToolkit, parentPeer);
595 xWindowPeer = xControl.getPeer();
596 return xControl.getPeer();
597 }
** CID 1397059: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/document/GridControl.java: 66 in ()
/wizards/com/sun/star/wizards/document/GridControl.java: 69 in ()
________________________________________________________________________________________________________
*** CID 1397059: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
/wizards/com/sun/star/wizards/document/GridControl.java: 66 in ()
60 if (xControlShape == null) {
61 throw new Exception(
62 "Error: GridModel does not have a XControlShape");
63 }
64
65 xControlShape.setControl(xControlModel);
>>> CID 1397059: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.document.GridControl.xPropertySet.
66 xPropertySet = UnoRuntime.queryInterface(
XPropertySet.class, oGridModel );
67 oFormHandler.xDrawPage.add(xShape);
68 xGridColumnFactory = UnoRuntime.queryInterface(
XGridColumnFactory.class, oGridModel );
69 xComponent = UnoRuntime.queryInterface( XComponent.class,
oGridModel );
70
71 for (int i = 0; i < _fieldcolumns.length; i++)
/wizards/com/sun/star/wizards/document/GridControl.java: 69 in ()
63 }
64
65 xControlShape.setControl(xControlModel);
66 xPropertySet = UnoRuntime.queryInterface(
XPropertySet.class, oGridModel );
67 oFormHandler.xDrawPage.add(xShape);
68 xGridColumnFactory = UnoRuntime.queryInterface(
XGridColumnFactory.class, oGridModel );
>>> CID 1397059: (FB.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
>>> Unread public/protected field:
>>> com.sun.star.wizards.document.GridControl.xComponent.
69 xComponent = UnoRuntime.queryInterface( XComponent.class,
oGridModel );
70
71 for (int i = 0; i < _fieldcolumns.length; i++)
72 {
73 FieldColumn curfieldcolumn = _fieldcolumns[i];
74 if (curfieldcolumn.getFieldType() == DataType.TIMESTAMP)
** CID 1397058: Null pointer dereferences (NULL_RETURNS)
/wizards/com/sun/star/wizards/db/TableDescriptor.java: 685 in
com.sun.star.wizards.db.TableDescriptor.getNonBinaryFieldNames()()
________________________________________________________________________________________________________
*** CID 1397058: Null pointer dereferences (NULL_RETURNS)
/wizards/com/sun/star/wizards/db/TableDescriptor.java: 685 in
com.sun.star.wizards.db.TableDescriptor.getNonBinaryFieldNames()()
679 {
680 ColumnDescriptor oColumnDescriptor =
columncontainer.get(i);
681 XPropertySet xColPropertySet =
getByName(oColumnDescriptor.Name);
682 int itype;
683 try
684 {
>>> CID 1397058: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "xColPropertySet".
685 itype =
AnyConverter.toInt(xColPropertySet.getPropertyValue("Type"));
686 if (!isBinaryDataType(itype))
687 {
688
NonBinaryFieldNameVector.add(oColumnDescriptor.Name);
689 }
690 }
** CID 1397057: Null pointer dereferences (NULL_RETURNS)
/wizards/com/sun/star/wizards/common/Configuration.java: 98 in
com.sun.star.wizards.common.Configuration.getLocaleString(com.sun.star.lang.XMultiServiceFactory,
java.lang.String, java.lang.String)()
________________________________________________________________________________________________________
*** CID 1397057: Null pointer dereferences (NULL_RETURNS)
/wizards/com/sun/star/wizards/common/Configuration.java: 98 in
com.sun.star.wizards.common.Configuration.getLocaleString(com.sun.star.lang.XMultiServiceFactory,
java.lang.String, java.lang.String)()
92 sLocale = (String) Helper.getUnoObjectbyName(oMasterKey,
key);
93 }
94 catch (Exception exception)
95 {
96 exception.printStackTrace(System.err);
97 }
>>> CID 1397057: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "sLocale".
98 if (sLocale.length() == 0 && (!key.equals("Locale") ||
!root.equals("org.openoffice.System/L10N/")))
99 {
100 return getLocaleString(xMSF, "org.openoffice.System/L10N/",
"Locale");
101 }
102 return sLocale;
103 }
** CID 1397056: Null pointer dereferences (NULL_RETURNS)
/svtools/source/contnr/treelistbox.cxx: 1849 in
SvTreeListBox::SetCheckButtonInvisible(SvTreeListEntry *)()
________________________________________________________________________________________________________
*** CID 1397056: Null pointer dereferences (NULL_RETURNS)
/svtools/source/contnr/treelistbox.cxx: 1849 in
SvTreeListBox::SetCheckButtonInvisible(SvTreeListEntry *)()
1843 }
1844
1845 void SvTreeListBox::SetCheckButtonInvisible( SvTreeListEntry* pEntry)
1846 {
1847 if( nTreeFlags & SvTreeFlags::CHKBTN )
1848 {
>>> CID 1397056: Null pointer dereferences (NULL_RETURNS)
>>> Assigning: "pItem" = null return value from "GetFirstItem".
1849 SvLBoxButton* pItem =
static_cast<SvLBoxButton*>(pEntry->GetFirstItem(SvLBoxItemType::Button));
1850 pItem->SetStateInvisible();
1851 InvalidateEntry( pEntry );
1852 }
1853 }
1854
** CID 1397055: (MIXED_ENUMS)
/xmloff/source/text/txtimp.cxx: 2297 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
/xmloff/source/text/txtimp.cxx: 2299 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
________________________________________________________________________________________________________
*** CID 1397055: (MIXED_ENUMS)
/xmloff/source/text/txtimp.cxx: 2297 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
2291
2292 case XML_TOK_TEXT_CHANGE:
2293 case XML_TOK_TEXT_CHANGE_START:
2294 case XML_TOK_TEXT_CHANGE_END:
2295 pContext = new XMLChangeImportContext(
2296 rImport, nPrefix, rLocalName,
>>> CID 1397055: (MIXED_ENUMS)
>>> Mixing enum types "SwXMLTextElemTokens" and "XMLTextPElemTokens" for
>>> "nToken".
2297 ((nToken == XML_TOK_TEXTP_CHANGE_END)
2298 ? XMLChangeImportContext::Element::END
2299 : (nToken == XML_TOK_TEXTP_CHANGE_START)
2300 ? XMLChangeImportContext::Element::START
2301 : XMLChangeImportContext::Element::POINT),
2302 true);
/xmloff/source/text/txtimp.cxx: 2299 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
2293 case XML_TOK_TEXT_CHANGE_START:
2294 case XML_TOK_TEXT_CHANGE_END:
2295 pContext = new XMLChangeImportContext(
2296 rImport, nPrefix, rLocalName,
2297 ((nToken == XML_TOK_TEXTP_CHANGE_END)
2298 ? XMLChangeImportContext::Element::END
>>> CID 1397055: (MIXED_ENUMS)
>>> Mixing enum types "SwXMLTextElemTokens" and "XMLTextPElemTokens" for
>>> "nToken".
2299 : (nToken == XML_TOK_TEXTP_CHANGE_START)
2300 ? XMLChangeImportContext::Element::START
2301 : XMLChangeImportContext::Element::POINT),
2302 true);
2303 break;
2304
** CID 1397054: Null pointer dereferences (FORWARD_NULL)
/vcl/source/window/paint.cxx: 693 in
vcl::Window::ImplInvalidateFrameRegion(const vcl::Region *, InvalidateFlags)()
________________________________________________________________________________________________________
*** CID 1397054: Null pointer dereferences (FORWARD_NULL)
/vcl/source/window/paint.cxx: 693 in
vcl::Window::ImplInvalidateFrameRegion(const vcl::Region *, InvalidateFlags)()
687 // set Paint-Flags
688 mpWindowImpl->mnPaintFlags |= ImplPaintFlags::Paint;
689 if ( nFlags & InvalidateFlags::Children )
690 mpWindowImpl->mnPaintFlags |= ImplPaintFlags::PaintAllChildren;
691 if ( !(nFlags & InvalidateFlags::NoErase) )
692 mpWindowImpl->mnPaintFlags |= ImplPaintFlags::Erase;
>>> CID 1397054: Null pointer dereferences (FORWARD_NULL)
>>> Comparing "pRegion" to null implies that "pRegion" might be null.
693 if ( !pRegion )
694 mpWindowImpl->mnPaintFlags |= ImplPaintFlags::PaintAll;
695
696 // if not everything has to be redrawn, add the region to it
697 if ( !(mpWindowImpl->mnPaintFlags & ImplPaintFlags::PaintAll) )
698 mpWindowImpl->maInvalidateRegion.Union( *pRegion );
** CID 1397053: (DEADCODE)
/xmloff/source/text/txtimp.cxx: 2295 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
/xmloff/source/text/txtimp.cxx: 2295 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
________________________________________________________________________________________________________
*** CID 1397053: (DEADCODE)
/xmloff/source/text/txtimp.cxx: 2295 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
2289 bContent = false;
2290 break;
2291
2292 case XML_TOK_TEXT_CHANGE:
2293 case XML_TOK_TEXT_CHANGE_START:
2294 case XML_TOK_TEXT_CHANGE_END:
>>> CID 1397053: (DEADCODE)
>>> Execution cannot reach the expression
>>> "XMLChangeImportContext::Element::END" inside this statement: "<storage
>>> from new>->XMLChan...".
2295 pContext = new XMLChangeImportContext(
2296 rImport, nPrefix, rLocalName,
2297 ((nToken == XML_TOK_TEXTP_CHANGE_END)
2298 ? XMLChangeImportContext::Element::END
2299 : (nToken == XML_TOK_TEXTP_CHANGE_START)
2300 ? XMLChangeImportContext::Element::START
/xmloff/source/text/txtimp.cxx: 2295 in
XMLTextImportHelper::CreateTextChildContext(SvXMLImport &, unsigned short,
const rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
XMLTextType)()
2289 bContent = false;
2290 break;
2291
2292 case XML_TOK_TEXT_CHANGE:
2293 case XML_TOK_TEXT_CHANGE_START:
2294 case XML_TOK_TEXT_CHANGE_END:
>>> CID 1397053: (DEADCODE)
>>> Execution cannot reach the expression
>>> "XMLChangeImportContext::Element::START" inside this statement: "<storage
>>> from new>->XMLChan...".
2295 pContext = new XMLChangeImportContext(
2296 rImport, nPrefix, rLocalName,
2297 ((nToken == XML_TOK_TEXTP_CHANGE_END)
2298 ? XMLChangeImportContext::Element::END
2299 : (nToken == XML_TOK_TEXTP_CHANGE_START)
2300 ? XMLChangeImportContext::Element::START
** CID 1397052: (DEADCODE)
/vcl/source/outdev/textline.cxx: 780 in
OutputDevice::ImplDrawTextLines(SalLayout &, FontStrikeout, FontLineStyle,
FontLineStyle, bool, bool)()
/vcl/source/outdev/textline.cxx: 789 in
OutputDevice::ImplDrawTextLines(SalLayout &, FontStrikeout, FontLineStyle,
FontLineStyle, bool, bool)()
________________________________________________________________________________________________________
*** CID 1397052: (DEADCODE)
/vcl/source/outdev/textline.cxx: 780 in
OutputDevice::ImplDrawTextLines(SalLayout &, FontStrikeout, FontLineStyle,
FontLineStyle, bool, bool)()
774 // update the length of the textline
775 nWidth += nAdvance;
776 }
777 else if( nWidth > 0 )
778 {
779 // draw the textline for each word
>>> CID 1397052: (DEADCODE)
>>> Execution cannot reach this statement: "this->ImplDrawTextLine(aSta...".
780 ImplDrawTextLine( aStartPt.X(), aStartPt.Y(), nDist,
nWidth,
781 eStrikeout, eUnderline, eOverline,
bUnderlineAbove );
782 nWidth = 0;
783 }
784 }
785
/vcl/source/outdev/textline.cxx: 789 in
OutputDevice::ImplDrawTextLines(SalLayout &, FontStrikeout, FontLineStyle,
FontLineStyle, bool, bool)()
783 }
784 }
785
786 // draw textline for the last word
787 if( nWidth > 0 )
788 {
>>> CID 1397052: (DEADCODE)
>>> Execution cannot reach this statement: "this->ImplDrawTextLine(aSta...".
789 ImplDrawTextLine( aStartPt.X(), aStartPt.Y(), nDist, nWidth,
790 eStrikeout, eUnderline, eOverline,
bUnderlineAbove );
791 }
792 }
793 else
794 {
** CID 1397051: (CHECKED_RETURN)
/xmloff/source/draw/ximp3dscene.cxx: 82 in
SdXML3DLightContext::SdXML3DLightContext(SvXMLImport &, unsigned short, const
rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
/xmloff/source/draw/ximp3dscene.cxx: 87 in
SdXML3DLightContext::SdXML3DLightContext(SvXMLImport &, unsigned short, const
rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
________________________________________________________________________________________________________
*** CID 1397051: (CHECKED_RETURN)
/xmloff/source/draw/ximp3dscene.cxx: 82 in
SdXML3DLightContext::SdXML3DLightContext(SvXMLImport &, unsigned short, const
rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
76 SAL_WARN("xmloff", "NaNs found in light direction: "
<< sValue);
77 }
78 break;
79 }
80 case XML_TOK_3DLIGHT_ENABLED:
81 {
>>> CID 1397051: (CHECKED_RETURN)
>>> Calling "convertBool" without checking return value (as is done
>>> elsewhere 66 out of 82 times).
82 ::sax::Converter::convertBool(mbEnabled, sValue);
83 break;
84 }
85 case XML_TOK_3DLIGHT_SPECULAR:
86 {
87 ::sax::Converter::convertBool(mbSpecular, sValue);
/xmloff/source/draw/ximp3dscene.cxx: 87 in
SdXML3DLightContext::SdXML3DLightContext(SvXMLImport &, unsigned short, const
rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
81 {
82 ::sax::Converter::convertBool(mbEnabled, sValue);
83 break;
84 }
85 case XML_TOK_3DLIGHT_SPECULAR:
86 {
>>> CID 1397051: (CHECKED_RETURN)
>>> Calling "convertBool" without checking return value (as is done
>>> elsewhere 66 out of 82 times).
87 ::sax::Converter::convertBool(mbSpecular, sValue);
88 break;
89 }
90 }
91 }
92 }
** CID 1397050: Error handling issues (CHECKED_RETURN)
/xmloff/source/draw/ximp3dscene.cxx: 332 in
SdXML3DSceneAttributesHelper::processSceneAttribute(unsigned short, const
rtl::OUString &, const rtl::OUString &)()
________________________________________________________________________________________________________
*** CID 1397050: Error handling issues (CHECKED_RETURN)
/xmloff/source/draw/ximp3dscene.cxx: 332 in
SdXML3DSceneAttributesHelper::processSceneAttribute(unsigned short, const
rtl::OUString &, const rtl::OUString &)()
326 {
327 ::sax::Converter::convertColor(maAmbientColor, rValue);
328 return;
329 }
330 else if( IsXMLToken( rLocalName, XML_LIGHTING_MODE ) )
331 {
>>> CID 1397050: Error handling issues (CHECKED_RETURN)
>>> Calling "convertBool" without checking return value (as is done
>>> elsewhere 66 out of 82 times).
332 ::sax::Converter::convertBool(mbLightingMode, rValue);
333 return;
334 }
335 }
336 }
337
** CID 1397049: (CHECKED_RETURN)
/xmloff/source/chart/SchXMLRegressionCurveObjectContext.cxx: 156 in
SchXMLEquationContext::StartElement(const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
/xmloff/source/chart/SchXMLRegressionCurveObjectContext.cxx: 159 in
SchXMLEquationContext::StartElement(const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
________________________________________________________________________________________________________
*** CID 1397049: (CHECKED_RETURN)
/xmloff/source/chart/SchXMLRegressionCurveObjectContext.cxx: 156 in
SchXMLEquationContext::StartElement(const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
150 case XML_TOK_REGEQ_POS_Y:
151 rImport.GetMM100UnitConverter().convertMeasureToCore(
152 aPosition.Y, aValue );
153 bHasYPos = true;
154 break;
155 case XML_TOK_REGEQ_DISPLAY_EQUATION:
>>> CID 1397049: (CHECKED_RETURN)
>>> Calling "convertBool" without checking return value (as is done
>>> elsewhere 66 out of 82 times).
156 ::sax::Converter::convertBool(bShowEquation, aValue);
157 break;
158 case XML_TOK_REGEQ_DISPLAY_R_SQUARE:
159 ::sax::Converter::convertBool(bShowRSquare, aValue);
160 break;
161 case XML_TOK_REGEQ_STYLE_NAME:
/xmloff/source/chart/SchXMLRegressionCurveObjectContext.cxx: 159 in
SchXMLEquationContext::StartElement(const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &)()
153 bHasYPos = true;
154 break;
155 case XML_TOK_REGEQ_DISPLAY_EQUATION:
156 ::sax::Converter::convertBool(bShowEquation, aValue);
157 break;
158 case XML_TOK_REGEQ_DISPLAY_R_SQUARE:
>>> CID 1397049: (CHECKED_RETURN)
>>> Calling "convertBool" without checking return value (as is done
>>> elsewhere 66 out of 82 times).
159 ::sax::Converter::convertBool(bShowRSquare, aValue);
160 break;
161 case XML_TOK_REGEQ_STYLE_NAME:
162 sAutoStyleName = aValue;
163 break;
164 }
** CID 1397048: Error handling issues (CHECKED_RETURN)
/desktop/source/splash/splash.cxx: 540 in
<unnamed>::SplashScreen::SetScreenBitmap(BitmapEx &)()
________________________________________________________________________________________________________
*** CID 1397048: Error handling issues (CHECKED_RETURN)
/desktop/source/splash/splash.cxx: 540 in
<unnamed>::SplashScreen::SetScreenBitmap(BitmapEx &)()
534
535 aStrBuf.append( "intro_" );
536 aStrBuf.append( aResBuf.getStr() );
537 if (Application::LoadBrandBitmap
(aResBuf.makeStringAndClear().getStr(), rBitmap))
538 return;
539
>>> CID 1397048: Error handling issues (CHECKED_RETURN)
>>> Calling "LoadBrandBitmap" without checking return value (as is done
>>> elsewhere 4 out of 5 times).
540 Application::LoadBrandBitmap ("intro", rBitmap);
541 }
542
543 void SplashScreen::determineProgressRatioValues(
544 double& rXRelPos, double& rYRelPos,
545 double& rRelWidth, double& rRelHeight )
** CID 1397047: Error handling issues (CHECKED_RETURN)
/xmloff/source/forms/officeforms.cxx: 78 in
xmloff::OFormsRootImport::implImportBool(const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
xmloff::OfficeFormsAttributes, const
com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &, const
com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo> &,
const rtl::OUString &, bool)()
________________________________________________________________________________________________________
*** CID 1397047: Error handling issues (CHECKED_RETURN)
/xmloff/source/forms/officeforms.cxx: 78 in
xmloff::OFormsRootImport::implImportBool(const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> &,
xmloff::OfficeFormsAttributes, const
com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &, const
com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo> &,
const rtl::OUString &, bool)()
72
OAttributeMetaData::getOfficeFormsAttributeNamespace(_eAttribute),
73
OUString::createFromAscii(OAttributeMetaData::getOfficeFormsAttributeName(_eAttribute)));
74
75 // get and convert the value
76 OUString sAttributeValue =
_rxAttributes->getValueByName(sCompleteAttributeName);
77 bool bValue = _bDefault;
>>> CID 1397047: Error handling issues (CHECKED_RETURN)
>>> Calling "convertBool" without checking return value (as is done
>>> elsewhere 66 out of 82 times).
78 ::sax::Converter::convertBool(bValue, sAttributeValue);
79
80 // set the property
81 if (_rxPropInfo->hasPropertyByName(_rPropName))
82 {
83 _rxProps->setPropertyValue(_rPropName, makeAny(bValue));
** CID 1397046: Error handling issues (CHECKED_RETURN)
/svtools/source/svrtf/rtfout.cxx: 144 in <unnamed>::Out_Char(SvStream &,
char16_t, int *, unsigned short, bool)()
________________________________________________________________________________________________________
*** CID 1397046: Error handling issues (CHECKED_RETURN)
/svtools/source/svrtf/rtfout.cxx: 144 in <unnamed>::Out_Char(SvStream &,
char16_t, int *, unsigned short, bool)()
138 RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR;
139 bool bWriteAsUnicode =
!(sBuf.convertToString(&sConverted,
140 eDestEnc, nFlags))
141 ||
(RTL_TEXTENCODING_UTF8==eDestEnc); // #i43933# do not export UTF-8 chars in RTF;
142 if (bWriteAsUnicode)
143 {
>>> CID 1397046: Error handling issues (CHECKED_RETURN)
>>> Calling "convertToString" without checking return value (as is done
>>> elsewhere 11 out of 12 times).
144 sBuf.convertToString(&sConverted,
145 eDestEnc, OUSTRING_TO_OSTRING_CVTFLAGS);
146 }
147 const sal_Int32 nLen = sConverted.getLength();
148
149 if (bWriteAsUnicode && pUCMode)
** CID 1397045: Error handling issues (CHECKED_RETURN)
/editeng/source/uno/unoipset.cxx: 102 in
SvxItemPropertySet::getPropertyValue(const SfxItemPropertySimpleEntry *, const
SfxItemSet &, bool, bool)()
________________________________________________________________________________________________________
*** CID 1397045: Error handling issues (CHECKED_RETURN)
/editeng/source/uno/unoipset.cxx: 102 in
SvxItemPropertySet::getPropertyValue(const SfxItemPropertySimpleEntry *, const
SfxItemSet &, bool, bool)()
96 uno::Any aVal;
97 if(!pMap || !pMap->nWID)
98 return aVal;
99
100 const SfxPoolItem* pItem = nullptr;
101 SfxItemPool* pPool = rSet.GetPool();
>>> CID 1397045: Error handling issues (CHECKED_RETURN)
>>> Calling "GetItemState" without checking return value (as is done
>>> elsewhere 85 out of 94 times).
102 rSet.GetItemState( pMap->nWID, bSearchInParent, &pItem );
103 if( nullptr == pItem && pPool )
104 pItem = &(pPool->GetDefaultItem( pMap->nWID ));
105
106 const MapUnit eMapUnit = pPool ?
pPool->GetMetric((sal_uInt16)pMap->nWID) : MapUnit::Map100thMM;
107 sal_uInt8 nMemberId = pMap->nMemberId & (~SFX_METRIC_ITEM);
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyTbwhZFvlXophxrb12Z16PK8eEriEacB-2FpLglbtXCUkCHhHEB7i9UpbsO3KVlHV6u13oBcPmHRgqSyUQkOPe98SDMfUZ7j-2FfIxIcfUW3CDHk3E9ocXsegKYqLMQxdLlCUvkKg-2FJcfihrngQUyaUjDd5zZLjzfsD4mYbGZfEQu9OU-3D
To manage Coverity Scan email notifications for
"libreoffice@lists.freedesktop.org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyTbwhZFvlXophxrb12Z16PGyVXVGU7UI-2Fss80A9XaGGSIJP0OvxKypOBai-2BxDwtHwQulXPrcJdH6i5gMRa-2BAo4-2BgD6H7TPKFg3kLww0R4v06Vdy9MBQsBaDpF-2FMNYqWzjyT-2FELVx4jzIRswmppb8dfz-2FRYVRwwe4MB0OKsRlK280-3D
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
