I found one issue: - When we select by shortcuts (eg, shift + left arrow) it only updates selection counts in a next selection (showing the results of the previous selection region)
Regards. 2011/11/3 Jean-Baptiste Faure <jbf.fa...@orange.fr>: > Le 03/11/2011 03:21, Matt Pratt a écrit : >> On 11/02/2011 10:10 AM, Caolán McNamara wrote: >>> On Wed, 2011-11-02 at 14:55 +0000, Caolán McNamara wrote: >>>> There are some titchy little wrinkles worth looking at, e.g. its got >>>> handlers for cursor and mouse move and things like that to update the >>>> count, but not apparently for selecting text by clicking the mouse, i.e. >>>> double click to select a word and single click somewhere else to >>>> unselect the text. >>> >>> I *think* the right thing to do is to additionally hook into "EndSelect" >>> which gets called when a selection is completed, and "Invalidate" which >>> seems to get called when a selection is discarded. >>> i.e. >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=0cbcb89fde8cc81db499bc1e388fd53ef6fa3c3f >>> >>> >>> Seems to work anyway. >> >> Wow, thanks for sorting out the wrinkles and pushing the patch so quickly. >> >> I think with your hook into EndSelect we may be able to get rid of the >> mouse hook? > > Hi Matt, > > I tested the new Word count dialog in the master. It works well but I > have two points: > - I do not know if it possible to make the window resizable, in order do > not mask the text area > - the counts are updated when you press a character key. If you use an > autotext (F3), the counts are updated once you have entered another > character. To test : enter DT+F3 (if your UI is in English, DT for Dummy > Text). > > Thank you for this patch. :-) > > Best regards. > JBF > > -- > Seuls des formats ouverts peuvent assurer la pérennité de vos documents. > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
