xmlsecurity/inc/xmlsignaturehelper.hxx | 6 ++++++
1 file changed, 6 insertions(+)
New commits:
commit 6f82a540c505fca37292f4b5cb74a1441a25ca98
Author: Tor Lillqvist <t...@collabora.com>
Date: Wed Nov 2 23:37:51 2016 +0200
Add FIXME
Change-Id: I37e614f6dfa0778cb126a6de282921a15417af1c
diff --git a/xmlsecurity/inc/xmlsignaturehelper.hxx
b/xmlsecurity/inc/xmlsignaturehelper.hxx
index 4ba359c..3ff3a9c 100644
--- a/xmlsecurity/inc/xmlsignaturehelper.hxx
+++ b/xmlsecurity/inc/xmlsignaturehelper.hxx
@@ -91,6 +91,12 @@ class XMLSECURITY_DLLPUBLIC XMLSignatureHelper
{
private:
css::uno::Reference< css::uno::XComponentContext > mxCtx;
+ // FIXME: This field appears to be unused (it is only assigned to in the
XMLSignatureHelper
+ // constructor), but it can't be removed as it is that very assignment
which causes the object
+ // it to be acquired, and otherwise its reference counting will be borked
and we get a
+ // crash. This is stupid of course. Probably we should just kill the
separate XSecController
+ // class and move its contents inside this class. Nothing else uses
XSecController anyway, as
+ // far as I see.
css::uno::Reference< css::xml::crypto::sax::XSecurityController >
mxSecurityController;
css::uno::Reference< css::xml::crypto::XUriBinding > mxUriBinding;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
