sfx2/source/doc/objserv.cxx | 8 ++++++++
1 file changed, 8 insertions(+)
New commits:
commit 8e904d334cbf3c10202d486e0b6e2e58edec3f9c
Author: Tor Lillqvist <t...@collabora.com>
Date: Wed Nov 2 10:55:45 2016 +0200
Add a comment wondering about "ODF Version", further explanations welcome
Change-Id: Idc660ba71ccff02c97a018838974430c0206ace6
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index 9e1d8ef..5a77b77 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -1387,6 +1387,14 @@ void SfxObjectShell::ImplSign( bool bScriptingContent )
bool bHasSign = ( pImpl->nScriptingSignatureState !=
SignatureState::NOSIGNATURES || pImpl->nDocumentSignatureState !=
SignatureState::NOSIGNATURES );
// the target ODF version on saving
+
+ // Please fix this comment if you can: Note that the talk about "ODF
version" around here is a
+ // bit silly, as there should be nothing ODF-specific in this code, right?
What we mean, I
+ // think, is "ODF version iff it is ODF that is the format the document is
being stored as", and
+ // otherwise the "ODF version" is ignored. Not sure why such
format-specific things needs to be
+ // handled here. Digital signatures then complicate matters further, as
it's only ODF 1.2 and
+ // OOXML that have digital signatures.
+
SvtSaveOptions aSaveOpt;
SvtSaveOptions::ODFDefaultVersion nVersion =
aSaveOpt.GetODFDefaultVersion();
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
