loolwsd/test/httpwstest.cpp | 8 ++++++++
1 file changed, 8 insertions(+)
New commits:
commit f9a6ed93d589a3c48233137e99e18a9d96e1fd0b
Author: Tor Lillqvist <t...@collabora.com>
Date: Tue Oct 4 09:21:20 2016 +0300
Add FIXME rant
diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 91dc79a..d963e11 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -2159,6 +2159,14 @@ void HTTPWSTest::testCursorPosition()
getResponseMessage(socket0, "invalidatecursor:", response, false,
testname);
Poco::StringTokenizer cursorTokens(response, ",",
Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM);
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(4), cursorTokens.count());
+
+ // FIXME: The 'status:' we look for below occasionally has arrived
already before the
+ // 'invalidatecursor:' we wait for above, and then the
assertResponseLine() call leads to an
+ // assertion failure. Is there any reason to think that something is
"wrong" when that
+ // happens? Isn't the LOOL protocol intentionally supposed to be very
loose with little
+ // strict requirements on the order of messages etc? In general the
tests in this file are
+ // too fragile, they (unintentionally?) test undocumented, unstable
and coincidental
+ // details.
assertResponseLine(socket0, "status:", testname);
// Create second view
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
