Hi August, Michael, Michael Meeks píše v Pá 21. 10. 2011 v 10:13 +0100:
> Ooh ! :-) this is really nice. I was previously fooled by the subject > into not noticing that this was some sexy code cleanup + unit testing > patch. Michael - thank you a lot for pushing this, and sorry, August, that I did not get to that earlier :-( I did a small follow-up patch: http://cgit.freedesktop.org/libreoffice/core/commit/?id=548fc5db7c39f62d99b1c0a9e4348972ff72545e August, can you please check that I actually did not break it? ;-) The first hunk should do the same thing as it was doing before your String -> OUString conversion (force copy), just with fewer operations. The second hunk should fix a hidden O(n^2) complexity (OUStringBuffer creation + removal of 1 character for every cSep found). Your unit tests pass fine, but better when more eyes actually look at the code too :-) Thank you, Kendy _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
