On 10.06.2016 15:15, Lionel Elie Mamane wrote: > On Fri, Jun 10, 2016 at 01:45:23PM +0200, Michael Stahl wrote: >> On 10.06.2016 12:58, Bunth Tamás wrote: > >>> - Add tommath to external dependencies. I guess it's just a row >>> somewhere, not a big deal. > >> there is a comment in ExternalProject_firebird.mk that essentially says >> that firebird 2.5 bundles tommath (and atomic_ops) - is that no longer >> the case in 3.0? > > No, I think that's a comment left over from the very early days when > we were using firebird 3.0.alpha before we settled in firebird 2.5 > (stable). Andrzej, is that correct? > > I think "internal" refers to "libreoffice internal", not "firebird > internal".
ah, you are right! we even still have the "libatomic_ops" external! i just didn't notice because it's only used on non-x86 platforms. > Tamás, take a look at > > commit 290bfcd2fdb44a52943f6fdc134d2565cbb83db3 > Author: Andrzej J.R. Hunt <andr...@ahunt.org> > Date: Thu Sep 5 10:24:35 2013 +0100 > > there used to be a commented out "check for tommath". But if firebird > needs tommath, then indeed we need to add it to our externals. yes, Tamás needs to write some makefiles after all :) that will be a UnpackedTarball, possibly a ExternalProject (unless it's one of those "header-only" things), possibly a Library (if it doesn't build in any sane way with MSVC), probably a ExternalPackage (unless it's completely statically linked). but we can keep it simple stick to the (above mentioned) comment and not support the scenario with system tommath and bundled firebird, either bundle both or take both from system. that means we likely don't need to detect "tommath" in configure, unless it's exposed somehow by firebird's public headers. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
