On 06/01/2016 09:33 AM, Aptitude Testing Team wrote:
We have an inconsistency with the coding style in our shared_ptr typedefs
cd core/include; grep -R "typedef std::shared_ptr"
Shows (for "std::shared_ptr<Foo>") we have "FooPtr" or "FooRef" or "PFoo"
Should we standardise this?
FooPtr is my preference.
...and std::shared_ptr<Foo> is mine. (That is, most of the time I find
such trivial typedefs to be more of a distraction ("what's that FooPtr
thing? a plain *, some std smart ptr, or maybe an rtl::Reference? lets
look it up") than a help. I think we even have an EasyHack to get rid
of them.)
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
