On Tue, 2011-10-04 at 14:04 +0530, Marc-André Laverdière wrote:
> Based on Caolan's comments, here's another attempt at doing things right.
>
> I'm unable to test right now (some symlink problem)... please don't push
> right away :)
This looks right to me, pushed now, thanks for this.
Only micro-nit is can leave an argument unnamed rather than self-assign
it to avoid an unused parameter warnings, e.g.
void foo(int a, int, int c)
{
}
rather than
void foo(int a, int b, int c)
{
b = b;
}
C.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
