[Libreoffice-commits] core.git: 2 commits - opencl/inc opencl/source

[Caolán McNamara]

 opencl/inc/opencl_device_selection.h |    3 +++
 opencl/source/opencl_device.cxx      |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 478a4032da69654245d478e15902feda1e49c84c
Author: Caolán McNamara <caol...@redhat.com>
Date:   Fri Apr 29 20:11:50 2016 +0100

    coverity#1358844 Uninitialized pointer field
    
    Change-Id: I66f34570c49f647cb1fd7775ef263e5e720d8064

diff --git a/opencl/inc/opencl_device_selection.h 
b/opencl/inc/opencl_device_selection.h
index 6ec506d..e2bda73 100644
--- a/opencl/inc/opencl_device_selection.h
+++ b/opencl/inc/opencl_device_selection.h
@@ -326,6 +326,9 @@ private:
 
 public:
     XmlWalker()
+        : mpDocPtr(nullptr)
+        , mpRoot(nullptr)
+        , mpCurrent(nullptr)
     {}
 
     ~XmlWalker()
commit 77327a03904ad7d6f58b07ec698cd15f02a4d6fa
Author: Caolán McNamara <caol...@redhat.com>
Date:   Fri Apr 29 20:10:18 2016 +0100

    coverity#1358843 Argument cannot be negative
    
    Change-Id: I97911406d55464f042922a2e37b33f92e2c024ef

diff --git a/opencl/source/opencl_device.cxx b/opencl/source/opencl_device.cxx
index 907d551..db143e3 100644
--- a/opencl/source/opencl_device.cxx
+++ b/opencl/source/opencl_device.cxx
@@ -435,7 +435,7 @@ ds_status pickBestDevice(std::unique_ptr<ds_profile>& 
profile, int& rBestDeviceI
             rBestDeviceIndex = d;
         }
     }
-    if (profile->devices[rBestDeviceIndex].eType == DeviceType::OpenCLDevice)
+    if (rBestDeviceIndex != -1 && profile->devices[rBestDeviceIndex].eType == 
DeviceType::OpenCLDevice)
     {
         SAL_INFO("opencl.device", "Selected Device[" << rBestDeviceIndex << 
"]: " << profile->devices[rBestDeviceIndex].sDeviceName << "(OpenCL).");
     }

_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits