include/xmloff/animationexport.hxx | 4 ++-- include/xmloff/animexp.hxx | 4 ++-- include/xmloff/attrlist.hxx | 2 +- include/xmloff/txtparae.hxx | 2 +- include/xmloff/xmlexp.hxx | 2 +- include/xmloff/xmlexppr.hxx | 2 +- include/xmloff/xmlimp.hxx | 2 +- include/xmloff/xmlimppr.hxx | 2 +- sc/source/filter/xml/xmlstyle.cxx | 4 ++-- sc/source/filter/xml/xmlstyle.hxx | 4 ++-- sw/inc/SwNumberTree.hxx | 2 +- sw/inc/doc.hxx | 2 +- sw/inc/ndgrf.hxx | 2 +- sw/inc/textboxhelper.hxx | 2 +- sw/inc/unoparagraph.hxx | 2 +- sw/inc/unotbl.hxx | 4 ++-- sw/source/core/SwNumberTree/SwNumberTree.cxx | 2 +- sw/source/core/crsr/crbm.cxx | 2 +- sw/source/core/doc/docbm.cxx | 4 ++-- sw/source/core/doc/docglos.cxx | 2 +- sw/source/core/doc/swstylemanager.cxx | 2 +- sw/source/core/doc/tblcpy.cxx | 6 +++--- sw/source/core/doc/textboxhelper.cxx | 2 +- sw/source/core/graphic/ndgrf.cxx | 2 +- sw/source/core/unocore/unoobj2.cxx | 2 +- sw/source/core/unocore/unostyle.cxx | 2 +- sw/source/core/unocore/unotbl.cxx | 6 +++--- sw/source/core/unocore/unotext.cxx | 2 +- xmloff/inc/PropertySetMerger.hxx | 4 ++-- xmloff/inc/StyleMap.hxx | 2 +- xmloff/inc/XMLChartPropertySetMapper.hxx | 4 ++-- xmloff/source/chart/PropertyMaps.cxx | 4 ++-- xmloff/source/chart/SchXMLExport.cxx | 16 ++++++++-------- xmloff/source/chart/SchXMLPlotAreaContext.cxx | 4 ++-- xmloff/source/chart/SchXMLTableContext.cxx | 4 ++-- xmloff/source/chart/SchXMLTableContext.hxx | 4 ++-- xmloff/source/chart/SchXMLTools.cxx | 2 +- xmloff/source/chart/SchXMLTools.hxx | 4 ++-- xmloff/source/core/DomBuilderContext.cxx | 4 ++-- xmloff/source/core/PropertySetMerger.cxx | 2 +- xmloff/source/core/attrlist.cxx | 2 +- xmloff/source/core/xmlexp.cxx | 2 +- xmloff/source/core/xmlimp.cxx | 2 +- xmloff/source/draw/animationexport.cxx | 4 ++-- xmloff/source/draw/animexp.cxx | 4 ++-- xmloff/source/draw/sdpropls.cxx | 4 ++-- xmloff/source/draw/sdpropls.hxx | 4 ++-- xmloff/source/draw/sdxmlexp.cxx | 8 ++++---- xmloff/source/draw/sdxmlexp_impl.hxx | 8 ++++---- xmloff/source/draw/shapeimport.cxx | 4 ++-- xmloff/source/style/PageMasterExportPropMapper.cxx | 4 ++-- xmloff/source/style/PageMasterExportPropMapper.hxx | 2 +- xmloff/source/style/StyleMap.cxx | 2 +- xmloff/source/style/xmlexppr.cxx | 2 +- xmloff/source/style/xmlimppr.cxx | 4 ++-- xmloff/source/text/txtexppr.cxx | 2 +- xmloff/source/text/txtexppr.hxx | 2 +- xmloff/source/text/txtparae.cxx | 2 +- 58 files changed, 96 insertions(+), 96 deletions(-)
New commits: commit 7c99b5586d7cb145079129470fdbf720399eee3c Author: Noel Grandin <n...@peralex.com> Date: Tue Apr 12 08:33:08 2016 +0200 clang-tidy performance-unnecessary-value-param in sw Change-Id: I3e030743b640d5a5f6b3bf4a4e9ba50ccd001287 diff --git a/sw/inc/SwNumberTree.hxx b/sw/inc/SwNumberTree.hxx index f4144ee..4b9bdae 100644 --- a/sw/inc/SwNumberTree.hxx +++ b/sw/inc/SwNumberTree.hxx @@ -476,7 +476,7 @@ protected: - false only set if aItLastValid is preceding the current last valid node */ - void SetLastValid(tSwNumberTreeChildren::const_iterator aItLastValid, + void SetLastValid(const tSwNumberTreeChildren::const_iterator& aItLastValid, bool bValidating = false) const; /** diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx index 7c3cfc9..1dbf4ad 100644 --- a/sw/inc/doc.hxx +++ b/sw/inc/doc.hxx @@ -877,7 +877,7 @@ public: Convenince function used by ReplaceDocumentProperties to skip some UNO calls. */ - void ReplaceUserDefinedDocumentProperties( const css::uno::Reference< css::document::XDocumentProperties > xSourceDocProps ); + void ReplaceUserDefinedDocumentProperties( const css::uno::Reference< css::document::XDocumentProperties >& xSourceDocProps ); /** Replace document properties with those from rSource. diff --git a/sw/inc/ndgrf.hxx b/sw/inc/ndgrf.hxx index 7b960c9..3c29bef 100644 --- a/sw/inc/ndgrf.hxx +++ b/sw/inc/ndgrf.hxx @@ -195,7 +195,7 @@ public: bool IsLinkedInputStreamReady() const { return mbLinkedInputStreamReady;} void TriggerAsyncRetrieveInputStream(); void ApplyInputStream( - css::uno::Reference<css::io::XInputStream> xInputStream, + const css::uno::Reference<css::io::XInputStream>& xInputStream, const bool bIsStreamReadOnly ); void UpdateLinkWithInputStream(); bool IsAsyncRetrieveInputStreamPossible() const; diff --git a/sw/inc/textboxhelper.hxx b/sw/inc/textboxhelper.hxx index 2b3e0873..012869f 100644 --- a/sw/inc/textboxhelper.hxx +++ b/sw/inc/textboxhelper.hxx @@ -64,7 +64,7 @@ public: /// If we have an associated TextFrame, then return that. static SwFrameFormat* findTextBox(const SwFrameFormat* pShape); - static SwFrameFormat* findTextBox(css::uno::Reference<css::drawing::XShape> xShape); + static SwFrameFormat* findTextBox(const css::uno::Reference<css::drawing::XShape>& xShape); /// Return the textbox rectangle of a draw shape (in twips). static Rectangle getTextRectangle(SwFrameFormat* pShape, bool bAbsolute = true); diff --git a/sw/inc/unoparagraph.hxx b/sw/inc/unoparagraph.hxx index 4da09be..4515bbf 100644 --- a/sw/inc/unoparagraph.hxx +++ b/sw/inc/unoparagraph.hxx @@ -277,7 +277,7 @@ struct SwXParagraphEnumeration { static SwXParagraphEnumeration* Create( css::uno::Reference< css::text::XText > const & xParent, - std::shared_ptr<SwUnoCursor> pCursor, + const std::shared_ptr<SwUnoCursor>& pCursor, const CursorType eType, SwStartNode const*const pStartNode = nullptr, SwTable const*const pTable = nullptr); diff --git a/sw/inc/unotbl.hxx b/sw/inc/unotbl.hxx index a80a57d..f7ea606 100644 --- a/sw/inc/unotbl.hxx +++ b/sw/inc/unotbl.hxx @@ -425,12 +425,12 @@ private: class Impl; ::sw::UnoImplPtr<Impl> m_pImpl; - SwXCellRange(sw::UnoCursorPointer pCursor, SwFrameFormat& rFrameFormat, SwRangeDescriptor& rDesc); + SwXCellRange(const sw::UnoCursorPointer& pCursor, SwFrameFormat& rFrameFormat, SwRangeDescriptor& rDesc); virtual ~SwXCellRange(); public: static ::rtl::Reference<SwXCellRange> CreateXCellRange( - sw::UnoCursorPointer pCursor, SwFrameFormat& rFrameFormat, + const sw::UnoCursorPointer& pCursor, SwFrameFormat& rFrameFormat, SwRangeDescriptor& rDesc); static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); diff --git a/sw/source/core/SwNumberTree/SwNumberTree.cxx b/sw/source/core/SwNumberTree/SwNumberTree.cxx index eb8899b..6824c44 100644 --- a/sw/source/core/SwNumberTree/SwNumberTree.cxx +++ b/sw/source/core/SwNumberTree/SwNumberTree.cxx @@ -1027,7 +1027,7 @@ SwNumberTreeNode * SwNumberTreeNode::GetPred(bool bSibling) const } void SwNumberTreeNode::SetLastValid - ( SwNumberTreeNode::tSwNumberTreeChildren::const_iterator aItValid, + ( const SwNumberTreeNode::tSwNumberTreeChildren::const_iterator& aItValid, bool bValidating ) const { OSL_ENSURE( (aItValid == mChildren.end() || GetIterator(*aItValid) != mChildren.end()), diff --git a/sw/source/core/crsr/crbm.cxx b/sw/source/core/crsr/crbm.cxx index bd82a24..946af35 100644 --- a/sw/source/core/crsr/crbm.cxx +++ b/sw/source/core/crsr/crbm.cxx @@ -70,7 +70,7 @@ namespace return rpFirst->GetMarkEnd() > rpSecond->GetMarkEnd(); } - bool lcl_IsInvisibleBookmark(IDocumentMarkAccess::pMark_t pMark) + bool lcl_IsInvisibleBookmark(const IDocumentMarkAccess::pMark_t& pMark) { return IDocumentMarkAccess::GetType(*pMark) != IDocumentMarkAccess::MarkType::BOOKMARK; } diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx index d5dafda..e8fff02 100644 --- a/sw/source/core/doc/docbm.cxx +++ b/sw/source/core/doc/docbm.cxx @@ -260,8 +260,8 @@ namespace IDocumentMarkAccess::const_iterator_t lcl_FindMarkByName( const OUString& rName, - IDocumentMarkAccess::const_iterator_t ppMarksBegin, - IDocumentMarkAccess::const_iterator_t ppMarksEnd) + const IDocumentMarkAccess::const_iterator_t& ppMarksBegin, + const IDocumentMarkAccess::const_iterator_t& ppMarksEnd) { return find_if( ppMarksBegin, diff --git a/sw/source/core/doc/docglos.cxx b/sw/source/core/doc/docglos.cxx index 647a800..6a87006 100644 --- a/sw/source/core/doc/docglos.cxx +++ b/sw/source/core/doc/docglos.cxx @@ -36,7 +36,7 @@ using namespace ::com::sun::star; void SwDoc::ReplaceUserDefinedDocumentProperties( - uno::Reference<document::XDocumentProperties> xSourceDocProps) + const uno::Reference<document::XDocumentProperties>& xSourceDocProps) { OSL_ENSURE(xSourceDocProps.is(), "null reference"); diff --git a/sw/source/core/doc/swstylemanager.cxx b/sw/source/core/doc/swstylemanager.cxx index e1b47cd..e5be8bc 100644 --- a/sw/source/core/doc/swstylemanager.cxx +++ b/sw/source/core/doc/swstylemanager.cxx @@ -35,7 +35,7 @@ class SwStyleCache SwStyleNameCache mMap; public: SwStyleCache() {} - void addStyleName( StylePool::SfxItemSet_Pointer_t pStyle ) + void addStyleName( const StylePool::SfxItemSet_Pointer_t& pStyle ) { mMap[ StylePool::nameOf(pStyle) ] = pStyle; } void addCompletePool( StylePool& rPool ); StylePool::SfxItemSet_Pointer_t getByName( const OUString& rName ) { return mMap[rName]; } diff --git a/sw/source/core/doc/tblcpy.cxx b/sw/source/core/doc/tblcpy.cxx index f25cd8a..ed6de58 100644 --- a/sw/source/core/doc/tblcpy.cxx +++ b/sw/source/core/doc/tblcpy.cxx @@ -105,10 +105,10 @@ namespace }; SubTable::iterator insertSubLine( SubTable& rSubTable, SwTableLine& rLine, - SubTable::iterator pStartLn ); + const SubTable::iterator& pStartLn ); SubTable::iterator insertSubBox( SubTable& rSubTable, SwTableBox& rBox, - SubTable::iterator pStartLn, SubTable::iterator pEndLn ) + SubTable::iterator pStartLn, const SubTable::iterator& pEndLn ) { if( !rBox.GetTabLines().empty() ) { @@ -151,7 +151,7 @@ namespace } SubTable::iterator insertSubLine( SubTable& rSubTable, SwTableLine& rLine, - SubTable::iterator pStartLn ) + const SubTable::iterator& pStartLn ) { SubTable::iterator pMax = pStartLn; ++pMax; diff --git a/sw/source/core/doc/textboxhelper.cxx b/sw/source/core/doc/textboxhelper.cxx index 3c55e28..0a66017 100644 --- a/sw/source/core/doc/textboxhelper.cxx +++ b/sw/source/core/doc/textboxhelper.cxx @@ -274,7 +274,7 @@ void SwTextBoxHelper::getShapeWrapThrough(const SwFrameFormat* pTextBox, bool& r rWrapThrough = it->second->GetSurround().GetSurround() == SURROUND_THROUGHT; } -SwFrameFormat* SwTextBoxHelper::findTextBox(uno::Reference<drawing::XShape> xShape) +SwFrameFormat* SwTextBoxHelper::findTextBox(const uno::Reference<drawing::XShape>& xShape) { SwXShape* pShape = dynamic_cast<SwXShape*>(xShape.get()); if (!pShape) diff --git a/sw/source/core/graphic/ndgrf.cxx b/sw/source/core/graphic/ndgrf.cxx index cdf1fc1..cf6df9a 100644 --- a/sw/source/core/graphic/ndgrf.cxx +++ b/sw/source/core/graphic/ndgrf.cxx @@ -1107,7 +1107,7 @@ void SwGrfNode::TriggerAsyncRetrieveInputStream() void SwGrfNode::ApplyInputStream( - css::uno::Reference<css::io::XInputStream> xInputStream, + const css::uno::Reference<css::io::XInputStream>& xInputStream, const bool bIsStreamReadOnly ) { if ( IsLinkedFile() ) diff --git a/sw/source/core/unocore/unoobj2.cxx b/sw/source/core/unocore/unoobj2.cxx index 7c95bb3..b60e23e 100644 --- a/sw/source/core/unocore/unoobj2.cxx +++ b/sw/source/core/unocore/unoobj2.cxx @@ -515,7 +515,7 @@ struct SwXParagraphEnumerationImpl final : public SwXParagraphEnumeration SwXParagraphEnumeration* SwXParagraphEnumeration::Create( uno::Reference< text::XText > const& xParent, - ::std::shared_ptr<SwUnoCursor> pCursor, + const ::std::shared_ptr<SwUnoCursor>& pCursor, const CursorType eType, SwStartNode const*const pStartNode, SwTable const*const pTable) diff --git a/sw/source/core/unocore/unostyle.cxx b/sw/source/core/unocore/unostyle.cxx index 342f9cf..5e07f5e 100644 --- a/sw/source/core/unocore/unostyle.cxx +++ b/sw/source/core/unocore/unostyle.cxx @@ -2442,7 +2442,7 @@ void SwXStyle::setPropertyToDefault(const OUString& rPropertyName) setPropertiesToDefault(aSequence); } -SwFormat* lcl_GetFormatForStyle(SwDoc* pDoc, rtl::Reference<SwDocStyleSheet> xStyle, const SfxStyleFamily eFamily) +SwFormat* lcl_GetFormatForStyle(SwDoc* pDoc, const rtl::Reference<SwDocStyleSheet>& xStyle, const SfxStyleFamily eFamily) { if(!xStyle.is()) return nullptr; diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx index e64c5d6..24b1222 100644 --- a/sw/source/core/unocore/unotbl.cxx +++ b/sw/source/core/unocore/unotbl.cxx @@ -3206,7 +3206,7 @@ public: bool m_bFirstRowAsLabel; bool m_bFirstColumnAsLabel; - Impl(sw::UnoCursorPointer const pCursor, SwFrameFormat& rFrameFormat, + Impl(sw::UnoCursorPointer const& pCursor, SwFrameFormat& rFrameFormat, SwRangeDescriptor& rDesc) : SwClient(&rFrameFormat) , m_ChartListeners(m_Mutex) @@ -3280,7 +3280,7 @@ uno::Sequence<OUString> SwXCellRange::getSupportedServiceNames() throw( uno::Run "com.sun.star.style.ParagraphPropertiesComplex" }; } -SwXCellRange::SwXCellRange(sw::UnoCursorPointer const pCursor, +SwXCellRange::SwXCellRange(sw::UnoCursorPointer const& pCursor, SwFrameFormat& rFrameFormat, SwRangeDescriptor& rDesc) : m_pImpl(new Impl(pCursor, rFrameFormat, rDesc)) { @@ -3291,7 +3291,7 @@ SwXCellRange::~SwXCellRange() } rtl::Reference<SwXCellRange> SwXCellRange::CreateXCellRange( - sw::UnoCursorPointer const pCursor, SwFrameFormat& rFrameFormat, + sw::UnoCursorPointer const& pCursor, SwFrameFormat& rFrameFormat, SwRangeDescriptor& rDesc) { SwXCellRange *const pCellRange(new SwXCellRange(pCursor, rFrameFormat, rDesc)); diff --git a/sw/source/core/unocore/unotext.cxx b/sw/source/core/unocore/unotext.cxx index caf84cc..61692e9 100644 --- a/sw/source/core/unocore/unotext.cxx +++ b/sw/source/core/unocore/unotext.cxx @@ -2041,7 +2041,7 @@ lcl_ApplyCellProperties( const sal_Int32 nCell, TableColumnSeparators const& rRowSeparators, const uno::Sequence< beans::PropertyValue >& rCellProperties, - uno::Reference< uno::XInterface > xCell, + const uno::Reference< uno::XInterface >& xCell, ::std::vector<VerticallyMergedCell> & rMergedCells) { const sal_Int32 nCellProperties = rCellProperties.getLength(); commit dc0d98590f07c7dae4504b7ed0c0127794f032d8 Author: Noel Grandin <n...@peralex.com> Date: Mon Apr 11 16:05:03 2016 +0200 clang-tidy performance-unnecessary-value-param in xmloff Change-Id: I8e6d8e66cdab2e50ee10882e139be29c14ce50f6 diff --git a/include/xmloff/animationexport.hxx b/include/xmloff/animationexport.hxx index d07678f..1bb0353 100644 --- a/include/xmloff/animationexport.hxx +++ b/include/xmloff/animationexport.hxx @@ -43,8 +43,8 @@ public: AnimationsExporter( SvXMLExport& rExport, const css::uno::Reference< css::beans::XPropertySet >& xPageProps ); virtual ~AnimationsExporter(); - void prepare( css::uno::Reference< css::animations::XAnimationNode > xRootNode ); - void exportAnimations( css::uno::Reference< css::animations::XAnimationNode > xRootNode ); + void prepare( const css::uno::Reference< css::animations::XAnimationNode >& xRootNode ); + void exportAnimations( const css::uno::Reference< css::animations::XAnimationNode >& xRootNode ); }; } diff --git a/include/xmloff/animexp.hxx b/include/xmloff/animexp.hxx index 7276b47..cce1623 100644 --- a/include/xmloff/animexp.hxx +++ b/include/xmloff/animexp.hxx @@ -36,8 +36,8 @@ public: XMLAnimationsExporter( XMLShapeExport* pShapeExp ); virtual ~XMLAnimationsExporter(); - void prepare( css::uno::Reference< css::drawing::XShape > xShape, SvXMLExport& rExport ); - void collect( css::uno::Reference< css::drawing::XShape > xShape, SvXMLExport& rExport ); + void prepare( const css::uno::Reference< css::drawing::XShape >& xShape, SvXMLExport& rExport ); + void collect( const css::uno::Reference< css::drawing::XShape >& xShape, SvXMLExport& rExport ); void exportAnimations( SvXMLExport& rExport ); }; diff --git a/include/xmloff/attrlist.hxx b/include/xmloff/attrlist.hxx index 55e3e4e..34567c2 100644 --- a/include/xmloff/attrlist.hxx +++ b/include/xmloff/attrlist.hxx @@ -51,7 +51,7 @@ public: virtual ~SvXMLAttributeList(); static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId() throw(); - static SvXMLAttributeList* getImplementation( css::uno::Reference< css::uno::XInterface > ) throw(); + static SvXMLAttributeList* getImplementation( const css::uno::Reference< css::uno::XInterface >& ) throw(); // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) throw(css::uno::RuntimeException, std::exception) override; diff --git a/include/xmloff/txtparae.hxx b/include/xmloff/txtparae.hxx index ccf595b..c578fad 100644 --- a/include/xmloff/txtparae.hxx +++ b/include/xmloff/txtparae.hxx @@ -585,7 +585,7 @@ public: */ void PreventExportOfControlsInMuteSections( const css::uno::Reference< css::container::XIndexAccess> & rShapes, - rtl::Reference<xmloff::OFormLayerXMLExport> xFormExport ); + const rtl::Reference<xmloff::OFormLayerXMLExport>& xFormExport ); SinglePropertySetInfoCache& GetCharStyleNamesPropInfoCache() { return aCharStyleNamesPropInfoCache; } diff --git a/include/xmloff/xmlexp.hxx b/include/xmloff/xmlexp.hxx index 38f08c7..6240cb7 100644 --- a/include/xmloff/xmlexp.hxx +++ b/include/xmloff/xmlexp.hxx @@ -297,7 +297,7 @@ public: virtual ~SvXMLExport(); static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId() throw(); - static SvXMLExport* getImplementation( css::uno::Reference< css::uno::XInterface > ) throw(); + static SvXMLExport* getImplementation( const css::uno::Reference< css::uno::XInterface >& ) throw(); // XExporter virtual void SAL_CALL setSourceDocument( const css::uno::Reference< css::lang::XComponent >& xDoc ) throw(css::lang::IllegalArgumentException, css::uno::RuntimeException, std::exception) override; diff --git a/include/xmloff/xmlexppr.hxx b/include/xmloff/xmlexppr.hxx index b293e76..0df3869 100644 --- a/include/xmloff/xmlexppr.hxx +++ b/include/xmloff/xmlexppr.hxx @@ -71,7 +71,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference<css::beans::XPropertySet > rPropSet ) const; + const css::uno::Reference<css::beans::XPropertySet >& rPropSet ) const; /** fills the given attribute list with the items in the given set */ void _exportXML( sal_uInt16 nPropType, sal_uInt16& rPropTypeFlags, diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx index 6cc8607..5eda0d4 100644 --- a/include/xmloff/xmlimp.hxx +++ b/include/xmloff/xmlimp.hxx @@ -436,7 +436,7 @@ public: OUString const & i_rXmlId); /// Add a RDFa statement; parameters are XML attribute values - void AddRDFa( css::uno::Reference< css::rdf::XMetadatable> i_xObject, + void AddRDFa( const css::uno::Reference< css::rdf::XMetadatable>& i_xObject, OUString const & i_rAbout, OUString const & i_rProperty, OUString const & i_rContent, diff --git a/include/xmloff/xmlimppr.hxx b/include/xmloff/xmlimppr.hxx index 640d7bb..cd140e8 100644 --- a/include/xmloff/xmlimppr.hxx +++ b/include/xmloff/xmlimppr.hxx @@ -84,7 +84,7 @@ public: */ void importXML( ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::xml::sax::XAttributeList > xAttrList, + const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList, const SvXMLUnitConverter& rUnitConverter, const SvXMLNamespaceMap& rNamespaceMap, sal_uInt32 nPropType, diff --git a/sc/source/filter/xml/xmlstyle.cxx b/sc/source/filter/xml/xmlstyle.cxx index ea45c1b..613787e 100644 --- a/sc/source/filter/xml/xmlstyle.cxx +++ b/sc/source/filter/xml/xmlstyle.cxx @@ -191,7 +191,7 @@ ScXMLCellExportPropertyMapper::~ScXMLCellExportPropertyMapper() void ScXMLCellExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { XMLPropertyState* pPadding = nullptr; XMLPropertyState* pPadding_Bottom = nullptr; @@ -559,7 +559,7 @@ ScXMLRowExportPropertyMapper::~ScXMLRowExportPropertyMapper() void ScXMLRowExportPropertyMapper::ContextFilter( bool /* bEnableFoFontFamily */, ::std::vector< XMLPropertyState >& /* rProperties */, - uno::Reference< beans::XPropertySet > /* rPropSet */ ) const + const uno::Reference< beans::XPropertySet >& /* rPropSet */ ) const { //#108550#; don't filter the height, so other applications know the calculated height } diff --git a/sc/source/filter/xml/xmlstyle.hxx b/sc/source/filter/xml/xmlstyle.hxx index ce27051..2730ec1 100644 --- a/sc/source/filter/xml/xmlstyle.hxx +++ b/sc/source/filter/xml/xmlstyle.hxx @@ -109,7 +109,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference<css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference<css::beans::XPropertySet >& rPropSet ) const override; public: explicit ScXMLCellExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper ); @@ -138,7 +138,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference<css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference<css::beans::XPropertySet >& rPropSet ) const override; public: explicit ScXMLRowExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper ); diff --git a/xmloff/inc/PropertySetMerger.hxx b/xmloff/inc/PropertySetMerger.hxx index 7a711d3..22ec387 100644 --- a/xmloff/inc/PropertySetMerger.hxx +++ b/xmloff/inc/PropertySetMerger.hxx @@ -24,8 +24,8 @@ extern css::uno::Reference< css::beans::XPropertySet > PropertySetMerger_CreateInstance( - css::uno::Reference< css::beans::XPropertySet > rPropSet1, - css::uno::Reference< css::beans::XPropertySet > rPropSet2 ) throw(); + const css::uno::Reference< css::beans::XPropertySet >& rPropSet1, + const css::uno::Reference< css::beans::XPropertySet >& rPropSet2 ) throw(); #endif diff --git a/xmloff/inc/StyleMap.hxx b/xmloff/inc/StyleMap.hxx index 4d838ab..d11447d 100644 --- a/xmloff/inc/StyleMap.hxx +++ b/xmloff/inc/StyleMap.hxx @@ -75,7 +75,7 @@ public: static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId() throw(); static StyleMap* getImplementation( - css::uno::Reference< css::uno::XInterface > ) throw(); + const css::uno::Reference< css::uno::XInterface >& ) throw(); // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( diff --git a/xmloff/inc/XMLChartPropertySetMapper.hxx b/xmloff/inc/XMLChartPropertySetMapper.hxx index 819865b..cb8dcd5 100644 --- a/xmloff/inc/XMLChartPropertySetMapper.hxx +++ b/xmloff/inc/XMLChartPropertySetMapper.hxx @@ -52,7 +52,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference<css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference<css::beans::XPropertySet >& rPropSet ) const override; private: /// this method is called for every item that has the MID_FLAG_ELEMENT_EXPORT flag set @@ -74,7 +74,7 @@ public: SvXMLExport& rExport ); virtual ~XMLChartExportPropertyMapper(); - void setChartDoc( css::uno::Reference< css::chart2::XChartDocument > xChartDoc ); + void setChartDoc( const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc ); }; class XMLChartImportPropertyMapper : public SvXMLImportPropertyMapper diff --git a/xmloff/source/chart/PropertyMaps.cxx b/xmloff/source/chart/PropertyMaps.cxx index 67011a5..0e55b07 100644 --- a/xmloff/source/chart/PropertyMaps.cxx +++ b/xmloff/source/chart/PropertyMaps.cxx @@ -211,7 +211,7 @@ XMLChartExportPropertyMapper::~XMLChartExportPropertyMapper() void XMLChartExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { OUString aAutoPropName; bool bCheckAuto = false; @@ -508,7 +508,7 @@ void XMLChartExportPropertyMapper::handleSpecialItem( } } -void XMLChartExportPropertyMapper::setChartDoc( uno::Reference< chart2::XChartDocument > xChartDoc ) +void XMLChartExportPropertyMapper::setChartDoc( const uno::Reference< chart2::XChartDocument >& xChartDoc ) { mxChartDoc = xChartDoc; } diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx index 064f8d9..57abb96 100644 --- a/xmloff/source/chart/SchXMLExport.cxx +++ b/xmloff/source/chart/SchXMLExport.cxx @@ -184,8 +184,8 @@ public: bool bIncludeTable = false ); void exportTable(); void exportPlotArea( - css::uno::Reference< css::chart::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XDiagram > xNewDiagram, + const css::uno::Reference< css::chart::XDiagram >& xDiagram, + const css::uno::Reference< css::chart2::XDiagram >& xNewDiagram, const css::awt::Size & rPageSize, bool bExportContent, bool bIncludeTable ); @@ -234,10 +234,10 @@ public: /// add svg position as attribute for current element void addPosition( const css::awt::Point & rPosition ); - void addPosition( css::uno::Reference< css::drawing::XShape > xShape ); + void addPosition( const css::uno::Reference< css::drawing::XShape >& xShape ); /// add svg size as attribute for current element void addSize( const css::awt::Size & rSize, bool bIsOOoNamespace = false ); - void addSize( css::uno::Reference< css::drawing::XShape > xShape ); + void addSize( const css::uno::Reference< css::drawing::XShape >& xShape ); /// exports a string as a paragraph element void exportText( const OUString& rText ); @@ -1818,8 +1818,8 @@ Reference< chart2::XAxis > lcl_getAxis( const Reference< chart2::XCoordinateSyst } void SchXMLExportHelper_Impl::exportPlotArea( - Reference< chart::XDiagram > xDiagram, - Reference< chart2::XDiagram > xNewDiagram, + const Reference< chart::XDiagram >& xDiagram, + const Reference< chart2::XDiagram >& xNewDiagram, const awt::Size & rPageSize, bool bExportContent, bool bIncludeTable ) @@ -3457,7 +3457,7 @@ void SchXMLExportHelper_Impl::addPosition( const awt::Point & rPosition ) mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_Y, msString ); } -void SchXMLExportHelper_Impl::addPosition( Reference< drawing::XShape > xShape ) +void SchXMLExportHelper_Impl::addPosition( const Reference< drawing::XShape >& xShape ) { if( xShape.is()) addPosition( xShape->getPosition()); @@ -3476,7 +3476,7 @@ void SchXMLExportHelper_Impl::addSize( const awt::Size & rSize, bool bIsOOoNames mrExport.AddAttribute( bIsOOoNamespace ? XML_NAMESPACE_CHART_EXT : XML_NAMESPACE_SVG, XML_HEIGHT, msString ); } -void SchXMLExportHelper_Impl::addSize( Reference< drawing::XShape > xShape ) +void SchXMLExportHelper_Impl::addSize( const Reference< drawing::XShape >& xShape ) { if( xShape.is()) addSize( xShape->getSize() ); diff --git a/xmloff/source/chart/SchXMLPlotAreaContext.cxx b/xmloff/source/chart/SchXMLPlotAreaContext.cxx index 07e4db5..af2e117 100644 --- a/xmloff/source/chart/SchXMLPlotAreaContext.cxx +++ b/xmloff/source/chart/SchXMLPlotAreaContext.cxx @@ -977,7 +977,7 @@ SchXMLStatisticsObjectContext::~SchXMLStatisticsObjectContext() namespace { -void SetErrorBarStyleProperties( const OUString& rStyleName, uno::Reference< beans::XPropertySet > xBarProp, +void SetErrorBarStyleProperties( const OUString& rStyleName, const uno::Reference< beans::XPropertySet >& xBarProp, SchXMLImportHelper& rImportHelper ) { const SvXMLStylesContext* pStylesCtxt = rImportHelper.GetAutoStylesContext(); @@ -990,7 +990,7 @@ void SetErrorBarStyleProperties( const OUString& rStyleName, uno::Reference< bea rSeriesStyleContext.FillPropertySet( xBarProp ); } -void SetErrorBarPropertiesFromStyleName( const OUString& aStyleName, uno::Reference< beans::XPropertySet> xBarProp, +void SetErrorBarPropertiesFromStyleName( const OUString& aStyleName, const uno::Reference< beans::XPropertySet>& xBarProp, SchXMLImportHelper& rImportHelper, OUString& aPosRange, OUString& aNegRange) { const SvXMLStylesContext* pStylesCtxt = rImportHelper.GetAutoStylesContext(); diff --git a/xmloff/source/chart/SchXMLTableContext.cxx b/xmloff/source/chart/SchXMLTableContext.cxx index 5bef107..d3403d3 100644 --- a/xmloff/source/chart/SchXMLTableContext.cxx +++ b/xmloff/source/chart/SchXMLTableContext.cxx @@ -741,7 +741,7 @@ static void lcl_ApplyCellToComplexLabel( const SchXMLCell& rCell, Sequence< uno: void SchXMLTableHelper::applyTableToInternalDataProvider( const SchXMLTable& rTable, - uno::Reference< chart2::XChartDocument > xChartDoc ) + const uno::Reference< chart2::XChartDocument >& xChartDoc ) { // apply all data read from the local table to the internal data provider if( !xChartDoc.is() || !xChartDoc->hasInternalDataProvider() ) @@ -835,7 +835,7 @@ void SchXMLTableHelper::applyTableToInternalDataProvider( void SchXMLTableHelper::switchRangesFromOuterToInternalIfNecessary( const SchXMLTable& rTable, const tSchXMLLSequencesPerIndex & rLSequencesPerIndex, - uno::Reference< chart2::XChartDocument > xChartDoc, + const uno::Reference< chart2::XChartDocument >& xChartDoc, chart::ChartDataRowSource eDataRowSource ) { if( ! (xChartDoc.is() && xChartDoc->hasInternalDataProvider())) diff --git a/xmloff/source/chart/SchXMLTableContext.hxx b/xmloff/source/chart/SchXMLTableContext.hxx index 21ba2fd..6523fac 100644 --- a/xmloff/source/chart/SchXMLTableContext.hxx +++ b/xmloff/source/chart/SchXMLTableContext.hxx @@ -68,14 +68,14 @@ class SchXMLTableHelper { public: static void applyTableToInternalDataProvider( const SchXMLTable& rTable, - css::uno::Reference< css::chart2::XChartDocument > xChartDoc ); + const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc ); /** This function reorders local data to fit the correct data structure. Call it after the data series got their styles set. */ static void switchRangesFromOuterToInternalIfNecessary( const SchXMLTable& rTable, const tSchXMLLSequencesPerIndex & rLSequencesPerIndex, - css::uno::Reference< css::chart2::XChartDocument > xChartDoc, + const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc, css::chart::ChartDataRowSource eDataRowSource ); }; diff --git a/xmloff/source/chart/SchXMLTools.cxx b/xmloff/source/chart/SchXMLTools.cxx index bb5d011..619758f 100644 --- a/xmloff/source/chart/SchXMLTools.cxx +++ b/xmloff/source/chart/SchXMLTools.cxx @@ -746,7 +746,7 @@ bool switchBackToDataProviderFromParent( const Reference< chart2::XChartDocument return true; } -void setBuildIDAtImportInfo( uno::Reference< frame::XModel > xModel, Reference< beans::XPropertySet > xImportInfo ) +void setBuildIDAtImportInfo( const uno::Reference< frame::XModel >& xModel, const Reference< beans::XPropertySet >& xImportInfo ) { OUString aGenerator( lcl_getGeneratorFromModelOrItsParent(xModel) ); if( !aGenerator.isEmpty() ) diff --git a/xmloff/source/chart/SchXMLTools.hxx b/xmloff/source/chart/SchXMLTools.hxx index 567fa3b..456cf67 100644 --- a/xmloff/source/chart/SchXMLTools.hxx +++ b/xmloff/source/chart/SchXMLTools.hxx @@ -48,8 +48,8 @@ namespace SchXMLTools bool isDocumentGeneratedWithOpenOfficeOlderThan3_0( const css::uno::Reference< css::frame::XModel >& xChartModel); bool isDocumentGeneratedWithOpenOfficeOlderThan3_3( const css::uno::Reference< css::frame::XModel >& xChartModel); - void setBuildIDAtImportInfo( css::uno::Reference< css::frame::XModel > xModel - , css::uno::Reference< css::beans::XPropertySet > xImportInfo ); + void setBuildIDAtImportInfo( const css::uno::Reference< css::frame::XModel >& xModel + , const css::uno::Reference< css::beans::XPropertySet >& xImportInfo ); enum SchXMLChartTypeEnum { diff --git a/xmloff/source/core/DomBuilderContext.cxx b/xmloff/source/core/DomBuilderContext.cxx index d51d71e..89bab48 100644 --- a/xmloff/source/core/DomBuilderContext.cxx +++ b/xmloff/source/core/DomBuilderContext.cxx @@ -61,7 +61,7 @@ static Reference<XNode> lcl_createDomInstance(); static Reference<XNode> lcl_createElement( SvXMLImport& rImport, sal_uInt16 nPrefix, const OUString& rLocalName, - Reference<XNode> xParent); + const Reference<XNode>& xParent); DomBuilderContext::DomBuilderContext( SvXMLImport& rImport, @@ -195,7 +195,7 @@ static Reference<XNode> lcl_createDomInstance() static Reference<XNode> lcl_createElement( SvXMLImport& rImport, sal_uInt16 nPrefix, const OUString& rLocalName, - Reference<XNode> xParent) + const Reference<XNode>& xParent) { DBG_ASSERT( xParent.is(), "need parent node" ); diff --git a/xmloff/source/core/PropertySetMerger.cxx b/xmloff/source/core/PropertySetMerger.cxx index 2dc03ee..62a6cd5 100644 --- a/xmloff/source/core/PropertySetMerger.cxx +++ b/xmloff/source/core/PropertySetMerger.cxx @@ -243,7 +243,7 @@ sal_Bool SAL_CALL PropertySetMergerImpl::hasPropertyByName( const OUString& Name return mxPropSet2Info->hasPropertyByName( Name ); } -Reference< XPropertySet > PropertySetMerger_CreateInstance( Reference< XPropertySet > rPropSet1, Reference< XPropertySet > rPropSet2 ) throw() +Reference< XPropertySet > PropertySetMerger_CreateInstance( const Reference< XPropertySet >& rPropSet1, const Reference< XPropertySet >& rPropSet2 ) throw() { return new PropertySetMergerImpl( rPropSet1, rPropSet2 ); } diff --git a/xmloff/source/core/attrlist.cxx b/xmloff/source/core/attrlist.cxx index c3a651c..f01dc41 100644 --- a/xmloff/source/core/attrlist.cxx +++ b/xmloff/source/core/attrlist.cxx @@ -245,7 +245,7 @@ const uno::Sequence< sal_Int8 > & SvXMLAttributeList::getUnoTunnelId() throw() return theSvXMLAttributeListUnoTunnelId::get().getSeq(); } -SvXMLAttributeList* SvXMLAttributeList::getImplementation( uno::Reference< uno::XInterface > xInt ) throw() +SvXMLAttributeList* SvXMLAttributeList::getImplementation( const uno::Reference< uno::XInterface >& xInt ) throw() { uno::Reference< lang::XUnoTunnel > xUT( xInt, uno::UNO_QUERY ); if( xUT.is() ) diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx index dacacdb..6586867 100644 --- a/xmloff/source/core/xmlexp.cxx +++ b/xmloff/source/core/xmlexp.cxx @@ -2068,7 +2068,7 @@ const uno::Sequence< sal_Int8 > & SvXMLExport::getUnoTunnelId() throw() return theSvXMLExportUnoTunnelId::get().getSeq(); } -SvXMLExport* SvXMLExport::getImplementation( uno::Reference< uno::XInterface > xInt ) throw() +SvXMLExport* SvXMLExport::getImplementation( const uno::Reference< uno::XInterface >& xInt ) throw() { uno::Reference< lang::XUnoTunnel > xUT( xInt, uno::UNO_QUERY ); if( xUT.is() ) diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx index bf9e5de..513f610 100644 --- a/xmloff/source/core/xmlimp.cxx +++ b/xmloff/source/core/xmlimp.cxx @@ -1971,7 +1971,7 @@ SvXMLImport::GetRDFaImportHelper() } void -SvXMLImport::AddRDFa(uno::Reference<rdf::XMetadatable> i_xObject, +SvXMLImport::AddRDFa(const uno::Reference<rdf::XMetadatable>& i_xObject, OUString const & i_rAbout, OUString const & i_rProperty, OUString const & i_rContent, diff --git a/xmloff/source/draw/animationexport.cxx b/xmloff/source/draw/animationexport.cxx index 3140586c..7bc5521 100644 --- a/xmloff/source/draw/animationexport.cxx +++ b/xmloff/source/draw/animationexport.cxx @@ -1682,7 +1682,7 @@ AnimationsExporter::~AnimationsExporter() { } -void AnimationsExporter::prepare( Reference< XAnimationNode > xRootNode ) +void AnimationsExporter::prepare( const Reference< XAnimationNode >& xRootNode ) { try { @@ -1698,7 +1698,7 @@ void AnimationsExporter::prepare( Reference< XAnimationNode > xRootNode ) } } -void AnimationsExporter::exportAnimations( Reference< XAnimationNode > xRootNode ) +void AnimationsExporter::exportAnimations( const Reference< XAnimationNode >& xRootNode ) { try { diff --git a/xmloff/source/draw/animexp.cxx b/xmloff/source/draw/animexp.cxx index 0a14ef1..638d6fd 100644 --- a/xmloff/source/draw/animexp.cxx +++ b/xmloff/source/draw/animexp.cxx @@ -266,7 +266,7 @@ XMLAnimationsExporter::~XMLAnimationsExporter() { } -void XMLAnimationsExporter::prepare( Reference< XShape > xShape, SvXMLExport& ) +void XMLAnimationsExporter::prepare( const Reference< XShape >& xShape, SvXMLExport& ) { try { @@ -295,7 +295,7 @@ void XMLAnimationsExporter::prepare( Reference< XShape > xShape, SvXMLExport& ) } } -void XMLAnimationsExporter::collect( Reference< XShape > xShape, SvXMLExport& rExport ) +void XMLAnimationsExporter::collect( const Reference< XShape >& xShape, SvXMLExport& rExport ) { try { diff --git a/xmloff/source/draw/sdpropls.cxx b/xmloff/source/draw/sdpropls.cxx index da4366f..872cee8 100644 --- a/xmloff/source/draw/sdpropls.cxx +++ b/xmloff/source/draw/sdpropls.cxx @@ -1188,7 +1188,7 @@ XMLShapeExportPropertyMapper::~XMLShapeExportPropertyMapper() void XMLShapeExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { XMLPropertyState* pRepeatOffsetX = nullptr; XMLPropertyState* pRepeatOffsetY = nullptr; @@ -1569,7 +1569,7 @@ XMLPageExportPropertyMapper::~XMLPageExportPropertyMapper() void XMLPageExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { XMLPropertyState* pRepeatOffsetX = nullptr; XMLPropertyState* pRepeatOffsetY = nullptr; diff --git a/xmloff/source/draw/sdpropls.hxx b/xmloff/source/draw/sdpropls.hxx index 1b02570..22683e7 100644 --- a/xmloff/source/draw/sdpropls.hxx +++ b/xmloff/source/draw/sdpropls.hxx @@ -83,7 +83,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; public: XMLShapeExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper, SvXMLExport& rExport ); virtual ~XMLShapeExportPropertyMapper(); @@ -116,7 +116,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; public: XMLPageExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper, SvXMLExport& rExport ); virtual ~XMLPageExportPropertyMapper(); diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx index fdd1132..03586a0 100644 --- a/xmloff/source/draw/sdxmlexp.cxx +++ b/xmloff/source/draw/sdxmlexp.cxx @@ -623,7 +623,7 @@ void SAL_CALL SdXMLExport::setSourceDocument( const Reference< lang::XComponent } // #82003# helper function for recursive object count -sal_uInt32 SdXMLExport::ImpRecursiveObjectCount(Reference< drawing::XShapes > xShapes) +sal_uInt32 SdXMLExport::ImpRecursiveObjectCount(const Reference< drawing::XShapes >& xShapes) { sal_uInt32 nRetval(0L); @@ -1246,7 +1246,7 @@ void SdXMLExport::ImpWriteAutoLayoutPlaceholder(XmlPlaceholder ePl, const Rectan SvXMLElementExport aPPL(*this, XML_NAMESPACE_PRESENTATION, XML_PLACEHOLDER, true, true); } -ImpXMLEXPPageMasterInfo* SdXMLExport::ImpGetOrCreatePageMasterInfo( Reference< XDrawPage > xMasterPage ) +ImpXMLEXPPageMasterInfo* SdXMLExport::ImpGetOrCreatePageMasterInfo( const Reference< XDrawPage >& xMasterPage ) { bool bDoesExist = false; @@ -1614,7 +1614,7 @@ void SdXMLExport::ImplExportHeaderFooterDeclAttributes( const HeaderFooterPageSe AddAttribute( XML_NAMESPACE_PRESENTATION, XML_USE_DATE_TIME_NAME, aSettings.maStrDateTimeDeclName ); } -OUString SdXMLExport::ImpCreatePresPageStyleName( Reference<XDrawPage> xDrawPage, bool bExportBackground /* = true */ ) +OUString SdXMLExport::ImpCreatePresPageStyleName( const Reference<XDrawPage>& xDrawPage, bool bExportBackground /* = true */ ) { // create name OUString sStyleName; @@ -2485,7 +2485,7 @@ void SdXMLExport::ExportMasterStyles_() } } -void SdXMLExport::exportFormsElement( Reference< XDrawPage > xDrawPage ) +void SdXMLExport::exportFormsElement( const Reference< XDrawPage >& xDrawPage ) { if( xDrawPage.is() ) { diff --git a/xmloff/source/draw/sdxmlexp_impl.hxx b/xmloff/source/draw/sdxmlexp_impl.hxx index 49c3ebd..06be622 100644 --- a/xmloff/source/draw/sdxmlexp_impl.hxx +++ b/xmloff/source/draw/sdxmlexp_impl.hxx @@ -124,7 +124,7 @@ class SdXMLExport : public SvXMLExport virtual void ExportContent_() override; virtual void ExportMeta_() override; - ImpXMLEXPPageMasterInfo* ImpGetOrCreatePageMasterInfo( css::uno::Reference< css::drawing::XDrawPage > xMasterPage ); + ImpXMLEXPPageMasterInfo* ImpGetOrCreatePageMasterInfo( const css::uno::Reference< css::drawing::XDrawPage >& xMasterPage ); void ImpPrepPageMasterInfos(); void ImpWritePageMasterInfos(); void ImpPrepAutoLayoutInfos(); @@ -134,7 +134,7 @@ class SdXMLExport : public SvXMLExport void ImpPrepDrawPageInfos(); void ImpPrepMasterPageInfos(); void ImpWritePresentationStyles(); - OUString ImpCreatePresPageStyleName( css::uno::Reference<css::drawing::XDrawPage> xDrawPage, bool bExportBackground = true ); + OUString ImpCreatePresPageStyleName( const css::uno::Reference<css::drawing::XDrawPage>& xDrawPage, bool bExportBackground = true ); bool ImpPrepAutoLayoutInfo(const css::uno::Reference< css::drawing::XDrawPage >& xPage, OUString& rName); void ImpWriteAutoLayoutInfos(); @@ -142,11 +142,11 @@ class SdXMLExport : public SvXMLExport void ImpWriteHeaderFooterDecls(); void ImplExportHeaderFooterDeclAttributes( const HeaderFooterPageSettingsImpl& aSettings ); - void exportFormsElement( css::uno::Reference< css::drawing::XDrawPage > xDrawPage ); + void exportFormsElement( const css::uno::Reference< css::drawing::XDrawPage >& xDrawPage ); void exportPresentationSettings(); // #82003# helper function for recursive object count - sal_uInt32 ImpRecursiveObjectCount( css::uno::Reference< css::drawing::XShapes > xShapes); + sal_uInt32 ImpRecursiveObjectCount( const css::uno::Reference< css::drawing::XShapes >& xShapes); OUString getNavigationOrder( const css::uno::Reference< css::drawing::XDrawPage >& xDrawPage ); diff --git a/xmloff/source/draw/shapeimport.cxx b/xmloff/source/draw/shapeimport.cxx index 1f98a13..73cb3f7 100644 --- a/xmloff/source/draw/shapeimport.cxx +++ b/xmloff/source/draw/shapeimport.cxx @@ -65,8 +65,8 @@ struct ConnectionHint struct XShapeCompareHelper { - bool operator()(css::uno::Reference < css::drawing::XShape > x1, - css::uno::Reference < css::drawing::XShape > x2 ) const + bool operator()(const css::uno::Reference < css::drawing::XShape >& x1, + const css::uno::Reference < css::drawing::XShape >& x2 ) const { return x1.get() < x2.get(); } diff --git a/xmloff/source/style/PageMasterExportPropMapper.cxx b/xmloff/source/style/PageMasterExportPropMapper.cxx index 3aecf06..3bec5d6 100644 --- a/xmloff/source/style/PageMasterExportPropMapper.cxx +++ b/xmloff/source/style/PageMasterExportPropMapper.cxx @@ -55,7 +55,7 @@ static void lcl_RemoveStateIfZero16( XMLPropertyState* pState ) lcl_RemoveState( pState ); } -static void lcl_AddState(::std::vector< XMLPropertyState >& rPropState, sal_Int32 nIndex, const OUString& rProperty, uno::Reference< beans::XPropertySet >& xProps) +static void lcl_AddState(::std::vector< XMLPropertyState >& rPropState, sal_Int32 nIndex, const OUString& rProperty, const uno::Reference< beans::XPropertySet >& xProps) { if(::cppu::any2bool(xProps->getPropertyValue(rProperty))) rPropState.push_back(XMLPropertyState (nIndex, css::uno::Any(true))); @@ -300,7 +300,7 @@ void XMLPageMasterExportPropMapper::handleSpecialItem( void XMLPageMasterExportPropMapper::ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rPropState, - Reference< XPropertySet > rPropSet ) const + const Reference< XPropertySet >& rPropSet ) const { XMLPropertyStateBuffer aPageBuffer; XMLPropertyStateBuffer aHeaderBuffer; diff --git a/xmloff/source/style/PageMasterExportPropMapper.hxx b/xmloff/source/style/PageMasterExportPropMapper.hxx index f331249..8ee27e5 100644 --- a/xmloff/source/style/PageMasterExportPropMapper.hxx +++ b/xmloff/source/style/PageMasterExportPropMapper.hxx @@ -35,7 +35,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; public: diff --git a/xmloff/source/style/StyleMap.cxx b/xmloff/source/style/StyleMap.cxx index 73ee798..0ebcbc0 100644 --- a/xmloff/source/style/StyleMap.cxx +++ b/xmloff/source/style/StyleMap.cxx @@ -50,7 +50,7 @@ const Sequence<sal_Int8>& StyleMap::getUnoTunnelId() throw() return theStyleMapUnoTunnelId::get().getSeq(); } -StyleMap* StyleMap::getImplementation(Reference<XInterface> xInterface) throw() +StyleMap* StyleMap::getImplementation(const Reference<XInterface>& xInterface) throw() { Reference<XUnoTunnel> xUnoTunnel(xInterface, UNO_QUERY); if (xUnoTunnel.is()) diff --git a/xmloff/source/style/xmlexppr.cxx b/xmloff/source/style/xmlexppr.cxx index 5c8f673..1201dbc 100644 --- a/xmloff/source/style/xmlexppr.cxx +++ b/xmloff/source/style/xmlexppr.cxx @@ -667,7 +667,7 @@ vector<XMLPropertyState> SvXMLExportPropertyMapper::Filter_( void SvXMLExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, vector< XMLPropertyState >& rProperties, - Reference< XPropertySet > rPropSet ) const + const Reference< XPropertySet >& rPropSet ) const { // Derived class could implement this. if (mpImpl->mxNextMapper.is()) diff --git a/xmloff/source/style/xmlimppr.cxx b/xmloff/source/style/xmlimppr.cxx index 21cc0598..b841e59 100644 --- a/xmloff/source/style/xmlimppr.cxx +++ b/xmloff/source/style/xmlimppr.cxx @@ -104,8 +104,8 @@ void SvXMLImportPropertyMapper::ChainImportMapper( /** fills the given itemset with the attributes in the given list */ void SvXMLImportPropertyMapper::importXML( vector< XMLPropertyState >& rProperties, - Reference< XAttributeList > xAttrList, - const SvXMLUnitConverter& rUnitConverter, + const Reference< XAttributeList >& xAttrList, + const SvXMLUnitConverter& rUnitConverter, const SvXMLNamespaceMap& rNamespaceMap, sal_uInt32 nPropType, sal_Int32 nStartIdx, diff --git a/xmloff/source/text/txtexppr.cxx b/xmloff/source/text/txtexppr.cxx index 8b072c6..5bf9461 100644 --- a/xmloff/source/text/txtexppr.cxx +++ b/xmloff/source/text/txtexppr.cxx @@ -498,7 +498,7 @@ void lcl_FilterBorders( void XMLTextExportPropertySetMapper::ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - Reference< XPropertySet > rPropSet ) const + const Reference< XPropertySet >& rPropSet ) const { // filter font XMLPropertyState *pFontNameState = nullptr; diff --git a/xmloff/source/text/txtexppr.hxx b/xmloff/source/text/txtexppr.hxx index f89dd02..823db14 100644 --- a/xmloff/source/text/txtexppr.hxx +++ b/xmloff/source/text/txtexppr.hxx @@ -59,7 +59,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; const SvXMLExport& GetExport() const { return rExport; } public: diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx index f094cff..c7e03bb 100644 --- a/xmloff/source/text/txtparae.cxx +++ b/xmloff/source/text/txtparae.cxx @@ -3740,7 +3740,7 @@ void XMLTextParagraphExport::exportMeta( void XMLTextParagraphExport::PreventExportOfControlsInMuteSections( const Reference<XIndexAccess> & rShapes, - rtl::Reference<xmloff::OFormLayerXMLExport> xFormExport ) + const rtl::Reference<xmloff::OFormLayerXMLExport>& xFormExport ) { // check parameters ad pre-conditions if( ( ! rShapes.is() ) || ( ! xFormExport.is() ) ) _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits