include/sax/fshelper.hxx | 4 ++--
include/svtools/headbar.hxx | 2 +-
include/svtools/unoimap.hxx | 2 +-
include/svx/PaletteManager.hxx | 2 +-
include/svx/SmartTagItem.hxx | 6 +++---
include/svx/svdmodel.hxx | 4 ++--
include/svx/tbcontrl.hxx | 2 +-
include/svx/unoapi.hxx | 4 ++--
include/toolkit/controls/roadmapcontrol.hxx | 8 ++++----
include/tools/b3dtrans.hxx | 2 +-
include/ucbhelper/content.hxx | 2 +-
include/unotools/ucbhelper.hxx | 4 ++--
include/unotools/ucbstreamhelper.hxx | 10 +++++-----
include/vbahelper/vbashapes.hxx | 4 ++--
sax/source/tools/fshelper.cxx | 4 ++--
svtools/inc/table/tablecontrol.hxx | 2 +-
svtools/source/control/headbar.cxx | 2 +-
svtools/source/misc/dialogcontrolling.cxx | 2 +-
svtools/source/table/tablecontrol.cxx | 2 +-
svtools/source/table/tablecontrol_impl.cxx | 2 +-
svtools/source/table/tablecontrol_impl.hxx | 2 +-
svtools/source/uno/unoimap.cxx | 2 +-
svx/source/dialog/rubydialog.cxx | 4 ++--
svx/source/fmcomp/gridcell.cxx | 2 +-
svx/source/form/fmpgeimp.cxx | 2 +-
svx/source/form/fmvwimp.cxx | 2 +-
svx/source/inc/fmpgeimp.hxx | 2 +-
svx/source/inc/gridcell.hxx | 2 +-
svx/source/items/SmartTagItem.cxx | 6 +++---
svx/source/sidebar/line/LineWidthValueSet.cxx | 2 +-
svx/source/sidebar/line/LineWidthValueSet.hxx | 2 +-
svx/source/svdraw/svdmodel.cxx | 4 ++--
svx/source/table/accessibletableshape.cxx | 4 ++--
svx/source/tbxctrls/PaletteManager.cxx | 2 +-
svx/source/tbxctrls/tbcontrl.cxx | 4 ++--
svx/source/unodraw/unopage.cxx | 2 +-
svx/source/unodraw/unoshape.cxx | 4 ++--
svx/source/xml/xmlxtexp.cxx | 2 +-
svx/source/xml/xmlxtimp.cxx | 2 +-
toolkit/source/controls/roadmapcontrol.cxx | 8 ++++----
toolkit/source/controls/unocontrolcontainer.cxx | 2 +-
tools/source/generic/b3dtrans.cxx | 2 +-
ucbhelper/source/client/content.cxx | 2 +-
unotools/source/ucbhelper/ucbhelper.cxx | 4 ++--
unotools/source/ucbhelper/ucblockbytes.cxx | 20 ++++++++++----------
unotools/source/ucbhelper/ucbstreamhelper.cxx | 12 ++++++------
vbahelper/source/vbahelper/vbafillformat.cxx | 2 +-
vbahelper/source/vbahelper/vbafillformat.hxx | 2 +-
vbahelper/source/vbahelper/vbashapes.cxx | 4 ++--
49 files changed, 90 insertions(+), 90 deletions(-)
New commits:
commit 2c93d340ae4e854b5c9d3aa8c38a8bba0ae6b74b
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 15:11:42 2016 +0200
clang-tidy performance-unnecessary-value-param in vbahelper
Change-Id: Ifbe78c4a43b9d77d6ecf481bb1a9aaac6bcd01a6
diff --git a/include/vbahelper/vbashapes.hxx b/include/vbahelper/vbashapes.hxx
index 22ba0aa..78bdc33 100644
--- a/include/vbahelper/vbashapes.hxx
+++ b/include/vbahelper/vbashapes.hxx
@@ -52,8 +52,8 @@ protected:
public:
ScVbaShapes( const css::uno::Reference< ov::XHelperInterface >& xParent,
const css::uno::Reference< css::uno::XComponentContext >& xContext, const
css::uno::Reference< css::container::XIndexAccess >& xShapes, const
css::uno::Reference< css::frame::XModel >& xModel );
- static void setDefaultShapeProperties( css::uno::Reference<
css::drawing::XShape > xShape ) throw (css::uno::RuntimeException);
- static void setShape_NameProperty( css::uno::Reference<
css::drawing::XShape > xShape, const OUString& sName );
+ static void setDefaultShapeProperties( const css::uno::Reference<
css::drawing::XShape >& xShape ) throw (css::uno::RuntimeException);
+ static void setShape_NameProperty( const css::uno::Reference<
css::drawing::XShape >& xShape, const OUString& sName );
//XEnumerationAccess
virtual css::uno::Type SAL_CALL getElementType() throw
(css::uno::RuntimeException) override;
virtual css::uno::Reference< css::container::XEnumeration > SAL_CALL
createEnumeration() throw (css::uno::RuntimeException) override;
diff --git a/vbahelper/source/vbahelper/vbafillformat.cxx
b/vbahelper/source/vbahelper/vbafillformat.cxx
index 0313dd8..31f77dd 100644
--- a/vbahelper/source/vbahelper/vbafillformat.cxx
+++ b/vbahelper/source/vbahelper/vbafillformat.cxx
@@ -26,7 +26,7 @@
using namespace ooo::vba;
using namespace com::sun::star;
-ScVbaFillFormat::ScVbaFillFormat( const uno::Reference< XHelperInterface >&
xParent, const uno::Reference< uno::XComponentContext >& xContext, const
uno::Reference< drawing::XShape > xShape ) : ScVbaFillFormat_BASE( xParent,
xContext ), m_xShape( xShape )
+ScVbaFillFormat::ScVbaFillFormat( const uno::Reference< XHelperInterface >&
xParent, const uno::Reference< uno::XComponentContext >& xContext, const
uno::Reference< drawing::XShape >& xShape ) : ScVbaFillFormat_BASE( xParent,
xContext ), m_xShape( xShape )
{
m_xPropertySet.set( xShape, uno::UNO_QUERY_THROW );
m_nFillStyle = drawing::FillStyle_SOLID;
diff --git a/vbahelper/source/vbahelper/vbafillformat.hxx
b/vbahelper/source/vbahelper/vbafillformat.hxx
index fd19d74..80a3e79 100644
--- a/vbahelper/source/vbahelper/vbafillformat.hxx
+++ b/vbahelper/source/vbahelper/vbafillformat.hxx
@@ -43,7 +43,7 @@ protected:
virtual css::uno::Sequence<OUString> getServiceNames() override;
public:
- ScVbaFillFormat( const css::uno::Reference< ov::XHelperInterface >&
xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext,
const css::uno::Reference< css::drawing::XShape > xShape );
+ ScVbaFillFormat( const css::uno::Reference< ov::XHelperInterface >&
xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext,
const css::uno::Reference< css::drawing::XShape >& xShape );
void setForeColorAndInternalStyle( sal_Int32 nForeColor ) throw
(css::uno::RuntimeException);
// Attributes
diff --git a/vbahelper/source/vbahelper/vbashapes.cxx
b/vbahelper/source/vbahelper/vbashapes.cxx
index 9e3346d..0126bfe 100644
--- a/vbahelper/source/vbahelper/vbashapes.cxx
+++ b/vbahelper/source/vbahelper/vbashapes.cxx
@@ -409,7 +409,7 @@ ScVbaShapes::AddTextboxInWriter( sal_Int32
/*_nOrientation*/, sal_Int32 _nLeft,
}
void
-ScVbaShapes::setDefaultShapeProperties( uno::Reference< drawing::XShape >
xShape ) throw (uno::RuntimeException)
+ScVbaShapes::setDefaultShapeProperties( const uno::Reference< drawing::XShape
>& xShape ) throw (uno::RuntimeException)
{
uno::Reference< beans::XPropertySet > xPropertySet( xShape,
uno::UNO_QUERY_THROW );
xPropertySet->setPropertyValue( "FillStyle", uno::makeAny(
OUString("SOLID") ) );
@@ -420,7 +420,7 @@ ScVbaShapes::setDefaultShapeProperties( uno::Reference<
drawing::XShape > xShape
}
void
-ScVbaShapes::setShape_NameProperty( uno::Reference< css::drawing::XShape >
xShape, const OUString& sName )
+ScVbaShapes::setShape_NameProperty( const uno::Reference< css::drawing::XShape
>& xShape, const OUString& sName )
{
uno::Reference< beans::XPropertySet > xPropertySet( xShape,
uno::UNO_QUERY_THROW );
try
commit fb42d03b5a404ac73e24d90e094885c14c3b7584
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 14:49:04 2016 +0200
clang-tidy performance-unnecessary-value-param in unotools
Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5
diff --git a/include/unotools/ucbhelper.hxx b/include/unotools/ucbhelper.hxx
index e7cd434..6b31a6f 100644
--- a/include/unotools/ucbhelper.hxx
+++ b/include/unotools/ucbhelper.hxx
@@ -61,8 +61,8 @@ UNOTOOLS_DLLPUBLIC bool MakeFolder(
/// like mkdir -p
UNOTOOLS_DLLPUBLIC bool ensureFolder(
- css::uno::Reference< css::uno::XComponentContext > xCtx,
- css::uno::Reference< css::ucb::XCommandEnvironment > xEnv,
+ const css::uno::Reference< css::uno::XComponentContext >& xCtx,
+ const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
const OUString& rFolder, ucbhelper::Content & result) throw();
/// @return the value of the "Size" property of the given content, or zero if
diff --git a/include/unotools/ucbstreamhelper.hxx
b/include/unotools/ucbstreamhelper.hxx
index 2e8308b..904e132 100644
--- a/include/unotools/ucbstreamhelper.hxx
+++ b/include/unotools/ucbstreamhelper.hxx
@@ -54,13 +54,13 @@ namespace utl
public:
static SvStream* CreateStream( const OUString& rFileName,
StreamMode eOpenMode );
static SvStream* CreateStream( const OUString& rFileName,
StreamMode eOpenMode,
- css::uno::Reference <
css::task::XInteractionHandler > );
+ const css::uno::Reference <
css::task::XInteractionHandler >& );
static SvStream* CreateStream( const OUString& rFileName,
StreamMode eOpenMode,
bool bFileExists );
- static SvStream* CreateStream( css::uno::Reference <
css::io::XInputStream > xStream );
- static SvStream* CreateStream( css::uno::Reference <
css::io::XStream > xStream );
- static SvStream* CreateStream( css::uno::Reference <
css::io::XInputStream > xStream, bool bCloseStream );
- static SvStream* CreateStream( css::uno::Reference <
css::io::XStream > xStream, bool bCloseStream );
+ static SvStream* CreateStream( const css::uno::Reference <
css::io::XInputStream >& xStream );
+ static SvStream* CreateStream( const css::uno::Reference <
css::io::XStream >& xStream );
+ static SvStream* CreateStream( const css::uno::Reference <
css::io::XInputStream >& xStream, bool bCloseStream );
+ static SvStream* CreateStream( const css::uno::Reference <
css::io::XStream >& xStream, bool bCloseStream );
};
}
diff --git a/unotools/source/ucbhelper/ucbhelper.cxx
b/unotools/source/ucbhelper/ucbhelper.cxx
index 427cad2..acbc63f 100644
--- a/unotools/source/ucbhelper/ucbhelper.cxx
+++ b/unotools/source/ucbhelper/ucbhelper.cxx
@@ -449,8 +449,8 @@ bool utl::UCBContentHelper::EqualURLs(
}
bool utl::UCBContentHelper::ensureFolder(
- css::uno::Reference< css::uno::XComponentContext > xCtx,
- css::uno::Reference< css::ucb::XCommandEnvironment > xEnv,
+ const css::uno::Reference< css::uno::XComponentContext >& xCtx,
+ const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv,
const OUString& rFolder, ucbhelper::Content & result) throw()
{
try
diff --git a/unotools/source/ucbhelper/ucblockbytes.cxx
b/unotools/source/ucbhelper/ucblockbytes.cxx
index 71ad3ca..a73b87c 100644
--- a/unotools/source/ucbhelper/ucblockbytes.cxx
+++ b/unotools/source/ucbhelper/ucblockbytes.cxx
@@ -712,17 +712,17 @@ void SAL_CALL Moderator::onTerminated()
but with handled timeout;
*/
static bool UCBOpenContentSync_(
- UcbLockBytesRef xLockBytes,
- Reference < XContent > xContent,
+ const UcbLockBytesRef& xLockBytes,
+ const Reference < XContent >& xContent,
const Command& rArg,
- Reference < XInterface > xSink,
- Reference < XInteractionHandler > xInteract );
+ const Reference < XInterface >& xSink,
+ const Reference < XInteractionHandler >& xInteract );
static bool UCBOpenContentSync(
- UcbLockBytesRef xLockBytes,
+ const UcbLockBytesRef& xLockBytes,
Reference < XContent > xContent,
const Command& rArg,
- Reference < XInterface > xSink,
+ const Reference < XInterface >& xSink,
Reference < XInteractionHandler > xInteract )
{
// http protocol must be handled in a special way:
@@ -957,11 +957,11 @@ static bool UCBOpenContentSync(
Function for opening UCB contents synchronously
*/
static bool UCBOpenContentSync_(
- UcbLockBytesRef xLockBytes,
- Reference < XContent > xContent,
+ const UcbLockBytesRef& xLockBytes,
+ const Reference < XContent >& xContent,
const Command& rArg,
- Reference < XInterface > xSink,
- Reference < XInteractionHandler > xInteract )
+ const Reference < XInterface >& xSink,
+ const Reference < XInteractionHandler >& xInteract )
{
::ucbhelper::Content aContent(
xContent, new UcbTaskEnvironment( xInteract, nullptr ),
diff --git a/unotools/source/ucbhelper/ucbstreamhelper.cxx
b/unotools/source/ucbhelper/ucbstreamhelper.cxx
index 07421c5..ff11524 100644
--- a/unotools/source/ucbhelper/ucbstreamhelper.cxx
+++ b/unotools/source/ucbhelper/ucbstreamhelper.cxx
@@ -41,7 +41,7 @@ namespace utl
{
static SvStream* lcl_CreateStream( const OUString& rFileName, StreamMode
eOpenMode,
- Reference < XInteractionHandler >
xInteractionHandler,
+ const Reference < XInteractionHandler >&
xInteractionHandler,
UcbLockBytesHandler* pHandler, bool
bEnsureFileExists )
{
SvStream* pStream = nullptr;
@@ -144,7 +144,7 @@ SvStream* UcbStreamHelper::CreateStream( const OUString&
rFileName, StreamMode e
}
SvStream* UcbStreamHelper::CreateStream( const OUString& rFileName, StreamMode
eOpenMode,
- Reference < XInteractionHandler >
xInteractionHandler )
+ const Reference < XInteractionHandler
>& xInteractionHandler )
{
return lcl_CreateStream( rFileName, eOpenMode, xInteractionHandler,
nullptr, true /* bEnsureFileExists */ );
}
@@ -155,7 +155,7 @@ SvStream* UcbStreamHelper::CreateStream( const OUString&
rFileName, StreamMode e
return lcl_CreateStream( rFileName, eOpenMode, Reference <
XInteractionHandler >(), nullptr, !bFileExists );
}
-SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XInputStream >&
xStream )
{
SvStream* pStream = nullptr;
UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream );
@@ -169,7 +169,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference <
XInputStream > xStream )
return pStream;
}
-SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XStream >& xStream )
{
SvStream* pStream = nullptr;
if ( xStream->getOutputStream().is() )
@@ -188,7 +188,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference <
XStream > xStream )
return pStream;
}
-SvStream* UcbStreamHelper::CreateStream( Reference < XInputStream > xStream,
bool bCloseStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XInputStream >&
xStream, bool bCloseStream )
{
SvStream* pStream = nullptr;
UcbLockBytesRef xLockBytes = UcbLockBytes::CreateInputLockBytes( xStream );
@@ -205,7 +205,7 @@ SvStream* UcbStreamHelper::CreateStream( Reference <
XInputStream > xStream, boo
return pStream;
};
-SvStream* UcbStreamHelper::CreateStream( Reference < XStream > xStream, bool
bCloseStream )
+SvStream* UcbStreamHelper::CreateStream( const Reference < XStream >& xStream,
bool bCloseStream )
{
SvStream* pStream = nullptr;
if ( xStream->getOutputStream().is() )
commit b76c2ea81df92e1a863ce04e02005f58ab5ea5f9
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 14:30:16 2016 +0200
clang-tidy performance-unnecessary-value-param in ucbhelper
Change-Id: I595485e8804d6f2e4e0f9bc8a78c8cb132411f7d
diff --git a/include/ucbhelper/content.hxx b/include/ucbhelper/content.hxx
index e31a95d..d407c6c 100644
--- a/include/ucbhelper/content.hxx
+++ b/include/ucbhelper/content.hxx
@@ -429,7 +429,7 @@ public:
css::uno::Reference< css::sdbc::XResultSet >
createSortedCursor( const css::uno::Sequence< OUString >& rPropertyNames,
const css::uno::Sequence<
css::ucb::NumberedSortingInfo >& rSortInfo,
- css::uno::Reference< css::ucb::XAnyCompareFactory >
rAnyCompareFactory,
+ const css::uno::Reference<
css::ucb::XAnyCompareFactory >& rAnyCompareFactory,
ResultSetInclude eMode = INCLUDE_FOLDERS_AND_DOCUMENTS
)
throw( css::ucb::CommandAbortedException,
css::uno::RuntimeException,
diff --git a/ucbhelper/source/client/content.cxx
b/ucbhelper/source/client/content.cxx
index 87ec398..dd03977 100644
--- a/ucbhelper/source/client/content.cxx
+++ b/ucbhelper/source/client/content.cxx
@@ -651,7 +651,7 @@ Reference< XDynamicResultSet > Content::createDynamicCursor(
Reference< XResultSet > Content::createSortedCursor(
const Sequence< OUString >& rPropertyNames,
const Sequence< NumberedSortingInfo >& rSortInfo,
- Reference< XAnyCompareFactory > rAnyCompareFactory,
+ const Reference< XAnyCompareFactory >&
rAnyCompareFactory,
ResultSetInclude eMode )
throw( CommandAbortedException, RuntimeException, Exception )
{
commit 50d02ad99f73aafbf25350c7275920af53d20ae1
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 14:13:06 2016 +0200
clang-tidy performance-unnecessary-value-param in tools
Change-Id: I57b2fd191dfd937f3327f148b27767b364acf667
diff --git a/include/tools/b3dtrans.hxx b/include/tools/b3dtrans.hxx
index bf0f961..a273dad 100644
--- a/include/tools/b3dtrans.hxx
+++ b/include/tools/b3dtrans.hxx
@@ -154,7 +154,7 @@ public:
double fNear = 0.0, double fFar = 1.0);
static void Orientation(
basegfx::B3DHomMatrix& rTarget,
- basegfx::B3DPoint aVRP = basegfx::B3DPoint(0.0,0.0,1.0),
+ const basegfx::B3DPoint& aVRP = basegfx::B3DPoint(0.0,0.0,1.0),
basegfx::B3DVector aVPN = basegfx::B3DVector(0.0,0.0,1.0),
basegfx::B3DVector aVUP = basegfx::B3DVector(0.0,1.0,0.0));
diff --git a/tools/source/generic/b3dtrans.cxx
b/tools/source/generic/b3dtrans.cxx
index 34b205a..f4a0920 100644
--- a/tools/source/generic/b3dtrans.cxx
+++ b/tools/source/generic/b3dtrans.cxx
@@ -33,7 +33,7 @@ B3dTransformationSet::~B3dTransformationSet()
{
}
-void B3dTransformationSet::Orientation(basegfx::B3DHomMatrix& rTarget,
basegfx::B3DPoint aVRP, basegfx::B3DVector aVPN, basegfx::B3DVector aVUP)
+void B3dTransformationSet::Orientation(basegfx::B3DHomMatrix& rTarget, const
basegfx::B3DPoint& aVRP, basegfx::B3DVector aVPN, basegfx::B3DVector aVUP)
{
rTarget.translate( -aVRP.getX(), -aVRP.getY(), -aVRP.getZ());
aVUP.normalize();
commit 28c96a09105f87d76441234a6e77f2ac1e1473df
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 14:09:58 2016 +0200
clang-tidy performance-unnecessary-value-param in toolkit
Change-Id: Ic08723ef15f2bc31031e3887b9916ecc7e2205da
diff --git a/include/toolkit/controls/roadmapcontrol.hxx
b/include/toolkit/controls/roadmapcontrol.hxx
index f948dc2..6b97158 100644
--- a/include/toolkit/controls/roadmapcontrol.hxx
+++ b/include/toolkit/controls/roadmapcontrol.hxx
@@ -79,10 +79,10 @@ namespace toolkit
ContainerListenerMultiplexer maContainerListeners;
RoadmapItemHolderList maRoadmapItems;
- void MakeRMItemValidation( sal_Int32
Index, css::uno::Reference< XInterface > xRoadmapItem );
- css::container::ContainerEvent GetContainerEvent(sal_Int32 Index,
css::uno::Reference< XInterface > );
- void SetRMItemDefaultProperties( const
sal_Int32 Index, css::uno::Reference< XInterface > );
- static sal_Int16 GetCurrentItemID(
css::uno::Reference< css::beans::XPropertySet > xPropertySet );
+ void MakeRMItemValidation( sal_Int32
Index, const css::uno::Reference< XInterface >& xRoadmapItem );
+ css::container::ContainerEvent GetContainerEvent(sal_Int32 Index,
const css::uno::Reference< XInterface >& );
+ void SetRMItemDefaultProperties( const
sal_Int32 Index, const css::uno::Reference< XInterface >& );
+ static sal_Int16 GetCurrentItemID( const
css::uno::Reference< css::beans::XPropertySet >& xPropertySet );
sal_Int32 GetUniqueID();
diff --git a/toolkit/source/controls/roadmapcontrol.cxx
b/toolkit/source/controls/roadmapcontrol.cxx
index 83476bd..6febbff 100644
--- a/toolkit/source/controls/roadmapcontrol.cxx
+++ b/toolkit/source/controls/roadmapcontrol.cxx
@@ -192,7 +192,7 @@ static void lcl_throwIndexOutOfBoundsException( )
}
- void UnoControlRoadmapModel::MakeRMItemValidation( sal_Int32 Index,
Reference< XInterface > xRoadmapItem )
+ void UnoControlRoadmapModel::MakeRMItemValidation( sal_Int32 Index, const
Reference< XInterface >& xRoadmapItem )
{
if ((Index > (sal_Int32)maRoadmapItems.size()) || ( Index < 0 ) )
lcl_throwIndexOutOfBoundsException( );
@@ -205,7 +205,7 @@ static void lcl_throwIndexOutOfBoundsException( )
}
- void UnoControlRoadmapModel::SetRMItemDefaultProperties( const sal_Int32 ,
Reference< XInterface > xRoadmapItem)
+ void UnoControlRoadmapModel::SetRMItemDefaultProperties( const sal_Int32 ,
const Reference< XInterface >& xRoadmapItem)
{
Any aAny;
Reference< XPropertySet > xPropertySet( xRoadmapItem, UNO_QUERY );
@@ -255,7 +255,7 @@ static void lcl_throwIndexOutOfBoundsException( )
}
- ContainerEvent UnoControlRoadmapModel::GetContainerEvent(sal_Int32 Index,
Reference< XInterface > xRoadmapItem)
+ ContainerEvent UnoControlRoadmapModel::GetContainerEvent(sal_Int32 Index,
const Reference< XInterface >& xRoadmapItem)
{
ContainerEvent aEvent;
aEvent.Source = *this;
@@ -265,7 +265,7 @@ static void lcl_throwIndexOutOfBoundsException( )
}
- sal_Int16 UnoControlRoadmapModel::GetCurrentItemID( Reference<
XPropertySet > xPropertySet )
+ sal_Int16 UnoControlRoadmapModel::GetCurrentItemID( const Reference<
XPropertySet >& xPropertySet )
{
Any aAny = xPropertySet->getPropertyValue( GetPropertyName(
BASEPROPERTY_CURRENTITEMID ) );
sal_Int16 n_CurrentItemID = 0;
diff --git a/toolkit/source/controls/unocontrolcontainer.cxx
b/toolkit/source/controls/unocontrolcontainer.cxx
index aec738f..5bfd89a 100644
--- a/toolkit/source/controls/unocontrolcontainer.cxx
+++ b/toolkit/source/controls/unocontrolcontainer.cxx
@@ -308,7 +308,7 @@ OUString UnoControlHolderList::impl_getFreeName_throw()
void implUpdateVisibility
(
sal_Int32 nDialogStep,
- uno::Reference< awt::XControlContainer > xControlContainer
+ const uno::Reference< awt::XControlContainer >& xControlContainer
)
{
uno::Sequence< uno::Reference< awt::XControl > >
commit e9cded40c8727cec7d0d29219c14ef0d0eef5195
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 13:51:50 2016 +0200
clang-tidy performance-unnecessary-value-param in svx
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
diff --git a/include/svx/PaletteManager.hxx b/include/svx/PaletteManager.hxx
index 561dcac..2d4c528 100644
--- a/include/svx/PaletteManager.hxx
+++ b/include/svx/PaletteManager.hxx
@@ -72,7 +72,7 @@ public:
void SetBtnUpdater(svx::ToolboxButtonColorUpdater* pBtnUpdater);
void PopupColorPicker(const OUString& aCommand);
- void SetColorSelectFunction(std::function<void(const OUString&,
const Color&)> aColorSelectFunction);
+ void SetColorSelectFunction(const std::function<void(const
OUString&, const Color&)>& aColorSelectFunction);
static void DispatchColorCommand(const OUString& aCommand, const Color&
rColor);
};
diff --git a/include/svx/SmartTagItem.hxx b/include/svx/SmartTagItem.hxx
index 63292ff..0cc025d 100644
--- a/include/svx/SmartTagItem.hxx
+++ b/include/svx/SmartTagItem.hxx
@@ -57,9 +57,9 @@ public:
const css::uno::Sequence < css::uno::Sequence<
css::uno::Reference< css::smarttags::XSmartTagAction > > >&
rActionComponentsSequence,
const css::uno::Sequence < css::uno::Sequence< sal_Int32
> >& rActionIndicesSequence,
const css::uno::Sequence< css::uno::Reference<
css::container::XStringKeyMap > >& rStringKeyMaps,
- const css::uno::Reference<css::text::XTextRange> rRange,
- const css::uno::Reference<css::frame::XController>
rController,
- const css::lang::Locale rLocale,
+ const css::uno::Reference<css::text::XTextRange>& rRange,
+ const css::uno::Reference<css::frame::XController>&
rController,
+ const css::lang::Locale& rLocale,
const OUString& rApplicationName,
const OUString& rRangeText );
diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index a6d5aaf..9525e0c 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -559,14 +559,14 @@ public:
void SetDisableTextEditUsesCommonUndoManager(bool bNew) {
mbDisableTextEditUsesCommonUndoManager = bNew; }
css::uno::Reference< css::uno::XInterface > getUnoModel();
- void setUnoModel( css::uno::Reference< css::uno::XInterface > xModel );
+ void setUnoModel( const css::uno::Reference< css::uno::XInterface >&
xModel );
// these functions are used by the api to disable repaints during a
// set of api calls.
bool isLocked() const { return mbModelLocked; }
void setLock( bool bLock );
- void SetForbiddenCharsTable(
rtl::Reference<SvxForbiddenCharactersTable> xForbiddenChars );
+ void SetForbiddenCharsTable( const
rtl::Reference<SvxForbiddenCharactersTable>& xForbiddenChars );
rtl::Reference<SvxForbiddenCharactersTable> GetForbiddenCharsTable() const
{ return mpForbiddenCharactersTable;}
void SetCharCompressType( sal_uInt16 nType );
diff --git a/include/svx/tbcontrl.hxx b/include/svx/tbcontrl.hxx
index 0aaa94f..34e5563 100644
--- a/include/svx/tbcontrl.hxx
+++ b/include/svx/tbcontrl.hxx
@@ -251,7 +251,7 @@ public:
virtual sal_Bool SAL_CALL opensSubToolbar() throw
(css::uno::RuntimeException, std::exception) override;
virtual void SAL_CALL updateImage() throw (css::uno::RuntimeException,
std::exception) override;
- void setColorSelectFunction(ColorSelectFunction aColorSelectFunction);
+ void setColorSelectFunction(const ColorSelectFunction&
aColorSelectFunction);
};
class SVX_DLLPUBLIC SvxFrameToolBoxControl : public SfxToolBoxControl
diff --git a/include/svx/unoapi.hxx b/include/svx/unoapi.hxx
index 0223508..5d4a40d 100644
--- a/include/svx/unoapi.hxx
+++ b/include/svx/unoapi.hxx
@@ -46,13 +46,13 @@ SVX_DLLPUBLIC SvxShape*
CreateSvxShapeByTypeAndInventor(sal_uInt16 nType, sal_uI
SVX_DLLPUBLIC css::uno::Reference< css::drawing::XShape >
GetXShapeForSdrObject( SdrObject* pObj ) throw ();
/** Returns the SdrObject from the given StarOffice API wrapper */
-SVX_DLLPUBLIC SdrObject* GetSdrObjectFromXShape( css::uno::Reference<
css::drawing::XShape > xShape ) throw() ;
+SVX_DLLPUBLIC SdrObject* GetSdrObjectFromXShape( const css::uno::Reference<
css::drawing::XShape >& xShape ) throw() ;
/** Returns a StarOffice API wrapper for the given SdrPage */
SVX_DLLPUBLIC css::uno::Reference< css::drawing::XDrawPage >
GetXDrawPageForSdrPage( SdrPage* pPage ) throw ();
/** Returns the SdrPage from the given StarOffice API wrapper */
-SVX_DLLPUBLIC SdrPage* GetSdrPageFromXDrawPage( css::uno::Reference<
css::drawing::XDrawPage > xDrawPage ) throw() ;
+SVX_DLLPUBLIC SdrPage* GetSdrPageFromXDrawPage( const css::uno::Reference<
css::drawing::XDrawPage >& xDrawPage ) throw() ;
/**
* Maps the vcl MapUnit enum to a API constant MeasureUnit.
diff --git a/svx/source/dialog/rubydialog.cxx b/svx/source/dialog/rubydialog.cxx
index ae9c7a9..6c08873 100644
--- a/svx/source/dialog/rubydialog.cxx
+++ b/svx/source/dialog/rubydialog.cxx
@@ -95,7 +95,7 @@ public:
SvxRubyData_Impl();
virtual ~SvxRubyData_Impl();
- void SetController(Reference<XController> xCtrl);
+ void SetController(const Reference<XController>& xCtrl);
Reference<XModel> GetModel()
{
if (!xController.is())
@@ -143,7 +143,7 @@ SvxRubyData_Impl::~SvxRubyData_Impl()
{
}
-void SvxRubyData_Impl::SetController(Reference<XController> xCtrl)
+void SvxRubyData_Impl::SetController(const Reference<XController>& xCtrl)
{
if (xCtrl.get() != xController.get())
{
diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index 8f9861e..d2577e6 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -297,7 +297,7 @@ DbGridColumn::~DbGridColumn()
}
-void DbGridColumn::setModel(css::uno::Reference< css::beans::XPropertySet >
_xModel)
+void DbGridColumn::setModel(const css::uno::Reference<
css::beans::XPropertySet >& _xModel)
{
if ( m_pCell )
impl_toggleScriptManager_nothrow( false );
diff --git a/svx/source/form/fmpgeimp.cxx b/svx/source/form/fmpgeimp.cxx
index d775aca..895f729 100644
--- a/svx/source/form/fmpgeimp.cxx
+++ b/svx/source/form/fmpgeimp.cxx
@@ -355,7 +355,7 @@ bool FmFormPageImpl::validateCurForm()
}
-void FmFormPageImpl::setCurForm(Reference< css::form::XForm > xForm)
+void FmFormPageImpl::setCurForm(const Reference< css::form::XForm >& xForm)
{
xCurrentForm = xForm;
}
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index 6fb1a9b..8c2daea 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -680,7 +680,7 @@ namespace
public:
- explicit find_active_databaseform( const Reference< XFormController >
_xActiveController )
+ explicit find_active_databaseform( const Reference< XFormController >&
_xActiveController )
: xActiveController(_xActiveController )
{}
diff --git a/svx/source/inc/fmpgeimp.hxx b/svx/source/inc/fmpgeimp.hxx
index ae743c0..17cf77b 100644
--- a/svx/source/inc/fmpgeimp.hxx
+++ b/svx/source/inc/fmpgeimp.hxx
@@ -65,7 +65,7 @@ public:
void initFrom( FmFormPageImpl& i_foreignImpl );
// nur wichtig fuer den DesignMode
- void setCurForm(css::uno::Reference< css::form::XForm> xForm);
+ void setCurForm(const css::uno::Reference< css::form::XForm>& xForm);
css::uno::Reference< css::form::XForm> getDefaultForm();
/** finds a place in the form component hierarchy where to insert the
given component
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 9b0efa8..786c490 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -120,7 +120,7 @@ public:
~DbGridColumn();
const css::uno::Reference< css::beans::XPropertySet >& getModel() const {
return m_xModel; }
- void setModel(css::uno::Reference< css::beans::XPropertySet > _xModel);
+ void setModel(const css::uno::Reference< css::beans::XPropertySet >&
_xModel);
sal_uInt16 GetId() const {return m_nId;}
diff --git a/svx/source/items/SmartTagItem.cxx
b/svx/source/items/SmartTagItem.cxx
index c81eacc..e80c6f8 100644
--- a/svx/source/items/SmartTagItem.cxx
+++ b/svx/source/items/SmartTagItem.cxx
@@ -32,9 +32,9 @@ SvxSmartTagItem::SvxSmartTagItem( const sal_uInt16 nId,
const css::uno::Sequence <
css::uno::Sequence< css::uno::Reference< css::smarttags::XSmartTagAction > > >&
rActionComponentsSequence,
const css::uno::Sequence <
css::uno::Sequence< sal_Int32 > >& rActionIndicesSequence,
const css::uno::Sequence<
css::uno::Reference< css::container::XStringKeyMap > >& rStringKeyMaps,
- const
css::uno::Reference<css::text::XTextRange> rRange,
- const
css::uno::Reference<css::frame::XController> rController,
- const css::lang::Locale rLocale,
+ const
css::uno::Reference<css::text::XTextRange>& rRange,
+ const
css::uno::Reference<css::frame::XController>& rController,
+ const css::lang::Locale& rLocale,
const OUString& rApplicationName,
const OUString& rRangeText ) :
SfxPoolItem( nId ),
diff --git a/svx/source/sidebar/line/LineWidthValueSet.cxx
b/svx/source/sidebar/line/LineWidthValueSet.cxx
index d4172d4..0d7503f 100644
--- a/svx/source/sidebar/line/LineWidthValueSet.cxx
+++ b/svx/source/sidebar/line/LineWidthValueSet.cxx
@@ -74,7 +74,7 @@ void LineWidthValueSet::SetSelItem(sal_uInt16 nSel)
}
}
-void LineWidthValueSet::SetImage(Image img)
+void LineWidthValueSet::SetImage(const Image& img)
{
imgCus = img;
}
diff --git a/svx/source/sidebar/line/LineWidthValueSet.hxx
b/svx/source/sidebar/line/LineWidthValueSet.hxx
index 6fb9ae5..ca7e104 100644
--- a/svx/source/sidebar/line/LineWidthValueSet.hxx
+++ b/svx/source/sidebar/line/LineWidthValueSet.hxx
@@ -35,7 +35,7 @@ public:
void SetUnit(OUString* str);
void SetSelItem(sal_uInt16 nSel);
sal_uInt16 GetSelItem() { return nSelItem;}
- void SetImage(Image img);
+ void SetImage(const Image& img);
void SetCusEnable(bool bEnable);
virtual void UserDraw( const UserDrawEvent& rUDEvt ) override;
diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx
index b50f5e3..2511e5d 100644
--- a/svx/source/svdraw/svdmodel.cxx
+++ b/svx/source/svdraw/svdmodel.cxx
@@ -1820,7 +1820,7 @@ uno::Reference< uno::XInterface > SdrModel::getUnoModel()
return mxUnoModel;
}
-void SdrModel::setUnoModel( css::uno::Reference< css::uno::XInterface > xModel
)
+void SdrModel::setUnoModel( const css::uno::Reference< css::uno::XInterface >&
xModel )
{
mxUnoModel = xModel;
}
@@ -1903,7 +1903,7 @@ void SdrModel::MigrateItemSet( const SfxItemSet*
pSourceSet, SfxItemSet* pDestSe
}
-void SdrModel::SetForbiddenCharsTable(
rtl::Reference<SvxForbiddenCharactersTable> xForbiddenChars )
+void SdrModel::SetForbiddenCharsTable( const
rtl::Reference<SvxForbiddenCharactersTable>& xForbiddenChars )
{
if( mpForbiddenCharactersTable )
mpForbiddenCharactersTable->release();
diff --git a/svx/source/table/accessibletableshape.cxx
b/svx/source/table/accessibletableshape.cxx
index 97e53b67..40798bb 100644
--- a/svx/source/table/accessibletableshape.cxx
+++ b/svx/source/table/accessibletableshape.cxx
@@ -84,7 +84,7 @@ public:
Reference< XAccessible> mxAccessible;
sal_Int32 mRowCount, mColCount;
//get the cached AccessibleCell from XCell
- Reference< AccessibleCell > getAccessibleCell (Reference< XCell > xCell);
+ Reference< AccessibleCell > getAccessibleCell (const Reference< XCell >&
xCell);
Reference< AccessibleCell > getAccessibleCell (sal_Int32 nRow, sal_Int32
nColumn) throw (IndexOutOfBoundsException, RuntimeException);
};
@@ -136,7 +136,7 @@ void AccessibleTableShapeImpl::dispose()
//get the cached AccessibleCell from XCell
-Reference< AccessibleCell > AccessibleTableShapeImpl::getAccessibleCell
(Reference< XCell > xCell)
+Reference< AccessibleCell > AccessibleTableShapeImpl::getAccessibleCell (const
Reference< XCell >& xCell)
{
AccessibleCellMap::iterator iter( maChildMap.find( xCell ) );
diff --git a/svx/source/tbxctrls/PaletteManager.cxx
b/svx/source/tbxctrls/PaletteManager.cxx
index 430623e..535134f 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -219,7 +219,7 @@ void
PaletteManager::SetBtnUpdater(svx::ToolboxButtonColorUpdater* pBtnUpdater)
mpBtnUpdater = pBtnUpdater;
}
-void PaletteManager::SetColorSelectFunction(std::function<void(const
OUString&, const Color&)> aColorSelectFunction)
+void PaletteManager::SetColorSelectFunction(const std::function<void(const
OUString&, const Color&)>& aColorSelectFunction)
{
maColorSelectFunction = aColorSelectFunction;
}
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index dc70581..38a2f1f 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -2094,7 +2094,7 @@ struct SvxStyleToolBoxControl::Impl
}
- void InitializeStyles(Reference < frame::XModel > xModel)
+ void InitializeStyles(const Reference < frame::XModel >& xModel)
{
//now convert the default style names to the localized names
try
@@ -2693,7 +2693,7 @@ SvxColorToolBoxControl::~SvxColorToolBoxControl()
{
}
-void SvxColorToolBoxControl::setColorSelectFunction(ColorSelectFunction
aColorSelectFunction)
+void SvxColorToolBoxControl::setColorSelectFunction(const ColorSelectFunction&
aColorSelectFunction)
{
maColorSelectFunction = aColorSelectFunction;
mPaletteManager.SetColorSelectFunction(aColorSelectFunction);
diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx
index 558aad2..c662014 100644
--- a/svx/source/unodraw/unopage.cxx
+++ b/svx/source/unodraw/unopage.cxx
@@ -911,7 +911,7 @@ uno::Reference< drawing::XDrawPage >
GetXDrawPageForSdrPage( SdrPage* pPage ) th
}
/** returns the SdrObject from the given StarOffice API wrapper */
-SdrPage* GetSdrPageFromXDrawPage( uno::Reference< drawing::XDrawPage >
xDrawPage ) throw()
+SdrPage* GetSdrPageFromXDrawPage( const uno::Reference< drawing::XDrawPage >&
xDrawPage ) throw()
{
if(xDrawPage.is())
{
diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index 386eeda..bb32dd0 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -594,7 +594,7 @@ void
SvxShape::ForceMetricTo100th_mm(basegfx::B2DPolyPolygon& rPolyPolygon) cons
void SvxItemPropertySet_ObtainSettingsFromPropertySet(const
SvxItemPropertySet& rPropSet,
- SfxItemSet& rSet, uno::Reference< beans::XPropertySet > xSet, const
SfxItemPropertyMap* pMap )
+ SfxItemSet& rSet, const uno::Reference< beans::XPropertySet >& xSet, const
SfxItemPropertyMap* pMap )
{
if(rPropSet.AreThereOwnUsrAnys())
{
@@ -4135,7 +4135,7 @@ uno::Reference< drawing::XShape > GetXShapeForSdrObject(
SdrObject* pObj ) throw
}
/** returns the SdrObject from the given StarOffice API wrapper */
-SdrObject* GetSdrObjectFromXShape( uno::Reference< drawing::XShape > xShape )
throw()
+SdrObject* GetSdrObjectFromXShape( const uno::Reference< drawing::XShape >&
xShape ) throw()
{
SvxShape* pShape = SvxShape::getImplementation( xShape );
return pShape ? pShape->GetSdrObject() : nullptr;
diff --git a/svx/source/xml/xmlxtexp.cxx b/svx/source/xml/xmlxtexp.cxx
index 1903527..5c4fbc6 100644
--- a/svx/source/xml/xmlxtexp.cxx
+++ b/svx/source/xml/xmlxtexp.cxx
@@ -188,7 +188,7 @@ static void initializeStreamMetadata( const uno::Reference<
uno::XInterface > &x
static void createStorageStream( uno::Reference < io::XOutputStream > *xOut,
SvXMLGraphicHelper
**ppGraphicHelper,
- uno::Reference < embed::XStorage >
xSubStorage )
+ const uno::Reference < embed::XStorage >&
xSubStorage )
{
uno::Reference < io::XStream > xStream;
xStream = xSubStorage->openStreamElement(
diff --git a/svx/source/xml/xmlxtimp.cxx b/svx/source/xml/xmlxtimp.cxx
index 0183888..0974603 100644
--- a/svx/source/xml/xmlxtimp.cxx
+++ b/svx/source/xml/xmlxtimp.cxx
@@ -348,7 +348,7 @@ SvxXMLXTableImport::~SvxXMLXTableImport() throw ()
static void openStorageStream( xml::sax::InputSource *pParserInput,
SvXMLGraphicHelper **ppGraphicHelper,
- uno::Reference < embed::XStorage > xStorage )
+ const uno::Reference < embed::XStorage >&
xStorage )
{
uno::Reference < io::XStream > xIStm;
xIStm.set( xStorage->openStreamElement( "Content.xml",
embed::ElementModes::READ ), uno::UNO_QUERY_THROW );
commit c399630f9cd94bc570659c3bdfd6526e3532c46f
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 13:26:19 2016 +0200
clang-tidy performance-unnecessary-value-param in svtools
Change-Id: I6360a780aac9a387fed3a1c9a086196dbba0b089
diff --git a/include/svtools/headbar.hxx b/include/svtools/headbar.hxx
index 8ebef5e..b5373f7 100644
--- a/include/svtools/headbar.hxx
+++ b/include/svtools/headbar.hxx
@@ -335,7 +335,7 @@ public:
/** Creates and returns the accessible object of the header bar. */
virtual css::uno::Reference< css::accessibility::XAccessible >
CreateAccessible() override;
- void SetAccessible( css::uno::Reference< css::accessibility::XAccessible >
);
+ void SetAccessible( const css::uno::Reference<
css::accessibility::XAccessible >& );
virtual css::uno::Reference< css::awt::XWindowPeer >
GetComponentInterface( bool bCreate ) override;
};
diff --git a/include/svtools/unoimap.hxx b/include/svtools/unoimap.hxx
index 46613ad..98c43765 100644
--- a/include/svtools/unoimap.hxx
+++ b/include/svtools/unoimap.hxx
@@ -32,7 +32,7 @@ SVT_DLLPUBLIC css::uno::Reference< css::uno::XInterface >
SvUnoImageMapPolygonOb
SVT_DLLPUBLIC css::uno::Reference< css::uno::XInterface >
SvUnoImageMap_createInstance( const SvEventDescription* pSupportedMacroItems );
SVT_DLLPUBLIC css::uno::Reference< css::uno::XInterface >
SvUnoImageMap_createInstance( const ImageMap& rMap, const SvEventDescription*
pSupportedMacroItems );
-SVT_DLLPUBLIC bool SvUnoImageMap_fillImageMap( css::uno::Reference<
css::uno::XInterface > xImageMap, ImageMap& rMap );
+SVT_DLLPUBLIC bool SvUnoImageMap_fillImageMap( const css::uno::Reference<
css::uno::XInterface >& xImageMap, ImageMap& rMap );
#endif
diff --git a/svtools/inc/table/tablecontrol.hxx
b/svtools/inc/table/tablecontrol.hxx
index b0725f5..9ab11b1 100644
--- a/svtools/inc/table/tablecontrol.hxx
+++ b/svtools/inc/table/tablecontrol.hxx
@@ -67,7 +67,7 @@ namespace svt { namespace table
virtual void dispose() override;
/// sets a new table model
- void SetModel( PTableModel _pModel );
+ void SetModel( const PTableModel& _pModel );
/// retrieves the current table model
PTableModel GetModel() const;
diff --git a/svtools/source/control/headbar.cxx
b/svtools/source/control/headbar.cxx
index d61e4c4..5e31f37 100644
--- a/svtools/source/control/headbar.cxx
+++ b/svtools/source/control/headbar.cxx
@@ -1389,7 +1389,7 @@ css::uno::Reference< css::accessibility::XAccessible >
HeaderBar::CreateAccessib
return mxAccessible;
}
-void HeaderBar::SetAccessible( css::uno::Reference<
css::accessibility::XAccessible > _xAccessible )
+void HeaderBar::SetAccessible( const css::uno::Reference<
css::accessibility::XAccessible >& _xAccessible )
{
mxAccessible = _xAccessible;
}
diff --git a/svtools/source/misc/dialogcontrolling.cxx
b/svtools/source/misc/dialogcontrolling.cxx
index 73a286c..b630caa 100644
--- a/svtools/source/misc/dialogcontrolling.cxx
+++ b/svtools/source/misc/dialogcontrolling.cxx
@@ -53,7 +53,7 @@ namespace svt
PWindowEventFilter pEventFilter;
PWindowOperator pOperator;
- DialogController_Data( vcl::Window& _xInstigator, const
PWindowEventFilter _pEventFilter, const PWindowOperator _pOperator )
+ DialogController_Data( vcl::Window& _xInstigator, const
PWindowEventFilter& _pEventFilter, const PWindowOperator& _pOperator )
:xInstigator( &_xInstigator )
,pEventFilter( _pEventFilter )
,pOperator( _pOperator )
diff --git a/svtools/source/table/tablecontrol.cxx
b/svtools/source/table/tablecontrol.cxx
index b46e0ad..9689d9ec 100644
--- a/svtools/source/table/tablecontrol.cxx
+++ b/svtools/source/table/tablecontrol.cxx
@@ -163,7 +163,7 @@ namespace svt { namespace table
}
- void TableControl::SetModel( PTableModel _pModel )
+ void TableControl::SetModel( const PTableModel& _pModel )
{
m_pImpl->setModel( _pModel );
}
diff --git a/svtools/source/table/tablecontrol_impl.cxx
b/svtools/source/table/tablecontrol_impl.cxx
index b023d90..46049a4 100644
--- a/svtools/source/table/tablecontrol_impl.cxx
+++ b/svtools/source/table/tablecontrol_impl.cxx
@@ -263,7 +263,7 @@ namespace svt { namespace table
DELETEZ( m_pSelEngine );
}
- void TableControl_Impl::setModel( PTableModel _pModel )
+ void TableControl_Impl::setModel( const PTableModel& _pModel )
{
SuppressCursor aHideCursor( *this );
diff --git a/svtools/source/table/tablecontrol_impl.hxx
b/svtools/source/table/tablecontrol_impl.hxx
index e2153d9..28ddc6b 100644
--- a/svtools/source/table/tablecontrol_impl.hxx
+++ b/svtools/source/table/tablecontrol_impl.hxx
@@ -134,7 +134,7 @@ namespace svt { namespace table
IAccessibleTableControl* m_pAccessibleTable;
public:
- void setModel( PTableModel _pModel );
+ void setModel( const PTableModel& _pModel );
inline const PTableInputHandler& getInputHandler() const { return
m_pInputHandler; }
diff --git a/svtools/source/uno/unoimap.cxx b/svtools/source/uno/unoimap.cxx
index d7fef22..8dee26a 100644
--- a/svtools/source/uno/unoimap.cxx
+++ b/svtools/source/uno/unoimap.cxx
@@ -760,7 +760,7 @@ Reference< XInterface > SvUnoImageMap_createInstance( const
ImageMap& rMap, cons
return static_cast<XWeak*>(new SvUnoImageMap( rMap, pSupportedMacroItems
));
}
-bool SvUnoImageMap_fillImageMap( Reference< XInterface > xImageMap, ImageMap&
rMap )
+bool SvUnoImageMap_fillImageMap( const Reference< XInterface >& xImageMap,
ImageMap& rMap )
{
SvUnoImageMap* pUnoImageMap = SvUnoImageMap::getImplementation( xImageMap
);
if( nullptr == pUnoImageMap )
commit 76bff82cc637c10c8dbbbb7148e07555cf8e7ff4
Author: Noel Grandin <n...@peralex.com>
Date: Mon Apr 11 13:10:00 2016 +0200
clang-tidy performance-unnecessary-value-param in sax
Change-Id: I46aad7b0a96210e5f3f278c3f6f3a945825b7cae
diff --git a/include/sax/fshelper.hxx b/include/sax/fshelper.hxx
index e1046b1..4c79a36 100644
--- a/include/sax/fshelper.hxx
+++ b/include/sax/fshelper.hxx
@@ -114,11 +114,11 @@ public:
inline void endElementNS(sal_Int32 namespaceTokenId, sal_Int32
elementTokenId)
{ endElement( FSNS( namespaceTokenId, elementTokenId ) ); }
- void singleElement(sal_Int32 elementTokenId, XFastAttributeListRef
xAttrList);
+ void singleElement(sal_Int32 elementTokenId, const XFastAttributeListRef&
xAttrList);
inline void singleElementNS(sal_Int32 namespaceTokenId, sal_Int32
elementTokenId, XFastAttributeListRef xAttrList)
{ singleElement(FSNS( namespaceTokenId, elementTokenId), xAttrList); }
- void startElement(sal_Int32 elementTokenId, XFastAttributeListRef
xAttrList);
+ void startElement(sal_Int32 elementTokenId, const XFastAttributeListRef&
xAttrList);
inline void startElementNS(sal_Int32 namespaceTokenId, sal_Int32
elementTokenId, XFastAttributeListRef xAttrList)
{ startElement( FSNS( namespaceTokenId, elementTokenId ), xAttrList );
}
diff --git a/sax/source/tools/fshelper.cxx b/sax/source/tools/fshelper.cxx
index e2150d4..9456743 100644
--- a/sax/source/tools/fshelper.cxx
+++ b/sax/source/tools/fshelper.cxx
@@ -85,14 +85,14 @@ void FastSerializerHelper::endElement(sal_Int32
elementTokenId)
mpSerializer->endFastElement(elementTokenId);
}
-void FastSerializerHelper::startElement(sal_Int32 elementTokenId,
XFastAttributeListRef xAttrList)
+void FastSerializerHelper::startElement(sal_Int32 elementTokenId, const
XFastAttributeListRef& xAttrList)
{
FastAttributeList* pAttrList = dynamic_cast< FastAttributeList*
>(xAttrList.get());
assert(pAttrList);
mpSerializer->startFastElement(elementTokenId, pAttrList);
}
-void FastSerializerHelper::singleElement(sal_Int32 elementTokenId,
XFastAttributeListRef xAttrList)
+void FastSerializerHelper::singleElement(sal_Int32 elementTokenId, const
XFastAttributeListRef& xAttrList)
{
FastAttributeList* pAttrList = dynamic_cast< FastAttributeList*
>(xAttrList.get());
assert(pAttrList);
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
