comphelper/source/container/namecontainer.cxx | 2 +-
comphelper/source/misc/configurationhelper.cxx | 6 +++---
comphelper/source/misc/dispatchcommand.cxx | 2 +-
comphelper/source/property/opropertybag.cxx | 2 +-
comphelper/source/property/propertybag.cxx | 2 +-
include/comphelper/configurationhelper.hxx | 6 +++---
include/comphelper/dispatchcommand.hxx | 2 +-
include/comphelper/namecontainer.hxx | 2 +-
8 files changed, 12 insertions(+), 12 deletions(-)
New commits:
commit f3a43c723eaf751d5ee28b13c0cc6f8014094bbe
Author: Noel Grandin <n...@peralex.com>
Date: Fri Apr 8 15:54:34 2016 +0200
clang-tidy performance-unnecessary-value-param in comphelper
Change-Id: Iff26c89ea6079e0f12691dbc04bb36f02b85c305
Reviewed-on: https://gerrit.libreoffice.org/23920
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Noel Grandin <noelgran...@gmail.com>
diff --git a/comphelper/source/container/namecontainer.cxx
b/comphelper/source/container/namecontainer.cxx
index b04ada1..6ef8143 100644
--- a/comphelper/source/container/namecontainer.cxx
+++ b/comphelper/source/container/namecontainer.cxx
@@ -187,7 +187,7 @@ Type SAL_CALL NameContainer::getElementType()
return maType;
}
-Reference< XNameContainer > comphelper::NameContainer_createInstance( Type
aType )
+Reference< XNameContainer > comphelper::NameContainer_createInstance( const
Type& aType )
{
return static_cast<XNameContainer*>(new NameContainer( aType ));
}
diff --git a/comphelper/source/misc/configurationhelper.cxx
b/comphelper/source/misc/configurationhelper.cxx
index f5eb95e..3da8109 100644
--- a/comphelper/source/misc/configurationhelper.cxx
+++ b/comphelper/source/misc/configurationhelper.cxx
@@ -76,7 +76,7 @@ css::uno::Reference< css::uno::XInterface >
ConfigurationHelper::openConfig(cons
}
-css::uno::Any ConfigurationHelper::readRelativeKey(const css::uno::Reference<
css::uno::XInterface > xCFG ,
+css::uno::Any ConfigurationHelper::readRelativeKey(const css::uno::Reference<
css::uno::XInterface >& xCFG ,
const OUString&
sRelPath,
const OUString&
sKey )
{
@@ -98,7 +98,7 @@ css::uno::Any ConfigurationHelper::readRelativeKey(const
css::uno::Reference< cs
}
-void ConfigurationHelper::writeRelativeKey(const css::uno::Reference<
css::uno::XInterface > xCFG ,
+void ConfigurationHelper::writeRelativeKey(const css::uno::Reference<
css::uno::XInterface >& xCFG ,
const OUString&
sRelPath,
const OUString&
sKey ,
const css::uno::Any&
aValue )
@@ -121,7 +121,7 @@ void ConfigurationHelper::writeRelativeKey(const
css::uno::Reference< css::uno::
}
-css::uno::Reference< css::uno::XInterface >
ConfigurationHelper::makeSureSetNodeExists(const css::uno::Reference<
css::uno::XInterface > xCFG ,
+css::uno::Reference< css::uno::XInterface >
ConfigurationHelper::makeSureSetNodeExists(const css::uno::Reference<
css::uno::XInterface >& xCFG ,
const OUString& sRelPathToSet,
const OUString& sSetNode )
{
diff --git a/comphelper/source/misc/dispatchcommand.cxx
b/comphelper/source/misc/dispatchcommand.cxx
index 04cc2d7..6b97eef 100644
--- a/comphelper/source/misc/dispatchcommand.cxx
+++ b/comphelper/source/misc/dispatchcommand.cxx
@@ -31,7 +31,7 @@ using namespace css;
namespace comphelper {
-bool dispatchCommand(const OUString& rCommand, const
css::uno::Sequence<css::beans::PropertyValue>& rArguments,
uno::Reference<css::frame::XDispatchResultListener> aListener)
+bool dispatchCommand(const OUString& rCommand, const
css::uno::Sequence<css::beans::PropertyValue>& rArguments, const
uno::Reference<css::frame::XDispatchResultListener>& aListener)
{
// Target where we will execute the .uno: command
uno::Reference<uno::XComponentContext> xContext =
::comphelper::getProcessComponentContext();
diff --git a/comphelper/source/property/opropertybag.cxx
b/comphelper/source/property/opropertybag.cxx
index 20fc6f0..651c72c 100644
--- a/comphelper/source/property/opropertybag.cxx
+++ b/comphelper/source/property/opropertybag.cxx
@@ -343,7 +343,7 @@ namespace comphelper
// check whether the type is allowed, everything else will be checked
// by m_aDynamicProperties
- Type aPropertyType = _rInitialValue.getValueType();
+ const Type& aPropertyType = _rInitialValue.getValueType();
if ( _rInitialValue.hasValue()
&& !m_aAllowedTypes.empty()
&& m_aAllowedTypes.find( aPropertyType ) == m_aAllowedTypes.end()
diff --git a/comphelper/source/property/propertybag.cxx
b/comphelper/source/property/propertybag.cxx
index a3d22c0..7f32dd9 100644
--- a/comphelper/source/property/propertybag.cxx
+++ b/comphelper/source/property/propertybag.cxx
@@ -130,7 +130,7 @@ namespace comphelper
void PropertyBag::addProperty( const OUString& _rName, sal_Int32 _nHandle,
sal_Int32 _nAttributes, const Any& _rInitialValue )
{
// check type sanity
- Type aPropertyType = _rInitialValue.getValueType();
+ const Type& aPropertyType = _rInitialValue.getValueType();
if ( aPropertyType.getTypeClass() == TypeClass_VOID )
throw IllegalTypeException(
"The initial value must be non-NULL to determine the property
type.",
diff --git a/include/comphelper/configurationhelper.hxx
b/include/comphelper/configurationhelper.hxx
index c5cf9d4..45890cc 100644
--- a/include/comphelper/configurationhelper.hxx
+++ b/include/comphelper/configurationhelper.hxx
@@ -120,7 +120,7 @@ public:
* E.g. css::container::NoSuchElementException if the specified
* key does not exists.
*/
- static css::uno::Any readRelativeKey(const css::uno::Reference<
css::uno::XInterface > xCFG ,
+ static css::uno::Any readRelativeKey(const css::uno::Reference<
css::uno::XInterface >& xCFG ,
const OUString&
sRelPath,
const OUString&
sKey );
@@ -150,7 +150,7 @@ public:
* key does not exists or css::uno::Exception if the provided
configuration
* access does not allow writing for this key.
*/
- static void writeRelativeKey(const css::uno::Reference<
css::uno::XInterface > xCFG ,
+ static void writeRelativeKey(const css::uno::Reference<
css::uno::XInterface >& xCFG ,
const OUString&
sRelPath,
const OUString&
sKey ,
const css::uno::Any&
aValue );
@@ -184,7 +184,7 @@ public:
* E.g. css::uno::Exception if the provided configuration
* access does not allow writing for this set.
*/
- static css::uno::Reference< css::uno::XInterface >
makeSureSetNodeExists(const css::uno::Reference< css::uno::XInterface > xCFG
,
+ static css::uno::Reference< css::uno::XInterface >
makeSureSetNodeExists(const css::uno::Reference< css::uno::XInterface >& xCFG
,
const OUString& sRelPathToSet,
const OUString& sSetNode );
diff --git a/include/comphelper/dispatchcommand.hxx
b/include/comphelper/dispatchcommand.hxx
index 7b76bd5..0a8e158 100644
--- a/include/comphelper/dispatchcommand.hxx
+++ b/include/comphelper/dispatchcommand.hxx
@@ -27,7 +27,7 @@ namespace comphelper
*/
COMPHELPER_DLLPUBLIC bool dispatchCommand(const OUString& rCommand,
const css::uno::Sequence<css::beans::PropertyValue>& rArguments,
- css::uno::Reference<css::frame::XDispatchResultListener> aListener =
css::uno::Reference<css::frame::XDispatchResultListener>());
+ const css::uno::Reference<css::frame::XDispatchResultListener>&
aListener = css::uno::Reference<css::frame::XDispatchResultListener>());
}
diff --git a/include/comphelper/namecontainer.hxx
b/include/comphelper/namecontainer.hxx
index 1af6119..fd078c6 100644
--- a/include/comphelper/namecontainer.hxx
+++ b/include/comphelper/namecontainer.hxx
@@ -27,7 +27,7 @@
namespace comphelper
{
COMPHELPER_DLLPUBLIC css::uno::Reference< css::container::XNameContainer >
- NameContainer_createInstance( css::uno::Type aType );
+ NameContainer_createInstance( const css::uno::Type& aType );
}
#endif // INCLUDED_COMPHELPER_NAMECONTAINER_HXX
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
