sal/qa/osl/mutex/osl_Mutex.cxx | 4 -
sal/qa/osl/pipe/osl_Pipe.cxx | 8 --
sal/qa/osl/process/osl_Thread.cxx | 86 --------------------------
sal/qa/rtl/ostring/rtl_OString2.cxx | 36 ----------
svl/qa/unit/svl.cxx | 5 -
svtools/qa/unit/testHtmlWriter.cxx | 4 -
tools/qa/cppunit/test_urlobj.cxx | 9 --
unotools/qa/unit/testGetEnglishSearchName.cxx | 5 -
xmlsecurity/qa/certext/SanCertExt.cxx | 10 ---
9 files changed, 167 deletions(-)
New commits:
commit cc84aaf70ac56092b32d1d329143eca0550dce12
Author: Chirag Manwani <cmkmanw...@gmail.com>
Date: Mon Mar 7 02:14:49 2016 +0530
tdf#97703 removed empty setUp/tearDown methods
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604
Reviewed-on: https://gerrit.libreoffice.org/22959
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/sal/qa/osl/mutex/osl_Mutex.cxx b/sal/qa/osl/mutex/osl_Mutex.cxx
index 67924d2..83c1b687 100644
--- a/sal/qa/osl/mutex/osl_Mutex.cxx
+++ b/sal/qa/osl/mutex/osl_Mutex.cxx
@@ -254,10 +254,6 @@ namespace osl_Mutex
m_Res.data2 = 0;
}
- void tearDown() override
- {
- }
-
/** Create two threads to write data to the same buffer, use Mutex to
assure
during one thread write data five times, the other thread should
not begin writing.
the two threads wrote two different datas: their thread ID, so we
can check the datas
diff --git a/sal/qa/osl/pipe/osl_Pipe.cxx b/sal/qa/osl/pipe/osl_Pipe.cxx
index 568f047..ce184f0 100644
--- a/sal/qa/osl/pipe/osl_Pipe.cxx
+++ b/sal/qa/osl/pipe/osl_Pipe.cxx
@@ -122,14 +122,6 @@ namespace osl_Pipe
public:
bool bRes, bRes1;
- void setUp( ) override
- {
- }
-
- void tearDown( ) override
- {
- }
-
void ctors_none( )
{
::osl::Pipe aPipe;
diff --git a/sal/qa/osl/process/osl_Thread.cxx
b/sal/qa/osl/process/osl_Thread.cxx
index 0d0eb0f2..28080b4 100644
--- a/sal/qa/osl/process/osl_Thread.cxx
+++ b/sal/qa/osl/process/osl_Thread.cxx
@@ -449,16 +449,6 @@ namespace osl_Thread
class create : public CppUnit::TestFixture
{
public:
-
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
/** Simple create a thread.
Create a simple thread, it just does add 1 to value(which
initialized 0),
@@ -518,15 +508,6 @@ namespace osl_Thread
class createSuspended : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
/** Create a suspended thread, use the same class as create_001
after create, wait enough time, check the value, if it's still the
initial value, pass
@@ -599,15 +580,6 @@ namespace osl_Thread
class suspend : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
/** Use a thread which has a flag added 1 every second
ALGORITHM:
@@ -653,15 +625,6 @@ namespace osl_Thread
class resume : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
/** check if the thread run samely as usual after suspend and resume
ALGORITHM:
@@ -738,15 +701,6 @@ namespace osl_Thread
class terminate : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
/** Check after call terminate if the running thread running go on
executing
ALGORITHM:
@@ -817,15 +771,6 @@ namespace osl_Thread
class join : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
/** Check after call terminate if the thread running function will not
go on executing
the next statement after join will not exec before the thread
terminate
@@ -909,17 +854,6 @@ namespace osl_Thread
class isRunning : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
- /**
- */
void isRunning_001()
{
OCountThread *aCountThread = new OCountThread();
@@ -975,15 +909,6 @@ namespace osl_Thread
class setPriority : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override
- {
- }
-
- void tearDown() override
- {
- }
-
// insert your test code here.
rtl::OString getPrioName(oslThreadPriority _aPriority)
{
@@ -1433,11 +1358,6 @@ namespace osl_Thread
class getPriority : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp() override {}
-
- void tearDown() override {}
-
// insert your test code here.
void getPriority_001()
{
@@ -1520,9 +1440,6 @@ namespace osl_Thread
class waittest : public CppUnit::TestFixture
{
public:
- void setUp() override {}
- void tearDown() override {}
-
/** call wait in the run method
ALGORITHM:
@@ -1580,9 +1497,6 @@ namespace osl_Thread
class yield : public CppUnit::TestFixture
{
public:
- void setUp() override {}
- void tearDown() override {}
-
void yield_001()
{
// insert your test code here.
diff --git a/sal/qa/rtl/ostring/rtl_OString2.cxx
b/sal/qa/rtl/ostring/rtl_OString2.cxx
index 5c76057..e42ac2b 100644
--- a/sal/qa/rtl/ostring/rtl_OString2.cxx
+++ b/sal/qa/rtl/ostring/rtl_OString2.cxx
@@ -53,15 +53,6 @@ class valueOf : public CppUnit::TestFixture
}
public:
- // initialise your test code values here.
- void setUp()
- {
- }
-
- void tearDown()
- {
- }
-
// insert your test code here.
void valueOf_float_test_001()
{
@@ -209,15 +200,6 @@ public:
// testPrecision a;
}
- // initialise your test code values here.
- void setUp()
- {
- }
-
- void tearDown()
- {
- }
-
void toDouble_test_impl(rtl::OString const& _sValue)
{
double nValueATOF = atof( _sValue.getStr() );
@@ -353,16 +335,6 @@ class getToken : public CppUnit::TestFixture
{
public:
-
- // initialise your test code values here.
- void setUp()
- {
- }
-
- void tearDown()
- {
- }
-
void getToken_000()
{
rtl::OString sTokenStr;
@@ -465,14 +437,6 @@ class replaceAt : public CppUnit::TestFixture
{
public:
- // initialise your test code values here.
- void setUp()
- {
- }
-
- void tearDown()
- {
- }
sal_Bool check_replaceAt( const rtl::OString* expVal, const rtl::OString*
input,
const rtl::OString* newStr, sal_Int32 index, sal_Int32 count)
{
diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 53d05cb..7f4c1e8 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -50,7 +50,6 @@ public:
Test();
virtual ~Test();
- virtual void setUp() override;
virtual void tearDown() override;
void testNumberFormat();
@@ -98,10 +97,6 @@ Test::Test()
m_pDefaultTimeZone.reset(icu::TimeZone::createDefault());
}
-void Test::setUp()
-{
-}
-
void Test::tearDown()
{
icu::TimeZone::setDefault(*m_pDefaultTimeZone);
diff --git a/svtools/qa/unit/testHtmlWriter.cxx
b/svtools/qa/unit/testHtmlWriter.cxx
index 6c2862b..5dd9491 100644
--- a/svtools/qa/unit/testHtmlWriter.cxx
+++ b/svtools/qa/unit/testHtmlWriter.cxx
@@ -34,7 +34,6 @@ class Test: public CppUnit::TestFixture
{
public:
- virtual void setUp() override;
void testSingleElement();
void testSingleElementWithAttributes();
void testSingleElementWithContent();
@@ -53,9 +52,6 @@ public:
CPPUNIT_TEST_SUITE_END();
};
-void Test::setUp()
-{}
-
void Test::testSingleElement()
{
{
diff --git a/tools/qa/cppunit/test_urlobj.cxx b/tools/qa/cppunit/test_urlobj.cxx
index dce5cc1..79f20b1 100644
--- a/tools/qa/cppunit/test_urlobj.cxx
+++ b/tools/qa/cppunit/test_urlobj.cxx
@@ -43,15 +43,6 @@ namespace tools_urlobj
{
public:
- // initialise your test code values here.
- void setUp( ) override
- {
- }
-
- void tearDown( ) override
- {
- }
-
// insert your test code here.
// this is only demonstration code
void urlobjTest_001( )
diff --git a/unotools/qa/unit/testGetEnglishSearchName.cxx
b/unotools/qa/unit/testGetEnglishSearchName.cxx
index 42ceeba..41dffa2 100644
--- a/unotools/qa/unit/testGetEnglishSearchName.cxx
+++ b/unotools/qa/unit/testGetEnglishSearchName.cxx
@@ -18,7 +18,6 @@
class Test: public CppUnit::TestFixture
{
public:
- virtual void setUp() override;
void testSingleElement();
CPPUNIT_TEST_SUITE(Test);
@@ -27,10 +26,6 @@ public:
CPPUNIT_TEST_SUITE_END();
};
-void Test::setUp()
-{
-}
-
void Test::testSingleElement()
{
{ // lowercase
diff --git a/xmlsecurity/qa/certext/SanCertExt.cxx
b/xmlsecurity/qa/certext/SanCertExt.cxx
index 12f0317..11cf6e9 100644
--- a/xmlsecurity/qa/certext/SanCertExt.cxx
+++ b/xmlsecurity/qa/certext/SanCertExt.cxx
@@ -65,10 +65,6 @@ namespace {
~Test();
- virtual void setUp();
-
- virtual void tearDown();
-
void test_Others();
void test_RFC822();
@@ -164,12 +160,6 @@ namespace {
}
- void Test::setUp() {
- }
-
- void Test::tearDown() {
- }
-
void Test::test_Others() {
CPPUNIT_ASSERT_ASSERTION_PASS( CPPUNIT_ASSERT( altNames.getLength() >
0 ) );
for(int n = 1; n < altNames.getLength(); n++)
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
