On Tue, Feb 2, 2016 at 4:22 AM, Kohei Yoshida <libreoff...@kohei.us> wrote:
> Hi Josh, > > On Sat, 2016-01-30 at 07:21 -0500, joshbaldwin42 . wrote: > > > I am working on > > https://bugs.documentfoundation.org/show_bug.cgi?id=66754 . This > > required a change to /setup_native/scripts/admin.pl. I did > > > > egrep -ir "admin.pl" . > > BTW, when grepping through git-managed files, it's normally a lot faster > to run 'git grep' than the normal grep command (in case you were not > aware of it). > > > > to see where in libreoffice admin.pl used. However, it does not > > appear to be called anywhere. > > Yup, it looks that way. Running git log -S'admin.pl' reveals that this > commit > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=bdd97ec6ee5ad96fd2452ce99b3ebd28e540629a > > removed the last use of this script. I'm not an expert on the packaging > part of the build system, but I'm pretty certain that this script is > unused for real. > > But just in case it is still used externally, let me CC Andras who is > more familiar with this part of the code. > > > I wanted to know so I can properly test the code before submitting. > > I think you've done your due diligence to make sure the script is now > unused. Unless someone else screams and tells you "Please don't remove > it!", I would just remove that file in your gerrit patch, to at least > have Jenkins tell us if it still is buildable on all major platforms. > > I've never used admin.pl. I think its functionality is 100% covered by 'msiexec -a' command, so we don't need it. Best regards, Andras
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
