connectivity/source/drivers/dbase/DTable.cxx | 2 - sax/source/fastparser/fastparser.cxx | 6 ++-- sax/source/tools/fastserializer.hxx | 4 +- sax/test/sax/testsax.cxx | 2 - sax/test/sax/testwriter.cxx | 4 +- sax/test/saxdemo.cxx | 4 +- slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx | 14 +++++++--- 7 files changed, 22 insertions(+), 14 deletions(-)
New commits: commit 6e2736705dbbeada40ae6663c006176d052d026a Author: Caolán McNamara <[email protected]> Date: Fri Oct 30 08:10:47 2015 +0000 coverity#1332210 Uninitialized scalar field Change-Id: I9f62e3f9d2bb517ad8f40400004670de1c4d06a5 diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx index 1cb003d..963397c 100644 --- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx +++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx @@ -1650,9 +1650,17 @@ class VortexTransition : public ShaderTransition { public: VortexTransition(const TransitionScene& rScene, const TransitionSettings& rSettings, int nNX, int nNY) - : ShaderTransition(rScene, rSettings), - mnNX(nNX), - mnNY(nNY) + : ShaderTransition(rScene, rSettings) + , mnCenterLocation(0) + , mnTileXIndexLocation(0) + , mnTileYIndexLocation(0) + , mnVertexIndexInTileLocation(0) + , mnCenterBuffer(0) + , mnTileXIndexBuffer(0) + , mnTileYIndexBuffer(0) + , mnVertexIndexInTileBuffer(0) + , mnNX(nNX) + , mnNY(nNY) { mvCenters.resize(6*mnNX*mnNY); mvTileXIndexes.resize(6*mnNX*mnNY); commit e87f71cebee26624b4e9495b0acc172d47e705dd Author: Caolán McNamara <[email protected]> Date: Thu Oct 29 20:23:30 2015 +0000 cppcheck: noExplicitConstructor Change-Id: Id6d969713d94b558a93d303c6dabcbfdd1c65194 diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx index 824225e..d8baef9 100644 --- a/sax/source/fastparser/fastparser.cxx +++ b/sax/source/fastparser/fastparser.cxx @@ -200,7 +200,7 @@ namespace sax_fastparser { class FastSaxParserImpl { public: - FastSaxParserImpl( FastSaxParser* pFront ); + explicit FastSaxParserImpl(FastSaxParser* pFront); ~FastSaxParserImpl(); // XFastParser @@ -270,7 +270,7 @@ class ParserThread: public salhelper::Thread { FastSaxParserImpl *mpParser; public: - ParserThread(FastSaxParserImpl *pParser): Thread("Parser"), mpParser(pParser) {} + explicit ParserThread(FastSaxParserImpl *pParser): Thread("Parser"), mpParser(pParser) {} private: virtual void execute() override { @@ -331,7 +331,7 @@ static int call_callbackExternalEntityRef( XML_Parser parser, class FastLocatorImpl : public WeakImplHelper< XLocator > { public: - FastLocatorImpl( FastSaxParserImpl *p ) : mpParser(p) {} + explicit FastLocatorImpl(FastSaxParserImpl *p) : mpParser(p) {} void dispose() { mpParser = 0; } void checkDispose() throw (RuntimeException) { if( !mpParser ) throw DisposedException(); } diff --git a/sax/source/tools/fastserializer.hxx b/sax/source/tools/fastserializer.hxx index a45da2e..7a56524 100644 --- a/sax/source/tools/fastserializer.hxx +++ b/sax/source/tools/fastserializer.hxx @@ -48,7 +48,7 @@ class FastSaxSerializer typedef css::uno::Sequence< ::sal_Int32 > Int32Sequence; public: - FastSaxSerializer( const css::uno::Reference< css::io::XOutputStream >& xOutputStream ); + explicit FastSaxSerializer(const css::uno::Reference< css::io::XOutputStream >& xOutputStream); ~FastSaxSerializer(); css::uno::Reference< css::io::XOutputStream > getOutputStream(); @@ -176,7 +176,7 @@ private: std::deque<sal_Int32> m_DebugPostponedStartedElements; #endif - ForMerge(sal_Int32 const nTag) : m_Tag(nTag) {} + explicit ForMerge(sal_Int32 const nTag) : m_Tag(nTag) {} virtual ~ForMerge() {} virtual void setCurrentElement( ::sal_Int32 /*nToken*/ ) {} diff --git a/sax/test/sax/testsax.cxx b/sax/test/sax/testsax.cxx index 104ac8c..8dbfdfb 100644 --- a/sax/test/sax/testsax.cxx +++ b/sax/test/sax/testsax.cxx @@ -47,7 +47,7 @@ namespace sax_test { class OSaxParserTest : public WeakImplHelper< XSimpleTest > { public: - OSaxParserTest( const Reference < XMultiServiceFactory > & rFactory ) : m_rFactory( rFactory ) + explicit OSaxParserTest( const Reference < XMultiServiceFactory > & rFactory ) : m_rFactory( rFactory ) { } diff --git a/sax/test/sax/testwriter.cxx b/sax/test/sax/testwriter.cxx index a1bddcf..c0af020 100644 --- a/sax/test/sax/testwriter.cxx +++ b/sax/test/sax/testwriter.cxx @@ -49,7 +49,7 @@ class OFileWriter : public WeakImplHelper< XOutputStream > { public: - OFileWriter( char *pcFile ) { strncpy( m_pcFile, pcFile, 256 - 1 ); m_f = 0; } + explicit OFileWriter( char *pcFile ) { strncpy( m_pcFile, pcFile, 256 - 1 ); m_f = 0; } public: @@ -94,7 +94,7 @@ class OSaxWriterTest : public WeakImplHelper< XSimpleTest > { public: - OSaxWriterTest( const Reference < XMultiServiceFactory > & rFactory ) : m_rFactory( rFactory ) + explicit OSaxWriterTest( const Reference < XMultiServiceFactory > & rFactory ) : m_rFactory( rFactory ) { } diff --git a/sax/test/saxdemo.cxx b/sax/test/saxdemo.cxx index 51012fe..cc881eb 100644 --- a/sax/test/saxdemo.cxx +++ b/sax/test/saxdemo.cxx @@ -59,7 +59,7 @@ using namespace ::com::sun::star::io; class OInputStream : public WeakImplHelper < XInputStream > { public: - OInputStream( const Sequence< sal_Int8 >&seq ) : + explicit OInputStream( const Sequence< sal_Int8 >&seq ) : m_seq( seq ), nPos( 0 ) {} @@ -433,7 +433,7 @@ class OFileWriter : public WeakImplHelper< XOutputStream > { public: - OFileWriter( char *pcFile ) { strncpy( m_pcFile , pcFile, 256 - 1 ); m_f = 0; } + explicit OFileWriter( char *pcFile ) { strncpy( m_pcFile , pcFile, 256 - 1 ); m_f = 0; } public: commit 8be504b6239d34963cb44411d0b3502ac23aeeb2 Author: Caolán McNamara <[email protected]> Date: Thu Oct 29 20:20:25 2015 +0000 cppcheck: unreadVariable Change-Id: I109e5f36a524e2996d00bf81e873776d0d738011 diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx index 3d10573..fe0750e 100644 --- a/connectivity/source/drivers/dbase/DTable.cxx +++ b/connectivity/source/drivers/dbase/DTable.cxx @@ -2432,7 +2432,7 @@ void ODbaseTable::addColumn(const Reference< XPropertySet >& _xNewColumn) pNewTable->renameImpl(m_Name); // release the temp file } - xHold = pNewTable = NULL; + xHold.clear(); FileClose(); construct();
_______________________________________________ Libreoffice-commits mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
