[Libreoffice-commits] core.git: 3 commits - qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/chart/_XChartDataArray.java |    6 ++----
 qadevOOo/tests/java/ifc/text/_BaseIndex.java        |    3 +++
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 0d8f7f69c632c34621cac46db5358ebc908434f6
Author: Caolán McNamara <caol...@redhat.com>
Date:   Tue Oct 27 20:41:36 2015 +0000

    coverity#1326106 Missing call to superclass
    
    Change-Id: I546d3a1be35c627b4fe36972620eefd4ee099e7f

diff --git a/qadevOOo/tests/java/ifc/text/_BaseIndex.java 
b/qadevOOo/tests/java/ifc/text/_BaseIndex.java
index 37fc8e7..017d4a8 100644
--- a/qadevOOo/tests/java/ifc/text/_BaseIndex.java
+++ b/qadevOOo/tests/java/ifc/text/_BaseIndex.java
@@ -145,6 +145,9 @@ public class _BaseIndex extends MultiPropertyTest {
                                        Object newValue, Object resValue,
                                        Exception exception)
                                 throws Exception {
+
+                super.checkResult(propName, oldValue, newValue, resValue, 
exception);
+
                 PropertyValue[][] res = (PropertyValue[][]) 
UnoRuntime.queryInterface(
                                                                      
XIndexAccess.class,
                                                                      
resValue).getByIndex(0);
commit b56088673094374cd20b0e62ce7e3a94ef30a6fc
Author: Caolán McNamara <caol...@redhat.com>
Date:   Mon Oct 26 23:31:35 2015 +0000

    coverity#1326926 NS: Suspicious use of non-short-circuit boolean operator
    
    Change-Id: Iceccb42d7e65abe012411fd61b3c69145d91f17a

diff --git a/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java 
b/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java
index 4cee4ef..14ead16 100644
--- a/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java
+++ b/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java
@@ -184,10 +184,9 @@ public class _XChartDataArray extends MultiMethodTest {
     */
     public void _getRowDescriptions() {
         requiredMethod("setRowDescriptions()");
-        bResult = true;
 
         String[] dscs = oObj.getRowDescriptions();
-        bResult &= dscs.length == rowDscs.length;
+        bResult = dscs.length == rowDscs.length;
         if (bResult) {
             for (int i = 0; i < dscs.length; i++) {
                 log.println("Row " + i + ": got " + dscs[i] + " expected: " + 
rowDscs[i]);
commit decdab2c65decdce2270d1029bc9cc626159619c
Author: Caolán McNamara <caol...@redhat.com>
Date:   Mon Oct 26 23:30:57 2015 +0000

    coverity#1326924 NS: Suspicious use of non-short-circuit boolean operator
    
    Change-Id: I99aba91939af31837923d2e2e3ca4814178449dc

diff --git a/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java 
b/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java
index 2cfaedb..4cee4ef 100644
--- a/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java
+++ b/qadevOOo/tests/java/ifc/chart/_XChartDataArray.java
@@ -160,10 +160,9 @@ public class _XChartDataArray extends MultiMethodTest {
     */
     public void _getColumnDescriptions() {
         requiredMethod("setColumnDescriptions()");
-        bResult = true;
 
         String[] dscs = oObj.getColumnDescriptions();
-        bResult &= dscs.length == colDscs.length;
+        bResult = dscs.length == colDscs.length;
         if (bResult) {
             for (int i = 0; i < dscs.length; i++) {
                 log.println("Col " + i + ": got " + dscs[i] + " expected: " + 
colDscs[i]);

_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits