[Libreoffice-commits] core.git: bridges/source

[Caolán McNamara]

 bridges/source/cpp_uno/shared/vtablefactory.cxx |    4 ++--
 bridges/source/jni_uno/jni_base.h               |   10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit f51994efcd08af992fd9836b700a0c651b120813
Author: Caolán McNamara <caol...@redhat.com>
Date:   Mon Aug 17 14:20:43 2015 +0100

    cppcheck: noExplicitConstructor
    
    Change-Id: I4bdbcd9debdf6a385d3b6f199b71b09d7e27b0fa
    Reviewed-on: https://gerrit.libreoffice.org/17810
    Tested-by: Jenkins <c...@libreoffice.org>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>
    Tested-by: Caolán McNamara <caol...@redhat.com>

diff --git a/bridges/source/cpp_uno/shared/vtablefactory.cxx 
b/bridges/source/cpp_uno/shared/vtablefactory.cxx
index 474dfcd..c81bcae 100644
--- a/bridges/source/cpp_uno/shared/vtablefactory.cxx
+++ b/bridges/source/cpp_uno/shared/vtablefactory.cxx
@@ -122,7 +122,7 @@ class VtableFactory::GuardedBlocks:
     public std::vector<Block>, private boost::noncopyable
 {
 public:
-    GuardedBlocks(VtableFactory const & factory):
+    explicit GuardedBlocks(VtableFactory const & factory):
         m_factory(factory), m_guarded(true) {}
 
     ~GuardedBlocks();
@@ -144,7 +144,7 @@ VtableFactory::GuardedBlocks::~GuardedBlocks() {
 
 class VtableFactory::BaseOffset {
 public:
-    BaseOffset(typelib_InterfaceTypeDescription * type) { calculate(type, 0); }
+    explicit BaseOffset(typelib_InterfaceTypeDescription * type) { 
calculate(type, 0); }
 
     sal_Int32 getFunctionOffset(OUString const & name) const
     { return m_map.find(name)->second; }
diff --git a/bridges/source/jni_uno/jni_base.h 
b/bridges/source/jni_uno/jni_base.h
index 4fd90ea..62474ea 100644
--- a/bridges/source/jni_uno/jni_base.h
+++ b/bridges/source/jni_uno/jni_base.h
@@ -46,7 +46,7 @@ struct BridgeRuntimeError
 {
     OUString m_message;
 
-    inline BridgeRuntimeError( OUString const & message )
+    explicit BridgeRuntimeError( OUString const & message )
         : m_message( message )
         {}
 };
@@ -142,20 +142,20 @@ class JLocalAutoRef
     jobject m_jo;
 
 public:
-    inline JLocalAutoRef( JNI_context const & jni )
+    explicit JLocalAutoRef( JNI_context const & jni )
         : m_jni( jni ),
           m_jo( 0 )
         {}
-    inline explicit JLocalAutoRef( JNI_context const & jni, jobject jo )
+    explicit JLocalAutoRef( JNI_context const & jni, jobject jo )
         : m_jni( jni ),
           m_jo( jo )
         {}
     inline JLocalAutoRef( JLocalAutoRef & auto_ref );
     inline ~JLocalAutoRef();
 
-    inline jobject get() const
+    jobject get() const
         { return m_jo; }
-    inline bool is() const
+    bool is() const
         { return (0 != m_jo); }
     inline jobject release();
     inline void reset( jobject jo );

_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits