sc/source/filter/excel/excrecds.cxx | 2 sc/source/filter/excel/expop2.cxx | 2 sc/source/filter/excel/xeformula.cxx | 2 sc/source/filter/excel/xltools.cxx | 2 sc/source/filter/html/htmlexp.cxx | 4 - sc/source/filter/html/htmlpars.cxx | 2 sc/source/filter/lotus/tool.cxx | 18 +++--- sc/source/filter/oox/biffinputstream.cxx | 2 sc/source/filter/oox/drawingfragment.cxx | 2 sc/source/filter/oox/formulabuffer.cxx | 4 - sc/source/filter/oox/workbookhelper.cxx | 2 sc/source/filter/orcus/interface.cxx | 4 - sc/source/filter/qpro/qpro.cxx | 2 sc/source/filter/rtf/expbase.cxx | 2 sc/source/filter/starcalc/scflt.cxx | 8 +- sc/source/filter/xcl97/xcl97rec.cxx | 3 - sc/source/filter/xml/xmlcoli.cxx | 2 sc/source/filter/xml/xmlexprt.cxx | 11 +-- sc/source/filter/xml/xmlrowi.cxx | 2 sc/source/filter/xml/xmlstyli.cxx | 2 sc/source/filter/xml/xmltabi.cxx | 2 sc/source/ui/Accessibility/AccessibleEditObject.cxx | 4 - sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx | 2 sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx | 4 - sc/source/ui/StatisticsDialogs/SamplingDialog.cxx | 2 sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx | 2 sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx | 2 sc/source/ui/app/drwtrans.cxx | 2 sc/source/ui/app/inputhdl.cxx | 28 +++++----- sc/source/ui/app/inputwin.cxx | 2 sc/source/ui/app/scmod.cxx | 2 sc/source/ui/app/transobj.cxx | 6 +- sc/source/ui/cctrl/checklistmenu.cxx | 2 sc/source/ui/dbgui/PivotLayoutDialog.cxx | 14 ++--- sc/source/ui/dbgui/dbnamdlg.cxx | 12 ++-- sc/source/ui/dbgui/foptmgr.cxx | 4 - sc/source/ui/dbgui/scendlg.cxx | 6 +- sc/source/ui/dbgui/scuiasciiopt.cxx | 2 sc/source/ui/dbgui/scuiimoptdlg.cxx | 2 sc/source/ui/dbgui/sfiltdlg.cxx | 2 sc/source/ui/dbgui/textimportoptions.cxx | 2 sc/source/ui/dbgui/tpsort.cxx | 4 - sc/source/ui/dbgui/tpsubt.cxx | 4 - sc/source/ui/docshell/datastream.cxx | 2 sc/source/ui/docshell/docfunc.cxx | 10 +-- sc/source/ui/docshell/docsh.cxx | 2 sc/source/ui/docshell/docsh3.cxx | 6 +- sc/source/ui/docshell/docsh4.cxx | 6 +- sc/source/ui/docshell/docsh5.cxx | 2 sc/source/ui/docshell/docsh6.cxx | 2 sc/source/ui/docshell/olinefun.cxx | 6 +- sc/source/ui/drawfunc/drawsh5.cxx | 4 - sc/source/ui/drawfunc/fuconcustomshape.cxx | 2 sc/source/ui/drawfunc/fudraw.cxx | 4 - sc/source/ui/drawfunc/fuins2.cxx | 4 - sc/source/ui/drawfunc/fusel.cxx | 2 sc/source/ui/drawfunc/futext.cxx | 2 sc/source/ui/formdlg/dwfunctr.cxx | 2 sc/source/ui/miscdlgs/acredlin.cxx | 12 ++-- sc/source/ui/miscdlgs/anyrefdg.cxx | 8 +- sc/source/ui/miscdlgs/crnrdlg.cxx | 14 ++--- sc/source/ui/miscdlgs/highred.cxx | 6 +- sc/source/ui/miscdlgs/inscodlg.cxx | 28 +++++----- sc/source/ui/miscdlgs/instbdlg.cxx | 6 +- sc/source/ui/miscdlgs/mvtabdlg.cxx | 4 - sc/source/ui/miscdlgs/optsolver.cxx | 2 sc/source/ui/miscdlgs/protectiondlg.cxx | 6 +- sc/source/ui/miscdlgs/redcom.cxx | 2 sc/source/ui/miscdlgs/retypepassdlg.cxx | 4 - sc/source/ui/navipi/content.cxx | 2 sc/source/ui/navipi/navipi.cxx | 2 sc/source/ui/navipi/scenwnd.cxx | 2 sc/source/ui/optdlg/calcoptionsdlg.cxx | 4 - sc/source/ui/optdlg/tpformula.cxx | 4 - sc/source/ui/pagedlg/tphfedit.cxx | 4 - sc/source/ui/sidebar/AlignmentPropertyPanel.cxx | 6 +- sc/source/ui/sidebar/CellBorderStyleControl.cxx | 6 +- sc/source/ui/sidebar/CellLineStyleValueSet.cxx | 2 sc/source/ui/undo/undobase.cxx | 2 sc/source/ui/undo/undoblk.cxx | 6 +- sc/source/ui/undo/undoblk3.cxx | 12 ++-- sc/source/ui/undo/undocell.cxx | 2 sc/source/ui/undo/undodat.cxx | 14 ++--- sc/source/ui/undo/undotab.cxx | 2 sc/source/ui/unoobj/cellsuno.cxx | 10 +-- sc/source/ui/unoobj/chart2uno.cxx | 5 - sc/source/ui/unoobj/docuno.cxx | 8 +- sc/source/ui/unoobj/styleuno.cxx | 2 sc/source/ui/vba/vbaformat.cxx | 4 - sc/source/ui/vba/vbaname.cxx | 8 +- sc/source/ui/vba/vbarange.cxx | 2 sc/source/ui/view/cellsh1.cxx | 6 +- sc/source/ui/view/cellsh3.cxx | 2 sc/source/ui/view/drawview.cxx | 6 +- sc/source/ui/view/formatsh.cxx | 4 - sc/source/ui/view/gridwin.cxx | 6 +- sc/source/ui/view/gridwin4.cxx | 4 - sc/source/ui/view/gridwin_dbgutil.cxx | 4 - sc/source/ui/view/output.cxx | 2 sc/source/ui/view/output2.cxx | 8 +- sc/source/ui/view/preview.cxx | 20 +++---- sc/source/ui/view/printfun.cxx | 15 ++--- sc/source/ui/view/select.cxx | 8 +- sc/source/ui/view/tabview.cxx | 6 +- sc/source/ui/view/tabview2.cxx | 2 sc/source/ui/view/tabview3.cxx | 6 +- sc/source/ui/view/tabview5.cxx | 4 - sc/source/ui/view/tabvwsh3.cxx | 3 - sc/source/ui/view/viewdata.cxx | 8 +- sc/source/ui/view/viewfun2.cxx | 2 sc/source/ui/view/viewfun3.cxx | 28 +++++----- sc/source/ui/view/viewfun6.cxx | 4 - sc/source/ui/view/viewfun7.cxx | 2 sc/source/ui/view/viewfunc.cxx | 8 +- 114 files changed, 300 insertions(+), 305 deletions(-)
New commits: commit fcd4c6dabecb348096ed8eb7ffe16c7ec059df31 Author: Noel Grandin <n...@peralex.com> Date: Wed Aug 12 15:11:19 2015 +0200 loplugin: defaultparams Change-Id: If342e813063eb0a17f7a8f8e872290f056964e05 diff --git a/sc/source/ui/vba/vbaformat.cxx b/sc/source/ui/vba/vbaformat.cxx index 0278b00..33a0584 100644 --- a/sc/source/ui/vba/vbaformat.cxx +++ b/sc/source/ui/vba/vbaformat.cxx @@ -554,7 +554,7 @@ ScVbaFormat<Ifc1>::getLocked( ) throw (script::BasicErrorException, uno::Runtim SfxItemSet* pDataSet = getCurrentDataSet(); if ( pDataSet ) { - const ScProtectionAttr& rProtAttr = static_cast<const ScProtectionAttr &>( pDataSet->Get(ATTR_PROTECTION, true) ); + const ScProtectionAttr& rProtAttr = static_cast<const ScProtectionAttr &>( pDataSet->Get(ATTR_PROTECTION) ); SfxItemState eState = pDataSet->GetItemState(ATTR_PROTECTION, true, NULL); if(eState != SfxItemState::DONTCARE) aCellProtection = uno::makeAny(rProtAttr.GetProtection()); @@ -587,7 +587,7 @@ ScVbaFormat<Ifc1>::getFormulaHidden( ) throw (script::BasicErrorException, uno: SfxItemSet* pDataSet = getCurrentDataSet(); if ( pDataSet ) { - const ScProtectionAttr& rProtAttr = static_cast<const ScProtectionAttr &>( pDataSet->Get(ATTR_PROTECTION, true) ); + const ScProtectionAttr& rProtAttr = static_cast<const ScProtectionAttr &>( pDataSet->Get(ATTR_PROTECTION) ); SfxItemState eState = pDataSet->GetItemState(ATTR_PROTECTION, true, NULL); if(eState != SfxItemState::DONTCARE) aBoolRet = uno::makeAny(rProtAttr.GetHideFormula()); diff --git a/sc/source/ui/vba/vbaname.cxx b/sc/source/ui/vba/vbaname.cxx index 6230344..4b0531a 100644 --- a/sc/source/ui/vba/vbaname.cxx +++ b/sc/source/ui/vba/vbaname.cxx @@ -139,7 +139,7 @@ void ScVbaName::setContent( const OUString& rContent, const formula::FormulaGra OUString ScVbaName::getValue() throw (css::uno::RuntimeException, std::exception) { - rtl::OUString sResult = getContent( formula::FormulaGrammar::GRAM_NATIVE_XL_A1, true ); + rtl::OUString sResult = getContent( formula::FormulaGrammar::GRAM_NATIVE_XL_A1 ); return sResult; } @@ -147,7 +147,7 @@ ScVbaName::getValue() throw (css::uno::RuntimeException, std::exception) void ScVbaName::setValue( const OUString & rValue ) throw (css::uno::RuntimeException, std::exception) { - setContent( rValue, formula::FormulaGrammar::GRAM_NATIVE_XL_A1, true ); + setContent( rValue, formula::FormulaGrammar::GRAM_NATIVE_XL_A1 ); } OUString @@ -177,14 +177,14 @@ ScVbaName::setRefersToLocal( const OUString & rRefersTo ) throw (css::uno::Runti OUString ScVbaName::getRefersToR1C1() throw (css::uno::RuntimeException, std::exception) { - rtl::OUString sResult = getContent( formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1, true ); + rtl::OUString sResult = getContent( formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1 ); return sResult; } void ScVbaName::setRefersToR1C1( const OUString & rRefersTo ) throw (css::uno::RuntimeException, std::exception) { - setContent( rRefersTo, formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1, true ); + setContent( rRefersTo, formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1 ); } OUString diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx index a65dbc8..e4eaf2f 100644 --- a/sc/source/ui/vba/vbarange.cxx +++ b/sc/source/ui/vba/vbarange.cxx @@ -2281,7 +2281,7 @@ void setCursor( const SCCOL& nCol, const SCROW& nRow, const uno::Reference< fra if ( bInSel ) pShell->SetCursor( nCol, nRow ); else - pShell->MoveCursorAbs( nCol, nRow, SC_FOLLOW_NONE, false, false, true, false ); + pShell->MoveCursorAbs( nCol, nRow, SC_FOLLOW_NONE, false, false, true ); } } diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx index 54b28e1..64aa830 100644 --- a/sc/source/ui/view/cellsh1.cxx +++ b/sc/source/ui/view/cellsh1.cxx @@ -720,7 +720,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq ) if ( nStartCol != nEndCol && nStartRow != nEndRow ) { - pDlg->SetEdStartValEnabled(false); + pDlg->SetEdStartValEnabled(); } if ( pDlg->Execute() == RET_OK ) @@ -1434,13 +1434,13 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq ) //check if horizontal shift will fit if ( !pData->GetDocument()->IsBlockEmpty( nStartTab, MAXCOL - nRangeSizeX, nStartY, - MAXCOL, nStartY + nRangeSizeY, false ) ) + MAXCOL, nStartY + nRangeSizeY ) ) nDisableShiftX = SC_CELL_SHIFT_DISABLE_RIGHT; //check if vertical shift will fit if ( !pData->GetDocument()->IsBlockEmpty( nStartTab, nStartX, MAXROW - nRangeSizeY, - nStartX + nRangeSizeX, MAXROW, false ) ) + nStartX + nRangeSizeX, MAXROW ) ) nDisableShiftY = SC_CELL_SHIFT_DISABLE_DOWN; if ( nDisableShiftX || nDisableShiftY ) diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx index 0f96121..0df3ad9 100644 --- a/sc/source/ui/view/cellsh3.cxx +++ b/sc/source/ui/view/cellsh3.cxx @@ -785,7 +785,7 @@ void ScCellShell::Execute( SfxRequest& rReq ) const ScMarkData& rMark = GetViewData()->GetMarkData(); if ( !rMark.IsMarked() && !rMark.IsMultiMarked() ) - pTabViewShell->MarkDataArea( true ); + pTabViewShell->MarkDataArea(); GetViewData()->GetSimpleArea( nStartCol,nStartRow,nStartTab, nEndCol,nEndRow,nEndTab ); diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx index 8a622c2..bc575d4 100644 --- a/sc/source/ui/view/drawview.cxx +++ b/sc/source/ui/view/drawview.cxx @@ -66,7 +66,7 @@ void ScDrawView::Construct() EnableExtendedMouseEventDispatcher(false); EnableExtendedCommandEventDispatcher(false); - SetFrameDragSingles(true); + SetFrameDragSingles(); SetMinMoveDistancePixel( 2 ); SetHitTolerancePixel( 2 ); @@ -87,7 +87,7 @@ void ScDrawView::Construct() SetLayerLocked( pLayer->GetName(), bProt || !bEx ); pLayer = rAdmin.GetLayerPerID(SC_LAYER_INTERN); if (pLayer) - SetLayerLocked( pLayer->GetName(), true ); + SetLayerLocked( pLayer->GetName() ); pLayer = rAdmin.GetLayerPerID(SC_LAYER_FRONT); if (pLayer) { @@ -104,7 +104,7 @@ void ScDrawView::Construct() SetLayerVisible( pLayer->GetName(), false); } - SetSwapAsynchron(true); + SetSwapAsynchron(); } else { diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx index a4f6a0a..315afb3 100644 --- a/sc/source/ui/view/formatsh.cxx +++ b/sc/source/ui/view/formatsh.cxx @@ -371,7 +371,7 @@ void ScFormatShell::ExecuteStyle( SfxRequest& rReq ) OUString aStyleName; sal_uInt16 nRetMask = 0xffff; - pStylePool->SetSearchMask( eFamily, SFXSTYLEBIT_ALL ); + pStylePool->SetSearchMask( eFamily ); switch ( nSlotId ) { @@ -1174,7 +1174,7 @@ void ScFormatShell::ExecuteNumFormat( SfxRequest& rReq ) SfxItemPool* pDocPool = GetViewData()->GetDocument()->GetPool(); SfxItemSet aNewSet( *pDocPool, ATTR_PATTERN_START, ATTR_PATTERN_END ); aNewSet.Put( *pItem ); - pTabViewShell->ApplyAttributes( &aNewSet, &rOldSet, true ); + pTabViewShell->ApplyAttributes( &aNewSet, &rOldSet ); } } break; diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index 1a3afa7..00ad26e 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -4324,7 +4324,7 @@ sal_Int8 ScGridWindow::DropTransferObj( ScTransferObj* pTransObj, SCCOL nDestPos if ( bDone ) { - pView->MarkRange( aDest, false, false ); + pView->MarkRange( aDest, false ); SCCOL nDCol = pViewData->GetCurX() - aSource.aStart.Col() + nCorrectCursorPosCol; SCROW nDRow = pViewData->GetCurY() - aSource.aStart.Row() + nCorrectCursorPosRow; @@ -4432,7 +4432,7 @@ sal_Int8 ScGridWindow::DropTransferObj( ScTransferObj* pTransObj, SCCOL nDestPos pView->EnterMatrix( aFormula.makeStringAndClear(), ::formula::FormulaGrammar::GRAM_NATIVE ); - pView->MarkRange( aDest, false, false ); + pView->MarkRange( aDest, false ); pView->SetCursor( aDest.aStart.Col(), aDest.aStart.Row() ); } @@ -4466,7 +4466,7 @@ sal_Int8 ScGridWindow::DropTransferObj( ScTransferObj* pTransObj, SCCOL nDestPos bDone = pView->PasteFromClip( IDF_ALL, pTransObj->GetDocument() ); // clip-doc if ( bDone ) { - pView->MarkRange( aDest, false, false ); + pView->MarkRange( aDest, false ); pView->SetCursor( aDest.aStart.Col(), aDest.aStart.Row() ); } } diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx index 4839bb9..3cb269d 100644 --- a/sc/source/ui/view/gridwin4.cxx +++ b/sc/source/ui/view/gridwin4.cxx @@ -745,7 +745,7 @@ void ScGridWindow::DrawContent(OutputDevice &rDevice, const ScTableInfo& rTableI aOutputData.DrawNoteMarks(*pContentDev); if ( !bLogicText ) - aOutputData.DrawStrings(false); // in pixel MapMode + aOutputData.DrawStrings(); // in pixel MapMode // edit cells and printer-metrics text must be before the buttons // (DataPilot buttons contain labels in UI font) @@ -1450,7 +1450,7 @@ void ScGridWindow::DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo aComboButton.SetPosPixel( aRect.TopLeft() ); aComboButton.SetSizePixel( aRect.GetSize() ); pContentDev->SetClipRegion(vcl::Region(aRect)); - aComboButton.Draw( false, false ); + aComboButton.Draw( false ); pContentDev->SetClipRegion(); // always called from Draw() without clip region aComboButton.SetPosPixel( aOldPos ); // restore old state aComboButton.SetSizePixel( aOldSize ); // for MouseUp/Down (AutoFilter) diff --git a/sc/source/ui/view/gridwin_dbgutil.cxx b/sc/source/ui/view/gridwin_dbgutil.cxx index 494edfc..a6d884d 100644 --- a/sc/source/ui/view/gridwin_dbgutil.cxx +++ b/sc/source/ui/view/gridwin_dbgutil.cxx @@ -41,7 +41,7 @@ void ScGridWindow::dumpColumnInformationPixel() SCTAB nTab = pViewData->GetTabNo(); for (SCCOL nCol = 0; nCol <= 20; ++nCol) { - sal_uInt16 nWidth = pDoc->GetColWidth(nCol, nTab, true); + sal_uInt16 nWidth = pDoc->GetColWidth(nCol, nTab); long nPixel = LogicToPixel(Point(nWidth, 0), MapMode(MAP_TWIP)).getX(); std::cout << "Column: " << nCol << ", Width: " << nPixel << "px" << std::endl; } @@ -53,7 +53,7 @@ void ScGridWindow::dumpColumnInformationHmm() SCTAB nTab = pViewData->GetTabNo(); for (SCCOL nCol = 0; nCol <= 20; ++nCol) { - sal_uInt16 nWidth = pDoc->GetColWidth(nCol, nTab, true); + sal_uInt16 nWidth = pDoc->GetColWidth(nCol, nTab); long nPixel = LogicToLogic(Point(nWidth, 0), MAP_TWIP, MAP_100TH_MM).getX(); std::cout << "Column: " << nCol << ", Width: " << nPixel << "hmm" << std::endl; } diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx index a84aa3b..f4378ba 100644 --- a/sc/source/ui/view/output.cxx +++ b/sc/source/ui/view/output.cxx @@ -1985,7 +1985,7 @@ void ScOutputData::FindChanged() ScFormulaCell* pFCell = rCell.mpFormula; if ( !bProgress && pFCell->GetDirty() ) { - ScProgress::CreateInterpretProgress(mpDoc, true); + ScProgress::CreateInterpretProgress(mpDoc); bProgress = true; } if (pFCell->IsRunning()) diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx index cd63e9d..97fd6da 100644 --- a/sc/source/ui/view/output2.cxx +++ b/sc/source/ui/view/output2.cxx @@ -1048,7 +1048,7 @@ static inline void lcl_CreateInterpretProgress( bool& bProgress, ScDocument* pDo { if ( !bProgress && pFCell->GetDirty() ) { - ScProgress::CreateInterpretProgress( pDoc, true ); + ScProgress::CreateInterpretProgress( pDoc ); bProgress = true; } } @@ -3138,7 +3138,7 @@ void ScOutputData::DrawEditStandard(DrawEditParam& rParam) } else { - rParam.mpEngine->Draw(mpDev, aLogicStart, 0); + rParam.mpEngine->Draw(mpDev, aLogicStart); } if (bClip) @@ -4110,7 +4110,7 @@ void ScOutputData::DrawEditStacked(DrawEditParam& rParam) } else { - rParam.mpEngine->Draw( mpDev, aLogicStart, 0 ); + rParam.mpEngine->Draw( mpDev, aLogicStart ); } if (bClip) @@ -4435,7 +4435,7 @@ void ScOutputData::DrawEditAsianVertical(DrawEditParam& rParam) // the whole output area, not the text itself aLogicStart.X() -= rParam.mpEngine->GetPaperSize().Width(); - rParam.mpEngine->Draw(mpDev, aLogicStart, 0); + rParam.mpEngine->Draw(mpDev, aLogicStart); if (bClip) { diff --git a/sc/source/ui/view/preview.cxx b/sc/source/ui/view/preview.cxx index 4336099..4706342 100644 --- a/sc/source/ui/view/preview.cxx +++ b/sc/source/ui/view/preview.cxx @@ -175,8 +175,8 @@ void ScPreview::UpdateDrawView() // nTab must be right // The DrawView takes over the Design-Mode from the Model // (Settings "In opening Draftmode"), therefore to restore here - pDrawView->SetDesignMode( true ); - pDrawView->SetPrintPreview( true ); + pDrawView->SetDesignMode(); + pDrawView->SetPrintPreview(); pDrawView->ShowSdrPage(pPage); } } @@ -513,7 +513,7 @@ void ScPreview::DoPrint( ScPreviewLocationData* pFillLocation ) pEditEng->SetRefMapMode(aMMMode); SfxItemSet* pEditDefaults = new SfxItemSet( pEditEng->GetEmptyItemSet() ); rDefPattern.FillEditItemSet(pEditDefaults); - pEditEng->SetDefaults(pEditDefaults, true); + pEditEng->SetDefaults(pEditDefaults); Color aTextColor(COL_LIGHTGRAY); pEditDefaults->Put(SvxColorItem(aTextColor, EE_CHAR_COLOR)); @@ -1105,13 +1105,13 @@ void ScPreview::MouseButtonUp( const MouseEvent& rMEvt ) { aLRItem.SetLeft( (long)( aButtonUpPt.X() / HMM_PER_TWIPS + aOffset.X() / HMM_PER_TWIPS )); rStyleSet.Put( aLRItem ); - pDocShell->SetModified(true); + pDocShell->SetModified(); } else if( bRightRulerChange && bRightRulerMove ) { aLRItem.SetRight( (long)( nWidth - aButtonUpPt.X() / HMM_PER_TWIPS - aOffset.X() / HMM_PER_TWIPS )); rStyleSet.Put( aLRItem ); - pDocShell->SetModified(true); + pDocShell->SetModified(); } ScStyleSaveData aNewData; @@ -1177,13 +1177,13 @@ void ScPreview::MouseButtonUp( const MouseEvent& rMEvt ) { aULItem.SetUpperValue( (sal_uInt16)( aButtonUpPt.Y() / HMM_PER_TWIPS + aOffset.Y() / HMM_PER_TWIPS ) ); rStyleSet.Put( aULItem ); - pDocShell->SetModified(true); + pDocShell->SetModified(); } else if( bBottomRulerMove && bBottomRulerChange ) { aULItem.SetLowerValue( (sal_uInt16)( nHeight - aButtonUpPt.Y() / HMM_PER_TWIPS - aOffset.Y() / HMM_PER_TWIPS ) ); rStyleSet.Put( aULItem ); - pDocShell->SetModified(true); + pDocShell->SetModified(); } else if( bHeaderRulerMove && bHeaderRulerChange ) { @@ -1197,7 +1197,7 @@ void ScPreview::MouseButtonUp( const MouseEvent& rMEvt ) SvxSetItem aNewHeader( static_cast<const SvxSetItem&>(rStyleSet.Get(ATTR_PAGE_HEADERSET)) ); aNewHeader.GetItemSet().Put( SvxSizeItem( ATTR_PAGE_SIZE, aHeaderSize ) ); rStyleSet.Put( aNewHeader ); - pDocShell->SetModified(true); + pDocShell->SetModified(); } } else if( bFooterRulerMove && bFooterRulerChange ) @@ -1212,7 +1212,7 @@ void ScPreview::MouseButtonUp( const MouseEvent& rMEvt ) SvxSetItem aNewFooter( static_cast<const SvxSetItem&>(rStyleSet.Get(ATTR_PAGE_FOOTERSET)) ); aNewFooter.GetItemSet().Put( SvxSizeItem( ATTR_PAGE_SIZE, aFooterSize ) ); rStyleSet.Put( aNewFooter ); - pDocShell->SetModified(true); + pDocShell->SetModified(); } } @@ -1281,7 +1281,7 @@ void ScPreview::MouseButtonUp( const MouseEvent& rMEvt ) { pDocShell->GetDocFunc().SetWidthOrHeight( true, aCols, nTab, SC_SIZE_DIRECT, (sal_uInt16)nNewColWidth, true, true); - pDocShell->SetModified(true); + pDocShell->SetModified(); } if ( ValidTab( nTab ) ) { diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx index aa13c16..cff117f 100644 --- a/sc/source/ui/view/printfun.cxx +++ b/sc/source/ui/view/printfun.cxx @@ -523,7 +523,7 @@ void ScPrintFunc::DrawToDev( ScDocument* pDoc, OutputDevice* pDev, double /* nPr { pDrawView.reset(new FmFormView( pModel, pDev )); pDrawView->ShowSdrPage(pDrawView->GetModel()->GetPage(nTab)); - pDrawView->SetPrintPreview( true ); + pDrawView->SetPrintPreview(); aOutputData.SetDrawView( pDrawView.get() ); } @@ -693,8 +693,7 @@ bool ScPrintFunc::AdjustPrintArea( bool bNew ) bChangeRow = true; } - pDoc->ExtendMerge( nStartCol,nStartRow, nEndCol,nEndRow, nPrintTab, - false ); // no Refresh, incl. Attrs + pDoc->ExtendMerge( nStartCol,nStartRow, nEndCol,nEndRow, nPrintTab ); // no Refresh, incl. Attrs if ( bChangeCol ) { @@ -1798,7 +1797,7 @@ void ScPrintFunc::PrintHF( long nPageNo, bool bHeader, long nStartY, long nDif = aPaperSize.Height() - (long) pEditEngine->GetTextHeight(); if (nDif > 0) aDraw.Y() += nDif / 2; - pEditEngine->Draw( pDev, aDraw, 0 ); + pEditEngine->Draw( pDev, aDraw ); } // center @@ -1812,7 +1811,7 @@ void ScPrintFunc::PrintHF( long nPageNo, bool bHeader, long nStartY, long nDif = aPaperSize.Height() - (long) pEditEngine->GetTextHeight(); if (nDif > 0) aDraw.Y() += nDif / 2; - pEditEngine->Draw( pDev, aDraw, 0 ); + pEditEngine->Draw( pDev, aDraw ); } // right @@ -1826,7 +1825,7 @@ void ScPrintFunc::PrintHF( long nPageNo, bool bHeader, long nStartY, long nDif = aPaperSize.Height() - (long) pEditEngine->GetTextHeight(); if (nDif > 0) aDraw.Y() += nDif / 2; - pEditEngine->Draw( pDev, aDraw, 0 ); + pEditEngine->Draw( pDev, aDraw ); } pDev->SetClipRegion(); @@ -1883,14 +1882,14 @@ long ScPrintFunc::DoNotes( long nNoteStart, bool bDoPrint, ScPreviewLocationData { if (bDoPrint) { - pEditEngine->Draw( pDev, Point( nPosX, nPosY ), 0 ); + pEditEngine->Draw( pDev, Point( nPosX, nPosY ) ); OUString aMarkStr(rPos.Format(SCA_VALID, pDoc, pDoc->GetAddressConvention())); aMarkStr += ":"; // cell position also via EditEngine, for correct positioning pEditEngine->SetText(aMarkStr); - pEditEngine->Draw( pDev, Point( aPageRect.Left(), nPosY ), 0 ); + pEditEngine->Draw( pDev, Point( aPageRect.Left(), nPosY ) ); } if ( pLocationData ) diff --git a/sc/source/ui/view/select.cxx b/sc/source/ui/view/select.cxx index 09169f1..fe1ffff 100644 --- a/sc/source/ui/view/select.cxx +++ b/sc/source/ui/view/select.cxx @@ -238,7 +238,7 @@ void ScViewFunctionSet::SetAnchor( SCCOL nPosX, SCROW nPosY ) if (bRefMode) { - pView->DoneRefMode( false ); + pView->DoneRefMode(); aAnchorPos.Set( nPosX, nPosY, nTab ); pView->InitRefMode( aAnchorPos.Col(), aAnchorPos.Row(), aAnchorPos.Tab(), SC_REFTYPE_REF ); @@ -721,11 +721,11 @@ void ScViewFunctionSet::DeselectAll() bool bRefMode = SC_MOD()->IsFormulaMode(); if (bRefMode) { - pViewData->GetView()->DoneRefMode( false ); + pViewData->GetView()->DoneRefMode(); } else { - pViewData->GetView()->DoneBlockMode( false ); + pViewData->GetView()->DoneBlockMode(); pViewData->GetViewShell()->UpdateInputHandler(); } @@ -912,7 +912,7 @@ void ScHeaderFunctionSet::DeselectAtPoint( const Point& /* rPointPixel */ ) void ScHeaderFunctionSet::DeselectAll() { - pViewData->GetView()->DoneBlockMode( false ); + pViewData->GetView()->DoneBlockMode(); bAnchor = false; } diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx index 9e4fcca..a273d9c 100644 --- a/sc/source/ui/view/tabview.cxx +++ b/sc/source/ui/view/tabview.cxx @@ -1389,7 +1389,7 @@ void ScTabView::UpdateHeaderWidth( const ScVSplitPos* pWhich, const SCROW* pPosY nEndPos = *pPosY; else nEndPos = aViewData.GetPosY( SC_SPLIT_BOTTOM ); - nEndPos += aViewData.CellsAtY( nEndPos, 1, SC_SPLIT_BOTTOM, SC_SIZE_NONE ); // VisibleCellsY + nEndPos += aViewData.CellsAtY( nEndPos, 1, SC_SPLIT_BOTTOM ); // VisibleCellsY if (nEndPos > MAXROW) nEndPos = lcl_LastVisible( aViewData ); @@ -1400,7 +1400,7 @@ void ScTabView::UpdateHeaderWidth( const ScVSplitPos* pWhich, const SCROW* pPosY nTopEnd = *pPosY; else nTopEnd = aViewData.GetPosY( SC_SPLIT_TOP ); - nTopEnd += aViewData.CellsAtY( nTopEnd, 1, SC_SPLIT_TOP, SC_SIZE_NONE );// VisibleCellsY + nTopEnd += aViewData.CellsAtY( nTopEnd, 1, SC_SPLIT_TOP );// VisibleCellsY if (nTopEnd > MAXROW) nTopEnd = lcl_LastVisible( aViewData ); @@ -2226,7 +2226,7 @@ void ScTabView::EnableRefInput(bool bFlag) // ab hier dynamisch angelegte - if(pTabControl!=nullptr) pTabControl->EnableInput(bFlag,true); + if(pTabControl!=nullptr) pTabControl->EnableInput(bFlag); if(pGridWin[SC_SPLIT_BOTTOMLEFT]!=nullptr) pGridWin[SC_SPLIT_BOTTOMLEFT]->EnableInput(bFlag,false); diff --git a/sc/source/ui/view/tabview2.cxx b/sc/source/ui/view/tabview2.cxx index 6d355f7..1df73e4 100644 --- a/sc/source/ui/view/tabview2.cxx +++ b/sc/source/ui/view/tabview2.cxx @@ -483,7 +483,7 @@ void ScTabView::MarkCursor( SCCOL nCurX, SCROW nCurY, SCTAB nCurZ, bool bOldShift = bMoveIsShift; bMoveIsShift = false; // wirklich umsetzen - DoneBlockMode(false); //! direkt Variablen setzen? (-> kein Geflacker) + DoneBlockMode(); //! direkt Variablen setzen? (-> kein Geflacker) bMoveIsShift = bOldShift; InitBlockMode( aMarkRange.aStart.Col(), aMarkRange.aStart.Row(), diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx index 80f7858..b434c4a 100644 --- a/sc/source/ui/view/tabview3.cxx +++ b/sc/source/ui/view/tabview3.cxx @@ -105,7 +105,7 @@ void ScTabView::ClickCursor( SCCOL nPosX, SCROW nPosY, bool bControl ) if ( bRefMode ) { - DoneRefMode( false ); + DoneRefMode(); if (bControl) SC_MOD()->AddRefEntry(); @@ -1535,7 +1535,7 @@ void ScTabView::SetTabNo( SCTAB nTab, bool bNew, bool bExtendSelection, bool bSa FmFormShell* pFormSh = aViewData.GetViewShell()->GetFormShell(); if (pFormSh) { - bool bAllowed = pFormSh->PrepareClose(true); + bool bAllowed = pFormSh->PrepareClose(); if (!bAllowed) { //! Fehlermeldung? oder macht das die FormShell selber? @@ -2381,7 +2381,7 @@ void ScTabView::ActivateView( bool bActivate, bool bFirst ) aViewData.Activate(bActivate); - PaintBlock(false); // Repaint, Markierung je nach Active-Status + PaintBlock(); // Repaint, Markierung je nach Active-Status if (!bActivate) HideAllCursors(); // Cursor diff --git a/sc/source/ui/view/tabview5.cxx b/sc/source/ui/view/tabview5.cxx index 971fe9c..c3f5516 100644 --- a/sc/source/ui/view/tabview5.cxx +++ b/sc/source/ui/view/tabview5.cxx @@ -335,7 +335,7 @@ void ScTabView::UpdateLayerLocks() pDrawView->SetLayerLocked( pLayer->GetName(), bProt || !bEx || bShared ); pLayer = rAdmin.GetLayerPerID(SC_LAYER_INTERN); if (pLayer) - pDrawView->SetLayerLocked( pLayer->GetName(), true ); + pDrawView->SetLayerLocked( pLayer->GetName() ); pLayer = rAdmin.GetLayerPerID(SC_LAYER_FRONT); if (pLayer) pDrawView->SetLayerLocked( pLayer->GetName(), bProt || bShared ); @@ -478,7 +478,7 @@ void ScTabView::DrawEnableAnim(bool bSet) { if ( !pDrawView->IsAnimationEnabled() ) { - pDrawView->SetAnimationEnabled(true); + pDrawView->SetAnimationEnabled(); // Animierte GIFs muessen wieder gestartet werden: ScDocument* pDoc = aViewData.GetDocument(); diff --git a/sc/source/ui/view/tabvwsh3.cxx b/sc/source/ui/view/tabvwsh3.cxx index f0fc87f..0e265f9 100644 --- a/sc/source/ui/view/tabvwsh3.cxx +++ b/sc/source/ui/view/tabvwsh3.cxx @@ -269,8 +269,7 @@ void ScTabViewShell::Execute( SfxRequest& rReq ) { // URL has to be decoded for escaped characters (%20) aAddress = INetURLObject::decode( aAddress, - INetURLObject::DECODE_WITH_CHARSET, - RTL_TEXTENCODING_UTF8 ); + INetURLObject::DECODE_WITH_CHARSET ); } bool bFound = false; diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx index 18857ae0..d6400db 100644 --- a/sc/source/ui/view/viewdata.cxx +++ b/sc/source/ui/view/viewdata.cxx @@ -1696,22 +1696,22 @@ SCROW ScViewData::CellsAtY( SCsROW nPosY, SCsROW nDir, ScVSplitPos eWhichY, sal_ SCCOL ScViewData::VisibleCellsX( ScHSplitPos eWhichX ) const { - return CellsAtX( GetPosX( eWhichX ), 1, eWhichX, SC_SIZE_NONE ); + return CellsAtX( GetPosX( eWhichX ), 1, eWhichX ); } SCROW ScViewData::VisibleCellsY( ScVSplitPos eWhichY ) const { - return CellsAtY( GetPosY( eWhichY ), 1, eWhichY, SC_SIZE_NONE ); + return CellsAtY( GetPosY( eWhichY ), 1, eWhichY ); } SCCOL ScViewData::PrevCellsX( ScHSplitPos eWhichX ) const { - return CellsAtX( GetPosX( eWhichX ), -1, eWhichX, SC_SIZE_NONE ); + return CellsAtX( GetPosX( eWhichX ), -1, eWhichX ); } SCROW ScViewData::PrevCellsY( ScVSplitPos eWhichY ) const { - return CellsAtY( GetPosY( eWhichY ), -1, eWhichY, SC_SIZE_NONE ); + return CellsAtY( GetPosY( eWhichY ), -1, eWhichY ); } bool ScViewData::GetMergeSizePixel( SCCOL nX, SCROW nY, long& rSizeXPix, long& rSizeYPix ) const diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx index 8ee3c3f..c085289 100644 --- a/sc/source/ui/view/viewfun2.cxx +++ b/sc/source/ui/view/viewfun2.cxx @@ -1739,7 +1739,7 @@ bool ScViewFunc::SearchAndReplace( const SvxSearchItem* pSearchItem, SfxViewFrame* pViewFrm = SfxViewFrame::Current(); if (pViewFrm) { - pViewFrm->ShowChildWindow(sc::SearchResultsDlgWrapper::GetChildWindowId(), true); + pViewFrm->ShowChildWindow(sc::SearchResultsDlgWrapper::GetChildWindowId()); SfxChildWindow* pWnd = pViewFrm->GetChildWindow(sc::SearchResultsDlgWrapper::GetChildWindowId()); if (pWnd) { diff --git a/sc/source/ui/view/viewfun3.cxx b/sc/source/ui/view/viewfun3.cxx index 6262601..d994e2b 100644 --- a/sc/source/ui/view/viewfun3.cxx +++ b/sc/source/ui/view/viewfun3.cxx @@ -683,7 +683,7 @@ void ScViewFunc::PasteFromTransferable( const uno::Reference<datatransfer::XTran PasteDataFormat( nFormatId, aDataHelper.GetTransferable(), GetViewData().GetCurX(), GetViewData().GetCurY(), - NULL, false, false ); + NULL, false ); } } } @@ -1145,7 +1145,7 @@ bool ScViewFunc::PasteFromClip( InsertDeleteFlags nFlags, ScDocument* pClipDoc, // content outside the clip area. for (SCTAB nClipTab=0; nClipTab < pClipDoc->GetTableCount(); nClipTab++) if ( pClipDoc->HasTable(nClipTab) ) - if ( pClipDoc->ExtendMerge( nClipStartX,nClipStartY, nUndoEndCol,nUndoEndRow, nClipTab, false ) ) + if ( pClipDoc->ExtendMerge( nClipStartX,nClipStartY, nUndoEndCol,nUndoEndRow, nClipTab ) ) bClipOver = true; nUndoEndCol -= nClipStartX + nClipSizeX; nUndoEndRow -= nClipStartY + nClipSizeY; // now contains only the difference added by ExtendMerge @@ -1158,7 +1158,7 @@ bool ScViewFunc::PasteFromClip( InsertDeleteFlags nFlags, ScDocument* pClipDoc, return false; } - pDoc->ExtendMergeSel( nStartCol,nStartRow, nUndoEndCol,nUndoEndRow, aFilteredMark, false ); + pDoc->ExtendMergeSel( nStartCol,nStartRow, nUndoEndCol,nUndoEndRow, aFilteredMark ); // check cell-protection @@ -1228,7 +1228,7 @@ bool ScViewFunc::PasteFromClip( InsertDeleteFlags nFlags, ScDocument* pClipDoc, if ( bCutMode ) { pRefUndoDoc = new ScDocument( SCDOCMODE_UNDO ); - pRefUndoDoc->InitUndo( pDoc, 0, nTabCount-1, false, false ); + pRefUndoDoc->InitUndo( pDoc, 0, nTabCount-1, false ); pUndoData = new ScRefUndoData( pDoc ); } @@ -1515,8 +1515,8 @@ bool ScViewFunc::PasteMultiRangesFromClip( if (pDoc->IsUndoEnabled()) { pUndoDoc.reset(new ScDocument(SCDOCMODE_UNDO)); - pUndoDoc->InitUndoSelected(pDoc, aMark, false, false); - pDoc->CopyToDocument(aMarkedRange, nUndoFlags, false, pUndoDoc.get(), &aMark, true); + pUndoDoc->InitUndoSelected(pDoc, aMark, false); + pDoc->CopyToDocument(aMarkedRange, nUndoFlags, false, pUndoDoc.get(), &aMark); } ::std::unique_ptr<ScDocument> pMixDoc; @@ -1525,8 +1525,8 @@ bool ScViewFunc::PasteMultiRangesFromClip( if ( nFlags & IDF_CONTENTS ) { pMixDoc.reset(new ScDocument(SCDOCMODE_UNDO)); - pMixDoc->InitUndoSelected(pDoc, aMark, false, false); - pDoc->CopyToDocument(aMarkedRange, IDF_CONTENTS, false, pMixDoc.get(), &aMark, true); + pMixDoc->InitUndoSelected(pDoc, aMark, false); + pDoc->CopyToDocument(aMarkedRange, IDF_CONTENTS, false, pMixDoc.get(), &aMark); } } @@ -1580,7 +1580,7 @@ bool ScViewFunc::PasteMultiRangesFromClip( if (bInsertCells) pUndoMgr->AddUndoAction(new ScUndoWrapper(pUndo), true); else - pUndoMgr->AddUndoAction(pUndo, false); + pUndoMgr->AddUndoAction(pUndo); pUndoMgr->LeaveListAction(); } @@ -1661,11 +1661,11 @@ bool ScViewFunc::PasteFromClipToMultiRanges( if (pDoc->IsUndoEnabled()) { pUndoDoc.reset(new ScDocument(SCDOCMODE_UNDO)); - pUndoDoc->InitUndoSelected(pDoc, aMark, false, false); + pUndoDoc->InitUndoSelected(pDoc, aMark, false); for (size_t i = 0, n = aRanges.size(); i < n; ++i) { pDoc->CopyToDocument( - *aRanges[i], nUndoFlags, false, pUndoDoc.get(), &aMark, true); + *aRanges[i], nUndoFlags, false, pUndoDoc.get(), &aMark); } } @@ -1675,11 +1675,11 @@ bool ScViewFunc::PasteFromClipToMultiRanges( if (nFlags & IDF_CONTENTS) { pMixDoc.reset(new ScDocument(SCDOCMODE_UNDO)); - pMixDoc->InitUndoSelected(pDoc, aMark, false, false); + pMixDoc->InitUndoSelected(pDoc, aMark, false); for (size_t i = 0, n = aRanges.size(); i < n; ++i) { pDoc->CopyToDocument( - *aRanges[i], IDF_CONTENTS, false, pMixDoc.get(), &aMark, true); + *aRanges[i], IDF_CONTENTS, false, pMixDoc.get(), &aMark); } } } @@ -1737,7 +1737,7 @@ bool ScViewFunc::PasteFromClipToMultiRanges( ScUndoPaste* pUndo = new ScUndoPaste( pDocSh, aRanges, aMark, pUndoDoc.release(), NULL, nFlags|nUndoFlags, NULL, false, &aOptions); - pUndoMgr->AddUndoAction(pUndo, false); + pUndoMgr->AddUndoAction(pUndo); pUndoMgr->LeaveListAction(); } diff --git a/sc/source/ui/view/viewfun6.cxx b/sc/source/ui/view/viewfun6.cxx index 20db7b0..2365234 100644 --- a/sc/source/ui/view/viewfun6.cxx +++ b/sc/source/ui/view/viewfun6.cxx @@ -199,7 +199,7 @@ void ScViewFunc::DetectiveMarkPred() else { ScRange aRange; - ScRefTokenHelper::getRangeFromToken(aRange, p, aCurPos, false); + ScRefTokenHelper::getRangeFromToken(aRange, p, aCurPos); if (aRange.aStart.Tab() != aCurPos.Tab()) { // The first precedent range is on a different sheet. Jump to it @@ -325,7 +325,7 @@ void ScViewFunc::InsertCurrentTime(short nReqFmt, const OUString& rUndoStr) EditView* pTableView = pInputHdl->GetTableView(); if (pTableView) pTableView->InsertText( aString); - pInputHdl->DataChanged( false, true); + pInputHdl->DataChanged( false ); } else { diff --git a/sc/source/ui/view/viewfun7.cxx b/sc/source/ui/view/viewfun7.cxx index 578e62e..311924e 100644 --- a/sc/source/ui/view/viewfun7.cxx +++ b/sc/source/ui/view/viewfun7.cxx @@ -133,7 +133,7 @@ void ScViewFunc::PasteDraw( const Point& rLogicPos, SdrModel* pModel, pDragEditView->GetSdrPageView()->GetPage() ) { if ( nDiffX != 0 || nDiffY != 0 ) - pDragEditView->MoveAllMarked(Size(nDiffX,nDiffY), false); + pDragEditView->MoveAllMarked(Size(nDiffX,nDiffY)); } else { diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx index ce48261..7375f18 100644 --- a/sc/source/ui/view/viewfunc.cxx +++ b/sc/source/ui/view/viewfunc.cxx @@ -1661,7 +1661,7 @@ void ScViewFunc::DeleteMulti( bool bRows, bool bRecord ) // all Formulas because of references SCTAB nTabCount = rDoc.GetTableCount(); - pUndoDoc->AddUndoTab( 0, nTabCount-1, false, false ); + pUndoDoc->AddUndoTab( 0, nTabCount-1, false ); rDoc.CopyToDocument( 0,0,0, MAXCOL,MAXROW,MAXTAB, IDF_FORMULA,false,pUndoDoc ); pUndoData = new ScRefUndoData( &rDoc ); @@ -1892,9 +1892,9 @@ void ScViewFunc::SetWidthOrHeight( if (bWidth) { if ( *itr == nFirstTab ) - pUndoDoc->InitUndo( &rDoc, *itr, *itr, true, false ); + pUndoDoc->InitUndo( &rDoc, *itr, *itr, true ); else - pUndoDoc->AddUndoTab( *itr, *itr, true, false ); + pUndoDoc->AddUndoTab( *itr, *itr, true ); rDoc.CopyToDocument( static_cast<SCCOL>(nStart), 0, *itr, static_cast<SCCOL>(nEnd), MAXROW, *itr, IDF_NONE, false, pUndoDoc ); @@ -2121,7 +2121,7 @@ void ScViewFunc::SetMarkedWidthOrHeight( bool bWidth, ScSizeMode eMode, sal_uInt SCTAB nTab = GetViewData().GetTabNo(); DoneBlockMode(); InitOwnBlockMode(); - rMark.SetMultiMarkArea( ScRange( nCol,nRow,nTab ), true ); + rMark.SetMultiMarkArea( ScRange( nCol,nRow,nTab ) ); MarkDataChanged(); } commit 4a2d17c3a15117e91b8d158aa24d7f084596554b Author: Noel Grandin <n...@peralex.com> Date: Wed Aug 12 15:11:12 2015 +0200 loplugin: defaultparams Change-Id: Idd291659ca786b7bd2755c8faf98edc51314687b diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx index 106cb58..ab70ebc 100644 --- a/sc/source/ui/navipi/content.cxx +++ b/sc/source/ui/navipi/content.cxx @@ -761,7 +761,7 @@ void ScContentTree::ObjectFresh( sal_uInt16 nType, SvTreeListEntry* pEntry ) if( pOldEntry ) { Expand(pParent); - Select( pOldEntry, true); + Select( pOldEntry ); } } } diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx index 04ec62b..e865dfc 100644 --- a/sc/source/ui/navipi/navipi.cxx +++ b/sc/source/ui/navipi/navipi.cxx @@ -421,7 +421,7 @@ void CommandToolBox::UpdateButtons() } else { - EnableItem( IID_CHANGEROOT, true ); + EnableItem( IID_CHANGEROOT ); bool bRootSet = rDlg.aLbEntries->GetRootType() != SC_CONTENT_ROOT; CheckItem( IID_CHANGEROOT, bRootSet ); } diff --git a/sc/source/ui/navipi/scenwnd.cxx b/sc/source/ui/navipi/scenwnd.cxx index eedca03..a8e53ab 100644 --- a/sc/source/ui/navipi/scenwnd.cxx +++ b/sc/source/ui/navipi/scenwnd.cxx @@ -87,7 +87,7 @@ void ScScenarioListBox::UpdateEntries( const std::vector<OUString> &aNewEntryLis aEntry.mbProtected = !(*iter).isEmpty() && (*iter)[0] != '0'; maEntries.push_back( aEntry ); - InsertEntry( aEntry.maName, LISTBOX_APPEND ); + InsertEntry( aEntry.maName ); } SetUpdateMode( true ); SetNoSelection(); diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx b/sc/source/ui/optdlg/calcoptionsdlg.cxx index dc41f5f..912a098 100644 --- a/sc/source/ui/optdlg/calcoptionsdlg.cxx +++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx @@ -91,7 +91,7 @@ ScCalcOptionsDialog::ScCalcOptionsDialog(vcl::Window* pParent, const ScCalcConfi get(mpFtMemory, "memory"); get(mpConversion,"comboConversion"); - mpConversion->SelectEntryPos(static_cast<sal_Int32>(rConfig.meStringConversion), true); + mpConversion->SelectEntryPos(static_cast<sal_Int32>(rConfig.meStringConversion)); mpConversion->SetSelectHdl(LINK(this, ScCalcOptionsDialog, ConversionModifiedHdl)); get(mpEmptyAsZero,"checkEmptyAsZero"); @@ -211,7 +211,7 @@ IMPL_LINK(ScCalcOptionsDialog, ConversionModifiedHdl, ListBox*, pConv ) break; case ScCalcConfig::StringConversion::ZERO: maConfig.mbEmptyStringAsZero = true; - mpEmptyAsZero->Check(true); + mpEmptyAsZero->Check(); mpEmptyAsZero->Enable(false); break; case ScCalcConfig::StringConversion::UNAMBIGUOUS: diff --git a/sc/source/ui/optdlg/tpformula.cxx b/sc/source/ui/optdlg/tpformula.cxx index 2e4643e..255d71a 100644 --- a/sc/source/ui/optdlg/tpformula.cxx +++ b/sc/source/ui/optdlg/tpformula.cxx @@ -125,14 +125,14 @@ void ScTpFormulaOptions::UpdateCustomCalcRadioButtons(bool bDefault) { if (bDefault) { - mpBtnCustomCalcDefault->Check(true); + mpBtnCustomCalcDefault->Check(); mpBtnCustomCalcCustom->Check(false); mpBtnCustomCalcDetails->Disable(); } else { mpBtnCustomCalcDefault->Check(false); - mpBtnCustomCalcCustom->Check(true); + mpBtnCustomCalcCustom->Check(); mpBtnCustomCalcDetails->Enable(); } } diff --git a/sc/source/ui/pagedlg/tphfedit.cxx b/sc/source/ui/pagedlg/tphfedit.cxx index a448183..4d907e0 100644 --- a/sc/source/ui/pagedlg/tphfedit.cxx +++ b/sc/source/ui/pagedlg/tphfedit.cxx @@ -234,7 +234,7 @@ void ScEditWindow::Paint( vcl::RenderContext& rRenderContext, const Rectangle& r pEdView->Paint(rRect); if( HasFocus() ) - pEdView->ShowCursor(true,true); + pEdView->ShowCursor(true); } void ScEditWindow::MouseMove( const MouseEvent& rMEvt ) @@ -283,7 +283,7 @@ void ScEditWindow::Command( const CommandEvent& rCEvt ) void ScEditWindow::GetFocus() { - pEdView->ShowCursor(true,true); + pEdView->ShowCursor(true); pActiveEdWnd = this; ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible > xTemp = xAcc; diff --git a/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx b/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx index 66c5fc9..270b68f 100644 --- a/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx +++ b/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx @@ -222,7 +222,7 @@ IMPL_LINK_NOARG(AlignmentPropertyPanel, CBOXMergnCellClkHdl) GetBindings()->GetDispatcher()->Execute(FID_MERGE_ON, SfxCallMode::RECORD); else GetBindings()->GetDispatcher()->Execute(FID_MERGE_OFF, SfxCallMode::RECORD); - GetBindings()->Invalidate(FID_MERGE_TOGGLE,true,false); + GetBindings()->Invalidate(FID_MERGE_TOGGLE,true); //modified end return 0; @@ -349,7 +349,7 @@ void AlignmentPropertyPanel::NotifyItemUpdate( } else if(eState == SfxItemState::DONTCARE) { - mpCBXWrapText->EnableTriState(true); + mpCBXWrapText->EnableTriState(); mpCBXWrapText->SetState(TRISTATE_INDET); } } @@ -367,7 +367,7 @@ void AlignmentPropertyPanel::NotifyItemUpdate( { mbMultiDisable = true; mpTextOrientBox->Disable(); - mpCBStacked->EnableTriState(true); + mpCBStacked->EnableTriState(); mpCBStacked->SetState(TRISTATE_INDET); } break; diff --git a/sc/source/ui/sidebar/CellBorderStyleControl.cxx b/sc/source/ui/sidebar/CellBorderStyleControl.cxx index 548be751..8a80d40 100644 --- a/sc/source/ui/sidebar/CellBorderStyleControl.cxx +++ b/sc/source/ui/sidebar/CellBorderStyleControl.cxx @@ -194,7 +194,7 @@ IMPL_LINK_TYPED(CellBorderStyleControl, TB1SelectHdl, ToolBox*, pToolBox, void) aBorderInner.SetValid( SvxBoxInfoItemValidFlags::RIGHT, 0 != (nValidFlags&FRM_VALID_RIGHT )); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::HORI, 0 != (nValidFlags&FRM_VALID_HINNER )); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::VERT, 0 != (nValidFlags&FRM_VALID_VINNER)); - aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true ); + aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISTANCE ); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISABLE, false ); mrCellAppearancePropertyPanel.GetBindings()->GetDispatcher()->Execute(SID_ATTR_BORDER, SfxCallMode::RECORD, &aBorderOuter, &aBorderInner, 0L); @@ -262,7 +262,7 @@ IMPL_LINK_TYPED(CellBorderStyleControl, TB2SelectHdl, ToolBox *, pToolBox, void) aBorderInner.SetValid( SvxBoxInfoItemValidFlags::RIGHT, 0 != (nValidFlags&FRM_VALID_RIGHT )); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::HORI, 0 != (nValidFlags&FRM_VALID_HINNER )); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::VERT, 0 != (nValidFlags&FRM_VALID_VINNER)); - aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true ); + aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISTANCE ); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISABLE, false ); mrCellAppearancePropertyPanel.GetBindings()->GetDispatcher()->Execute(SID_ATTR_BORDER, SfxCallMode::RECORD, &aBorderOuter, &aBorderInner, 0L); @@ -333,7 +333,7 @@ IMPL_LINK_TYPED(CellBorderStyleControl, TB3SelectHdl, ToolBox *, pToolBox, void) aBorderInner.SetValid( SvxBoxInfoItemValidFlags::RIGHT, 0 != (nValidFlags&FRM_VALID_RIGHT )); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::HORI, 0 != (nValidFlags&FRM_VALID_HINNER )); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::VERT, 0 != (nValidFlags&FRM_VALID_VINNER)); - aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true ); + aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISTANCE ); aBorderInner.SetValid( SvxBoxInfoItemValidFlags::DISABLE, false ); mrCellAppearancePropertyPanel.GetBindings()->GetDispatcher()->Execute(SID_ATTR_BORDER, SfxCallMode::RECORD, &aBorderOuter, &aBorderInner, 0L); diff --git a/sc/source/ui/sidebar/CellLineStyleValueSet.cxx b/sc/source/ui/sidebar/CellLineStyleValueSet.cxx index 7f3c644..dadc65d 100644 --- a/sc/source/ui/sidebar/CellLineStyleValueSet.cxx +++ b/sc/source/ui/sidebar/CellLineStyleValueSet.cxx @@ -28,7 +28,7 @@ CellLineStyleValueSet::CellLineStyleValueSet( vcl::Window* pParent, const ResId& pVDev(NULL), nSelItem(0) { - SetColCount( 1 ); + SetColCount(); SetLineCount( 9); } diff --git a/sc/source/ui/undo/undobase.cxx b/sc/source/ui/undo/undobase.cxx index a383eed..cecea86 100644 --- a/sc/source/ui/undo/undobase.cxx +++ b/sc/source/ui/undo/undobase.cxx @@ -408,7 +408,7 @@ void ScMultiBlockUndo::ShowBlock() SCTAB nTab = pViewShell->GetViewData().GetTabNo(); aRange.aStart.SetTab(nTab); aRange.aEnd.SetTab(nTab); - pViewShell->MarkRange(aRange, false, false); + pViewShell->MarkRange(aRange, false); for (size_t i = 1, n = maBlockRanges.size(); i < n; ++i) { diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx index 379d213..1430a12 100644 --- a/sc/source/ui/undo/undoblk.cxx +++ b/sc/source/ui/undo/undoblk.cxx @@ -556,7 +556,7 @@ void ScUndoDeleteCells::Redo() void ScUndoDeleteCells::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DeleteCells( eCmd, true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DeleteCells( eCmd ); } bool ScUndoDeleteCells::CanRepeat(SfxRepeatTarget& rTarget) const @@ -735,7 +735,7 @@ void ScUndoDeleteMulti::Repeat(SfxRepeatTarget& rTarget) { // if single selection if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DeleteCells( DEL_DELROWS, true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DeleteCells( DEL_DELROWS ); } bool ScUndoDeleteMulti::CanRepeat(SfxRepeatTarget& rTarget) const @@ -1766,7 +1766,7 @@ void ScUndoSelectionStyle::Repeat(SfxRepeatTarget& rTarget) } ScTabViewShell& rViewShell = *static_cast<ScTabViewTarget&>(rTarget).GetViewShell(); - rViewShell.SetStyleSheetToMarked( pStyleSheet, true ); + rViewShell.SetStyleSheetToMarked( pStyleSheet ); } } diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx index 764d717..3d84110 100644 --- a/sc/source/ui/undo/undoblk3.cxx +++ b/sc/source/ui/undo/undoblk3.cxx @@ -211,7 +211,7 @@ void ScUndoDeleteContents::Redo() void ScUndoDeleteContents::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DeleteContents( nFlags, true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DeleteContents( nFlags ); } bool ScUndoDeleteContents::CanRepeat(SfxRepeatTarget& rTarget) const @@ -481,7 +481,7 @@ void ScUndoSelectionAttr::Repeat(SfxRepeatTarget& rTarget) { ScTabViewShell& rViewShell = *static_cast<ScTabViewTarget&>(rTarget).GetViewShell(); if (pLineOuter) - rViewShell.ApplyPatternLines( *pApplyPattern, pLineOuter, pLineInner, true ); + rViewShell.ApplyPatternLines( *pApplyPattern, pLineOuter, pLineInner ); else rViewShell.ApplySelectionPattern( *pApplyPattern, true ); } @@ -628,10 +628,10 @@ void ScUndoAutoFill::Repeat(SfxRepeatTarget& rTarget) { ScTabViewShell& rViewShell = *static_cast<ScTabViewTarget&>(rTarget).GetViewShell(); if (eFillCmd==FILL_SIMPLE) - rViewShell.FillSimple( eFillDir, true ); + rViewShell.FillSimple( eFillDir ); else rViewShell.FillSeries( eFillDir, eFillCmd, eFillDateCmd, - fStartValue, fStepValue, fMaxValue, true ); + fStartValue, fStepValue, fMaxValue ); } } @@ -906,7 +906,7 @@ void ScUndoAutoFormat::Redo() void ScUndoAutoFormat::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->AutoFormat( nFormatNo, true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->AutoFormat( nFormatNo ); } bool ScUndoAutoFormat::CanRepeat(SfxRepeatTarget& rTarget) const @@ -1267,7 +1267,7 @@ void ScUndoConversion::Redo() void ScUndoConversion::Repeat( SfxRepeatTarget& rTarget ) { if( rTarget.ISA( ScTabViewTarget ) ) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DoSheetConversion( maConvParam, true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DoSheetConversion( maConvParam ); } bool ScUndoConversion::CanRepeat(SfxRepeatTarget& rTarget) const diff --git a/sc/source/ui/undo/undocell.cxx b/sc/source/ui/undo/undocell.cxx index c239686..c69c308 100644 --- a/sc/source/ui/undo/undocell.cxx +++ b/sc/source/ui/undo/undocell.cxx @@ -718,7 +718,7 @@ void ScUndoThesaurus::Redo() void ScUndoThesaurus::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DoThesaurus( true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->DoThesaurus(); } bool ScUndoThesaurus::CanRepeat(SfxRepeatTarget& rTarget) const diff --git a/sc/source/ui/undo/undodat.cxx b/sc/source/ui/undo/undodat.cxx index 9fd4702..f636c59 100644 --- a/sc/source/ui/undo/undodat.cxx +++ b/sc/source/ui/undo/undodat.cxx @@ -226,9 +226,9 @@ void ScUndoMakeOutline::Repeat(SfxRepeatTarget& rTarget) ScTabViewShell& rViewShell = *static_cast<ScTabViewTarget&>(rTarget).GetViewShell(); if (bMake) - rViewShell.MakeOutline( bColumns, true ); + rViewShell.MakeOutline( bColumns ); else - rViewShell.RemoveOutline( bColumns, true ); + rViewShell.RemoveOutline( bColumns ); } } @@ -415,9 +415,9 @@ void ScUndoOutlineBlock::Repeat(SfxRepeatTarget& rTarget) ScTabViewShell& rViewShell = *static_cast<ScTabViewTarget&>(rTarget).GetViewShell(); if (bShow) - rViewShell.ShowMarkedOutlines( true ); + rViewShell.ShowMarkedOutlines(); else - rViewShell.HideMarkedOutlines( true ); + rViewShell.HideMarkedOutlines(); } } @@ -503,7 +503,7 @@ void ScUndoRemoveAllOutlines::Redo() void ScUndoRemoveAllOutlines::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->RemoveAllOutlines( true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->RemoveAllOutlines(); } bool ScUndoRemoveAllOutlines::CanRepeat(SfxRepeatTarget& rTarget) const @@ -606,7 +606,7 @@ void ScUndoAutoOutline::Redo() void ScUndoAutoOutline::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->AutoOutline( true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->AutoOutline(); } bool ScUndoAutoOutline::CanRepeat(SfxRepeatTarget& rTarget) const @@ -1417,7 +1417,7 @@ void ScUndoRepeatDB::Redo() void ScUndoRepeatDB::Repeat(SfxRepeatTarget& rTarget) { if (rTarget.ISA(ScTabViewTarget)) - static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->RepeatDB( true ); + static_cast<ScTabViewTarget&>(rTarget).GetViewShell()->RepeatDB(); } bool ScUndoRepeatDB::CanRepeat(SfxRepeatTarget& rTarget) const diff --git a/sc/source/ui/undo/undotab.cxx b/sc/source/ui/undo/undotab.cxx index d7950c8..e6acdbd 100644 --- a/sc/source/ui/undo/undotab.cxx +++ b/sc/source/ui/undo/undotab.cxx @@ -415,7 +415,7 @@ void ScUndoDeleteTab::Repeat(SfxRepeatTarget& rTarget) if (rTarget.ISA(ScTabViewTarget)) { ScTabViewShell* pViewShell = static_cast<ScTabViewTarget&>(rTarget).GetViewShell(); - pViewShell->DeleteTable( pViewShell->GetViewData().GetTabNo(), true ); + pViewShell->DeleteTable( pViewShell->GetViewData().GetTabNo() ); } } diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx index f2f8193..7895ef9 100644 --- a/sc/source/ui/unoobj/cellsuno.cxx +++ b/sc/source/ui/unoobj/cellsuno.cxx @@ -1517,7 +1517,7 @@ const ScPatternAttr* ScCellRangesBase::GetCurrentAttrsDeep() if ( !pCurrentDeep && pDocShell ) { ScDocument& rDoc = pDocShell->GetDocument(); - pCurrentDeep = rDoc.CreateSelectionPattern( *GetMarkData(), true ); + pCurrentDeep = rDoc.CreateSelectionPattern( *GetMarkData() ); } return pCurrentDeep; } @@ -3605,7 +3605,7 @@ uno::Reference<sheet::XSheetCellRanges> SAL_CALL ScCellRangesBase::queryContentC } if (bAdd) - aMarkData.SetMultiMarkArea(aIter.GetPos(), true); + aMarkData.SetMultiMarkArea(aIter.GetPos()); } } @@ -3660,7 +3660,7 @@ uno::Reference<sheet::XSheetCellRanges> SAL_CALL ScCellRangesBase::queryFormulaC } if (bAdd) - aMarkData.SetMultiMarkArea(aIter.GetPos(), true); + aMarkData.SetMultiMarkArea(aIter.GetPos()); } } } @@ -3832,7 +3832,7 @@ uno::Reference<sheet::XSheetCellRanges> SAL_CALL ScCellRangesBase::queryPreceden { if ( bRecursive && !bFound && !aMarkData.IsAllMarked( aRefRange ) ) bFound = true; - aMarkData.SetMultiMarkArea(aRefRange, true); + aMarkData.SetMultiMarkArea(aRefRange); } } } @@ -3892,7 +3892,7 @@ uno::Reference<sheet::XSheetCellRanges> SAL_CALL ScCellRangesBase::queryDependen ScRange aCellRange(aCellIter.GetPos()); if ( bRecursive && !bFound && !aMarkData.IsAllMarked( aCellRange ) ) bFound = true; - aMarkData.SetMultiMarkArea(aCellRange, true); + aMarkData.SetMultiMarkArea(aCellRange); } } diff --git a/sc/source/ui/unoobj/chart2uno.cxx b/sc/source/ui/unoobj/chart2uno.cxx index bc67a5b..e0793a2 100644 --- a/sc/source/ui/unoobj/chart2uno.cxx +++ b/sc/source/ui/unoobj/chart2uno.cxx @@ -2269,7 +2269,6 @@ OUString SAL_CALL ScChart2DataProvider::convertRangeFromXML( const OUString& sXM throw ( uno::RuntimeException, lang::IllegalArgumentException, std::exception ) { const sal_Unicode cSep = ' '; - const sal_Unicode cQuote = '\''; if (!m_pDocument) { @@ -2281,14 +2280,14 @@ OUString SAL_CALL ScChart2DataProvider::convertRangeFromXML( const OUString& sXM while( nOffset >= 0 ) { OUString sToken; - ScRangeStringConverter::GetTokenByOffset( sToken, sXMLRange, nOffset, cSep, cQuote ); + ScRangeStringConverter::GetTokenByOffset( sToken, sXMLRange, nOffset, cSep ); if( nOffset >= 0 ) { // convert one address (remove dots) OUString aUIString(sToken); - sal_Int32 nIndex = ScRangeStringConverter::IndexOf( sToken, ':', 0, cQuote ); + sal_Int32 nIndex = ScRangeStringConverter::IndexOf( sToken, ':', 0 ); if ( nIndex >= 0 && nIndex < aUIString.getLength() - 1 && aUIString[nIndex + 1] == '.' ) aUIString = aUIString.replaceAt( nIndex + 1, 1, "" ); diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 059626c..693301d 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -551,8 +551,8 @@ Size ScModelObj::getDocumentSize() return aSize; // convert to twips - aSize.setWidth(rDoc.GetColWidth(0, nEndCol, nTab, true)); - aSize.setHeight(rDoc.GetRowHeight(0, nEndRow, nTab, true)); + aSize.setWidth(rDoc.GetColWidth(0, nEndCol, nTab)); + aSize.setHeight(rDoc.GetRowHeight(0, nEndRow, nTab)); return aSize; } @@ -1544,7 +1544,7 @@ void SAL_CALL ScModelObj::render( sal_Int32 nSelRenderer, const uno::Any& aSelec { pDrawView = new FmFormView( pModel, pDev ); pDrawView->ShowSdrPage(pDrawView->GetModel()->GetPage(nTab)); - pDrawView->SetPrintPreview( true ); + pDrawView->SetPrintPreview(); } ScRange aRange; @@ -1940,7 +1940,7 @@ void SAL_CALL ScModelObj::consolidate( if (pDocShell) { const ScConsolidateParam& rParam = xImpl->GetParam(); - pDocShell->DoConsolidate( rParam, true ); + pDocShell->DoConsolidate( rParam ); pDocShell->GetDocument().SetConsolidateDlgData( &rParam ); } } diff --git a/sc/source/ui/unoobj/styleuno.cxx b/sc/source/ui/unoobj/styleuno.cxx index 7bbce7a..c0d3372 100644 --- a/sc/source/ui/unoobj/styleuno.cxx +++ b/sc/source/ui/unoobj/styleuno.cxx @@ -1483,7 +1483,7 @@ void SAL_CALL ScStyleObj::setAllPropertiesToDefault() SvxBoxInfoItem aBoxInfoItem( ATTR_BORDER_INNER ); aBoxInfoItem.SetTable( false ); aBoxInfoItem.SetDist( true ); - aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true ); + aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE ); rSet.Put( aBoxInfoItem ); pDocShell->PageStyleModified( aStyleName, true ); commit f60c67c48621c9798020628bbccbec681a05a1c8 Author: Noel Grandin <n...@peralex.com> Date: Wed Aug 12 15:11:06 2015 +0200 loplugin: defaultparams Change-Id: I4f635044b93f74fb397a4e47535e91160fce456c diff --git a/sc/source/ui/docshell/datastream.cxx b/sc/source/ui/docshell/datastream.cxx index e2ab970..b847ddd 100644 --- a/sc/source/ui/docshell/datastream.cxx +++ b/sc/source/ui/docshell/datastream.cxx @@ -461,7 +461,7 @@ void DataStream::Refresh() // Hard recalc will repaint the grid area. mpDocShell->DoHardRecalc(true); - mpDocShell->SetDocumentModified(true); + mpDocShell->SetDocumentModified(); fTimes[ DEBUG_TIME_RECALC ] = getNow() - fStart; diff --git a/sc/source/ui/docshell/docfunc.cxx b/sc/source/ui/docshell/docfunc.cxx index 3e8752b..5c0cc2c 100644 --- a/sc/source/ui/docshell/docfunc.cxx +++ b/sc/source/ui/docshell/docfunc.cxx @@ -1444,7 +1444,7 @@ bool ScDocFunc::ApplyStyle( const ScMarkData& rMark, const OUString& rStyleName, rDoc.ApplySelectionStyle( (ScStyleSheet&)*pStyleSheet, rMark ); if (!AdjustRowHeight( aMultiRange )) - rDocShell.PostPaint( aMultiRange, PAINT_GRID, 0 ); + rDocShell.PostPaint( aMultiRange, PAINT_GRID ); aModificator.SetDocumentModified(); @@ -1768,7 +1768,7 @@ bool ScDocFunc::InsertCells( const ScRange& rRange, const ScMarkData* pTabMark, if ( bRecord ) { pRefUndoDoc = new ScDocument( SCDOCMODE_UNDO ); - pRefUndoDoc->InitUndo( &rDoc, 0, nTabCount-1, false, false ); + pRefUndoDoc->InitUndo( &rDoc, 0, nTabCount-1, false ); // pRefUndoDoc is filled in InsertCol / InsertRow @@ -2357,7 +2357,7 @@ bool ScDocFunc::DeleteCells( const ScRange& rRange, const ScMarkData* pTabMark, } pRefUndoDoc = new ScDocument( SCDOCMODE_UNDO ); - pRefUndoDoc->InitUndo( &rDoc, 0, nTabCount-1, false, false ); + pRefUndoDoc->InitUndo( &rDoc, 0, nTabCount-1, false ); pUndoData = new ScRefUndoData( &rDoc ); @@ -2410,7 +2410,7 @@ bool ScDocFunc::DeleteCells( const ScRange& rRange, const ScMarkData* pTabMark, pRefUndoDoc->DeleteAreaTab(nUndoStartCol,nUndoStartRow,nUndoEndCol,nUndoEndRow, *itr, IDF_ALL); // alle Tabellen anlegen, damit Formeln kopiert werden koennen: - pUndoDoc->AddUndoTab( 0, nTabCount-1, false, false ); + pUndoDoc->AddUndoTab( 0, nTabCount-1, false ); // kopieren mit bColRowFlags=false (#54194#) pRefUndoDoc->CopyToDocument(0,0,0,MAXCOL,MAXROW,MAXTAB,IDF_FORMULA,false,pUndoDoc,NULL,false); @@ -3413,7 +3413,7 @@ bool ScDocFunc::SetWidthOrHeight( pUndoDoc = new ScDocument( SCDOCMODE_UNDO ); if (bWidth) { - pUndoDoc->InitUndo( &rDoc, nTab, nTab, true, false ); + pUndoDoc->InitUndo( &rDoc, nTab, nTab, true ); rDoc.CopyToDocument( static_cast<SCCOL>(nStart), 0, nTab, static_cast<SCCOL>(nEnd), MAXROW, nTab, IDF_NONE, false, pUndoDoc ); } else diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx index f0b5d3a..2094ac3 100644 --- a/sc/source/ui/docshell/docsh.cxx +++ b/sc/source/ui/docshell/docsh.cxx @@ -675,7 +675,7 @@ void ScDocShell::Notify( SfxBroadcaster&, const SfxHint& rHint ) { // switching to shared mode has failed, the document should be opened readonly // TODO/LATER: And error message should be shown here probably - SetReadOnlyUI( true ); + SetReadOnlyUI(); } } #endif diff --git a/sc/source/ui/docshell/docsh3.cxx b/sc/source/ui/docshell/docsh3.cxx index 218bf4d..631e1fb 100644 --- a/sc/source/ui/docshell/docsh3.cxx +++ b/sc/source/ui/docshell/docsh3.cxx @@ -630,7 +630,7 @@ void ScDocShell::ExecuteChangeCommentDialog( ScChangeAction* pAction, vcl::Windo DateTime aDT = pAction->GetDateTime(); OUString aDate = ScGlobal::pLocaleData->getDate( aDT ); aDate += " "; - aDate += ScGlobal::pLocaleData->getTime( aDT, false, false ); + aDate += ScGlobal::pLocaleData->getTime( aDT, false ); SfxItemSet aSet( GetPool(), SID_ATTR_POSTIT_AUTHOR, SID_ATTR_POSTIT_AUTHOR, @@ -1267,7 +1267,7 @@ bool ScDocShell::MergeSharedDocument( ScDocShell* pSharedDocShell ) // only show changes from shared document aChangeViewSet.SetShowChanges( true ); aChangeViewSet.SetShowAccepted( true ); - aChangeViewSet.SetHasActionRange( true ); + aChangeViewSet.SetHasActionRange(); aChangeViewSet.SetTheActionRange( nStartShared, nEndShared ); aDocument.SetChangeViewSettings( aChangeViewSet ); @@ -1311,7 +1311,7 @@ bool ScDocShell::MergeSharedDocument( ScDocShell* pSharedDocShell ) // only show changes from shared document aChangeViewSet.SetShowChanges( true ); aChangeViewSet.SetShowAccepted( true ); - aChangeViewSet.SetHasActionRange( true ); + aChangeViewSet.SetHasActionRange(); aChangeViewSet.SetTheActionRange( nStartShared, nEndShared ); aDocument.SetChangeViewSettings( aChangeViewSet ); } diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx index 7da6c13..585fe94 100644 --- a/sc/source/ui/docshell/docsh4.cxx +++ b/sc/source/ui/docshell/docsh4.cxx @@ -764,7 +764,7 @@ void ScDocShell::Execute( SfxRequest& rReq ) SfxViewFrame* pViewFrm = SfxViewFrame::Current(); if ( pViewFrm ) { - pViewFrm->ShowChildWindow( ScAcceptChgDlgWrapper::GetChildWindowId(), true ); //@51669 + pViewFrm->ShowChildWindow( ScAcceptChgDlgWrapper::GetChildWindowId() ); //@51669 } if ( pBindings ) { @@ -795,7 +795,7 @@ void ScDocShell::Execute( SfxRequest& rReq ) ScChangeViewSettings aChangeViewSet; aChangeViewSet.SetShowChanges( true ); aChangeViewSet.SetShowAccepted( true ); - aChangeViewSet.SetHasActionRange( true ); + aChangeViewSet.SetHasActionRange(); aChangeViewSet.SetTheActionRange( nStart, nEnd ); aDocument.SetChangeViewSettings( aChangeViewSet ); @@ -1772,7 +1772,7 @@ void ScDocShell::GetStatePageStyle( SfxViewShell& /* rCaller */, void ScDocShell::GetState( SfxItemSet &rSet ) { - bool bTabView = GetBestViewShell(true) != NULL; + bool bTabView = GetBestViewShell() != NULL; SfxWhichIter aIter(rSet); for (sal_uInt16 nWhich = aIter.FirstWhich(); nWhich; nWhich = aIter.NextWhich()) diff --git a/sc/source/ui/docshell/docsh5.cxx b/sc/source/ui/docshell/docsh5.cxx index b34d9e9..c66fc65 100644 --- a/sc/source/ui/docshell/docsh5.cxx +++ b/sc/source/ui/docshell/docsh5.cxx @@ -1011,7 +1011,7 @@ IMPL_LINK_TYPED( ScDocShell, RefreshDBDataHdl, Timer*, pRefreshTimer, void ) { ScRange aRange; pDBData->GetArea( aRange ); - bool bContinue = aFunc.DoImport( aRange.aStart.Tab(), aImportParam, NULL, true, false ); //! Api-Flag as parameter + bool bContinue = aFunc.DoImport( aRange.aStart.Tab(), aImportParam, NULL, true ); //! Api-Flag as parameter // internal operations (sort, query, subtotal) only if no error if (bContinue) { diff --git a/sc/source/ui/docshell/docsh6.cxx b/sc/source/ui/docshell/docsh6.cxx index 3c5db06..5acc3dd 100644 --- a/sc/source/ui/docshell/docsh6.cxx +++ b/sc/source/ui/docshell/docsh6.cxx @@ -225,7 +225,7 @@ SfxStyleSheetBasePool* ScDocShell::GetStyleSheetPool() static void lcl_AdjustPool( SfxStyleSheetBasePool* pStylePool ) { - pStylePool->SetSearchMask(SFX_STYLE_FAMILY_PAGE, SFXSTYLEBIT_ALL); + pStylePool->SetSearchMask(SFX_STYLE_FAMILY_PAGE); SfxStyleSheetBase *pStyle = pStylePool->First(); while ( pStyle ) { diff --git a/sc/source/ui/docshell/olinefun.cxx b/sc/source/ui/docshell/olinefun.cxx index 9def268..8f3e3d0 100644 --- a/sc/source/ui/docshell/olinefun.cxx +++ b/sc/source/ui/docshell/olinefun.cxx @@ -343,7 +343,7 @@ bool ScOutlineDocFunc::SelectLevel( SCTAB nTab, bool bColumns, sal_uInt16 nLevel ScDocument* pUndoDoc = new ScDocument( SCDOCMODE_UNDO ); if (bColumns) { - pUndoDoc->InitUndo( &rDoc, nTab, nTab, true, false ); + pUndoDoc->InitUndo( &rDoc, nTab, nTab, true ); rDoc.CopyToDocument( static_cast<SCCOL>(nStart), 0, nTab, static_cast<SCCOL>(nEnd), MAXROW, nTab, IDF_NONE, false, pUndoDoc ); @@ -626,7 +626,7 @@ bool ScOutlineDocFunc::ShowOutline( SCTAB nTab, bool bColumns, sal_uInt16 nLevel ScDocument* pUndoDoc = new ScDocument( SCDOCMODE_UNDO ); if (bColumns) { - pUndoDoc->InitUndo( &rDoc, nTab, nTab, true, false ); + pUndoDoc->InitUndo( &rDoc, nTab, nTab, true ); rDoc.CopyToDocument( static_cast<SCCOL>(nStart), 0, nTab, static_cast<SCCOL>(nEnd), MAXROW, nTab, IDF_NONE, false, pUndoDoc ); @@ -710,7 +710,7 @@ bool ScOutlineDocFunc::HideOutline( SCTAB nTab, bool bColumns, sal_uInt16 nLevel ScDocument* pUndoDoc = new ScDocument( SCDOCMODE_UNDO ); if (bColumns) { - pUndoDoc->InitUndo( &rDoc, nTab, nTab, true, false ); + pUndoDoc->InitUndo( &rDoc, nTab, nTab, true ); rDoc.CopyToDocument( static_cast<SCCOL>(nStart), 0, nTab, static_cast<SCCOL>(nEnd), MAXROW, nTab, IDF_NONE, false, pUndoDoc ); diff --git a/sc/source/ui/drawfunc/drawsh5.cxx b/sc/source/ui/drawfunc/drawsh5.cxx index 5d2483a..772dabb 100644 --- a/sc/source/ui/drawfunc/drawsh5.cxx +++ b/sc/source/ui/drawfunc/drawsh5.cxx @@ -401,7 +401,7 @@ void ScDrawShell::ExecDrawFunc( SfxRequest& rReq ) rBindings.Invalidate( SID_OBJECT_MIRROR ); if (eMode == SDRDRAG_ROTATE && !pView->IsFrameDragSingles()) { - pView->SetFrameDragSingles( true ); + pView->SetFrameDragSingles(); rBindings.Invalidate( SID_BEZIER_EDIT ); } } @@ -418,7 +418,7 @@ void ScDrawShell::ExecDrawFunc( SfxRequest& rReq ) rBindings.Invalidate( SID_OBJECT_MIRROR ); if (eMode == SDRDRAG_MIRROR && !pView->IsFrameDragSingles()) { - pView->SetFrameDragSingles( true ); + pView->SetFrameDragSingles(); rBindings.Invalidate( SID_BEZIER_EDIT ); } } diff --git a/sc/source/ui/drawfunc/fuconcustomshape.cxx b/sc/source/ui/drawfunc/fuconcustomshape.cxx index d48f6da..6e3272a 100644 --- a/sc/source/ui/drawfunc/fuconcustomshape.cxx +++ b/sc/source/ui/drawfunc/fuconcustomshape.cxx @@ -153,7 +153,7 @@ bool FuConstCustomShape::KeyInput(const KeyEvent& rKEvt) void FuConstCustomShape::Activate() { - pView->SetCurrentObj( OBJ_CUSTOMSHAPE, SdrInventor ); + pView->SetCurrentObj( OBJ_CUSTOMSHAPE ); aNewPointer = Pointer( PointerStyle::DrawRect ); aOldPointer = pWindow->GetPointer(); diff --git a/sc/source/ui/drawfunc/fudraw.cxx b/sc/source/ui/drawfunc/fudraw.cxx index caa5102..767ba47 100644 --- a/sc/source/ui/drawfunc/fudraw.cxx +++ b/sc/source/ui/drawfunc/fudraw.cxx @@ -370,7 +370,7 @@ bool FuDraw::KeyInput(const KeyEvent& rKEvt) { // mark last object pView->UnmarkAllObj(); - pView->MarkNextObj(false); + pView->MarkNextObj(); // II if(pView->AreObjectsMarked()) @@ -553,7 +553,7 @@ bool FuDraw::KeyInput(const KeyEvent& rKEvt) // switch snapping off if(!bWasNoSnap) - ((SdrDragStat&)rDragStat).SetNoSnap(true); + ((SdrDragStat&)rDragStat).SetNoSnap(); if(bWasSnapEnabled) pView->SetSnapEnabled(false); diff --git a/sc/source/ui/drawfunc/fuins2.cxx b/sc/source/ui/drawfunc/fuins2.cxx index 226a4c4..03c8720 100644 --- a/sc/source/ui/drawfunc/fuins2.cxx +++ b/sc/source/ui/drawfunc/fuins2.cxx @@ -102,7 +102,7 @@ void lcl_ChartInit( const uno::Reference < embed::XEmbeddedObject >& xObj, ScVie ScMarkData& rMark = pViewData->GetMarkData(); if ( !rMark.IsMarked() ) - pViewData->GetView()->MarkDataArea( true ); + pViewData->GetView()->MarkDataArea(); if ( pViewData->GetSimpleArea( nCol1,nRow1,nTab1, nCol2,nRow2,nTab2 ) == SC_MARK_SIMPLE ) { @@ -457,7 +457,7 @@ FuInsertChart::FuInsertChart(ScTabViewShell* pViewSh, vcl::Window* pWin, ScDrawV bool bAutomaticMark = false; if ( !aMark.IsMarked() && !aMark.IsMultiMarked() ) { - pViewSh->GetViewData().GetView()->MarkDataArea( true ); + pViewSh->GetViewData().GetView()->MarkDataArea(); bAutomaticMark = true; } diff --git a/sc/source/ui/drawfunc/fusel.cxx b/sc/source/ui/drawfunc/fusel.cxx index 49d9b7764..f3e172d 100644 --- a/sc/source/ui/drawfunc/fusel.cxx +++ b/sc/source/ui/drawfunc/fusel.cxx @@ -438,7 +438,7 @@ bool FuSelection::MouseButtonUp(const MouseEvent& rMEvt) if (pView->PickObj(aMDPos, pView->getHitTolLog(), pObj, pPV, SdrSearchOptions::ALSOONMASTER | SdrSearchOptions::BEFOREMARK)) { pView->UnmarkAllObj(); - pView->MarkObj(pObj,pPV,false,false); + pView->MarkObj(pObj,pPV,false); return true; } } diff --git a/sc/source/ui/drawfunc/futext.cxx b/sc/source/ui/drawfunc/futext.cxx index 2cd2f5f..f9581a4 100644 --- a/sc/source/ui/drawfunc/futext.cxx +++ b/sc/source/ui/drawfunc/futext.cxx @@ -333,7 +333,7 @@ bool FuText::MouseButtonDown(const MouseEvent& rMEvt) pView->UnmarkAllObj(); ScViewData& rViewData = pViewShell->GetViewData(); rViewData.GetDispatcher().Execute(aSfxRequest.GetSlot(), SfxCallMode::SLOT | SfxCallMode::RECORD); - pView->MarkObj(pObj,pPV,false,false); + pView->MarkObj(pObj,pPV,false); pHdl=pView->PickHandle(aMDPos); pView->BegDragObj(aMDPos, nullptr, pHdl); diff --git a/sc/source/ui/formdlg/dwfunctr.cxx b/sc/source/ui/formdlg/dwfunctr.cxx index 372fae7..f189793 100644 --- a/sc/source/ui/formdlg/dwfunctr.cxx +++ b/sc/source/ui/formdlg/dwfunctr.cxx @@ -891,7 +891,7 @@ void ScFunctionDockWin::DoEnter() else { aString += "()"; - pEdView->InsertText(aString,false); + pEdView->InsertText(aString); pHdl->DataChanged(); } } diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx index f7453f0..b763e6f 100644 --- a/sc/source/ui/miscdlgs/acredlin.cxx +++ b/sc/source/ui/miscdlgs/acredlin.cxx @@ -822,7 +822,7 @@ void ScAcceptChgDlg::UpdateView() if(pParent!=NULL && pScChangeAction->IsDialogParent()) { if(!bFilterFlag) - pParent->EnableChildrenOnDemand(true); + pParent->EnableChildrenOnDemand(); else { bool bTestFlag = bHasFilterEntry; @@ -848,14 +848,14 @@ void ScAcceptChgDlg::UpdateView() pParent=pTheView->InsertEntry( aStrAllAccepted, static_cast< RedlinData * >(NULL), static_cast< SvTreeListEntry * >(NULL)); - pParent->EnableChildrenOnDemand(true); + pParent->EnableChildrenOnDemand(); } if(nRejectCount>0) { pParent=pTheView->InsertEntry( aStrAllRejected, static_cast< RedlinData * >(NULL), static_cast< SvTreeListEntry * >(NULL)); - pParent->EnableChildrenOnDemand(true); + pParent->EnableChildrenOnDemand(); } pTheView->SetUpdateMode(true); SetPointer(Pointer(PointerStyle::Arrow)); @@ -868,7 +868,7 @@ IMPL_LINK_NOARG(ScAcceptChgDlg, RefHandle) { sal_uInt16 nId =ScSimpleRefDlgWrapper::GetChildWindowId(); - ScSimpleRefDlgWrapper::SetDefaultPosSize(GetPosPixel(),GetSizePixel(),true); + ScSimpleRefDlgWrapper::SetDefaultPosSize(GetPosPixel(),GetSizePixel()); SC_MOD()->SetRefDialog( nId, true ); @@ -915,7 +915,7 @@ IMPL_LINK( ScAcceptChgDlg, RefInfoHandle, OUString*, pResult) Invalidate(); } nId = ScAcceptChgDlgWrapper::GetChildWindowId(); - pViewFrm->ShowChildWindow( nId, true ); + pViewFrm->ShowChildWindow( nId ); } else { @@ -1467,7 +1467,7 @@ void ScAcceptChgDlg::AppendChanges(ScChangeTrack* pChanges,sal_uLong nStartActio if(pParent!=NULL && pScChangeAction->IsDialogParent()) { if(!bFilterFlag) - pParent->EnableChildrenOnDemand(true); + pParent->EnableChildrenOnDemand(); else { bool bTestFlag = bHasFilterEntry; diff --git a/sc/source/ui/miscdlgs/anyrefdg.cxx b/sc/source/ui/miscdlgs/anyrefdg.cxx index c56cf72..422ca25 100644 --- a/sc/source/ui/miscdlgs/anyrefdg.cxx +++ b/sc/source/ui/miscdlgs/anyrefdg.cxx @@ -112,7 +112,7 @@ void ScFormulaReferenceHelper::enableInput( bool bEnable ) vcl::Window *pParent=pWin->GetParent(); if(pParent) { - pParent->EnableInput(bEnable,true); + pParent->EnableInput(bEnable); if(true) pViewSh->EnableRefInput(bEnable); } @@ -139,7 +139,7 @@ void ScFormulaReferenceHelper::ShowSimpleReference(const OUString& rStr) ScRangeList aRangeList; - pTabViewShell->DoneRefMode( false ); + pTabViewShell->DoneRefMode(); pTabViewShell->ClearHighlightRanges(); if( ParseWithNames( aRangeList, rStr, pDoc ) ) @@ -204,7 +204,7 @@ void ScFormulaReferenceHelper::ShowFormulaReference(const OUString& rStr) if (pTabViewShell && pScTokA) { - pTabViewShell->DoneRefMode( false ); + pTabViewShell->DoneRefMode(); pTabViewShell->ClearHighlightRanges(); pScTokA->Reset(); @@ -255,7 +255,7 @@ void ScFormulaReferenceHelper::HideReference( bool bDoneRefMode ) // In that case, RefMode was just started and must not be ended now. if ( bDoneRefMode ) - pTabViewShell->DoneRefMode( false ); + pTabViewShell->DoneRefMode(); pTabViewShell->ClearHighlightRanges(); } bHighlightRef=false; diff --git a/sc/source/ui/miscdlgs/crnrdlg.cxx b/sc/source/ui/miscdlgs/crnrdlg.cxx index 0c2531f..8d7c3f7 100644 --- a/sc/source/ui/miscdlgs/crnrdlg.cxx +++ b/sc/source/ui/miscdlgs/crnrdlg.cxx @@ -140,7 +140,7 @@ void ScColRowNameRangesDlg::Init() } else { - pBtnColHead->Check( true ); + pBtnColHead->Check(); pBtnRowHead->Check( false ); pEdAssign->SetText( EMPTY_OUSTRING ); pEdAssign2->SetText( EMPTY_OUSTRING ); @@ -168,7 +168,7 @@ void ScColRowNameRangesDlg::SetColRowData( const ScRange& rLabelRange, bool bRef SCROW nRow2 = theCurArea.aEnd.Row(); if ( (static_cast<SCCOLROW>(nCol2 - nCol1) >= nRow2 - nRow1) || (nCol1 == 0 && nCol2 == MAXCOL) ) { // Column headers and the limiting case of the whole sheet - pBtnColHead->Check( true ); + pBtnColHead->Check(); pBtnRowHead->Check( false ); if ( nRow2 == MAXROW ) { @@ -188,7 +188,7 @@ void ScColRowNameRangesDlg::SetColRowData( const ScRange& rLabelRange, bool bRef } else { // Column headers - pBtnRowHead->Check( true ); + pBtnRowHead->Check(); pBtnColHead->Check( false ); if ( nCol2 == MAXCOL ) { // Header at the right, data to the left @@ -561,7 +561,7 @@ IMPL_LINK_NOARG(ScColRowNameRangesDlg, AddBtnHdl) pBtnAdd->Disable(); pBtnRemove->Disable(); pEdAssign->SetText( EMPTY_OUSTRING ); - pBtnColHead->Check( true ); + pBtnColHead->Check(); pBtnRowHead->Check( false ); pEdAssign2->SetText( EMPTY_OUSTRING ); theCurArea = ScRange(); @@ -632,7 +632,7 @@ IMPL_LINK_NOARG(ScColRowNameRangesDlg, RemoveBtnHdl) pBtnRemove->Disable(); pEdAssign->SetText( EMPTY_OUSTRING ); theCurArea = theCurData = ScRange(); - pBtnColHead->Check( true ); + pBtnColHead->Check(); pBtnRowHead->Check( false ); pEdAssign2->SetText( EMPTY_OUSTRING ); Range1SelectHdl( 0 ); @@ -772,7 +772,7 @@ IMPL_LINK_NOARG(ScColRowNameRangesDlg, ColClickHdl) { if ( !pBtnColHead->GetSavedValue() ) { - pBtnColHead->Check( true ); + pBtnColHead->Check(); pBtnRowHead->Check( false ); if ( theCurArea.aStart.Row() == 0 && theCurArea.aEnd.Row() == MAXROW ) { @@ -793,7 +793,7 @@ IMPL_LINK_NOARG(ScColRowNameRangesDlg, RowClickHdl) { if ( !pBtnRowHead->GetSavedValue() ) { - pBtnRowHead->Check( true ); + pBtnRowHead->Check(); pBtnColHead->Check( false ); if ( theCurArea.aStart.Col() == 0 && theCurArea.aEnd.Col() == MAXCOL ) { diff --git a/sc/source/ui/miscdlgs/highred.cxx b/sc/source/ui/miscdlgs/highred.cxx index 6d75620..b9d893f 100644 --- a/sc/source/ui/miscdlgs/highred.cxx +++ b/sc/source/ui/miscdlgs/highred.cxx @@ -138,7 +138,7 @@ void ScHighlightChgDlg::Init() OUString aRefStr(pRangeEntry->Format(ABS_DREF3D, pDoc)); m_pFilterCtr->SetRange(aRefStr); } - m_pFilterCtr->Enable(true,true); + m_pFilterCtr->Enable(true); HighlightHandle(m_pHighlightBox); } @@ -189,13 +189,13 @@ IMPL_LINK( ScHighlightChgDlg, HighlightHandle, CheckBox*, pCb ) { if(m_pHighlightBox->IsChecked()) { - m_pFilterCtr->Enable(true,true); + m_pFilterCtr->Enable(true); m_pCbAccept->Enable(); m_pCbReject->Enable(); } else { - m_pFilterCtr->Disable(true); + m_pFilterCtr->Disable(); m_pCbAccept->Disable(); m_pCbReject->Disable(); } diff --git a/sc/source/ui/miscdlgs/inscodlg.cxx b/sc/source/ui/miscdlgs/inscodlg.cxx index 6d7d1ce..0b3357e 100644 --- a/sc/source/ui/miscdlgs/inscodlg.cxx +++ b/sc/source/ui/miscdlgs/inscodlg.cxx @@ -98,18 +98,18 @@ ScInsertContentsDlg::ScInsertContentsDlg( vcl::Window* pParent, switch( ScInsertContentsDlg::nPreviousFormulaChecks ) { - case PASTE_NOFUNC: mpRbNoOp->Check(true); break; - case PASTE_ADD: mpRbAdd->Check(true); break; - case PASTE_SUB: mpRbSub->Check(true); break; - case PASTE_MUL: mpRbMul->Check(true); break; - case PASTE_DIV: mpRbDiv->Check(true); break; + case PASTE_NOFUNC: mpRbNoOp->Check(); break; + case PASTE_ADD: mpRbAdd->Check(); break; + case PASTE_SUB: mpRbSub->Check(); break; + case PASTE_MUL: mpRbMul->Check(); break; + case PASTE_DIV: mpRbDiv->Check(); break; } switch( ScInsertContentsDlg::nPreviousMoveMode ) { - case INS_NONE: mpRbMoveNone->Check(true); break; - case INS_CELLSDOWN: mpRbMoveDown->Check(true); break; - case INS_CELLSRIGHT: mpRbMoveRight->Check(true); break; + case INS_NONE: mpRbMoveNone->Check(); break; + case INS_CELLSDOWN: mpRbMoveDown->Check(); break; + case INS_CELLSRIGHT: mpRbMoveRight->Check(); break; } mpBtnSkipEmptyCells->Check( ( ScInsertContentsDlg::nPreviousChecks2 & INS_CONT_NOEMPTY ) != 0); @@ -236,7 +236,7 @@ void ScInsertContentsDlg::TestModes() mpRbMoveRight->Disable(); mpBtnInsAll->Disable(); - DisableChecks(true); + DisableChecks(); } else { @@ -264,7 +264,7 @@ void ScInsertContentsDlg::SetOtherDoc( bool bSet ) bOtherDoc = bSet; TestModes(); if ( bSet ) - mpRbMoveNone->Check(true); + mpRbMoveNone->Check(); } } @@ -275,7 +275,7 @@ void ScInsertContentsDlg::SetFillMode( bool bSet ) bFillMode = bSet; TestModes(); if ( bSet ) - mpRbMoveNone->Check(true); + mpRbMoveNone->Check(); } } @@ -286,7 +286,7 @@ void ScInsertContentsDlg::SetChangeTrack( bool bSet ) bChangeTrack = bSet; TestModes(); if ( bSet ) - mpRbMoveNone->Check(true); + mpRbMoveNone->Check(); } } @@ -300,9 +300,9 @@ void ScInsertContentsDlg::SetCellShiftDisabled( int nDisable ) bMoveRightDisabled = bRight; TestModes(); if ( bMoveDownDisabled && mpRbMoveDown->IsChecked() ) - mpRbMoveNone->Check(true); + mpRbMoveNone->Check(); if ( bMoveRightDisabled && mpRbMoveRight->IsChecked() ) - mpRbMoveNone->Check(true); + mpRbMoveNone->Check(); } } diff --git a/sc/source/ui/miscdlgs/instbdlg.cxx b/sc/source/ui/miscdlgs/instbdlg.cxx index 6b09fa4..11d0458 100644 --- a/sc/source/ui/miscdlgs/instbdlg.cxx +++ b/sc/source/ui/miscdlgs/instbdlg.cxx @@ -218,10 +218,10 @@ const OUString* ScInsertTableDlg::GetFirstTable( sal_uInt16* pN ) } else if ( nSelTabIndex < m_pLbTables->GetSelectEntryCount() ) { - aStrCurSelTable = m_pLbTables->GetSelectEntry( 0 ); + aStrCurSelTable = m_pLbTables->GetSelectEntry(); pStr = &aStrCurSelTable; if ( pN ) - *pN = m_pLbTables->GetSelectEntryPos( 0 ); + *pN = m_pLbTables->GetSelectEntryPos(); nSelTabIndex = 1; } @@ -369,7 +369,7 @@ IMPL_LINK_TYPED( ScInsertTableDlg, DialogClosedHdl, sfx2::FileDialogHelper*, _pF } else if ( bMustClose ) // execute slot FID_INS_TABLE_EXT and cancel file dialog - EndDialog( RET_CANCEL ); + EndDialog(); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sc/source/ui/miscdlgs/mvtabdlg.cxx b/sc/source/ui/miscdlgs/mvtabdlg.cxx index 7948d09..4359e1b 100644 --- a/sc/source/ui/miscdlgs/mvtabdlg.cxx +++ b/sc/source/ui/miscdlgs/mvtabdlg.cxx @@ -87,7 +87,7 @@ void ScMoveTableDlg::GetTabNameString( OUString& rString ) const void ScMoveTableDlg::SetForceCopyTable() { - pBtnCopy->Check(true); + pBtnCopy->Check(); pBtnMove->Disable(); pBtnCopy->Disable(); } @@ -206,7 +206,7 @@ void ScMoveTableDlg::Init() pLbDoc->SetSelectHdl ( LINK( this, ScMoveTableDlg, SelHdl ) ); pBtnCopy->SetToggleHdl( LINK( this, ScMoveTableDlg, CheckBtnHdl ) ); pEdTabName->SetModifyHdl( LINK( this, ScMoveTableDlg, CheckNameHdl ) ); - pBtnMove->Check( true ); + pBtnMove->Check(); pBtnCopy->Check( false ); pEdTabName->Enable(false); pFtWarn->Hide(); diff --git a/sc/source/ui/miscdlgs/optsolver.cxx b/sc/source/ui/miscdlgs/optsolver.cxx index bb55b6f..2cb6a11 100644 --- a/sc/source/ui/miscdlgs/optsolver.cxx +++ b/sc/source/ui/miscdlgs/optsolver.cxx @@ -125,7 +125,7 @@ IMPL_LINK( ScSolverSuccessDialog, ClickHdl, PushButton*, pBtn ) if (pBtn == m_pBtnOk) EndDialog(RET_OK); else - EndDialog(RET_CANCEL); + EndDialog(); return 0; } diff --git a/sc/source/ui/miscdlgs/protectiondlg.cxx b/sc/source/ui/miscdlgs/protectiondlg.cxx index 1e3b7d4..826689f 100644 --- a/sc/source/ui/miscdlgs/protectiondlg.cxx +++ b/sc/source/ui/miscdlgs/protectiondlg.cxx @@ -105,13 +105,13 @@ void ScTableProtectionDlg::Init() m_pOptionsListBox->InsertEntry(m_aSelectLockedCells); m_pOptionsListBox->InsertEntry(m_aSelectUnlockedCells); - m_pOptionsListBox->CheckEntryPos(0, true); - m_pOptionsListBox->CheckEntryPos(1, true); + m_pOptionsListBox->CheckEntryPos(0); + m_pOptionsListBox->CheckEntryPos(1); m_pOptionsListBox->SetUpdateMode(true); // Set the default state of the dialog. - m_pBtnProtect->Check(true); + m_pBtnProtect->Check(); m_pPassword1Edit->GrabFocus(); } diff --git a/sc/source/ui/miscdlgs/redcom.cxx b/sc/source/ui/miscdlgs/redcom.cxx index f9af84e..87c8527 100644 --- a/sc/source/ui/miscdlgs/redcom.cxx +++ b/sc/source/ui/miscdlgs/redcom.cxx @@ -114,7 +114,7 @@ void ScRedComDialog::ReInit(ScChangeAction *pAction) DateTime aDT = pChangeAction->GetDateTime(); OUString aDate = ScGlobal::pLocaleData->getDate( aDT ); aDate += " "; - aDate += ScGlobal::pLocaleData->getTime( aDT, false, false ); + aDate += ScGlobal::pLocaleData->getTime( aDT, false ); pDlg->ShowLastAuthor(aAuthor, aDate); pDlg->SetNote(aComment); diff --git a/sc/source/ui/miscdlgs/retypepassdlg.cxx b/sc/source/ui/miscdlgs/retypepassdlg.cxx index 019c3ea..662a2a9 100644 --- a/sc/source/ui/miscdlgs/retypepassdlg.cxx +++ b/sc/source/ui/miscdlgs/retypepassdlg.cxx @@ -375,8 +375,8 @@ void ScRetypePassInputDlg::Init() m_pPassword2Edit->SetModifyHdl(aLink); m_pBtnOk->Disable(); - m_pBtnRetypePassword->Check(true); - m_pBtnMatchOldPass->Check(true); + m_pBtnRetypePassword->Check(); + m_pBtnMatchOldPass->Check(); m_pPassword1Edit->GrabFocus(); } commit 9b7eda2b4c4ef88967f156450e8bf1fb7ca1669a Author: Noel Grandin <n...@peralex.com> Date: Wed Aug 12 15:10:57 2015 +0200 loplugin: defaultparams Change-Id: Ibf8328d5000d82d09d5621d3701039bcbdb49407 diff --git a/sc/source/ui/Accessibility/AccessibleEditObject.cxx b/sc/source/ui/Accessibility/AccessibleEditObject.cxx index c688165..f0dc5ef 100644 --- a/sc/source/ui/Accessibility/AccessibleEditObject.cxx +++ b/sc/source/ui/Accessibility/AccessibleEditObject.cxx @@ -122,7 +122,7 @@ void ScAccessibleEditObject::GotFocus() mbHasFocus = true; CommitFocusGained(); if (mpTextHelper) - mpTextHelper->SetFocus(true); + mpTextHelper->SetFocus(); } //===== XInterface ========================================================== @@ -376,7 +376,7 @@ void ScAccessibleEditObject::CreateTextHelper() const ScInputHandler* pInputHdl = SC_MOD()->GetInputHdl(); if ( pInputHdl && pInputHdl->IsEditMode() ) { - mpTextHelper->SetFocus(true); + mpTextHelper->SetFocus(); } else { diff --git a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx index fd790c3..682debe 100644 --- a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx +++ b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx @@ -730,7 +730,7 @@ void ScAccessibleSpreadsheet::RemoveSelection(ScMarkData &refScMarkData) for(; miRemove != m_mapSelectionSend.end() ;) { if (refScMarkData.IsCellMarked(miRemove->first.Col(),miRemove->first.Row(),true) || - refScMarkData.IsCellMarked(miRemove->first.Col(),miRemove->first.Row(),false) ) + refScMarkData.IsCellMarked(miRemove->first.Col(),miRemove->first.Row()) ) { ++miRemove; continue; diff --git a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx index 6a7467d..ddd48bd 100644 --- a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx +++ b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx @@ -110,7 +110,7 @@ ScAnalysisOfVarianceDialog::ScAnalysisOfVarianceDialog( mpSingleFactorRadio->SetToggleHdl( LINK( this, ScAnalysisOfVarianceDialog, FactorChanged ) ); mpTwoFactorRadio->SetToggleHdl( LINK( this, ScAnalysisOfVarianceDialog, FactorChanged ) ); - mpSingleFactorRadio->Check(true); + mpSingleFactorRadio->Check(); mpTwoFactorRadio->Check(false); FactorChanged(NULL); @@ -525,7 +525,7 @@ void ScAnalysisOfVarianceDialog::AnovaTwoFactor(AddressWalkerWriter& output, For // Degree of freedom aTemplate.setTemplate("=%TOTAL_DF% - %ROW_DF% - %COLUMN_DF%"); - aTemplate.applyAddress("%TOTAL_DF%", output.current(0,1,0)); + aTemplate.applyAddress("%TOTAL_DF%", output.current(0,1)); aTemplate.autoReplaceAddress("%ERROR_DF%", output.current()); output.writeFormula(aTemplate.getTemplate()); output.nextColumn(); diff --git a/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx b/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx index f423d6f..95ce7e5 100644 --- a/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx +++ b/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx @@ -108,7 +108,7 @@ void ScSamplingDialog::Init() mpSampleSize->SetMax( SAL_MAX_INT64 ); mpOutputRangeEdit->GrabFocus(); - mpPeriodicMethodRadio->Check(true); + mpPeriodicMethodRadio->Check(); ToggleSamplingMethod(NULL); } diff --git a/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx b/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx index 54b623a..54f13b5 100644 --- a/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx +++ b/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx @@ -128,7 +128,7 @@ void ScStatisticsInputOutputDialog::Init() mpGroupByColumnsRadio->SetToggleHdl( LINK( this, ScStatisticsInputOutputDialog, GroupByChanged ) ); mpGroupByRowsRadio->SetToggleHdl( LINK( this, ScStatisticsInputOutputDialog, GroupByChanged ) ); - mpGroupByColumnsRadio->Check(true); + mpGroupByColumnsRadio->Check(); mpGroupByRowsRadio->Check(false); } diff --git a/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx b/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx index ce7cdf7..b39fb16 100644 --- a/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx +++ b/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx @@ -113,7 +113,7 @@ void ScStatisticsTwoVariableDialog::Init() mpGroupByColumnsRadio->SetToggleHdl( LINK( this, ScStatisticsTwoVariableDialog, GroupByChanged ) ); mpGroupByRowsRadio->SetToggleHdl( LINK( this, ScStatisticsTwoVariableDialog, GroupByChanged ) ); - mpGroupByColumnsRadio->Check(true); + mpGroupByColumnsRadio->Check(); mpGroupByRowsRadio->Check(false); } diff --git a/sc/source/ui/app/drwtrans.cxx b/sc/source/ui/app/drwtrans.cxx index 8662cf4..a0883bf 100644 --- a/sc/source/ui/app/drwtrans.cxx +++ b/sc/source/ui/app/drwtrans.cxx @@ -556,7 +556,7 @@ bool ScDrawTransferObj::WriteObject( tools::SvRef<SotStorageStream>& rxOStm, voi ::comphelper::OStorageHelper::GetStorageFromURL( aTempFile.GetURL(), embed::ElementModes::READWRITE ); // write document storage - pEmbObj->SetupStorage( xWorkStore, SOFFICE_FILEFORMAT_CURRENT, false, false ); + pEmbObj->SetupStorage( xWorkStore, SOFFICE_FILEFORMAT_CURRENT, false ); // mba: no relative URLs for clipboard! SfxMedium aMedium( xWorkStore, OUString() ); diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 09308b8..f1b1837 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -320,7 +320,7 @@ static void lcl_Replace( EditView* pView, const OUString& rNewStr, const ESelect // Dummy InsertText for Update and Paint // To do that we need to cancel the selection from above (before QuickInsertText) - pView->InsertText( EMPTY_OUSTRING, false ); + pView->InsertText( EMPTY_OUSTRING ); sal_Int32 nLen = pEngine->GetTextLen(0); ESelection aSel( 0, nLen, 0, nLen ); @@ -372,7 +372,7 @@ void ScInputHandler::UpdateRange( sal_uInt16 nIndex, const ScRange& rNew ) } EditView* pActiveView = pTopView ? pTopView : pTableView; - pActiveView->ShowCursor( false, true ); + pActiveView->ShowCursor( false ); } else { @@ -1195,7 +1195,7 @@ void completeFunction( EditView* pView, const OUString& rInsert, bool& rParInser } } - pView->InsertText( aInsStr, false ); + pView->InsertText( aInsStr ); if ( bDoParen ) // Put cursor between parentheses { @@ -1503,12 +1503,12 @@ void ScInputHandler::UseColData() // When typing // When editing in input line, apply to both edit views if ( pTableView ) { - pTableView->InsertText( aIns, false ); + pTableView->InsertText( aIns ); pTableView->SetSelection( aSelection ); } if ( pTopView ) { - pTopView->InsertText( aIns, false ); + pTopView->InsertText( aIns ); pTopView->SetSelection( aSelection ); } @@ -1566,7 +1566,7 @@ void ScInputHandler::NextAutoEntry( bool bBack ) if ( pTableView ) { pTableView->DeleteSelected(); - pTableView->InsertText( aIns, false ); + pTableView->InsertText( aIns ); pTableView->SetSelection( ESelection( aSel.nEndPara, aSel.nStartPos + aIns.getLength(), aSel.nEndPara, aSel.nStartPos ) ); @@ -1574,7 +1574,7 @@ void ScInputHandler::NextAutoEntry( bool bBack ) if ( pTopView ) { pTopView->DeleteSelected(); - pTopView->InsertText( aIns, false ); + pTopView->InsertText( aIns ); pTopView->SetSelection( ESelection( aSel.nEndPara, aSel.nStartPos + aIns.getLength(), aSel.nEndPara, aSel.nStartPos ) ); @@ -1632,7 +1632,7 @@ void ScInputHandler::UpdateParenthesis() pEngine->QuickSetAttribs( aSet, aSelOther ); // Dummy InsertText for Update and Paint (selection is empty) - pTableView->InsertText( EMPTY_OUSTRING, false ); + pTableView->InsertText( EMPTY_OUSTRING ); bFound = true; } @@ -1706,7 +1706,7 @@ void ScInputHandler::UpdateActiveView() sal_uInt16 nCount = pEngine->GetViewCount(); if (nCount > 0) { - pTableView = pEngine->GetView(0); + pTableView = pEngine->GetView(); for (sal_uInt16 i=1; i<nCount; i++) { EditView* pThis = pEngine->GetView(i); @@ -1840,7 +1840,7 @@ void ScInputHandler::RemoveRangeFinder() pEngine->SetUpdateMode(true); EditView* pActiveView = pTopView ? pTopView : pTableView; - pActiveView->ShowCursor( false, true ); + pActiveView->ShowCursor( false ); DeleteRangeFinder(); // Deletes the list and the labels on the table } ... etc. - the rest is truncated _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits