basctl/source/basicide/basicbox.cxx | 4
basctl/source/basicide/baside2.cxx | 6
basctl/source/basicide/baside2b.cxx | 20
-
basctl/source/basicide/basides1.cxx | 4
basctl/source/basicide/basidesh.cxx | 6
basctl/source/basicide/bastype2.cxx | 2
basctl/source/basicide/bastypes.cxx | 4
basctl/source/basicide/brkdlg.cxx | 4
basctl/source/basicide/moduldl2.cxx | 2
basctl/source/dlged/dlged.cxx | 6
basctl/source/dlged/dlgedfunc.cxx | 6
basctl/source/dlged/dlgedobj.cxx | 20
-
chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx | 4
chart2/source/controller/dialogs/DataBrowserModel.cxx | 2
chart2/source/controller/dialogs/ObjectNameProvider.cxx | 8
chart2/source/controller/dialogs/res_DataLabel.cxx | 2
chart2/source/controller/dialogs/res_LegendPosition.cxx | 8
chart2/source/controller/dialogs/res_Trendline.cxx | 6
chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx | 18
-
chart2/source/controller/dialogs/tp_3D_SceneGeometry.cxx | 2
chart2/source/controller/dialogs/tp_AxisLabel.cxx | 8
chart2/source/controller/dialogs/tp_Scale.cxx | 12
-
chart2/source/controller/dialogs/tp_SeriesToAxis.cxx | 10
chart2/source/controller/dialogs/tp_TitleRotation.cxx | 2
chart2/source/controller/main/ChartController_Insert.cxx | 4
chart2/source/controller/main/ChartController_Window.cxx | 12
-
chart2/source/controller/main/ControllerCommandDispatch.cxx | 2
chart2/source/controller/main/ObjectHierarchy.cxx | 2
chart2/source/controller/sidebar/ChartErrorBarPanel.cxx | 6
chart2/source/inc/CommonFunctors.hxx | 6
chart2/source/model/template/BubbleDataInterpreter.cxx | 6
chart2/source/model/template/DataInterpreter.cxx | 2
chart2/source/model/template/XYDataInterpreter.cxx | 4
chart2/source/tools/LegendHelper.cxx | 2
chart2/source/view/axes/Tickmarks_Equidistant.cxx | 2
chart2/source/view/charttypes/PieChart.cxx | 2
chart2/source/view/charttypes/VSeriesPlotter.cxx | 2
chart2/source/view/diagram/VDiagram.cxx | 7
chart2/source/view/main/ChartView.cxx | 8
chart2/source/view/main/GL3DRenderer.cxx | 2
chart2/source/view/main/PlottingPositionHelper.cxx | 2
compilerplugins/clang/defaultparams.cxx | 26
+-
connectivity/source/drivers/file/FResultSet.cxx | 2
connectivity/source/drivers/firebird/PreparedStatement.cxx | 2
connectivity/source/drivers/flat/ETable.cxx | 14
-
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 2
connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx | 2
connectivity/source/drivers/postgresql/pq_statement.cxx | 4
cui/source/customize/cfg.cxx | 102
+++++-----
cui/source/customize/cfgutil.cxx | 10
cui/source/customize/eventdlg.cxx | 4
cui/source/customize/selector.cxx | 10
cui/source/dialogs/cuifmsearch.cxx | 12
-
cui/source/dialogs/hangulhanjadlg.cxx | 2
cui/source/dialogs/hyphen.cxx | 2
cui/source/dialogs/iconcdlg.cxx | 4
cui/source/dialogs/insdlg.cxx | 6
cui/source/dialogs/multipat.cxx | 6
cui/source/dialogs/postdlg.cxx | 2
cui/source/dialogs/scriptdlg.cxx | 8
cui/source/dialogs/zoom.cxx | 2
cui/source/options/certpath.cxx | 2
cui/source/options/fontsubs.cxx | 4
cui/source/options/optasian.cxx | 4
cui/source/options/optcolor.cxx | 2
cui/source/options/optctl.cxx | 4
cui/source/options/optdict.cxx | 2
cui/source/options/optfltr.cxx | 4
cui/source/options/optgdlg.cxx | 6
cui/source/options/optinet2.cxx | 14
-
cui/source/options/optjava.cxx | 8
cui/source/options/personalization.cxx | 6
cui/source/options/radiobtnbox.cxx | 2
cui/source/options/treeopt.cxx | 2
cui/source/tabpages/autocdlg.cxx | 34
+--
cui/source/tabpages/backgrnd.cxx | 6
cui/source/tabpages/border.cxx | 2
cui/source/tabpages/chardlg.cxx | 20
-
cui/source/tabpages/numpages.cxx | 32
+--
cui/source/tabpages/paragrph.cxx | 6
cui/source/tabpages/tabarea.cxx | 2
cui/source/tabpages/tabline.cxx | 2
cui/source/tabpages/tabstpge.cxx | 4
cui/source/tabpages/tpline.cxx | 2
dbaccess/source/core/api/SingleSelectQueryComposer.cxx | 6
dbaccess/source/core/api/querydescriptor.cxx | 2
dbaccess/source/core/dataaccess/ModelImpl.cxx | 2
dbaccess/source/core/dataaccess/documentdefinition.cxx | 4
dbaccess/source/core/recovery/subcomponentrecovery.cxx | 2
dbaccess/source/ext/macromigration/macromigrationdialog.cxx | 4
dbaccess/source/ui/app/AppController.cxx | 16
-
dbaccess/source/ui/app/AppIconControl.cxx | 2
dbaccess/source/ui/browser/unodatbr.cxx | 4
dbaccess/source/ui/control/FieldDescControl.cxx | 2
dbaccess/source/ui/control/tabletree.cxx | 2
dbaccess/source/ui/dlg/ConnectionHelper.cxx | 2
dbaccess/source/ui/dlg/RelationDlg.cxx | 16
-
dbaccess/source/ui/dlg/TextConnectionHelper.cxx | 8
dbaccess/source/ui/dlg/adminpages.cxx | 2
dbaccess/source/ui/dlg/adtabdlg.cxx | 4
dbaccess/source/ui/dlg/advancedsettings.cxx | 2
dbaccess/source/ui/dlg/dbwiz.cxx | 2
dbaccess/source/ui/dlg/dbwizsetup.cxx | 4
dbaccess/source/ui/dlg/dlgsave.cxx | 2
dbaccess/source/ui/dlg/indexdialog.cxx | 4
dbaccess/source/ui/dlg/tablespage.cxx | 2
dbaccess/source/ui/misc/WCPage.cxx | 14
-
dbaccess/source/ui/misc/WNameMatch.cxx | 8
dbaccess/source/ui/querydesign/JoinTableView.cxx | 4
dbaccess/source/ui/querydesign/QueryDesignView.cxx | 8
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx | 47
++--
dbaccess/source/ui/querydesign/TableWindowListBox.cxx | 8
dbaccess/source/ui/tabledesign/TEditControl.cxx | 4
dbaccess/source/ui/tabledesign/TableUndo.cxx | 4
desktop/source/deployment/registry/package/dp_package.cxx | 7
desktop/source/splash/splash.cxx | 8
embeddedobj/source/msole/olepersist.cxx | 2
extensions/source/abpilot/abpfinalpage.cxx | 4
extensions/source/bibliography/toolbar.cxx | 2
extensions/source/dbpilots/gridwizard.cxx | 2
extensions/source/dbpilots/groupboxwiz.cxx | 2
extensions/source/dbpilots/listcombowizard.cxx | 2
extensions/source/plugin/unx/npnapi.cxx | 2
extensions/source/plugin/unx/nppapi.cxx | 2
extensions/source/plugin/unx/sysplug.cxx | 2
extensions/source/propctrlr/browserlistbox.cxx | 2
extensions/source/propctrlr/eformshelper.hxx | 2
extensions/source/propctrlr/selectlabeldialog.cxx | 6
extensions/source/propctrlr/standardcontrol.cxx | 4
extensions/source/propctrlr/usercontrol.cxx | 8
extensions/source/scanner/sane.cxx | 8
extensions/source/scanner/sanedlg.cxx | 4
132 files changed, 440 insertions(+), 449 deletions(-)
New commits:
commit 719c55cda76e0a00b4530396ebcf25777588a250
Author: Noel Grandin <n...@peralex.com>
Date: Wed Aug 12 15:09:57 2015 +0200
loplugin: defaultparams
Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74
diff --git a/desktop/source/deployment/registry/package/dp_package.cxx
b/desktop/source/deployment/registry/package/dp_package.cxx
index ae19ed3..d9ae1e0 100644
--- a/desktop/source/deployment/registry/package/dp_package.cxx
+++ b/desktop/source/deployment/registry/package/dp_package.cxx
@@ -1087,9 +1087,7 @@ void BackendImpl::PackageImpl::exportTo(
{
// transfer every item of folder into zip:
Reference<sdbc::XResultSet> xResultSet(
- sourceContent.createCursor(
- Sequence<OUString>(),
- ::ucbhelper::INCLUDE_FOLDERS_AND_DOCUMENTS ) );
+ sourceContent.createCursor( Sequence<OUString>() ) );
ProgressLevel progress( xCmdEnv, OUString() );
while (xResultSet->next())
{
@@ -1590,8 +1588,7 @@ void BackendImpl::PackageImpl::scanLegacyBundle(
OUString ar [] = { OUString("Title"), OUString("IsFolder") };
Reference<sdbc::XResultSet> xResultSet(
ucbContent.createCursor(
- Sequence<OUString>( ar, ARLEN(ar) ),
- ::ucbhelper::INCLUDE_FOLDERS_AND_DOCUMENTS ) );
+ Sequence<OUString>( ar, ARLEN(ar) ) ) );
while (xResultSet->next())
{
checkAborted( abortChannel );
diff --git a/desktop/source/splash/splash.cxx b/desktop/source/splash/splash.cxx
index 3d004f4..6b64d25 100644
--- a/desktop/source/splash/splash.cxx
+++ b/desktop/source/splash/splash.cxx
@@ -203,7 +203,7 @@ void SAL_CALL SplashScreen::start(const OUString&,
sal_Int32 nRange)
_bProgressEnd = false;
SolarMutexGuard aSolarGuard;
if ( _eBitmapMode == BM_FULLSCREEN )
- pWindow->ShowFullScreenMode( true );
+ pWindow->ShowFullScreenMode();
pWindow->Show();
pWindow->Redraw();
}
@@ -229,7 +229,7 @@ void SAL_CALL SplashScreen::reset()
if (_bVisible && !_bProgressEnd )
{
if ( _eBitmapMode == BM_FULLSCREEN )
- pWindow->ShowFullScreenMode( true );
+ pWindow->ShowFullScreenMode();
pWindow->Show();
updateStatus();
}
@@ -246,7 +246,7 @@ void SAL_CALL SplashScreen::setText(const OUString& rText)
if (_bVisible && !_bProgressEnd)
{
if ( _eBitmapMode == BM_FULLSCREEN )
- pWindow->ShowFullScreenMode( true );
+ pWindow->ShowFullScreenMode();
pWindow->Show();
updateStatus();
}
@@ -261,7 +261,7 @@ void SAL_CALL SplashScreen::setValue(sal_Int32 nValue)
SolarMutexGuard aSolarGuard;
if (_bVisible && !_bProgressEnd) {
if ( _eBitmapMode == BM_FULLSCREEN )
- pWindow->ShowFullScreenMode( true );
+ pWindow->ShowFullScreenMode();
pWindow->Show();
if (nValue >= _iMax)
_iProgress = _iMax;
diff --git a/embeddedobj/source/msole/olepersist.cxx
b/embeddedobj/source/msole/olepersist.cxx
index 2b1995b..4c9e7d6 100644
--- a/embeddedobj/source/msole/olepersist.cxx
+++ b/embeddedobj/source/msole/olepersist.cxx
@@ -746,7 +746,7 @@ uno::Reference< io::XStream >
OleEmbeddedObject::TryToRetrieveCachedVisualRepres
#endif
}
- xResult =
TryToRetrieveCachedVisualRepresentation_Impl( xStream, false );
+ xResult =
TryToRetrieveCachedVisualRepresentation_Impl( xStream );
}
}
}
diff --git a/extensions/source/abpilot/abpfinalpage.cxx
b/extensions/source/abpilot/abpfinalpage.cxx
index 12dbd49..6c85546 100644
--- a/extensions/source/abpilot/abpfinalpage.cxx
+++ b/extensions/source/abpilot/abpfinalpage.cxx
@@ -60,9 +60,9 @@ namespace abp
m_pName->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
m_pLocation->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
m_pRegisterName->SetClickHdl( LINK( this, FinalPage, OnRegister ) );
- m_pRegisterName->Check(true);
+ m_pRegisterName->Check();
m_pEmbed->SetClickHdl( LINK( this, FinalPage, OnEmbed ) );
- m_pEmbed->Check(true);
+ m_pEmbed->Check();
OnEmbed(m_pEmbed);
}
diff --git a/extensions/source/bibliography/toolbar.cxx
b/extensions/source/bibliography/toolbar.cxx
index 65952f0..56aeb13 100644
--- a/extensions/source/bibliography/toolbar.cxx
+++ b/extensions/source/bibliography/toolbar.cxx
@@ -107,7 +107,7 @@ void BibTBListBoxListener::statusChanged(const
::com::sun::star::frame::FeatureS
aEntry = pStringArray[i];
pToolBar->InsertSourceEntry(aEntry);
}
- pToolBar->UpdateSourceList(true);
+ pToolBar->UpdateSourceList();
}
pToolBar->SelectSourceEntry(rEvt.FeatureDescriptor);
diff --git a/extensions/source/dbpilots/gridwizard.cxx
b/extensions/source/dbpilots/gridwizard.cxx
index 58515c1..9b55042 100644
--- a/extensions/source/dbpilots/gridwizard.cxx
+++ b/extensions/source/dbpilots/gridwizard.cxx
@@ -65,7 +65,7 @@ namespace dbp
// if we do not need the data source selection page ...
if (!needDatasourceSelection())
{ // ... skip it!
- skip(1);
+ skip();
m_bHadDataSelection = false;
}
}
diff --git a/extensions/source/dbpilots/groupboxwiz.cxx
b/extensions/source/dbpilots/groupboxwiz.cxx
index e6bc4d9..8cfd5cf 100644
--- a/extensions/source/dbpilots/groupboxwiz.cxx
+++ b/extensions/source/dbpilots/groupboxwiz.cxx
@@ -267,7 +267,7 @@ namespace dbp
if (bMoveLeft)
{
while (m_pExistingRadios->GetSelectEntryCount())
-
m_pExistingRadios->RemoveEntry(m_pExistingRadios->GetSelectEntryPos(0));
+
m_pExistingRadios->RemoveEntry(m_pExistingRadios->GetSelectEntryPos());
}
else
{
diff --git a/extensions/source/dbpilots/listcombowizard.cxx
b/extensions/source/dbpilots/listcombowizard.cxx
index 7feea7d..62c8405 100644
--- a/extensions/source/dbpilots/listcombowizard.cxx
+++ b/extensions/source/dbpilots/listcombowizard.cxx
@@ -61,7 +61,7 @@ namespace dbp
// if we do not need the data source selection page ...
if (!needDatasourceSelection())
{ // ... skip it!
- skip(1);
+ skip();
m_bHadDataSelection = false;
}
}
diff --git a/extensions/source/plugin/unx/npnapi.cxx
b/extensions/source/plugin/unx/npnapi.cxx
index 5d222af..1129fc8 100644
--- a/extensions/source/plugin/unx/npnapi.cxx
+++ b/extensions/source/plugin/unx/npnapi.cxx
@@ -524,7 +524,7 @@ IMPL_LINK( PluginConnector, WorkOnNewMessageHdl, Mediator*,
/*pMediator*/ )
{
MediatorMessage* pMessage;
CommandAtoms nCommand;
- while( (pMessage = GetNextMessage( false )) )
+ while( (pMessage = GetNextMessage()) )
{
nCommand = (CommandAtoms)pMessage->GetUINT32();
SAL_INFO(
diff --git a/extensions/source/plugin/unx/nppapi.cxx
b/extensions/source/plugin/unx/nppapi.cxx
index 2ea3af1..e55b14b 100644
--- a/extensions/source/plugin/unx/nppapi.cxx
+++ b/extensions/source/plugin/unx/nppapi.cxx
@@ -94,7 +94,7 @@ IMPL_LINK( PluginConnector, WorkOnNewMessageHdl, Mediator*,
/*pMediator*/ )
MediatorMessage* pMessage;
CommandAtoms nCommand;
- while( (pMessage = GetNextMessage( false )) )
+ while( (pMessage = GetNextMessage()) )
{
nCommand = (CommandAtoms)pMessage->GetUINT32();
SAL_INFO("extensions.plugin", GetCommandName(nCommand));
diff --git a/extensions/source/plugin/unx/sysplug.cxx
b/extensions/source/plugin/unx/sysplug.cxx
index e8a1af9..87b5885 100644
--- a/extensions/source/plugin/unx/sysplug.cxx
+++ b/extensions/source/plugin/unx/sysplug.cxx
@@ -103,7 +103,7 @@ UnxPluginComm::UnxPluginComm(
m_nCommPID = pid;
// wait for pluginapp.bin to start up
- if( ! WaitForMessage( 5000 ) )
+ if( ! WaitForMessage() )
{
SAL_WARN(
"extensions.plugin",
diff --git a/extensions/source/propctrlr/browserlistbox.cxx
b/extensions/source/propctrlr/browserlistbox.cxx
index fddd0ec..011d80c 100644
--- a/extensions/source/propctrlr/browserlistbox.cxx
+++ b/extensions/source/propctrlr/browserlistbox.cxx
@@ -1187,7 +1187,7 @@ namespace pcr
vcl::Window *pWindow = rLine.pLine->getControlWindow();
Edit* pControlWindowAsEdit = dynamic_cast<Edit*>(pWindow);
if (pControlWindowAsEdit)
- pControlWindowAsEdit->SetReadOnly(true);
+ pControlWindowAsEdit->SetReadOnly();
else
pWindow->Enable(false);
}
diff --git a/extensions/source/propctrlr/eformshelper.hxx
b/extensions/source/propctrlr/eformshelper.hxx
index a607e91..b3c819a 100644
--- a/extensions/source/propctrlr/eformshelper.hxx
+++ b/extensions/source/propctrlr/eformshelper.hxx
@@ -109,7 +109,7 @@ namespace pcr
/** checks whether the control model can be bound to any XSD data type
*/
- bool canBindToAnyDataType() const { return canBindToDataType( -1 );
}
+ bool canBindToAnyDataType() const { return canBindToDataType(); }
/** checks whether the control model is a source for list entries, as
supplied by XML data bindings
*/
diff --git a/extensions/source/propctrlr/selectlabeldialog.cxx
b/extensions/source/propctrlr/selectlabeldialog.cxx
index e9acfb1..cc842f9 100644
--- a/extensions/source/propctrlr/selectlabeldialog.cxx
+++ b/extensions/source/propctrlr/selectlabeldialog.cxx
@@ -123,19 +123,19 @@ namespace pcr
if (m_pInitialSelection)
{
m_pControlTree->MakeVisible(m_pInitialSelection, true);
- m_pControlTree->Select(m_pInitialSelection, true);
+ m_pControlTree->Select(m_pInitialSelection);
}
else
{
m_pControlTree->MakeVisible(m_pControlTree->First(), true);
if (m_pControlTree->FirstSelected())
m_pControlTree->Select(m_pControlTree->FirstSelected(), false);
- m_pNoAssignment->Check(true);
+ m_pNoAssignment->Check();
}
if (!m_bHaveAssignableControl)
{ // no controls which can be assigned
- m_pNoAssignment->Check(true);
+ m_pNoAssignment->Check();
m_pNoAssignment->Enable(false);
}
diff --git a/extensions/source/propctrlr/standardcontrol.cxx
b/extensions/source/propctrlr/standardcontrol.cxx
index ed4d1df..bdd97c6 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -693,7 +693,7 @@ namespace pcr
getTypedControlWindow()->SetDropDownLineCount( LB_DEFAULT_COUNT );
if ( ( nWinStyle & WB_READONLY ) != 0 )
{
- getTypedControlWindow()->SetReadOnly( true );
+ getTypedControlWindow()->SetReadOnly();
getTypedControlWindow()->Enable( true );
}
}
@@ -802,7 +802,7 @@ namespace pcr
getTypedControlWindow()->SetDropDownLineCount( LB_DEFAULT_COUNT );
if ( ( nWinStyle & WB_READONLY ) != 0 )
{
- getTypedControlWindow()->SetReadOnly( true );
+ getTypedControlWindow()->SetReadOnly();
getTypedControlWindow()->Enable( true );
}
}
diff --git a/extensions/source/propctrlr/usercontrol.cxx
b/extensions/source/propctrlr/usercontrol.cxx
index 0c42e18..43f09b4 100644
--- a/extensions/source/propctrlr/usercontrol.cxx
+++ b/extensions/source/propctrlr/usercontrol.cxx
@@ -72,13 +72,13 @@ namespace pcr
TreatAsNumber( true );
SvNumberFormatter* pFormatter = pSupplier->GetNumberFormatter();
- SetFormatter( pFormatter, true );
+ SetFormatter( pFormatter );
SetValue( 1234.56789 );
}
else
{
TreatAsNumber( false );
- SetFormatter( NULL, true );
+ SetFormatter( NULL );
SetText( "" );
}
}
@@ -218,7 +218,7 @@ namespace pcr
SvNumberFormatter* pFormatter =
rDesc.pSupplier->GetNumberFormatter();
if (pFormatter != getTypedControlWindow()->GetFormatter())
- getTypedControlWindow()->SetFormatter(pFormatter, true);
+ getTypedControlWindow()->SetFormatter(pFormatter);
getTypedControlWindow()->SetFormatKey(rDesc.nKey);
const SvNumberformat* pEntry =
getTypedControlWindow()->GetFormatter()->GetEntry(getTypedControlWindow()->GetFormatKey());
@@ -251,7 +251,7 @@ namespace pcr
if ( bFallback )
{
getTypedControlWindow()->TreatAsNumber(false);
- getTypedControlWindow()->SetFormatter(NULL, true);
+ getTypedControlWindow()->SetFormatter(NULL);
getTypedControlWindow()->SetText("");
m_nLastDecimalDigits = 0;
}
diff --git a/extensions/source/scanner/sane.cxx
b/extensions/source/scanner/sane.cxx
index cde7224..c5ff202 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -562,24 +562,24 @@ bool Sane::Start( BitmapTransporter& rBitmap )
double fTLx, fTLy, fResl = 0.0;
int nOption;
if( ( nOption = GetOptionByName( "tl-x" ) ) != -1 &&
- GetOptionValue( nOption, fTLx, 0 ) &&
+ GetOptionValue( nOption, fTLx ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
double fBRx;
if( ( nOption = GetOptionByName( "br-x" ) ) != -1 &&
- GetOptionValue( nOption, fBRx, 0 ) &&
+ GetOptionValue( nOption, fBRx ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
nWidthMM = (int)fabs(fBRx - fTLx);
}
}
if( ( nOption = GetOptionByName( "tl-y" ) ) != -1 &&
- GetOptionValue( nOption, fTLy, 0 ) &&
+ GetOptionValue( nOption, fTLy ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
double fBRy;
if( ( nOption = GetOptionByName( "br-y" ) ) != -1 &&
- GetOptionValue( nOption, fBRy, 0 ) &&
+ GetOptionValue( nOption, fBRy ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
nHeightMM = (int)fabs(fBRy - fTLy);
diff --git a/extensions/source/scanner/sanedlg.cxx
b/extensions/source/scanner/sanedlg.cxx
index 30b3778..f17bbe8 100644
--- a/extensions/source/scanner/sanedlg.cxx
+++ b/extensions/source/scanner/sanedlg.cxx
@@ -471,7 +471,7 @@ void SaneDlg::InitFields()
bSuccess = false;
if( nOption != -1 )
{
- bSuccess = mrSane.GetOptionValue( nOption, fValue, 0 );
+ bSuccess = mrSane.GetOptionValue( nOption, fValue );
if( bSuccess )
{
if( mrSane.GetOptionUnit( nOption ) == SANE_UNIT_MM )
@@ -677,7 +677,7 @@ IMPL_LINK( SaneDlg, ClickBtnHdl, Button*, pButton )
else if( pButton == mpCancelButton )
{
mrSane.Close();
- EndDialog( 0 );
+ EndDialog();
}
return 0;
}
commit 56af9ab6bb38f8b795295080308cdab7b97e8acc
Author: Noel Grandin <n...@peralex.com>
Date: Wed Aug 12 15:09:51 2015 +0200
loplugin: defaultparams
Change-Id: Ia66788f5db2da8c6259cd08f655b3cb7cb12ed59
diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
index e5ad27c..e97ebf0 100644
--- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
+++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
@@ -485,7 +485,7 @@ OUString
OSingleSelectQueryComposer::impl_getColumnRealName_throw(const Referenc
aNewName = aName;
else
{
- if(sTableName.indexOf('.',0) != -1)
+ if(sTableName.indexOf('.') != -1)
{
OUString aCatlog,aSchema,aTable;
::dbtools::qualifiedNameComponents(m_xMetaData,sTableName,aCatlog,aSchema,aTable,::dbtools::eInDataManipulation);
@@ -789,7 +789,7 @@ Reference< XNameAccess > SAL_CALL
OSingleSelectQueryComposer::getColumns( ) thr
OUString sSQL( aSQL.makeStringAndClear() );
// normalize the statement so that it doesn't contain any
application-level features anymore
OUString sError;
- const boost::scoped_ptr< OSQLParseNode > pStatementTree(
m_aSqlParser.parseTree( sError, sSQL, false ) );
+ const boost::scoped_ptr< OSQLParseNode > pStatementTree(
m_aSqlParser.parseTree( sError, sSQL ) );
OSL_ENSURE( pStatementTree.get(),
"OSingleSelectQueryComposer::getColumns: could not parse the column retrieval
statement!" );
if ( pStatementTree.get() )
if ( !pStatementTree->parseNodeToExecutableStatement( sSQL,
m_xConnection, m_aSqlParser, NULL ) )
@@ -1588,7 +1588,7 @@ void OSingleSelectQueryComposer::setConditionByColumn(
const Reference< XPropert
OUString sRealName,sTableName;
xColumn->getPropertyValue(PROPERTY_REALNAME) >>= sRealName;
xColumn->getPropertyValue(PROPERTY_TABLENAME) >>= sTableName;
- if(sTableName.indexOf('.',0) != -1)
+ if(sTableName.indexOf('.') != -1)
{
OUString aCatlog,aSchema,aTable;
::dbtools::qualifiedNameComponents(m_xMetaData,sTableName,aCatlog,aSchema,aTable,::dbtools::eInDataManipulation);
diff --git a/dbaccess/source/core/api/querydescriptor.cxx
b/dbaccess/source/core/api/querydescriptor.cxx
index 8426f8e..ea1cb5d 100644
--- a/dbaccess/source/core/api/querydescriptor.cxx
+++ b/dbaccess/source/core/api/querydescriptor.cxx
@@ -201,7 +201,7 @@ Reference< XNameAccess > SAL_CALL
OQueryDescriptor_Base::getColumns( ) throw (Ru
}
catch ( const Exception& )
{
- setColumnsOutOfDate( true );
+ setColumnsOutOfDate();
throw;
}
}
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 3010043..bfd6d43 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -563,7 +563,7 @@ namespace
try
{
- Reference< XStorage > xContainerStorage( _rModel.getStorage(
_eType, ElementModes::READWRITE ) );
+ Reference< XStorage > xContainerStorage( _rModel.getStorage(
_eType ) );
// note the READWRITE here: If the storage already existed before,
then the OpenMode will
// be ignored, anyway.
// If the storage did not yet exist, then it will be created. If
the database document
diff --git a/dbaccess/source/core/dataaccess/documentdefinition.cxx
b/dbaccess/source/core/dataaccess/documentdefinition.cxx
index af004ea..ffbd8df 100644
--- a/dbaccess/source/core/dataaccess/documentdefinition.cxx
+++ b/dbaccess/source/core/dataaccess/documentdefinition.cxx
@@ -765,7 +765,7 @@ void ODocumentDefinition::impl_showOrHideComponent_throw(
const bool i_bShow )
case EmbedStates::ACTIVE:
{
- Reference< XModel > xEmbeddedDoc( impl_getComponent_throw( true ),
UNO_QUERY_THROW );
+ Reference< XModel > xEmbeddedDoc( impl_getComponent_throw(),
UNO_QUERY_THROW );
Reference< XController > xEmbeddedController(
xEmbeddedDoc->getCurrentController(), UNO_SET_THROW );
Reference< XFrame > xEmbeddedFrame( xEmbeddedController->getFrame(),
UNO_SET_THROW );
Reference< XWindow > xEmbeddedWindow(
xEmbeddedFrame->getContainerWindow(), UNO_SET_THROW );
@@ -1802,7 +1802,7 @@ Reference< util::XCloseable >
ODocumentDefinition::impl_getComponent_throw( cons
Reference< util::XCloseable > ODocumentDefinition::getComponent() throw
(RuntimeException, std::exception)
{
::osl::MutexGuard aGuard( m_aMutex );
- return impl_getComponent_throw( true );
+ return impl_getComponent_throw();
}
namespace
diff --git a/dbaccess/source/core/recovery/subcomponentrecovery.cxx
b/dbaccess/source/core/recovery/subcomponentrecovery.cxx
index 465e021..c438a26 100644
--- a/dbaccess/source/core/recovery/subcomponentrecovery.cxx
+++ b/dbaccess/source/core/recovery/subcomponentrecovery.cxx
@@ -382,7 +382,7 @@ namespace dbaccess
// find a free sub storage name, and create Yet Another Sub Storage
const OUString& rBaseName( lcl_getComponentStorageBaseName( m_eType )
);
- const OUString sStorName = ::dbtools::createUniqueName(
xComponentsStorage.get(), rBaseName, true );
+ const OUString sStorName = ::dbtools::createUniqueName(
xComponentsStorage.get(), rBaseName );
const Reference< XStorage > xObjectStor(
xComponentsStorage->openStorageElement(
sStorName, ElementModes::READWRITE ), UNO_QUERY_THROW );
diff --git a/dbaccess/source/ext/macromigration/macromigrationdialog.cxx
b/dbaccess/source/ext/macromigration/macromigrationdialog.cxx
index 4264b78..4745d24a 100644
--- a/dbaccess/source/ext/macromigration/macromigrationdialog.cxx
+++ b/dbaccess/source/ext/macromigration/macromigrationdialog.cxx
@@ -197,7 +197,7 @@ namespace dbmm
break;
case STATE_BACKUP_DBDOC:
- enableState( STATE_MIGRATE, true );
+ enableState( STATE_MIGRATE );
// Note that the state is automatically disabled if the current
page
// (SaveDBDocPage) returns false in its canAdvance, not caring that
// we enabled it here.
@@ -294,7 +294,7 @@ namespace dbmm
// re-enable the UI
enableButtons( WizardButtonFlags::FINISH | WizardButtonFlags::NEXT,
true );
- enableState( STATE_SUMMARY, true );
+ enableState( STATE_SUMMARY );
updateTravelUI();
m_pData->bMigrationIsRunning = false;
diff --git a/dbaccess/source/ui/app/AppController.cxx
b/dbaccess/source/ui/app/AppController.cxx
index 274bd3b..a21e6f7 100644
--- a/dbaccess/source/ui/app/AppController.cxx
+++ b/dbaccess/source/ui/app/AppController.cxx
@@ -1493,16 +1493,16 @@ void OApplicationController::describeSupportedFeatures()
// this one should not appear under Tools->Customize->Keyboard
implDescribeSupportedFeature( ".uno:DBNewReportWithPreSelection",
-
SID_APP_NEW_REPORT_PRE_SEL,CommandGroup::INTERNAL );
- implDescribeSupportedFeature( ".uno:DBDSImport",
SID_DB_APP_DSIMPORT, CommandGroup::INTERNAL);
- implDescribeSupportedFeature( ".uno:DBDSExport",
SID_DB_APP_DSEXPORT, CommandGroup::INTERNAL);
- implDescribeSupportedFeature( ".uno:DBDBAdmin",
SID_DB_APP_DBADMIN, CommandGroup::INTERNAL);
+
SID_APP_NEW_REPORT_PRE_SEL );
+ implDescribeSupportedFeature( ".uno:DBDSImport",
SID_DB_APP_DSIMPORT);
+ implDescribeSupportedFeature( ".uno:DBDSExport",
SID_DB_APP_DSEXPORT);
+ implDescribeSupportedFeature( ".uno:DBDBAdmin",
SID_DB_APP_DBADMIN);
// status info
- implDescribeSupportedFeature( ".uno:DBStatusType",
SID_DB_APP_STATUS_TYPE, CommandGroup::INTERNAL);
- implDescribeSupportedFeature( ".uno:DBStatusDBName",
SID_DB_APP_STATUS_DBNAME, CommandGroup::INTERNAL);
- implDescribeSupportedFeature( ".uno:DBStatusUserName",
SID_DB_APP_STATUS_USERNAME, CommandGroup::INTERNAL);
- implDescribeSupportedFeature( ".uno:DBStatusHostName",
SID_DB_APP_STATUS_HOSTNAME, CommandGroup::INTERNAL);
+ implDescribeSupportedFeature( ".uno:DBStatusType",
SID_DB_APP_STATUS_TYPE);
+ implDescribeSupportedFeature( ".uno:DBStatusDBName",
SID_DB_APP_STATUS_DBNAME);
+ implDescribeSupportedFeature( ".uno:DBStatusUserName",
SID_DB_APP_STATUS_USERNAME);
+ implDescribeSupportedFeature( ".uno:DBStatusHostName",
SID_DB_APP_STATUS_HOSTNAME);
}
OApplicationView* OApplicationController::getContainer() const
diff --git a/dbaccess/source/ui/app/AppIconControl.cxx
b/dbaccess/source/ui/app/AppIconControl.cxx
index a4b7d02..d37b0a1 100644
--- a/dbaccess/source/ui/app/AppIconControl.cxx
+++ b/dbaccess/source/ui/app/AppIconControl.cxx
@@ -56,7 +56,7 @@ OApplicationIconControl::OApplicationIconControl(vcl::Window*
_pParent)
pEntry->SetUserData( new ElementType( aCategories[i].eType ) );
}
- SetChoiceWithCursor( true );
+ SetChoiceWithCursor();
SetSelectionMode(SINGLE_SELECTION);
}
diff --git a/dbaccess/source/ui/browser/unodatbr.cxx
b/dbaccess/source/ui/browser/unodatbr.cxx
index 9ea96f9..78f1c49 100644
--- a/dbaccess/source/ui/browser/unodatbr.cxx
+++ b/dbaccess/source/ui/browser/unodatbr.cxx
@@ -2587,7 +2587,7 @@ bool SbaTableQueryBrowser::implSelect( SvTreeListEntry*
_pEntry )
// not really loaded
m_pCurrentlyDisplayed = _pEntry;
// tell the new entry it has been selected
- selectPath(m_pCurrentlyDisplayed, true);
+ selectPath(m_pCurrentlyDisplayed);
// get the name of the data source currently selected
ensureConnection( m_pCurrentlyDisplayed, pConData->xConnection );
@@ -3757,7 +3757,7 @@ void SbaTableQueryBrowser::impl_cleanupDataSourceEntry(
const OUString& _rDataSo
{ // a table or query belonging to the deleted data source is currently
being displayed.
OSL_ENSURE( m_pTreeView->getListBox().GetRootLevelParent(
m_pCurrentlyDisplayed ) == pDataSourceEntry,
"SbaTableQueryBrowser::impl_cleanupDataSourceEntry: inconsistence
(1)!" );
- unloadAndCleanup( true );
+ unloadAndCleanup();
}
else
OSL_ENSURE(
diff --git a/dbaccess/source/ui/control/FieldDescControl.cxx
b/dbaccess/source/ui/control/FieldDescControl.cxx
index e953a25..6440a2c 100644
--- a/dbaccess/source/ui/control/FieldDescControl.cxx
+++ b/dbaccess/source/ui/control/FieldDescControl.cxx
@@ -926,7 +926,7 @@ void OFieldDescControl::ActivateAggregate( EControlType
eType )
pFormatText = CreateText(STR_FORMAT);
pFormatSample = VclPtr<OPropEditCtrl>::Create( this,
STR_HELP_FORMAT_CODE, -1, WB_BORDER );
- pFormatSample->SetReadOnly(true);
+ pFormatSample->SetReadOnly();
pFormatSample->Enable(false);
InitializeControl(pFormatSample,HID_TAB_ENT_FORMAT_SAMPLE,false);
diff --git a/dbaccess/source/ui/control/tabletree.cxx
b/dbaccess/source/ui/control/tabletree.cxx
index 7afce2e..1b23471 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -394,7 +394,7 @@ void OTableTreeListBox::implEmphasize(SvTreeListEntry*
_pEntry, bool _bChecked,
{
// remove the mark for all ancestors of the entry
if (GetModel()->HasParent(_pEntry))
- implEmphasize(GetParent(_pEntry), false, false, true);
+ implEmphasize(GetParent(_pEntry), false, false);
}
}
diff --git a/dbaccess/source/ui/dlg/ConnectionHelper.cxx
b/dbaccess/source/ui/dlg/ConnectionHelper.cxx
index f1ede4d..24d1ebd 100644
--- a/dbaccess/source/ui/dlg/ConnectionHelper.cxx
+++ b/dbaccess/source/ui/dlg/ConnectionHelper.cxx
@@ -205,7 +205,7 @@ namespace dbaui
INetURLObject aSelectedDirectory( sSelectedDirectory,
INetURLObject::WAS_ENCODED, RTL_TEXTENCODING_UTF8 );
// for UI purpose, we don't want to have the path encoded
- sSelectedDirectory = aSelectedDirectory.GetMainURL(
INetURLObject::DECODE_WITH_CHARSET, RTL_TEXTENCODING_UTF8 );
+ sSelectedDirectory = aSelectedDirectory.GetMainURL(
INetURLObject::DECODE_WITH_CHARSET );
setURLNoPrefix( sSelectedDirectory );
SetRoadmapStateValue(true);
diff --git a/dbaccess/source/ui/dlg/RelationDlg.cxx
b/dbaccess/source/ui/dlg/RelationDlg.cxx
index 5091399..a408c34 100644
--- a/dbaccess/source/ui/dlg/RelationDlg.cxx
+++ b/dbaccess/source/ui/dlg/RelationDlg.cxx
@@ -116,18 +116,18 @@ void ORelationDialog::Init(const
TTableConnectionData::value_type& _pConnectionD
{
case KeyRule::NO_ACTION:
case KeyRule::RESTRICT:
- m_pRB_NoCascUpd->Check( true );
+ m_pRB_NoCascUpd->Check();
break;
case KeyRule::CASCADE:
- m_pRB_CascUpd->Check( true );
+ m_pRB_CascUpd->Check();
break;
case KeyRule::SET_NULL:
- m_pRB_CascUpdNull->Check( true );
+ m_pRB_CascUpdNull->Check();
break;
case KeyRule::SET_DEFAULT:
- m_pRB_CascUpdDefault->Check( true );
+ m_pRB_CascUpdDefault->Check();
break;
}
@@ -136,18 +136,18 @@ void ORelationDialog::Init(const
TTableConnectionData::value_type& _pConnectionD
{
case KeyRule::NO_ACTION:
case KeyRule::RESTRICT:
- m_pRB_NoCascDel->Check( true );
+ m_pRB_NoCascDel->Check();
break;
case KeyRule::CASCADE:
- m_pRB_CascDel->Check( true );
+ m_pRB_CascDel->Check();
break;
case KeyRule::SET_NULL:
- m_pRB_CascDelNull->Check( true );
+ m_pRB_CascDelNull->Check();
break;
case KeyRule::SET_DEFAULT:
- m_pRB_CascDelDefault->Check( true );
+ m_pRB_CascDelDefault->Check();
break;
}
}
diff --git a/dbaccess/source/ui/dlg/TextConnectionHelper.cxx
b/dbaccess/source/ui/dlg/TextConnectionHelper.cxx
index 593ad22..a6b307d 100644
--- a/dbaccess/source/ui/dlg/TextConnectionHelper.cxx
+++ b/dbaccess/source/ui/dlg/TextConnectionHelper.cxx
@@ -109,7 +109,7 @@ namespace dbaui
m_pAccessTextFiles->SetToggleHdl(LINK(this, OTextConnectionHelper,
OnSetExtensionHdl));
m_pAccessCSVFiles->SetToggleHdl(LINK(this, OTextConnectionHelper,
OnSetExtensionHdl));
m_pAccessOtherFiles->SetToggleHdl(LINK(this, OTextConnectionHelper,
OnSetExtensionHdl));
- m_pAccessCSVFiles->Check(true);
+ m_pAccessCSVFiles->Check();
struct SectionDescriptor
{
@@ -393,12 +393,12 @@ namespace dbaui
void OTextConnectionHelper::SetExtension(const OUString& _rVal)
{
if (_rVal == "txt")
- m_pAccessTextFiles->Check(true);
+ m_pAccessTextFiles->Check();
else if (_rVal == "csv")
- m_pAccessCSVFiles->Check(true);
+ m_pAccessCSVFiles->Check();
else
{
- m_pAccessOtherFiles->Check(true);
+ m_pAccessOtherFiles->Check();
m_pExtensionExample->SetText(_rVal);
}
}
diff --git a/dbaccess/source/ui/dlg/adminpages.cxx
b/dbaccess/source/ui/dlg/adminpages.cxx
index 7282b7f..1b5dbba 100644
--- a/dbaccess/source/ui/dlg/adminpages.cxx
+++ b/dbaccess/source/ui/dlg/adminpages.cxx
@@ -63,7 +63,7 @@ namespace dbaui
,m_pItemSetHelper(NULL)
{
- SetExchangeSupport(true);
+ SetExchangeSupport();
}
SfxTabPage::sfxpg OGenericAdministrationPage::DeactivatePage(SfxItemSet*
_pSet)
diff --git a/dbaccess/source/ui/dlg/adtabdlg.cxx
b/dbaccess/source/ui/dlg/adtabdlg.cxx
index 769d3ff..cd5e097 100644
--- a/dbaccess/source/ui/dlg/adtabdlg.cxx
+++ b/dbaccess/source/ui/dlg/adtabdlg.cxx
@@ -382,7 +382,7 @@ void OAddTableDlg::impl_switchTo( ObjectList _eList )
switch ( _eList )
{
case Tables:
- m_pTableList->Show( true ); m_pCaseTables->Check( true );
+ m_pTableList->Show( true ); m_pCaseTables->Check();
m_pQueryList->Show( false ); m_pCaseQueries->Check( false );
m_xCurrentList.reset( new TableListFacade( *m_pTableList,
m_rContext.getConnection() ) );
m_pTableList->GrabFocus();
@@ -390,7 +390,7 @@ void OAddTableDlg::impl_switchTo( ObjectList _eList )
case Queries:
m_pTableList->Show( false ); m_pCaseTables->Check( false );
- m_pQueryList->Show( true ); m_pCaseQueries->Check( true );
+ m_pQueryList->Show( true ); m_pCaseQueries->Check();
m_xCurrentList.reset( new QueryListFacade( *m_pQueryList,
m_rContext.getConnection() ) );
m_pQueryList->GrabFocus();
break;
diff --git a/dbaccess/source/ui/dlg/advancedsettings.cxx
b/dbaccess/source/ui/dlg/advancedsettings.cxx
index c09ebab..45d57e7 100644
--- a/dbaccess/source/ui/dlg/advancedsettings.cxx
+++ b/dbaccess/source/ui/dlg/advancedsettings.cxx
@@ -106,7 +106,7 @@ namespace dbaui
// check whether this must be a tristate check box
const SfxPoolItem& rItem = _rCoreAttrs.Get( nItemId );
if ( rItem.ISA( OptionalBoolItem ) )
- (*setting->ppControl)->EnableTriState( true );
+ (*setting->ppControl)->EnableTriState();
}
}
diff --git a/dbaccess/source/ui/dlg/dbwiz.cxx b/dbaccess/source/ui/dlg/dbwiz.cxx
index 9d00028..60490c4 100644
--- a/dbaccess/source/ui/dlg/dbwiz.cxx
+++ b/dbaccess/source/ui/dlg/dbwiz.cxx
@@ -84,7 +84,7 @@ ODbTypeWizDialog::ODbTypeWizDialog(vcl::Window* _pParent
SetPageSizePixel(LogicToPixel(::Size(PAGE_X, PAGE_Y), MAP_APPFONT));
defaultButton(WizardButtonFlags::NEXT);
enableButtons(WizardButtonFlags::FINISH, false);
- enableAutomaticNextButtonState( true );
+ enableAutomaticNextButtonState();
m_pPrevPage->SetHelpId(HID_DBWIZ_PREVIOUS);
m_pNextPage->SetHelpId(HID_DBWIZ_NEXT);
diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx
b/dbaccess/source/ui/dlg/dbwizsetup.cxx
index 6dd40a7..9a3f2ed 100644
--- a/dbaccess/source/ui/dlg/dbwizsetup.cxx
+++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx
@@ -329,7 +329,7 @@ void ODbTypeWizDialogSetup::activateDatabasePath()
OSL_ENSURE( nCreateNewDBIndex != -1,
"ODbTypeWizDialogSetup::activateDatabasePath: the GeneralPage should have
prevented this!" );
activatePath( static_cast< PathId >( nCreateNewDBIndex + 1 ), true );
- enableState(PAGE_DBSETUPWIZARD_FINAL, true );
+ enableState(PAGE_DBSETUPWIZARD_FINAL );
enableButtons( WizardButtonFlags::FINISH, true);
}
break;
@@ -994,7 +994,7 @@ bool ODbTypeWizDialogSetup::SaveDatabaseDocument()
// wants us to load could be a non-database document. Instead, we
asynchronously
// open the selected document. Thus, the wizard's return value is
RET_CANCEL,
// which means to not continue loading the database document
- if ( !OWizardMachine::Finish( RET_CANCEL ) )
+ if ( !OWizardMachine::Finish() )
return false;
try
diff --git a/dbaccess/source/ui/dlg/dlgsave.cxx
b/dbaccess/source/ui/dlg/dlgsave.cxx
index ffeaba0..39239d8 100644
--- a/dbaccess/source/ui/dlg/dlgsave.cxx
+++ b/dbaccess/source/ui/dlg/dlgsave.cxx
@@ -339,7 +339,7 @@ void OSaveAsDlg::implInitOnlyTitle(const OUString& _rLabel)
m_pImpl->m_pSchema->Hide();
m_pImpl->m_pTitle->SetText(m_pImpl->m_aName);
- m_pImpl->m_pTitle->setCheck(false); // enable non valid sql chars as well
+ m_pImpl->m_pTitle->setCheck(); // enable non valid sql chars as well
}
void OSaveAsDlg::implInit()
diff --git a/dbaccess/source/ui/dlg/indexdialog.cxx
b/dbaccess/source/ui/dlg/indexdialog.cxx
index 72456c0..9f0e584 100644
--- a/dbaccess/source/ui/dlg/indexdialog.cxx
+++ b/dbaccess/source/ui/dlg/indexdialog.cxx
@@ -564,7 +564,7 @@ namespace dbaui
OSL_ENSURE(!m_bEditAgain, "DbaIndexDialog::OnCloseDialog: somebody
was faster than hell!");
// this means somebody entered a new name, which was invalid,
which cause us to posted us an event,
// and before the event arrived the user clicked onto "close".
VERY fast, this user ....
- m_pIndexList->EndEditing(false);
+ m_pIndexList->EndEditing();
if (m_bEditAgain)
// could not commit the new name (started a new - asynchronous
- edit trial)
return 1L;
@@ -778,7 +778,7 @@ namespace dbaui
m_pIndexList->EndSelection();
if (m_pIndexList->IsEditingActive())
- m_pIndexList->EndEditing(false);
+ m_pIndexList->EndEditing();
// commit the old data
if (m_pIndexList->FirstSelected() != m_pPreviousSelection)
diff --git a/dbaccess/source/ui/dlg/tablespage.cxx
b/dbaccess/source/ui/dlg/tablespage.cxx
index 5829902..b20f677 100644
--- a/dbaccess/source/ui/dlg/tablespage.cxx
+++ b/dbaccess/source/ui/dlg/tablespage.cxx
@@ -212,7 +212,7 @@ namespace dbaui
{
if ((1 == _rTableFilter.getLength()) && _rTableFilter[0] == "%")
{ // all tables visible
- CheckAll(true);
+ CheckAll();
}
else
implCheckTables( _rTableFilter );
diff --git a/dbaccess/source/ui/misc/WCPage.cxx
b/dbaccess/source/ui/misc/WCPage.cxx
index 3ddd917..19d2af7 100644
--- a/dbaccess/source/ui/misc/WCPage.cxx
+++ b/dbaccess/source/ui/misc/WCPage.cxx
@@ -70,14 +70,14 @@ OCopyTable::OCopyTable(vcl::Window * pParent)
get(m_pFT_KeyName, "keynamelabel");
get(m_pEdKeyName, "keyname");
- m_pEdTableName->SetMaxTextLen(EDIT_NOLIMIT);
+ m_pEdTableName->SetMaxTextLen();
if ( m_pParent->m_xDestConnection.is() )
{
if ( !m_pParent->supportsViews() )
m_pRB_View->Disable();
- m_pCB_UseHeaderLine->Check(true);
+ m_pCB_UseHeaderLine->Check();
m_bPKeyAllowed = m_pParent->supportsPrimaryKey();
m_pCB_PrimaryColumn->Enable(m_bPKeyAllowed);
@@ -341,26 +341,26 @@ void OCopyTable::setCreateStyleAction()
switch(m_pParent->getOperation())
{
case CopyTableOperation::CopyDefinitionAndData:
- m_pRB_DefData->Check(true);
+ m_pRB_DefData->Check();
RadioChangeHdl(m_pRB_DefData);
break;
case CopyTableOperation::CopyDefinitionOnly:
- m_pRB_Def->Check(true);
+ m_pRB_Def->Check();
RadioChangeHdl(m_pRB_Def);
break;
case CopyTableOperation::AppendData:
- m_pRB_AppendData->Check(true);
+ m_pRB_AppendData->Check();
SetAppendDataRadio();
break;
case CopyTableOperation::CreateAsView:
if ( m_pRB_View->IsEnabled() )
{
- m_pRB_View->Check(true);
+ m_pRB_View->Check();
RadioChangeHdl(m_pRB_View);
}
else
{
- m_pRB_DefData->Check(true);
+ m_pRB_DefData->Check();
RadioChangeHdl(m_pRB_DefData);
}
}
diff --git a/dbaccess/source/ui/misc/WNameMatch.cxx
b/dbaccess/source/ui/misc/WNameMatch.cxx
index abd51ce..fbf71a0 100644
--- a/dbaccess/source/ui/misc/WNameMatch.cxx
+++ b/dbaccess/source/ui/misc/WNameMatch.cxx
@@ -275,7 +275,7 @@ IMPL_LINK_NOARG( OWizNameMatching, TableListClickHdl )
if ( nNewPos - nPos == 1 )
--nNewPos;
m_pCTRL_RIGHT->MakeVisible(m_pCTRL_RIGHT->GetEntry(nNewPos),
true);
- m_pCTRL_RIGHT->Select(pOldEntry,true);
+ m_pCTRL_RIGHT->Select(pOldEntry);
}
}
else if(!pOldEntry)
@@ -283,7 +283,7 @@ IMPL_LINK_NOARG( OWizNameMatching, TableListClickHdl )
pOldEntry = m_pCTRL_RIGHT->GetEntry(nPos);
if(pOldEntry)
{
- m_pCTRL_RIGHT->Select(pOldEntry,true);
+ m_pCTRL_RIGHT->Select(pOldEntry);
}
}
}
@@ -309,7 +309,7 @@ IMPL_LINK_NOARG( OWizNameMatching, TableListRightSelectHdl )
if ( nNewPos - nPos == 1 )
nNewPos--;
m_pCTRL_LEFT->MakeVisible(m_pCTRL_LEFT->GetEntry(nNewPos),
true);
- m_pCTRL_LEFT->Select(pOldEntry,true);
+ m_pCTRL_LEFT->Select(pOldEntry);
}
}
else if(!pOldEntry)
@@ -317,7 +317,7 @@ IMPL_LINK_NOARG( OWizNameMatching, TableListRightSelectHdl )
pOldEntry = m_pCTRL_LEFT->GetEntry(nPos);
if(pOldEntry)
{
- m_pCTRL_LEFT->Select(pOldEntry,true);
+ m_pCTRL_LEFT->Select(pOldEntry);
}
}
}
diff --git a/dbaccess/source/ui/querydesign/JoinTableView.cxx
b/dbaccess/source/ui/querydesign/JoinTableView.cxx
index 58973fc..4de43b5 100644
--- a/dbaccess/source/ui/querydesign/JoinTableView.cxx
+++ b/dbaccess/source/ui/querydesign/JoinTableView.cxx
@@ -917,14 +917,14 @@ void OJoinTableView::SelectConn(OTableConnection* pConn)
SvTreeListEntry* pSourceEntry =
pSourceBox->GetEntryFromText((*aIter)->GetData()->GetSourceFieldName());
if (pSourceEntry)
{
- pSourceBox->Select(pSourceEntry, true);
+ pSourceBox->Select(pSourceEntry);
pSourceBox->MakeVisible(pSourceEntry);
}
SvTreeListEntry* pDestEntry =
pDestBox->GetEntryFromText((*aIter)->GetData()->GetDestFieldName());
if (pDestEntry)
{
- pDestBox->Select(pDestEntry, true);
+ pDestBox->Select(pDestEntry);
pDestBox->MakeVisible(pDestEntry);
}
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 52f4f07..47550a9 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -1482,7 +1482,7 @@ namespace
aDragLeft->SetField(aCondition);
aDragLeft->SetFunctionType(FKT_CONDITION);
- eErrorCode =
_pSelectionBrw->InsertField(aDragLeft,BROWSER_INVALIDID,false,true).is() ? eOk
: eTooManyColumns;
+ eErrorCode =
_pSelectionBrw->InsertField(aDragLeft,BROWSER_INVALIDID,false).is() ? eOk :
eTooManyColumns;
}
else //! TODO not supported yet
eErrorCode = eStatementTooComplex;
@@ -1523,7 +1523,6 @@ namespace
pFunction->parseNodeToStr( aColumnName,
xConnection,
&rController.getParser().getContext(),
- true,
true); // quote is to true because we
need quoted elements inside the function
// don't display the column name
aCondition = aCondition.copy(aColumnName.getLength());
@@ -2015,7 +2014,7 @@ namespace
OQueryTableWindow* pExistentWin = pTableView->FindTable(
sAlias );
if ( !pExistentWin )
{
- pTableView->AddTabWin( sComposedName, sAlias, false );
// don't create data here
+ pTableView->AddTabWin( sComposedName, sAlias ); //
don't create data here
}
else
{
@@ -2223,7 +2222,6 @@ namespace
pParamRef->parseNodeToStr( sFieldName,
xConnection,
&rController.getParser().getContext(),
- true,
true); // quote is to
true because we need quoted elements inside the function
}
aInfo->SetDataType(DataType::DOUBLE);
@@ -2257,7 +2255,6 @@ namespace
pColumnRef->parseNodeToStr( aColumns,
xConnection,
&rController.getParser().getContext(),
- true,
true); // quote is to true
because we need quoted elements inside the function
aInfo->SetTabWindow( NULL );
@@ -2419,7 +2416,6 @@ namespace
pArgument->parseNodeToStr( sGroupByExpression,
xConnection,
&rController.getParser().getContext(),
- true,
true); // quote is to true
because we need quoted elements inside the function
_pView->fillFunctionInfo(pArgument,sGroupByExpression,aDragInfo);
aDragInfo->SetFunctionType(FKT_OTHER);
diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index f02dfa4..983233b 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -517,7 +517,7 @@ void OSelectionBrowseBox::InitController(CellControllerRef&
/*rController*/, lon
if(!pEntry->IsVisible() && pEntry->GetOrderDir() != ORDER_NONE &&
!m_bOrderByUnRelated)
{
// a column has to visible in order to show up in ORDER BY
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
m_pVisibleCell->GetBox().Check(pEntry->IsVisible());
m_pVisibleCell->GetBox().SaveValue();
m_pVisibleCell->GetBox().Disable();
@@ -574,7 +574,7 @@ void OSelectionBrowseBox::clearEntryFunctionField(const
OUString& _sFieldName,OT
// append undo action for the function field
_pEntry->SetFunctionType(FKT_NONE);
_pEntry->SetFunction(OUString());
- _pEntry->SetGroupBy(false);
+ _pEntry->SetGroupBy();
notifyFunctionFieldChanged(sOldLocalizedFunctionName,_pEntry->GetFunction(),_bListAction,_nColumnId);
}
}
@@ -667,7 +667,7 @@ bool OSelectionBrowseBox::saveField(OUString& _sFieldName
,OTableFieldDescRef& _
OUString devnull;
pParseNode = rParser.parseTree( devnull, _sFieldName, true );
if (pParseNode == NULL)
- pParseNode = rParser.parseTree( devnull, _sFieldName, false );
+ pParseNode = rParser.parseTree( devnull, _sFieldName );
if (pParseNode != NULL && SQL_ISRULE(pParseNode, select_statement))
_sFieldName = "(" + _sFieldName + ")";
}
@@ -748,7 +748,7 @@ bool OSelectionBrowseBox::saveField(OUString& _sFieldName
,OTableFieldDescRef& _
aSelEntry = FindFirstFreeCol(nColumnPostion);
if ( !aSelEntry.is() )
{
- AppendNewCol(1);
+ AppendNewCol();
aSelEntry = FindFirstFreeCol(nColumnPostion);
}
++nColumnPostion;
@@ -821,7 +821,7 @@ bool OSelectionBrowseBox::saveField(OUString& _sFieldName
,OTableFieldDescRef& _
if ( aSelEntry->IsGroupBy() )
{
sOldLocalizedFunctionName =
m_aFunctionStrings.getToken(comphelper::string::getTokenCount(m_aFunctionStrings,
';')-1, ';');
- aSelEntry->SetGroupBy(false);
+ aSelEntry->SetGroupBy();
}
// append undo action
@@ -839,7 +839,6 @@ bool OSelectionBrowseBox::saveField(OUString& _sFieldName
,OTableFieldDescRef& _
pColumnRef->parseNodeToStr( sFunction,
xConnection,
&rController.getParser().getContext(),
- true,
true); // quote is to true because
we need quoted elements inside the function
getDesignView()->fillFunctionInfo(pColumnRef,sFunction,aSelEntry);
@@ -852,7 +851,7 @@ bool OSelectionBrowseBox::saveField(OUString& _sFieldName
,OTableFieldDescRef& _
sal_uInt32 nFunCount = pColumnRef->count();
OUString sParameters;
for(sal_uInt32 function = 0; function < nFunCount;
++function)
- pColumnRef->getChild(function)->parseNodeToStr(
sParameters, xConnection, &rParser.getContext(), true, true );
+ pColumnRef->getChild(function)->parseNodeToStr(
sParameters, xConnection, &rParser.getContext(), true );
sOldAlias = aSelEntry->GetAlias();
sal_Int32 nNewFunctionType = aSelEntry->GetFunctionType()
| FKT_NUMERIC | FKT_OTHER;
@@ -919,7 +918,7 @@ bool OSelectionBrowseBox::SaveModified()
}
else
{
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
m_pVisibleCell->GetBox().Check();
}
break;
@@ -1020,7 +1019,7 @@ bool OSelectionBrowseBox::SaveModified()
pEntry->SetOrderDir(EOrderDir(nIdx));
if(!m_bOrderByUnRelated)
{
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
m_pVisibleCell->GetBox().Check();
RowModified(GetBrowseRow(BROW_VIS_ROW), GetCurColumnId());
}
@@ -1047,7 +1046,7 @@ bool OSelectionBrowseBox::SaveModified()
if ( !m_bGroupByUnRelated && !pEntry->IsVisible() )
{
// we have to change the visblie flag, so we must
append also an undo action
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
m_pVisibleCell->GetBox().Check();
appendUndoAction("0","1",BROW_VIS_ROW,bListAction);
RowModified(GetBrowseRow(BROW_VIS_ROW),
GetCurColumnId());
@@ -1189,7 +1188,7 @@ bool OSelectionBrowseBox::SaveModified()
if ( pEntry.is() && bWasEmpty && !pEntry->IsEmpty() && !bError )
{
// Default to visible
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
appendUndoAction("0","1",BROW_VIS_ROW,bListAction);
RowModified(BROW_VIS_ROW, GetCurColumnId());
@@ -1263,7 +1262,7 @@ void OSelectionBrowseBox::RemoveColumn(sal_uInt16
_nColumnId)
getFields().push_back(pEntry);
EditBrowseBox::RemoveColumn( _nColumnId );
- InsertDataColumn( _nColumnId , OUString(), DEFAULT_SIZE,
HeaderBarItemBits::STDSTYLE, HEADERBAR_APPEND);
+ InsertDataColumn( _nColumnId , OUString(), DEFAULT_SIZE,
HeaderBarItemBits::STDSTYLE);
// Neuzeichnen
Rectangle aInvalidRect = GetInvalidRect( _nColumnId );
@@ -1410,7 +1409,7 @@ OTableFieldDescRef OSelectionBrowseBox::AppendNewCol(
sal_uInt16 nCnt)
sal_uInt16 nColumnId = sal::static_int_cast< sal_uInt16
>(getFields().size());
pEmptyEntry->SetColumnId( nColumnId );
- InsertDataColumn( nColumnId , OUString(), DEFAULT_SIZE,
HeaderBarItemBits::STDSTYLE, HEADERBAR_APPEND);
+ InsertDataColumn( nColumnId , OUString(), DEFAULT_SIZE,
HeaderBarItemBits::STDSTYLE);
}
return getFields()[nCount];
@@ -1492,7 +1491,7 @@ void OSelectionBrowseBox::InsertColumn(OTableFieldDescRef
pEntry, sal_uInt16& _n
{
if (FindFirstFreeCol(_nColumnPosition) == NULL) // no more free
columns
{
- AppendNewCol(1);
+ AppendNewCol();
_nColumnPosition = sal::static_int_cast< sal_uInt16 >(
getFields().size());
}
@@ -1660,7 +1659,7 @@ void OSelectionBrowseBox::AddGroupBy( const
OTableFieldDescRef& rInfo , sal_uInt
{
if ( pEntry->isNumericOrAggreateFunction() && rInfo->IsGroupBy() )
{
- pEntry->SetGroupBy(false);
+ pEntry->SetGroupBy();
aIter = rFields.end();
break;
}
@@ -1670,7 +1669,7 @@ void OSelectionBrowseBox::AddGroupBy( const
OTableFieldDescRef& rInfo , sal_uInt
{
pEntry->SetGroupBy(rInfo->IsGroupBy());
if(!m_bGroupByUnRelated && pEntry->IsGroupBy())
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
break;
}
}
@@ -1682,7 +1681,7 @@ void OSelectionBrowseBox::AddGroupBy( const
OTableFieldDescRef& rInfo , sal_uInt
{
OTableFieldDescRef pTmp = InsertField(rInfo, BROWSER_INVALIDID, false,
false );
if ( (pTmp->isNumericOrAggreateFunction() && rInfo->IsGroupBy()) ) //
the GroupBy is inherited from rInfo
- pTmp->SetGroupBy(false);
+ pTmp->SetGroupBy();
}
}
@@ -1738,11 +1737,11 @@ void OSelectionBrowseBox::AddCondition( const
OTableFieldDescRef& rInfo, const O
pEntry->IsGroupBy() == rInfo->IsGroupBy() )
{
if ( pEntry->isNumericOrAggreateFunction() && rInfo->IsGroupBy() )
- pEntry->SetGroupBy(false);
+ pEntry->SetGroupBy();
else
{
if(!m_bGroupByUnRelated && pEntry->IsGroupBy())
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
}
if (pEntry->GetCriteria(nLevel).isEmpty() )
{
@@ -1787,7 +1786,7 @@ void OSelectionBrowseBox::AddCondition( const
OTableFieldDescRef& rInfo, const O
{
OTableFieldDescRef pTmp = InsertField(rInfo, BROWSER_INVALIDID, false,
false );
if ( pTmp->isNumericOrAggreateFunction() && rInfo->IsGroupBy() ) //
the GroupBy was inherited from rInfo
- pTmp->SetGroupBy(false);
+ pTmp->SetGroupBy();
if ( pTmp.is() )
{
pTmp->SetCriteria( nLevel, rValue);
@@ -1834,7 +1833,7 @@ void OSelectionBrowseBox::AddOrder( const
OTableFieldDescRef& rInfo, const EOrde
else
{
if ( !m_bOrderByUnRelated )
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
pEntry->SetOrderDir( eDir );
m_nLastSortColumn = nPos;
}
@@ -1849,7 +1848,7 @@ void OSelectionBrowseBox::AddOrder( const
OTableFieldDescRef& rInfo, const EOrde
{
m_nLastSortColumn = pTmp->GetColumnId() - 1;
if ( !m_bOrderByUnRelated && !bAppend )
- pTmp->SetVisible(true);
+ pTmp->SetVisible();
pTmp->SetOrderDir( eDir );
}
}
@@ -1884,7 +1883,7 @@ void OSelectionBrowseBox::CellModified()
pEntry->GetOrderDir() != ORDER_NONE)
{
m_pVisibleCell->GetBox().Check();
- pEntry->SetVisible(true);
+ pEntry->SetVisible();
}
else
pEntry->SetVisible(m_pVisibleCell->GetBox().IsChecked());
@@ -2290,7 +2289,7 @@ void OSelectionBrowseBox::SetCellContents(sal_Int32 nRow,
sal_uInt16 nColId, con
nFunctionType &= ~FKT_AGGREGATE;
pEntry->SetFunctionType(nFunctionType);
if ( pEntry->IsGroupBy() &&
!sGroupFunctionName.equalsIgnoreAsciiCase(strNewText) )
- pEntry->SetGroupBy(false);
+ pEntry->SetGroupBy();
if ( sGroupFunctionName.equalsIgnoreAsciiCase(strNewText) )
pEntry->SetGroupBy(true);
diff --git a/dbaccess/source/ui/querydesign/TableWindowListBox.cxx
b/dbaccess/source/ui/querydesign/TableWindowListBox.cxx
index 7ea13e3..47eaeb3 100644
--- a/dbaccess/source/ui/querydesign/TableWindowListBox.cxx
+++ b/dbaccess/source/ui/querydesign/TableWindowListBox.cxx
@@ -177,7 +177,7 @@ IMPL_LINK_NOARG_TYPED( OTableWindowListBox, ScrollUpHdl,
Timer*, void )
{
ScrollOutputArea( -1 );
pEntry = GetEntry( m_aMousePos );
- Select( pEntry, true );
+ Select( pEntry );
}
}
@@ -191,7 +191,7 @@ IMPL_LINK_NOARG_TYPED( OTableWindowListBox, ScrollDownHdl,
Timer*, void )
{
ScrollOutputArea( 1 );
pEntry = GetEntry( m_aMousePos );
- Select( pEntry, true );
+ Select( pEntry );
}
}
@@ -265,7 +265,7 @@ sal_Int8 OTableWindowListBox::AcceptDrop( const
AcceptDropEvent& _rEvt )
// automatically select right entry when dragging
if ((FirstSelected() != pEntry) || (FirstSelected() &&
NextSelected(FirstSelected())))
SelectAll(false);
- Select(pEntry, true);
+ Select(pEntry);
// one cannot drop on the first (*) entry
if(!( m_pTabWin->GetData()->IsShowAll() && (pEntry==First()) ))
@@ -336,7 +336,7 @@ void OTableWindowListBox::GetFocus()
{
if ( FirstSelected() )
Select(FirstSelected(), false);
- Select(GetCurEntry(), true);
+ Select(GetCurEntry());
}
else
ShowFocusRect(FirstSelected());
diff --git a/dbaccess/source/ui/tabledesign/TEditControl.cxx
b/dbaccess/source/ui/tabledesign/TEditControl.cxx
index c1a5a17..f2ab8c3 100644
--- a/dbaccess/source/ui/tabledesign/TEditControl.cxx
+++ b/dbaccess/source/ui/tabledesign/TEditControl.cxx
@@ -840,7 +840,7 @@ void OTableEditorCtrl::DeleteRows()
{
// Remove rows
m_pRowList->erase( m_pRowList->begin()+nIndex );
- RowRemoved( nIndex, 1, true );
+ RowRemoved( nIndex, 1 );
// Insert the empty row at the end
m_pRowList->push_back( ::boost::shared_ptr<OTableRow>(new
OTableRow()));
@@ -1366,7 +1366,7 @@ void OTableEditorCtrl::Command(const CommandEvent& rEvt)
}
else if ( GetSelectRowCount() > 0 )
{
- ::Rectangle aColRect( GetFieldRectPixel(
FirstSelectedRow(), HANDLE_ID, true ) );
+ ::Rectangle aColRect( GetFieldRectPixel(
FirstSelectedRow(), HANDLE_ID ) );
aMenuPos = aColRect.TopCenter();
}
diff --git a/dbaccess/source/ui/tabledesign/TableUndo.cxx
b/dbaccess/source/ui/tabledesign/TableUndo.cxx
index 4fd3181..ec495aa 100644
--- a/dbaccess/source/ui/tabledesign/TableUndo.cxx
+++ b/dbaccess/source/ui/tabledesign/TableUndo.cxx
@@ -254,7 +254,7 @@ void OTableEditorInsUndoAct::Undo()
pOriginalRows->erase(pOriginalRows->begin()+i);
}
- pTabEdCtrl->RowRemoved( m_nInsPos, m_vInsertedRows.size(), true );
+ pTabEdCtrl->RowRemoved( m_nInsPos, m_vInsertedRows.size() );
pTabEdCtrl->InvalidateHandleColumn();
OTableEditorUndoAct::Undo();
@@ -303,7 +303,7 @@ void OTableEditorInsNewUndoAct::Undo()
pOriginalRows->erase(pOriginalRows->begin()+i);
}
- pTabEdCtrl->RowRemoved( m_nInsPos, m_nInsRows, true );
+ pTabEdCtrl->RowRemoved( m_nInsPos, m_nInsRows );
pTabEdCtrl->InvalidateHandleColumn();
OTableEditorUndoAct::Undo();
commit 4c6d1a2636941c559d78fcac36125ba1374330f9
Author: Noel Grandin <n...@peralex.com>
Date: Wed Aug 12 15:09:44 2015 +0200
loplugin: defaultparams
Change-Id: I81537289a40bdc30bd8d896dc5364f0989205e39
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 2bb91d5..e3ce1d4 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -1138,7 +1138,7 @@ bool MenuSaveInData::LoadSubMenus(
}
else
{
- pEntry->SetMain( true );
+ pEntry->SetMain();
}
subMenuTitle += stripHotKey( aLabel );
@@ -1682,13 +1682,13 @@ void SvxConfigPage::Reset( const SfxItemSet* )
{
if ( pDocData && pDocData->HasURL( m_aURLToSelect ) )
{
- m_pSaveInListBox->SelectEntryPos( nPos, true );
+ m_pSaveInListBox->SelectEntryPos( nPos );
pCurrentSaveInData = pDocData;
bURLToSelectFound = true;
}
else if ( pModuleData && pModuleData->HasURL( m_aURLToSelect ) )
{
- m_pSaveInListBox->SelectEntryPos( 0, true );
+ m_pSaveInListBox->SelectEntryPos( 0 );
pCurrentSaveInData = pModuleData;
bURLToSelectFound = true;
}
@@ -1700,12 +1700,12 @@ void SvxConfigPage::Reset( const SfxItemSet* )
// it the SaveIn listbox, otherwise select the module data
if ( pDocData != NULL && pDocData->HasSettings() )
{
- m_pSaveInListBox->SelectEntryPos( nPos, true );
+ m_pSaveInListBox->SelectEntryPos( nPos );
pCurrentSaveInData = pDocData;
}
else
{
- m_pSaveInListBox->SelectEntryPos( 0, true );
+ m_pSaveInListBox->SelectEntryPos( 0 );
pCurrentSaveInData = pModuleData;
}
}
@@ -1916,7 +1916,7 @@ void SvxConfigPage::ReloadTopLevelListBox(
SvxConfigEntry* pToSelect )
nSelectionPos = nSelectionPos < m_pTopLevelListBox->GetEntryCount() ?
nSelectionPos : m_pTopLevelListBox->GetEntryCount() - 1;
- m_pTopLevelListBox->SelectEntryPos( nSelectionPos, true );
+ m_pTopLevelListBox->SelectEntryPos( nSelectionPos );
m_pTopLevelListBox->GetSelectHdl().Call( this );
}
@@ -1985,7 +1985,7 @@ SvTreeListEntry* SvxConfigPage::AddFunction(
SvxConfigEntry* pNewEntryData =
new SvxConfigEntry( aDisplayName, aURL, false );
- pNewEntryData->SetUserDefined( true );
+ pNewEntryData->SetUserDefined();
// check that this function is not already in the menu
SvxConfigEntry* pParent = GetTopLevelSelection();
@@ -2065,7 +2065,7 @@ SvTreeListEntry* SvxConfigPage::InsertEntry(
m_pContentsListBox->Select( pNewEntry );
m_pContentsListBox->MakeVisible( pNewEntry );
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
}
return pNewEntry;
@@ -2197,7 +2197,7 @@ bool SvxConfigPage::MoveEntryData(
// insert the source entry at the position after the target
pEntries->insert( ++iter, pSourceData );
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
return true;
}
@@ -2259,7 +2259,7 @@ void SvxMenuConfigPage::Init()
ReloadTopLevelListBox();
- m_pTopLevelListBox->SelectEntryPos(0, true);
+ m_pTopLevelListBox->SelectEntryPos(0);
m_pTopLevelListBox->GetSelectHdl().Call(this);
}
@@ -2298,7 +2298,7 @@ void SvxMenuConfigPage::UpdateButtonStates()
m_pMoveUpButton->Enable( false );
m_pMoveDownButton->Enable( false );
- pPopup->EnableItem( ID_BEGIN_GROUP, true );
+ pPopup->EnableItem( ID_BEGIN_GROUP );
pPopup->EnableItem( ID_RENAME, false );
pPopup->EnableItem( ID_DELETE, false );
@@ -2318,7 +2318,7 @@ void SvxMenuConfigPage::UpdateButtonStates()
if ( pEntryData->IsSeparator() )
{
- pPopup->EnableItem( ID_DELETE, true );
+ pPopup->EnableItem( ID_DELETE );
pPopup->EnableItem( ID_BEGIN_GROUP, false );
pPopup->EnableItem( ID_RENAME, false );
@@ -2326,9 +2326,9 @@ void SvxMenuConfigPage::UpdateButtonStates()
}
else
{
- pPopup->EnableItem( ID_BEGIN_GROUP, true );
- pPopup->EnableItem( ID_DELETE, true );
- pPopup->EnableItem( ID_RENAME, true );
+ pPopup->EnableItem( ID_BEGIN_GROUP );
+ pPopup->EnableItem( ID_DELETE );
+ pPopup->EnableItem( ID_RENAME );
m_pDescriptionField->SetText(pEntryData->GetHelpText());
}
@@ -2346,7 +2346,7 @@ void SvxMenuConfigPage::DeleteSelectedTopLevel()
ReloadTopLevelListBox();
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified( );
}
bool SvxMenuConfigPage::DeleteSelectedContent()
@@ -2377,7 +2377,7 @@ bool SvxMenuConfigPage::DeleteSelectedContent()
// delete data for menu entry
delete pMenuEntry;
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
return true;
}
@@ -2453,7 +2453,7 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, MenuSelectHdl,
MenuButton *, pButton, void )
ReloadTopLevelListBox();
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
}
}
else if (sIdent == "move")
@@ -2470,7 +2470,7 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, MenuSelectHdl,
MenuButton *, pButton, void )
ReloadTopLevelListBox( pDialog->GetSelectedEntry() );
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
}
}
}
@@ -2492,19 +2492,19 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, EntrySelectHdl,
MenuButton *, pButton, void
SvxConfigEntry* pNewEntryData =
new SvxConfigEntry( aNewName, aNewName, true );
- pNewEntryData->SetUserDefined( true );
+ pNewEntryData->SetUserDefined();
InsertEntry( pNewEntryData );
ReloadTopLevelListBox();
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
}
}
else if (sIdent == "addseparator")
{
SvxConfigEntry* pNewEntryData = new SvxConfigEntry;
- pNewEntryData->SetUserDefined( true );
+ pNewEntryData->SetUserDefined();
InsertEntry( pNewEntryData );
}
else if (sIdent == "moddelete")
@@ -2530,7 +2530,7 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, EntrySelectHdl,
MenuButton *, pButton, void
pEntry->SetName( aNewName );
m_pContentsListBox->SetEntryText( pActEntry, aNewName );
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
}
}
else
@@ -2565,7 +2565,7 @@ IMPL_LINK( SvxMenuConfigPage, NewMenuHdl, Button *,
pButton )
{
GetSaveInData()->SetEntries( pDialog->GetEntries() );
ReloadTopLevelListBox( pDialog->GetSelectedEntry() );
- GetSaveInData()->SetModified( true );
+ GetSaveInData()->SetModified();
}
return 0;
@@ -2652,8 +2652,8 @@ SvxMainMenuOrganizerDialog::SvxMainMenuOrganizerDialog(
SvxConfigEntry* pNewEntryData =
new SvxConfigEntry( newname, newurl, true );
- pNewEntryData->SetUserDefined( true );
- pNewEntryData->SetMain( true );
+ pNewEntryData->SetUserDefined();
+ pNewEntryData->SetMain();
pNewMenuEntry =
m_pMenuListBox->InsertEntry( stripHotKey( pNewEntryData->GetName()
) );
@@ -2989,11 +2989,11 @@ void SvxToolbarConfigPage::DeleteSelectedTopLevel()
// subtract one from the entry count
if ( nSelectionPos != m_pTopLevelListBox->GetEntryCount() - 1 )
{
- m_pTopLevelListBox->SelectEntryPos( nSelectionPos + 1, true );
+ m_pTopLevelListBox->SelectEntryPos( nSelectionPos + 1 );
}
else
{
- m_pTopLevelListBox->SelectEntryPos( nSelectionPos - 1, true );
+ m_pTopLevelListBox->SelectEntryPos( nSelectionPos - 1 );
}
m_pTopLevelListBox->GetSelectHdl().Call( this );
@@ -3263,7 +3263,7 @@ IMPL_LINK_TYPED( SvxToolbarConfigPage, EntrySelectHdl,
MenuButton *, pButton, vo
case ID_BEGIN_GROUP:
{
SvxConfigEntry* pNewEntryData = new SvxConfigEntry;
- pNewEntryData->SetUserDefined( true );
+ pNewEntryData->SetUserDefined();
SvTreeListEntry* pNewLBEntry = InsertEntry( pNewEntryData );
@@ -3465,7 +3465,7 @@ void SvxToolbarConfigPage::Init()
m_aURLToSelect += "standardbar";
}
- m_pTopLevelListBox->SelectEntryPos(nPos, true);
+ m_pTopLevelListBox->SelectEntryPos(nPos);
m_pTopLevelListBox->GetSelectHdl().Call(this);
}
@@ -3754,7 +3754,7 @@ SvxEntries* ToolbarSaveInData::GetEntries()
SvxConfigEntry* pEntry = new SvxConfigEntry(
uiname, url, true );
- pEntry->SetMain( true );
+ pEntry->SetMain();
pEntry->SetStyle( GetSystemStyle( url ) );
@@ -3764,7 +3764,7 @@ SvxEntries* ToolbarSaveInData::GetEntries()
OUString custom(CUSTOM_TOOLBAR_STR);
if ( systemname.startsWith( custom ) )
{
- pEntry->SetUserDefined( true );
+ pEntry->SetUserDefined();
}
else
{
@@ -3842,12 +3842,12 @@ SvxEntries* ToolbarSaveInData::GetEntries()
SvxConfigEntry* pEntry = new SvxConfigEntry(
uiname, url, true, true );
- pEntry->SetMain( true );
+ pEntry->SetMain();
pEntry->SetStyle( GetSystemStyle( url ) );
if ( systemname.startsWith( custom ) )
{
- pEntry->SetUserDefined( true );
+ pEntry->SetUserDefined();
}
else
{
@@ -4162,7 +4162,7 @@ void ToolbarSaveInData::RestoreToolbar( SvxConfigEntry*
pToolbar )
if ( IsDocConfig() )
{
xToolbarSettings = GetParentConfigManager()->getSettings( url,
sal_False );
- pToolbar->SetParentData( true );
+ pToolbar->SetParentData();
}
else
xToolbarSettings = GetConfigManager()->getSettings( url, sal_False
);
@@ -4313,22 +4313,22 @@ void SvxToolbarConfigPage::UpdateButtonStates()
SvxConfigEntry* pEntryData =
static_cast<SvxConfigEntry*>(selection->GetUserData());
if ( pEntryData->IsSeparator() )
- pPopup->EnableItem( ID_DELETE, true );
+ pPopup->EnableItem( ID_DELETE );
else
{
- pPopup->EnableItem( ID_BEGIN_GROUP, true );
- pPopup->EnableItem( ID_DELETE, true );
- pPopup->EnableItem( ID_RENAME, true );
- pPopup->EnableItem( ID_ICON_ONLY, true );
- pPopup->EnableItem( ID_ICON_AND_TEXT, true );
- pPopup->EnableItem( ID_TEXT_ONLY, true );
- pPopup->EnableItem( ID_CHANGE_SYMBOL, true );
+ pPopup->EnableItem( ID_BEGIN_GROUP );
+ pPopup->EnableItem( ID_DELETE );
+ pPopup->EnableItem( ID_RENAME );
+ pPopup->EnableItem( ID_ICON_ONLY );
+ pPopup->EnableItem( ID_ICON_AND_TEXT );
+ pPopup->EnableItem( ID_TEXT_ONLY );
+ pPopup->EnableItem( ID_CHANGE_SYMBOL );
if ( !pEntryData->IsUserDefined() )
- pPopup->EnableItem( ID_DEFAULT_COMMAND, true );
+ pPopup->EnableItem( ID_DEFAULT_COMMAND );
if ( pEntryData->IsIconModified() )
- pPopup->EnableItem( ID_RESET_SYMBOL, true );
+ pPopup->EnableItem( ID_RESET_SYMBOL );
m_pDescriptionField->SetText(pEntryData->GetHelpText());
}
@@ -4449,7 +4449,7 @@ IMPL_LINK( SvxToolbarConfigPage, NewToolbarHdl, Button *,
pButton )
}
pNameDialog->m_pSaveInListBox->SelectEntryPos(
- m_pSaveInListBox->GetSelectEntryPos(), true );
+ m_pSaveInListBox->GetSelectEntryPos() );
if ( pNameDialog->Execute() == RET_OK )
{
@@ -4462,24 +4462,24 @@ IMPL_LINK( SvxToolbarConfigPage, NewToolbarHdl, Button
*, pButton )
if ( GetSaveInData() != pData )
{
- m_pSaveInListBox->SelectEntryPos( nInsertPos, true );
+ m_pSaveInListBox->SelectEntryPos( nInsertPos );
m_pSaveInListBox->GetSelectHdl().Call(this);
}
SvxConfigEntry* pToolbar =
new SvxConfigEntry( aNewName, aNewURL, true );
- pToolbar->SetUserDefined( true );
- pToolbar->SetMain( true );
+ pToolbar->SetUserDefined();
+ pToolbar->SetMain();
pData->CreateToolbar( pToolbar );
nInsertPos = m_pTopLevelListBox->InsertEntry( pToolbar->GetName() );
m_pTopLevelListBox->SetEntryData( nInsertPos, pToolbar );
- m_pTopLevelListBox->SelectEntryPos( nInsertPos, true );
+ m_pTopLevelListBox->SelectEntryPos( nInsertPos );
m_pTopLevelListBox->GetSelectHdl().Call(this);
- pData->SetModified( true );
+ pData->SetModified();
}
return 0;
diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index 7d0b3ad..03c4be8 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -590,7 +590,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference<
css::uno::XComponent
OUString aTitle(pImp->m_sDlgMacros);
SvTreeListEntry *pNewEntry = InsertEntry( aTitle, NULL );
pNewEntry->SetUserData( pInfo );
- pNewEntry->EnableChildrenOnDemand( true );
+ pNewEntry->EnableChildrenOnDemand();
aArr.push_back( pInfo );
}
else
@@ -676,7 +676,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference<
css::uno::XComponent
{
if ( grandchildren[m]->getType() ==
browse::BrowseNodeTypes::CONTAINER )
{
- pNewEntry->EnableChildrenOnDemand(
true );
+ pNewEntry->EnableChildrenOnDemand();
m = grandchildren.getLength();
}
}
@@ -699,7 +699,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference<
css::uno::XComponent
SfxGroupInfo_Impl *pInfo = new SfxGroupInfo_Impl(
SfxCfgKind::GROUP_STYLES, 0, 0 ); // TODO last parameter should contain user
data
aArr.push_back( pInfo );
pEntry->SetUserData( pInfo );
- pEntry->EnableChildrenOnDemand( true );
+ pEntry->EnableChildrenOnDemand();
}
MakeVisible( GetEntry( 0,0 ) );
@@ -752,7 +752,7 @@ Image SfxConfigGroupListBox::GetImage(
}
if( !factoryURL.isEmpty() )
{
- aImage = SvFileInformationManager::GetFileImage(
INetURLObject(factoryURL), false );
+ aImage = SvFileInformationManager::GetFileImage(
INetURLObject(factoryURL) );
}
else
{
@@ -1073,7 +1073,7 @@ void SfxConfigGroupListBox::RequestingChildren(
SvTreeListEntry *pEntry )
{
if ( grandchildren[m]->getType() ==
browse::BrowseNodeTypes::CONTAINER )
{
- pNewEntry->EnableChildrenOnDemand(
true );
+
pNewEntry->EnableChildrenOnDemand();
m = grandchildren.getLength();
}
}
diff --git a/cui/source/customize/eventdlg.cxx
b/cui/source/customize/eventdlg.cxx
index cab1e26..4b7d8f8 100644
--- a/cui/source/customize/eventdlg.cxx
+++ b/cui/source/customize/eventdlg.cxx
@@ -88,7 +88,7 @@ SvxEventConfigPage::SvxEventConfigPage(vcl::Window *pParent,
const SfxItemSet& r
nPos = m_pSaveInListBox->InsertEntry(
utl::ConfigManager::getProductName() );
m_pSaveInListBox->SetEntryData( nPos, new bool(true) );
- m_pSaveInListBox->SelectEntryPos( nPos, true );
+ m_pSaveInListBox->SelectEntryPos( nPos );
}
void SvxEventConfigPage::LateInit( const uno::Reference< frame::XFrame >&
_rxFrame )
@@ -157,7 +157,7 @@ void SvxEventConfigPage::ImplInitDocument()
sal_uInt16 nPos = m_pSaveInListBox->InsertEntry( aTitle );
m_pSaveInListBox->SetEntryData( nPos, new bool(false) );
- m_pSaveInListBox->SelectEntryPos( nPos, true );
+ m_pSaveInListBox->SelectEntryPos( nPos );
bAppConfig = false;
}
diff --git a/cui/source/customize/selector.cxx
b/cui/source/customize/selector.cxx
index 99b17e2..8a5f269 100644
--- a/cui/source/customize/selector.cxx
+++ b/cui/source/customize/selector.cxx
@@ -386,7 +386,7 @@ void SvxConfigGroupListBox::fillScriptList( const
Reference< browse::XBrowseNode
* way to determine if a basic lib had children
* without having to ask for them (which forces
* the library to be loaded */
- pNewEntry->EnableChildrenOnDemand( true );
+ pNewEntry->EnableChildrenOnDemand();
}
else
{
@@ -399,7 +399,7 @@ void SvxConfigGroupListBox::fillScriptList( const
Reference< browse::XBrowseNode
{
if ( grandchildren[m]->getType() ==
browse::BrowseNodeTypes::CONTAINER )
{
- pNewEntry->EnableChildrenOnDemand( true );
+ pNewEntry->EnableChildrenOnDemand();
break;
}
}
@@ -532,7 +532,7 @@ void SvxConfigGroupListBox::Init(bool bShowSlots, const
Reference< frame::XFrame
SvTreeListEntry *pNewEntry = InsertEntry( aTitle, NULL );
pNewEntry->SetUserData( pInfo );
- pNewEntry->EnableChildrenOnDemand( true );
+ pNewEntry->EnableChildrenOnDemand();
aArr.push_back( pInfo );
}
else
@@ -587,7 +587,7 @@ Image SvxConfigGroupListBox::GetImage(
}
if( !factoryURL.isEmpty() )
{
- aImage = SvFileInformationManager::GetFileImage(
INetURLObject(factoryURL), false );
+ aImage = SvFileInformationManager::GetFileImage(
INetURLObject(factoryURL) );
}
else
{
@@ -987,7 +987,7 @@ IMPL_LINK( SvxScriptSelectorDialog, ClickHdl, Button *,
pButton )
// run from Tools/Configure and we should not close it, just hide it
if ( !m_bShowSlots )
{
- EndDialog( RET_CANCEL );
+ EndDialog();
}
else
{
diff --git a/cui/source/dialogs/cuifmsearch.cxx
b/cui/source/dialogs/cuifmsearch.cxx
index dedad53..1499411 100644
--- a/cui/source/dialogs/cuifmsearch.cxx
+++ b/cui/source/dialogs/cuifmsearch.cxx
@@ -792,14 +792,14 @@ void FmSearchDialog::LoadParams()
if (aParams.bAllFields)
{
m_prbSingleField->Check(false);
- m_prbAllFields->Check(true);
+ m_prbAllFields->Check();
LINK(this, FmSearchDialog, OnClickedFieldRadios).Call(m_prbAllFields);
// OnClickedFieldRadios also calls to RebuildUsedFields
}
else
{
m_prbAllFields->Check(false);
- m_prbSingleField->Check(true);
+ m_prbSingleField->Check();
LINK(this, FmSearchDialog,
OnClickedFieldRadios).Call(m_prbSingleField);
}
@@ -837,7 +837,7 @@ void FmSearchDialog::LoadParams()
pToCheck = m_pSoundsLikeCJK;
if (pToCheck)
{
- pToCheck->Check(true);
+ pToCheck->Check();
LINK(this, FmSearchDialog, OnCheckBoxToggled).Call(pToCheck);
}
@@ -854,9 +854,9 @@ void FmSearchDialog::LoadParams()
m_prbSearchForNotNull->Check(false);
switch (aParams.nSearchForType)
{
- case 1: m_prbSearchForNull->Check(true); break;
- case 2: m_prbSearchForNotNull->Check(true); break;
- default: m_prbSearchForText->Check(true); break;
+ case 1: m_prbSearchForNull->Check(); break;
+ case 2: m_prbSearchForNotNull->Check(); break;
+ default: m_prbSearchForText->Check(); break;
}
LINK(this, FmSearchDialog, OnClickedFieldRadios).Call(m_prbSearchForText);
}
diff --git a/cui/source/dialogs/hangulhanjadlg.cxx
b/cui/source/dialogs/hangulhanjadlg.cxx
index c6ceba7..2ab8c27 100644
--- a/cui/source/dialogs/hangulhanjadlg.cxx
+++ b/cui/source/dialogs/hangulhanjadlg.cxx
@@ -860,7 +860,7 @@ namespace svx
{
CheckBox *pBox = _ePrimaryConversionDirection ==
HHC::eHangulToHanja?
m_pHangulOnly : m_pHanjaOnly;
- pBox->Check( true );
+ pBox->Check();
OnConversionDirectionClicked( pBox );
}
}
diff --git a/cui/source/dialogs/hyphen.cxx b/cui/source/dialogs/hyphen.cxx
index a605af4..82d14bd 100644
--- a/cui/source/dialogs/hyphen.cxx
+++ b/cui/source/dialogs/hyphen.cxx
@@ -405,7 +405,7 @@ IMPL_LINK_NOARG(SvxHyphenWordDialog, CancelHdl_Impl)
{
m_bBusy = true;
m_pHyphWrapper->SpellEnd();
- EndDialog( RET_CANCEL );
+ EndDialog();
m_bBusy = false;
}
return 0;
diff --git a/cui/source/dialogs/iconcdlg.cxx b/cui/source/dialogs/iconcdlg.cxx
index da60498..d650542 100644
--- a/cui/source/dialogs/iconcdlg.cxx
+++ b/cui/source/dialogs/iconcdlg.cxx
@@ -97,7 +97,7 @@ void IconChoicePage::ImplInitSettings()
vcl::Window* pParent = GetParent();
if ( pParent->IsChildTransparentModeEnabled() && !IsControlBackground() )
{
- EnableChildTransparentMode( true );
+ EnableChildTransparentMode();
SetParentClipMode( ParentClipMode::NoClip );
SetPaintTransparent( true );
SetBackground();
@@ -186,7 +186,7 @@ IconChoiceDialog::IconChoiceDialog ( vcl::Window* pParent,
const OUString& rID,
SetCtrlStyle();
m_pIconCtrl->SetClickHdl ( LINK ( this, IconChoiceDialog ,
ChosePageHdl_Impl ) );
m_pIconCtrl->Show();
- m_pIconCtrl->SetChoiceWithCursor ( true );
+ m_pIconCtrl->SetChoiceWithCursor();
m_pIconCtrl->SetSelectionMode( SINGLE_SELECTION );
m_pIconCtrl->SetHelpId( HID_ICCDIALOG_CHOICECTRL );
diff --git a/cui/source/dialogs/insdlg.cxx b/cui/source/dialogs/insdlg.cxx
index 8c267f0..1a5a0f3 100644
--- a/cui/source/dialogs/insdlg.cxx
+++ b/cui/source/dialogs/insdlg.cxx
@@ -183,7 +183,7 @@ SvInsertOleDlg::SvInsertOleDlg
Link<> aLink( LINK( this, SvInsertOleDlg, RadioHdl ) );
m_pRbNewObject->SetClickHdl( aLink );
m_pRbObjectFromfile->SetClickHdl( aLink );
- m_pRbNewObject->Check( true );
+ m_pRbNewObject->Check();
RadioHdl( NULL );
}
@@ -590,7 +590,7 @@ short SfxInsertFloatingFrameDialog::Execute()
if ( nSize == SIZE_NOT_SET )
{
- m_pCBMarginWidthDefault->Check( true );
+ m_pCBMarginWidthDefault->Check();
m_pNMMarginWidth->SetText(
OUString::number(DEFAULT_MARGIN_WIDTH) );
m_pFTMarginWidth->Enable( false );
m_pNMMarginWidth->Enable( false );
@@ -603,7 +603,7 @@ short SfxInsertFloatingFrameDialog::Execute()
if ( nSize == SIZE_NOT_SET )
{
- m_pCBMarginHeightDefault->Check( true );
+ m_pCBMarginHeightDefault->Check();
m_pNMMarginHeight->SetText(
OUString::number(DEFAULT_MARGIN_HEIGHT) );
m_pFTMarginHeight->Enable( false );
m_pNMMarginHeight->Enable( false );
diff --git a/cui/source/dialogs/multipat.cxx b/cui/source/dialogs/multipat.cxx
index b8b5b04..ba91c93 100644
--- a/cui/source/dialogs/multipat.cxx
+++ b/cui/source/dialogs/multipat.cxx
@@ -121,7 +121,7 @@ IMPL_LINK_NOARG(SvxPathSelectDialog, AddHdl_Impl)
}
else
{
- sal_uInt16 nPos = m_pPathLB->InsertEntry( sInsPath, LISTBOX_APPEND
);
+ sal_uInt16 nPos = m_pPathLB->InsertEntry( sInsPath );
m_pPathLB->SetEntryData( nPos, new OUString( aURL ) );
}
@@ -349,9 +349,9 @@ void SvxPathSelectDialog::SetPath(const OUString& rPath)
::utl::LocalFileHelper::ConvertURLToSystemPath( sPath, sSystemPath
);
if ( bIsSystemPath )
- nPos = m_pPathLB->InsertEntry( sSystemPath, LISTBOX_APPEND );
+ nPos = m_pPathLB->InsertEntry( sSystemPath );
else
- nPos = m_pPathLB->InsertEntry( sPath, LISTBOX_APPEND );
+ nPos = m_pPathLB->InsertEntry( sPath );
m_pPathLB->SetEntryData( nPos, new OUString( sPath ) );
}
diff --git a/cui/source/dialogs/postdlg.cxx b/cui/source/dialogs/postdlg.cxx
index 0db4949..6355f2c 100644
--- a/cui/source/dialogs/postdlg.cxx
+++ b/cui/source/dialogs/postdlg.cxx
@@ -202,7 +202,7 @@ IMPL_LINK_NOARG(SvxPostItDialog, Stamp)
}
aStr += rLocaleWrapper.getDate(aDate);
aStr += ", ";
- aStr += rLocaleWrapper.getTime(aTime, false, false);
+ aStr += rLocaleWrapper.getTime(aTime, false);
aStr += " ----\n";
aStr = convertLineEnd(aStr, GetSystemLineEnd());
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 8a4d6bb..971ff3a 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -350,7 +350,7 @@ SvTreeListEntry * SFTreeListBox::insertEntry(
SvTreeListEntry * p;
if( nBitmap == RID_CUIIMG_DOC && !factoryURL.isEmpty() )
{
- Image aImage = SvFileInformationManager::GetFileImage(
INetURLObject(factoryURL), false );
+ Image aImage = SvFileInformationManager::GetFileImage(
INetURLObject(factoryURL) );
p = InsertEntry(
rText, aImage, aImage, pParent, bChildrenOnDemand, TREELIST_APPEND,
aUserData.release()); // XXX possible leak
@@ -655,7 +655,7 @@ IMPL_LINK( SvxScriptOrgDialog, ButtonHdl, Button *, pButton
)
if ( pButton == m_pCloseButton )
{
StoreCurrentSelection();
- EndDialog( 0 );
+ EndDialog();
}
if ( pButton == m_pEditButton ||
pButton == m_pCreateButton ||
@@ -757,7 +757,7 @@ IMPL_LINK( SvxScriptOrgDialog, ButtonHdl, Button *, pButton
)
}
}
StoreCurrentSelection();
- EndDialog( 0 );
+ EndDialog();
}
else if ( pButton == m_pEditButton )
{
@@ -765,7 +765,7 @@ IMPL_LINK( SvxScriptOrgDialog, ButtonHdl, Button *, pButton
)
if ( xInv.is() )
{
StoreCurrentSelection();
- EndDialog( 0 );
+ EndDialog();
Sequence< Any > args(0);
Sequence< Any > outArgs( 0 );
Sequence< sal_Int16 > outIndex;
diff --git a/cui/source/dialogs/zoom.cxx b/cui/source/dialogs/zoom.cxx
index 85dc0d2..059b562 100644
--- a/cui/source/dialogs/zoom.cxx
+++ b/cui/source/dialogs/zoom.cxx
@@ -463,7 +463,7 @@ IMPL_LINK(SvxZoomDialog, OKHdl, Button*, pButton)
}
else
{
- EndDialog( RET_CANCEL );
+ EndDialog();
}
return 0;
}
diff --git a/cui/source/options/certpath.cxx b/cui/source/options/certpath.cxx
index 10c2ebc..89a4930 100644
--- a/cui/source/options/certpath.cxx
+++ b/cui/source/options/certpath.cxx
@@ -174,7 +174,7 @@ IMPL_LINK( CertPathDialog, CheckHdl_Impl, SvSimpleTable *,
pList )
void CertPathDialog::HandleCheckEntry( SvTreeListEntry* _pEntry )
{
- m_pCertPathList->Select( _pEntry, true );
+ m_pCertPathList->Select( _pEntry );
SvButtonState eState = m_pCertPathList->GetCheckButtonState( _pEntry );
if (SV_BUTTON_CHECKED == eState)
diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx
index 7874a06..8486252 100644
--- a/cui/source/options/fontsubs.cxx
+++ b/cui/source/options/fontsubs.cxx
@@ -180,7 +180,7 @@ bool SvxFontSubstTabPage::FillItemSet( SfxItemSet* )
SubstitutionStruct aAdd;
aAdd.sFont = SvTabListBox::GetEntryText(pEntry, 0);
aAdd.sReplaceBy = SvTabListBox::GetEntryText(pEntry, 1);
- aAdd.bReplaceAlways = SvxFontSubstCheckListBox::IsChecked(pEntry, 0);
+ aAdd.bReplaceAlways = SvxFontSubstCheckListBox::IsChecked(pEntry);
aAdd.bReplaceOnScreenOnly =
SvxFontSubstCheckListBox::IsChecked(pEntry, 1);
pConfig->AddSubstitution(aAdd);
pEntry = m_pCheckLB->Next(pEntry);
@@ -459,7 +459,7 @@ void SvxFontSubstCheckListBox::KeyInput( const KeyEvent&
rKEvt )
else
{
sal_uInt16 nCheck = IsChecked(nSelPos, 1) ? 1 : 0;
- if(IsChecked(nSelPos, 0))
+ if(IsChecked(nSelPos))
nCheck += 2;
nCheck--;
nCheck &= 3;
diff --git a/cui/source/options/optasian.cxx b/cui/source/options/optasian.cxx
index 81d9a39..31d4b43 100644
--- a/cui/source/options/optasian.cxx
+++ b/cui/source/options/optasian.cxx
@@ -284,9 +284,9 @@ void SvxAsianLayoutPage::Reset( const SfxItemSet* )
m_pHintFT->Enable(false);
}
if(bKernWesternText)
- m_pCharKerningRB->Check(true);
+ m_pCharKerningRB->Check();
else
- m_pCharPunctKerningRB->Check(true);
+ m_pCharPunctKerningRB->Check();
switch(nCompress)
{
case 0 : m_pNoCompressionRB->Check(); break;
diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index 9098a79..999aeec 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -569,7 +569,7 @@ void ColorConfigWindow_Impl::CreateEntries()
aCheckBox->SetText(sSampleText);
aFixedText->SetText(sSampleText);
Size aCheckSize(aCheckBox->CalcMinimumSize(0x7fffffff));
- Size aFixedSize(aFixedText->CalcMinimumSize(0x7fffffff));
+ Size aFixedSize(aFixedText->CalcMinimumSize());
nCheckBoxLabelOffset = aCheckSize.Width() - aFixedSize.Width();
}
diff --git a/cui/source/options/optctl.cxx b/cui/source/options/optctl.cxx
index 652bba9..4cc0806 100644
--- a/cui/source/options/optctl.cxx
+++ b/cui/source/options/optctl.cxx
@@ -32,8 +32,8 @@ IMPL_LINK_NOARG(SvxCTLOptionsPage, SequenceCheckingCB_Hdl)
// #i48117#: by default restricted and type&replace have to be switched on
if(bIsSequenceChecking)
{
- m_pTypeReplaceCB->Check( true );
- m_pRestrictedCB->Check( true );
+ m_pTypeReplaceCB->Check();
+ m_pRestrictedCB->Check();
}
return 0;
}
diff --git a/cui/source/options/optdict.cxx b/cui/source/options/optdict.cxx
index 3a0bd9e..7026e5f 100644
--- a/cui/source/options/optdict.cxx
+++ b/cui/source/options/optdict.cxx
@@ -188,7 +188,7 @@ IMPL_LINK_NOARG(SvxNewDictionaryDialog, OKHdl_Impl)
ErrorHandler::HandleError( *new StringErrorInfo(
ERRCODE_SVX_LINGU_DICT_NOTWRITEABLE, sDict ) );
- EndDialog( RET_CANCEL );
+ EndDialog();
}
if (xDicList.is() && xNewDic.is())
diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx
index 5ede579..af543b3 100644
--- a/cui/source/options/optfltr.cxx
+++ b/cui/source/options/optfltr.cxx
@@ -319,9 +319,9 @@ void OfaMSFilterTabPage2::Reset( const SfxItemSet* )
m_pCheckLB->SetUpdateMode( true );
if (rOpt.IsCharBackground2Highlighting())
- aHighlightingRB->Check(true);
+ aHighlightingRB->Check();
else
- aShadingRB->Check(true);
+ aShadingRB->Check();
aHighlightingRB->SaveValue();
}
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index bcdcd41..3ed38dd 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -1104,7 +1104,7 @@ OfaLanguagesTabPage::OfaLanguagesTabPage(vcl::Window*
pParent, const SfxItemSet&
m_pComplexLanguageLB->SetLanguageList( SvxLanguageListFlags::CTL |
SvxLanguageListFlags::ONLY_KNOWN, true, false, true );
m_pComplexLanguageLB->InsertDefaultLanguage(
css::i18n::ScriptType::COMPLEX );
- m_pLocaleSettingLB->SetLanguageList( SvxLanguageListFlags::ALL |
SvxLanguageListFlags::ONLY_KNOWN, false, false, false);
+ m_pLocaleSettingLB->SetLanguageList( SvxLanguageListFlags::ALL |
SvxLanguageListFlags::ONLY_KNOWN, false, false);
m_pLocaleSettingLB->InsertSystemLanguage( );
const NfCurrencyTable& rCurrTab = SvNumberFormatter::GetTheCurrencyTable();
@@ -1603,7 +1603,7 @@ void OfaLanguagesTabPage::Reset( const SfxItemSet* rSet )
{
m_pWesternLanguageLB->GrabFocus();
m_pCurrentDocCB->Enable(true);
- m_pCurrentDocCB->Check(true);
+ m_pCurrentDocCB->Check();
}
}
@@ -1639,7 +1639,7 @@ namespace
void lcl_checkLanguageCheckBox(CheckBox* _rCB,bool _bNewValue,bool
_bOldValue)
{
if ( _bNewValue )
- _rCB->Check(true);
+ _rCB->Check();
else
_rCB->Check( _bOldValue );
// #i15082# do not call SaveValue() in running dialog...
diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 61b1870..59bee66 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -689,7 +689,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, SavePasswordHdl)
if ( xMasterPasswd->changeMasterPassword( Reference<
task::XInteractionHandler >() ) )
{
m_pMasterPasswordPB->Enable( true );
- m_pMasterPasswordCB->Check( true );
+ m_pMasterPasswordCB->Check();
m_pMasterPasswordCB->Enable( true );
m_pMasterPasswordFT->Enable( true );
m_pShowConnectionsPB->Enable( true );
@@ -708,7 +708,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, SavePasswordHdl)
if( RET_YES == nRet )
{
xMasterPasswd->allowPersistentStoring( sal_False );
- m_pMasterPasswordCB->Check( true );
+ m_pMasterPasswordCB->Check();
m_pMasterPasswordPB->Enable( false );
m_pMasterPasswordCB->Enable( false );
m_pMasterPasswordFT->Enable( false );
@@ -716,7 +716,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, SavePasswordHdl)
}
else
{
- m_pSavePasswordsCB->Check( true );
+ m_pSavePasswordsCB->Check();
m_pMasterPasswordPB->Enable( true );
m_pShowConnectionsPB->Enable( true );
}
@@ -776,7 +776,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, MasterPasswordCBHdl)
}
else
{
- m_pMasterPasswordCB->Check( true );
+ m_pMasterPasswordCB->Check();
m_pMasterPasswordPB->Enable( true );
m_pShowConnectionsPB->Enable( true );
}
@@ -876,7 +876,7 @@ void SvxSecurityTabPage::InitControls()
m_pMasterPasswordPB->Enable( false );
m_pMasterPasswordCB->Enable( false );
- m_pMasterPasswordCB->Check( true );
+ m_pMasterPasswordCB->Check();
m_pMasterPasswordFT->Enable( false );
m_pShowConnectionsPB->Enable( false );
@@ -890,14 +890,14 @@ void SvxSecurityTabPage::InitControls()
{
m_pMasterPasswordCB->Enable( true );
m_pShowConnectionsPB->Enable( true );
- m_pSavePasswordsCB->Check( true );
+ m_pSavePasswordsCB->Check();
if ( xMasterPasswd->isDefaultMasterPasswordUsed() )
m_pMasterPasswordCB->Check( false );
else
{
m_pMasterPasswordPB->Enable( true );
- m_pMasterPasswordCB->Check( true );
+ m_pMasterPasswordCB->Check();
m_pMasterPasswordFT->Enable( true );
}
}
diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index 14c2a22..6001535 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -555,7 +555,7 @@ void SvxJavaOptionsPage::AddJRE( JavaInfo* _pInfo )
void SvxJavaOptionsPage::HandleCheckEntry( SvTreeListEntry* _pEntry )
{
- m_pJavaList->Select( _pEntry, true );
+ m_pJavaList->Select( _pEntry );
SvButtonState eState = m_pJavaList->GetCheckButtonState( _pEntry );
if ( SV_BUTTON_CHECKED == eState )
@@ -1001,7 +1001,7 @@ IMPL_LINK_NOARG(SvxJavaClassPathDlg, AddArchiveHdl_Impl)
OUString sFile = aURL.getFSysPath( INetURLObject::FSYS_DETECT );
if ( !IsPathDuplicate( sURL ) )
{
- sal_Int32 nPos = m_pPathList->InsertEntry( sFile,
SvFileInformationManager::GetImage( aURL, false ) );
+ sal_Int32 nPos = m_pPathList->InsertEntry( sFile,
SvFileInformationManager::GetImage( aURL ) );
m_pPathList->SelectEntryPos( nPos );
}
else
@@ -1038,7 +1038,7 @@ IMPL_LINK_NOARG(SvxJavaClassPathDlg, AddPathHdl_Impl)
OUString sNewFolder = aURL.getFSysPath( INetURLObject::FSYS_DETECT );
if ( !IsPathDuplicate( sFolderURL ) )
{
- sal_Int32 nPos = m_pPathList->InsertEntry( sNewFolder,
SvFileInformationManager::GetImage( aURL, false ) );
+ sal_Int32 nPos = m_pPathList->InsertEntry( sNewFolder,
SvFileInformationManager::GetImage( aURL ) );
m_pPathList->SelectEntryPos( nPos );
}
else
@@ -1134,7 +1134,7 @@ void SvxJavaClassPathDlg::SetClassPath( const OUString&
_rPath )
OUString sToken = _rPath.getToken( 0, CLASSPATH_DELIMITER, nIdx );
INetURLObject aURL( sToken, INetURLObject::FSYS_DETECT );
OUString sPath = aURL.getFSysPath( INetURLObject::FSYS_DETECT );
- m_pPathList->InsertEntry( sPath, SvFileInformationManager::GetImage(
aURL, false ) );
+ m_pPathList->InsertEntry( sPath, SvFileInformationManager::GetImage(
aURL ) );
}
// select first entry
m_pPathList->SelectEntryPos(0);
diff --git a/cui/source/options/personalization.cxx
b/cui/source/options/personalization.cxx
index 5e550a2..8c0c594 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -203,7 +203,7 @@ IMPL_LINK( SelectPersonaDialog, ActionCancel, PushButton*,
/* pButton */ )
if( m_rSearchThread.is() )
m_rSearchThread->StopExecution();
- EndDialog( RET_CANCEL );
+ EndDialog();
return 0;
}
@@ -417,7 +417,7 @@ void SvxPersonalizationTabPage::LoadDefaultImages()
aStream.ReadLine( aLine );
OUString aPersonaSetting( OStringToOUString( aLine,
RTL_TEXTENCODING_UTF8 ) );
OUString aPreviewFile;
- sal_Int32 nNewIndex = aPersonaSetting.indexOf( ';', 0 );
+ sal_Int32 nNewIndex = aPersonaSetting.indexOf( ';' );
if( nNewIndex < 0 )
break;
aPreviewFile = aPersonaSetting.copy( 0, nNewIndex );
@@ -518,7 +518,7 @@ IMPL_LINK( SvxPersonalizationTabPage,
SelectInstalledPersona, ListBox*, )
m_pExtensionPersonaPreview->Show();
sal_Int32 nSelectedPos = m_pPersonaList->GetSelectEntryPos();
OUString aSettings = m_vExtensionPersonaSettings[nSelectedPos];
- sal_Int32 nIndex = aSettings.indexOf( ';', 0 );
+ sal_Int32 nIndex = aSettings.indexOf( ';' );
OUString aPreviewFile = aSettings.copy( 0, nIndex );
m_aPersonaSettings = aSettings.copy( nIndex + 1 );
diff --git a/cui/source/options/radiobtnbox.cxx
b/cui/source/options/radiobtnbox.cxx
index 500617b..1f1a422 100644
--- a/cui/source/options/radiobtnbox.cxx
+++ b/cui/source/options/radiobtnbox.cxx
@@ -62,7 +62,7 @@ void SvxRadioButtonListBox::KeyInput( const KeyEvent& rKEvt )
void SvxRadioButtonListBox::HandleEntryChecked( SvTreeListEntry* _pEntry )
{
- Select( _pEntry, true );
... etc. - the rest is truncated
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
