On 17/08/11 19:02, Lionel Elie Mamane wrote:

Which leads me to another bug: If I remove the librarie's only dialog
and save, I restart LO, I reopen the file again, the dialog is
back.
probably worth opening another bug for that then, anyway, lets look
at one thing at a time ( otherwise I will get depressed )
Fixed (by me) in master.

maybe  a better test would be

+ if ( ! ( xNameAccess->hasElements() || bInplaceStorage ) )

instead of

+ if ( ! ( xNameAccess->hasElements() || isModified() ) )

afaics in all cases where we have inplace storage we need to regenerate the basic related streams ( although I don't know where else other than base this is the case ) I just worry there might be some strange case where isModified might not be correct ( I have some vague recollection of it not being totally reliable under some circumstances... )

regards,
Noel
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to