Hi, Thank you for the patch. Assuming this is your first patch (or at-least one of the first few), I have a few suggestions: 1. It would nice if you could remove the test code commented - helps in reviewing quickly. 2. You have changed the multipliers in multiple locations - are you sure these don't affect the normal working? (say, having a blank template?) 3. It would also be nice if you could explain the reason for removing the content from STR_PRESOBJ_MPOUTLLAYER5 to STR_PRESOBJ_MPOUTLLAYER9
Will wait for your updates before pushing... Thanks again for your nice work... Regards, Muthu Subramanian -------------------------------------------------- Date: Mon, 1 Aug 2011 13:27:33 +0800 From: jeffrey chang <jeffdch...@gmail.com> Subject: [Libreoffice] [PATCH] for Bug 32719 To: libreoffice@lists.freedesktop.org Here is the patch for EasyHack 32719. I have also discovered another bug relating to Impress Templates, documented here: https://bugs.freedesktop.org/show_bug.cgi?id=39705 I am submitting this under the LGPLv3+/MPL 1.1 license. Thanks, -- --Jeffrey Chang _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
