cui/source/tabpages/tpshadow.cxx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
New commits: commit 2302e9eb8a161abaf5899288b4e1c689f5a1ff07 Author: Katarina Behrens <bu...@bubli.org> Date: Tue Mar 31 22:44:28 2015 +0200 tdf#84228: Fix annoying double shadow in preview SfxItemSet passed to ActivatePage method contains both rectangle AND shadow attributes, causing the old shadow to stick around even after new shadow attributes have been set. Thus, set shadow to none in a local copy of SfxItemSet and use that one to repaint the rectangle Change-Id: If798351fbecaaf951ef0479ae4a2c70d2db68ca4 diff --git a/cui/source/tabpages/tpshadow.cxx b/cui/source/tabpages/tpshadow.cxx index d57db3f..b163ceb 100644 --- a/cui/source/tabpages/tpshadow.cxx +++ b/cui/source/tabpages/tpshadow.cxx @@ -222,8 +222,15 @@ void SvxShadowTabPage::ActivatePage( const SfxItemSet& rSet ) else m_pLbShadowColor->SelectEntryPos( nPos ); + SfxItemSet rAttribs( rSet ); + // rSet contains shadow attributes too, but we want + // to use it for updating rectangle attributes only, + // so set the shadow to none here + SdrOnOffItem aItem( makeSdrShadowItem( false )); + rAttribs.Put( aItem ); + + m_pCtlXRectPreview->SetRectangleAttributes( rAttribs ); ModifyShadowHdl_Impl( this ); - m_pCtlXRectPreview->SetRectangleAttributes(rSet); } nPageType = PT_SHADOW; } _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits