[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - libreofficekit/source

[Miklos Vajna]

 libreofficekit/source/gtk/lokdocview.c |   25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

New commits:
commit 0f12997a0944ced3bb90e1f939a4e4b7981baa34
Author: Miklos Vajna <vmik...@collabora.co.uk>
Date:   Thu Feb 5 18:09:30 2015 +0100

    lokdocview: fix memory leak in lcl_payloadToRectangle()
    
    Change-Id: I2894c693d11b025d23ebbf0ae75f67532efe315f

diff --git a/libreofficekit/source/gtk/lokdocview.c 
b/libreofficekit/source/gtk/lokdocview.c
index 1df8c5c..daaf89f 100644
--- a/libreofficekit/source/gtk/lokdocview.c
+++ b/libreofficekit/source/gtk/lokdocview.c
@@ -323,23 +323,26 @@ static GdkRectangle lcl_payloadToRectangle(const char* 
pPayload)
 {
     GdkRectangle aRet;
     gchar** ppCoordinates;
+    gchar** ppCoordinate;
 
     ppCoordinates = g_strsplit(pPayload, ", ", 4);
-    if (!*ppCoordinates)
+    ppCoordinate = ppCoordinates;
+    if (!*ppCoordinate)
         return aRet;
-    aRet.width = atoi(*ppCoordinates);
-    ++ppCoordinates;
-    if (!*ppCoordinates)
+    aRet.width = atoi(*ppCoordinate);
+    ++ppCoordinate;
+    if (!*ppCoordinate)
         return aRet;
-    aRet.height = atoi(*ppCoordinates);
-    ++ppCoordinates;
-    if (!*ppCoordinates)
+    aRet.height = atoi(*ppCoordinate);
+    ++ppCoordinate;
+    if (!*ppCoordinate)
         return aRet;
-    aRet.x = atoi(*ppCoordinates);
-    ++ppCoordinates;
-    if (!*ppCoordinates)
+    aRet.x = atoi(*ppCoordinate);
+    ++ppCoordinate;
+    if (!*ppCoordinate)
         return aRet;
-    aRet.y = atoi(*ppCoordinates);
+    aRet.y = atoi(*ppCoordinate);
+    g_strfreev(ppCoordinates);
     return aRet;
 }
 
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits