https://bugs.freedesktop.org/show_bug.cgi?id=84938
--- Comment #6 from Noel Grandin <noelgran...@gmail.com> --- Glad to here you are working on this! (In reply to Terrence Enger from comment #5) > (*) I have the name DatasourceItemId for the class. Is this good? > Sounds finee. > (*) The member name looks like a #defined name: uppercase with > underscores between "words". Does anybody care for more details? > Sounds fine. > (*) I have changed to types of data members in some other classes. I > do not see why these variables are necessary, but I have not dug > into the question. > That's pretty normal. > (*) So far, I have arbitrarily limited my changes to dbaccess; when > an item goes outside the module--SfxItemSet comes to mind--I have > cast the item to int. Is this a reasonable way to do it? Failing > that, is the result worth anything? > That's a normal approach, except for cases where something else might be #including headers from dbaccess, in which case I'd except the code to be modified to use the new 'enum class' type. -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
