Hi Luke,
> @@ -542,6 +543,7 @@ void
> CustomAnimationList::select( CustomAnimationEffectPtr pEffect, bool
> bSelect
> {
> append( pEffect );
> select( pEffect );
> + MakeVisible( Last() );
we don't need to call it here ^^^, as select( pEffect ); on the previous
line recursively calls this function again and it is made visible from
the loop above already. So it should be enough to add it to the loop.
I have updated your patch and pushed it.
Cheers
Radek
> }
> }
On Sun, 2011-06-26 at 22:27 +1200, Luke Symes wrote:
> Hi Radek,
>
> On Sat, Jun 25, 2011 at 3:35 AM, Radek Doulik <r...@novell.com> wrote:
>
> At least I am not reaching the part you modified when adding
> custom
> animation thru custom animation pane (using the add button and
> custom
> animation dialog). If we move it to the loop, it will be
> reached always
> when selecting an entry - the select method is called
> recursively when
> adding new pEntry in:
>
> if( !pEntry && bSelect )
> {
> append( pEffect );
> select( pEffect );
> }
>
> I wonder how do you reach that part of code?
>
>
> Hmm. I think the code is incorrect here. That last if statement should
> really only be used if the effect wasn't in the list & needs to be
> added. But when I added the MakeVisible in the if statement, it made
> new animations be scrolled to, and I was doing it via add->custom
> animation dialog too. What do you think of my attached patch? Once we
> have found the given entry, we should select it and then we are done,
> aren't we?
>
>
> Kind regards,
>
>
> Luke.
--
Radek Doulík <r...@novell.com>
Novell, Inc.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
