Hello all,
I have a new patch for another problem around range names. We couldn't
import formulas with range names from xls due to a false check.
The named range index is 1-based during import and so the check is only
allowed to check for > but not >=.
I think we should include this patch into 3-4 because it is a serious
problem if all formulas with range names are screwed up.
Regards,
Markus
From 6a35e2e0d792b60b385a5f61f6842fd963487e20 Mon Sep 17 00:00:00 2001
From: Markus Mohrhard <markus.mohrh...@googlemail.com>
Date: Wed, 22 Jun 2011 20:29:46 +0200
Subject: [PATCH] fix for fdo#38204: formulas with range names were not imported correctly
---
sc/source/filter/excel/xiname.cxx | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sc/source/filter/excel/xiname.cxx b/sc/source/filter/excel/xiname.cxx
index 261d61f..19e18d9 100644
--- a/sc/source/filter/excel/xiname.cxx
+++ b/sc/source/filter/excel/xiname.cxx
@@ -271,7 +271,7 @@ const XclImpName* XclImpNameManager::FindName( const String& rXclName, SCTAB nSc
const XclImpName* XclImpNameManager::GetName( sal_uInt16 nXclNameIdx ) const
{
OSL_ENSURE( nXclNameIdx > 0, "XclImpNameManager::GetName - index must be >0" );
- return ( nXclNameIdx >= maNameList.size() ) ? NULL : &(maNameList.at( nXclNameIdx - 1 ));
+ return ( nXclNameIdx > maNameList.size() ) ? NULL : &(maNameList.at( nXclNameIdx - 1 ));
}
// ============================================================================
--
1.7.3.4
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
