Hi Albert, On Tue, 2011-05-31 at 01:38 +0200, Markus Mohrhard wrote: > Hello Albert, > > just two quick comments. > > We are trying to get away from using sal_Int16 for sheet numbers and > use SCTAB instead, so it would be nice if you could change this. > And I think we can't/shouldn't create a document without a sheet (but > Kohei may prove me wrong). And did you check that no negative > numbers/characters are inserted? > > But all in all some good work. I think Kohei will take a closer look > and give you some better advice.
Well, Markus gave pretty good suggestions there and I don't really have anything else to add. I'm re-building master at the moment since we have merged the -3-4-0 branch, and once that's done I'll give this patch a test-drive and see. The only thing I might say is that, I'm not too sure about the page being called "Initialize". There may be a better naming for an option page like this.... "Defaults" maybe? I don't know. Anyway, good stuff. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc <kyosh...@novell.com> _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
