On Sat, 2011-05-07 at 13:03 -0430, Rafael Dominguez wrote:
> Well it does look weird, but its the same object getting compared on
> both sides, so i think theres a problem there, but better wait for
> someone with more experience in the code say something about it.
In libreoffice-3-3 we had:
#if CHART_ADDRESS_CONV_WORKAROUND
::formula::FormulaGrammar::AddressConvention eConvUI =
pDocument->GetAddressConvention();
if (eConv != eConvUI)
return ((rAddress.Parse(sToken, const_cast<ScDocument*>(pDocument),
eConvUI) & SCA_VALID) == SCA_VALID);
#endif
Around here instead of:
if (!bResult && eConv != eConv)
bResult = ((rRange.aStart.Parse(
aUIString, const_cast<ScDocument*>(pDocument), eConv) &
SCA_VALID) == SCA_VALID);
It seems pretty bogus doing the same parse again - you would hope the
function would fail in the same way :-)
Best to ask Kohei to de-louse it though :-) nice catch ...
HTH,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
