Hi Bjoern, On 2011-03-21 at 18:34 +0100, Bjoern Michaelsen wrote:
> We clearly want to run unittest by default. It might make sense to > rename the current "all" target to "buildonly" and "allandcheck" to > "all" to be more explicit. The GNU make conventions are unclear if > checks should be run by the default target (However, they are clear on > that the default target should be "all" -- which we currently violate): > > http://www.gnu.org/software/make/manual/make.html#Standard-Targets > > Im open for opinions on this. I'd default to building without running checks when you issue make in the module (the developer running the make knows best whether the change is just adding a debug output, or does the "Real Thing"), and build with checks when you rebuild the entire LibreOffice - that way, even if you forget to do your 'make check', your changes are high that you spot the breakage, or (in the worst case) the tinderboxes uncover that. Wrt. the naming, I'd do 'all' build only, and 'check' depending on 'all', ie. the 'allandcheck' meaning. Regards, Kendy _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
